Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb handling not implemented to spec on the server #17002

Closed
bzbarsky-apple opened this issue Apr 4, 2022 · 1 comment
Closed

Breadcrumb handling not implemented to spec on the server #17002

bzbarsky-apple opened this issue Apr 4, 2022 · 1 comment
Labels
bug Something isn't working commissioning Involves placing devices on the network, initial setup spec Mismatch between spec and implementation V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Apr 4, 2022

Problem

The current state of breadcrumb handling on the server is:

  1. We have a breadcrumb in the configuration manager. It's written by SetRegulatoryConfig and read by absolutely nothing.
  2. We have a breadcrumb attribute in the attribute store. It's written by writes to that attribute and read by reads of that attribute.
  3. None of the commands that carry a breadcrumb update the attribute state.

Proposed Solution

  1. Have a single source of truth for breadcrumb. This should be the attribute store, because that causes the smallest number of complications.
  2. Ensure attribute reads and writes use the source of truth. This is automatic if we use the attribute store.
  3. Ensure all commands that take a breadcrumb field update the breadcrumb: call the relevant Set() method from Accessors.h, or add an API on the general commissioning cluster.
  4. Remove the persistent configuration manager storage of breadcrumb.

This is critical to having sane error recovery during commissioning.

@bzbarsky-apple bzbarsky-apple added V1.0 spec Mismatch between spec and implementation commissioning Involves placing devices on the network, initial setup labels Apr 4, 2022
@tcarmelveilleux tcarmelveilleux added the bug Something isn't working label Apr 4, 2022
@tcarmelveilleux tcarmelveilleux changed the title Need to implement breadcrumb handling on the server Breadcrumb handling not implemented to spec on the server Apr 4, 2022
@bzbarsky-apple
Copy link
Contributor Author

#17769 fixed most of this. The remainder is tracked in #17759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working commissioning Involves placing devices on the network, initial setup spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

No branches or pull requests

2 participants