Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make breadcrumb optional in network commissioning cluster commands. #17007

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Make breadcrumb optional in network commissioning cluster commands. #17007

merged 3 commits into from
Apr 4, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

It's optional in the spec.

Problem

Spec not correctly implemented for network commissioning cluster commands.

Change overview

Fix the cluster XML to match the spec.

Testing

No behavior changes due to #17002, but tested that tree compiles.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17007: Size comparison from 7ab6653 to 86db700

Increases (5 builds for cc13x2_26x2, linux)
platform target config section 7ab6653 86db700 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 183652 183668 16 0.0
pump-app LP_CC2652R7 (read/write) 165360 165376 16 0.0
pump-controller-app LP_CC2652R7 (read/write) 182896 182904 8 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 1003850 624 0.0
.text 8466420 8467044 624 0.0
thermostat-no-ble arm64 (read only) 2311676 2312220 544 0.0
.text 1943232 1943776 544 0.0
Decreases (14 builds for cc13x2_26x2, cyw30739, efr32, k32w, p6, telink)
platform target config section 7ab6653 86db700 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 668027 -16 -0.0
.text 587840 587824 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 617163 617147 -16 -0.0
.text 537072 537056 -16 -0.0
pump-app LP_CC2652R7 (read only) 687495 687479 -16 -0.0
.text 605220 605204 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 669703 669695 -8 -0.0
.text 591092 591084 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610618 610602 -16 -0.0
.app_xip_area 517392 517376 -16 -0.0
lock cyw930739m2evb_01 (read/write) 568154 568138 -16 -0.0
.app_xip_area 476456 476440 -16 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579734 579726 -8 -0.0
.app_xip_area 478404 478396 -8 -0.0
efr32 lighting-app BRD4161A (read only) 916048 916032 -16 -0.0
.text 916040 916024 -16 -0.0
k32w light k32w061+release (read/write) 707852 707836 -16 -0.0
.text 622240 622224 -16 -0.0
lock k32w061+release (read/write) 707260 707244 -16 -0.0
.text 621624 621608 -16 -0.0
p6 all-clusters-app default (read/write) 2504488 2504440 -48 -0.0
.text 1462752 1462704 -48 -0.0
light-app default (read/write) 2405648 2405616 -32 -0.0
.text 1363912 1363880 -32 -0.0
lock-app default (read/write) 2369280 2369264 -16 -0.0
.text 1327544 1327528 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 792052 792020 -32 -0.0
text 561924 561892 -32 -0.0
Full report (20 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 86db700 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 668027 -16 -0.0
(read/write) 183652 183668 16 0.0
.bss 81736 81736 0 0.0
.data 3128 3128 0 0.0
.rodata 79723 79723 0 0.0
.text 587840 587824 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 617163 617147 -16 -0.0
(read/write) 154448 154448 0 0.0
.bss 77464 77464 0 0.0
.data 3128 3128 0 0.0
.rodata 79603 79603 0 0.0
.text 537072 537056 -16 -0.0
pump-app LP_CC2652R7 (read only) 687495 687479 -16 -0.0
(read/write) 165360 165376 16 0.0
.bss 82128 82128 0 0.0
.data 3160 3160 0 0.0
.rodata 81791 81791 0 0.0
.text 605220 605204 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 669703 669695 -8 -0.0
(read/write) 182896 182904 8 0.0
.bss 81872 81872 0 0.0
.data 3124 3124 0 0.0
.rodata 78127 78127 0 0.0
.text 591092 591084 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610618 610602 -16 -0.0
.app_xip_area 517392 517376 -16 -0.0
.bss 75980 75980 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568154 568138 -16 -0.0
.app_xip_area 476456 476440 -16 -0.0
.bss 74484 74484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579734 579726 -8 -0.0
.app_xip_area 478404 478396 -8 -0.0
.bss 83796 83796 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916048 916032 -16 -0.0
(read/write) 129728 129728 0 0.0
.bss 127768 127768 0 0.0
.data 1956 1956 0 0.0
.text 916040 916024 -16 -0.0
BRD4161A+rpc (read only) 943944 943944 0 0.0
(read/write) 145680 145680 0 0.0
.bss 143544 143544 0 0.0
.data 2136 2136 0 0.0
.text 943936 943936 0 0.0
window-app BRD4161A (read only) 851360 851360 0 0.0
(read/write) 127752 127752 0 0.0
.bss 125912 125912 0 0.0
.data 1836 1836 0 0.0
.text 851352 851352 0 0.0
k32w light k32w061+release (read/write) 707852 707836 -16 -0.0
.bss 77944 77944 0 0.0
.data 1868 1868 0 0.0
.text 622240 622224 -16 -0.0
lock k32w061+release (read/write) 707260 707244 -16 -0.0
.bss 77928 77928 0 0.0
.data 1908 1908 0 0.0
.text 621624 621608 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 1003850 624 0.0
(read/write) 478337 478337 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376288 376288 0 0.0
.dynamic 560 560 0 0.0
.got 56784 56784 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506604 506604 0 0.0
.text 8466420 8467044 624 0.0
thermostat-no-ble arm64 (read only) 2311676 2312220 544 0.0
(read/write) 149249 149249 0 0.0
.bss 62913 62913 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 77656 77656 0 0.0
.dynamic 560 560 0 0.0
.got 4584 4584 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142972 142972 0 0.0
.text 1943232 1943776 544 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2359932 2359932 0 0.0
.bss 185020 185020 0 0.0
.data 5752 5752 0 0.0
.text 1322532 1322532 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1148735 0 0.0
bss 143048 143048 0 0.0
rodata 143328 143328 0 0.0
text 787512 787512 0 0.0
p6 all-clusters-app default (read/write) 2504488 2504440 -48 -0.0
.bss 118456 118456 0 0.0
.data 2632 2632 0 0.0
.text 1462752 1462704 -48 -0.0
light-app default (read/write) 2405648 2405616 -32 -0.0
.bss 111912 111912 0 0.0
.data 2488 2488 0 0.0
.text 1363912 1363880 -32 -0.0
lock-app default (read/write) 2369280 2369264 -16 -0.0
.bss 111656 111656 0 0.0
.data 2448 2448 0 0.0
.text 1327544 1327528 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 792052 792020 -32 -0.0
bss 70264 70264 0 0.0
noinit 40416 40416 0 0.0
text 561924 561892 -32 -0.0

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17007: Size comparison from 7ab6653 to 9cb9b85

Increases above 0.2%:

platform target config section 7ab6653 9cb9b85 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 .data 3128 3164 36 1.2
lock-mtd LP_CC2652R7 .data 3128 3164 36 1.2
pump-app LP_CC2652R7 .data 3160 3196 36 1.1
pump-controller-app LP_CC2652R7 .data 3124 3160 36 1.2
cyw30739 light cyw930739m2evb_01 .data 596 632 36 6.0
lock cyw930739m2evb_01 .data 560 596 36 6.4
ota-requestor-no-progress-logging cyw930739m2evb_01 .data 500 536 36 7.2
efr32 lighting-app BRD4161A .data 1956 1992 36 1.8
BRD4161A+rpc .data 2136 2172 36 1.7
window-app BRD4161A .data 1836 1872 36 2.0
k32w light k32w061+release .data 1868 1904 36 1.9
lock k32w061+release .data 1908 1944 36 1.9
linux all-clusters-app debug .data 1328 1440 112 8.4
bridge-app debug+rpc .data 1984 2048 64 3.2
door-lock-app debug .bss 47776 47872 96 0.2
.data 1056 1152 96 9.1
lighting-app debug+rpc .data 1504 1600 96 6.4
ota-provider-app debug .bss 47616 47712 96 0.2
.data 1320 1384 64 4.8
ota-requestor-app debug .data 1544 1608 64 4.1
.rodata 167276 167628 352 0.2
shell debug .data 784 848 64 8.2
thermostat-no-ble arm64 .data 1072 1136 64 6.0
.got 4584 4624 40 0.9
tv-app debug .data 3296 3392 96 2.9
mbed lock-app CY8CPROTO_062_4343W+release .data 5752 5784 32 0.6
p6 all-clusters-app default .data 2632 2672 40 1.5
light-app default .data 2488 2528 40 1.6
lock-app default .data 2448 2488 40 1.6
Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 9cb9b85 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 668171 128 0.0
.bss 81736 81752 16 0.0
.data 3128 3164 36 1.2
.text 587840 588016 176 0.0
lock-mtd LP_CC2652R7 (read only) 617163 617299 136 0.0
(read/write) 154448 154500 52 0.0
.bss 77464 77480 16 0.0
.data 3128 3164 36 1.2
.text 537072 537248 176 0.0
pump-app LP_CC2652R7 (read only) 687495 687623 128 0.0
.bss 82128 82152 24 0.0
.data 3160 3196 36 1.1
.text 605220 605380 160 0.0
pump-controller-app LP_CC2652R7 (read only) 669703 669871 168 0.0
.bss 81872 81888 16 0.0
.data 3124 3160 36 1.2
.text 591092 591292 200 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610618 610806 188 0.0
.app_xip_area 517392 517516 124 0.0
.bss 75980 76004 24 0.0
.data 596 632 36 6.0
lock cyw930739m2evb_01 (read/write) 568154 568314 160 0.0
.app_xip_area 476456 476568 112 0.0
.bss 74484 74500 16 0.0
.data 560 596 36 6.4
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579734 579982 248 0.0
.app_xip_area 478404 478592 188 0.0
.bss 83796 83816 20 0.0
.data 500 536 36 7.2
efr32 lighting-app BRD4161A (read only) 916048 916136 88 0.0
(read/write) 129728 129784 56 0.0
.bss 127768 127792 24 0.0
.data 1956 1992 36 1.8
.text 916040 916128 88 0.0
BRD4161A+rpc (read only) 943944 944040 96 0.0
(read/write) 145680 145736 56 0.0
.bss 143544 143560 16 0.0
.data 2136 2172 36 1.7
.text 943936 944032 96 0.0
window-app BRD4161A (read only) 851360 851456 96 0.0
(read/write) 127752 127808 56 0.0
.bss 125912 125936 24 0.0
.data 1836 1872 36 2.0
.text 851352 851448 96 0.0
esp32 all-clusters-app c3devkit (read only) 985618 985838 220 0.0
.dram0.bss 62920 62944 24 0.0
.dram0.data 14164 14196 32 0.2
.flash.text 985618 985838 220 0.0
m5stack (read only) 1038235 1038371 136 0.0
(read/write) 461584 461600 16 0.0
.dram0.bss 68448 68472 24 0.0
.dram0.data 34024 34056 32 0.1
.flash.text 1032851 1032987 136 0.0
k32w light k32w061+release (read/write) 707852 708012 160 0.0
.bss 77944 77952 8 0.0
.data 1868 1904 36 1.9
.text 622240 622356 116 0.0
lock k32w061+release (read/write) 707260 707452 192 0.0
.bss 77928 77952 24 0.0
.data 1908 1944 36 1.9
.text 621624 621756 132 0.0
linux all-clusters-app debug (read only) 2577057 2579257 2200 0.1
(read/write) 144488 144744 256 0.2
.bss 57536 57632 96 0.2
.data 1328 1440 112 8.4
.data.rel.ro 79736 79784 48 0.1
.rodata 220613 220965 352 0.2
.text 2188786 2190466 1680 0.1
bridge-app debug+rpc (read only) 1787533 1789509 1976 0.1
(read/write) 90040 90200 160 0.2
.bss 44520 44552 32 0.1
.data 1984 2048 64 3.2
.data.rel.ro 38448 38520 72 0.2
.rodata 147001 147257 256 0.2
.text 1524261 1525813 1552 0.1
chip-tool debug (read only) 10437245 10437661 416 0.0
.text 9112293 9112709 416 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 1003850 624 0.0
.text 8466420 8467044 624 0.0
door-lock-app debug (read only) 2058361 2060513 2152 0.1
(read/write) 117936 118160 224 0.2
.bss 47776 47872 96 0.2
.data 1056 1152 96 9.1
.data.rel.ro 63544 63592 48 0.1
.rodata 184969 185289 320 0.2
.text 1719938 1721602 1664 0.1
lighting-app debug+rpc (read only) 2236593 2238857 2264 0.1
(read/write) 124928 125152 224 0.2
.bss 49120 49184 64 0.1
.data 1504 1600 96 6.4
.data.rel.ro 68616 68680 64 0.1
.rodata 179113 179433 320 0.2
.text 1894562 1896338 1776 0.1
ota-provider-app debug (read only) 1996401 1998505 2104 0.1
(read/write) 113536 113760 224 0.2
.bss 47616 47712 96 0.2
.data 1320 1384 64 4.8
.data.rel.ro 58856 58936 80 0.1
.rodata 170819 171107 288 0.2
.text 1671218 1672866 1648 0.1
ota-requestor-app debug (read only) 2025433 2027601 2168 0.1
(read/write) 116792 117016 224 0.2
.bss 48608 48704 96 0.2
.data 1544 1608 64 4.1
.data.rel.ro 61064 61128 64 0.1
.rodata 167276 167628 352 0.2
.text 1702114 1703762 1648 0.1
shell debug (read only) 2474417 2476313 1896 0.1
(read/write) 148016 148208 192 0.1
.bss 67240 67304 64 0.1
.data 784 848 64 8.2
.data.rel.ro 74264 74328 64 0.1
.rodata 212434 212722 288 0.1
.text 2103810 2105250 1440 0.1
thermostat-no-ble arm64 (read only) 2311676 2313340 1664 0.1
(read/write) 149249 149361 112 0.1
.bss 62913 62945 32 0.1
.data 1072 1136 64 6.0
.got 4584 4624 40 0.9
.rodata 142972 143084 112 0.1
.text 1943232 1944656 1424 0.1
tv-app debug (read only) 2740761 2743073 2312 0.1
(read/write) 249440 249664 224 0.1
.bss 165200 165264 64 0.0
.data 3296 3392 96 2.9
.data.rel.ro 74776 74848 72 0.1
.rodata 210699 210955 256 0.1
.text 2352002 2353890 1888 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2359932 2360316 384 0.0
.bss 185020 185036 16 0.0
.data 5752 5784 32 0.6
.text 1322532 1322916 384 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1148875 140 0.0
bss 143048 143060 12 0.0
text 787512 787660 148 0.0
p6 all-clusters-app default .bss 118456 118472 16 0.0
.data 2632 2672 40 1.5
light-app default .bss 111912 111928 16 0.0
.data 2488 2528 40 1.6
lock-app default (read/write) 2369280 2369296 16 0.0
.bss 111656 111672 16 0.0
.data 2448 2488 40 1.6
.text 1327544 1327560 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 792052 792252 200 0.0
bss 70264 70288 24 0.0
text 561924 562112 188 0.0
Decreases (10 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6)
platform target config section 7ab6653 9cb9b85 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 183652 183540 -112 -0.1
.rodata 79723 79675 -48 -0.1
lock-mtd LP_CC2652R7 .rodata 79603 79563 -40 -0.1
pump-app LP_CC2652R7 (read/write) 165360 165256 -104 -0.1
.rodata 81791 81759 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 182896 182744 -152 -0.1
.rodata 78127 78095 -32 -0.0
esp32 all-clusters-app c3devkit .flash.rodata 198000 197952 -48 -0.0
m5stack .flash.rodata 226968 226928 -40 -0.0
linux thermostat-no-ble arm64 .data.rel.ro 77656 77640 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 143328 143284 -44 -0.0
p6 all-clusters-app default (read/write) 2504488 2504448 -40 -0.0
.text 1462752 1462712 -40 -0.0
light-app default (read/write) 2405648 2405640 -8 -0.0
.text 1363912 1363904 -8 -0.0
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 9cb9b85 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 668171 128 0.0
(read/write) 183652 183540 -112 -0.1
.bss 81736 81752 16 0.0
.data 3128 3164 36 1.2
.rodata 79723 79675 -48 -0.1
.text 587840 588016 176 0.0
lock-mtd LP_CC2652R7 (read only) 617163 617299 136 0.0
(read/write) 154448 154500 52 0.0
.bss 77464 77480 16 0.0
.data 3128 3164 36 1.2
.rodata 79603 79563 -40 -0.1
.text 537072 537248 176 0.0
pump-app LP_CC2652R7 (read only) 687495 687623 128 0.0
(read/write) 165360 165256 -104 -0.1
.bss 82128 82152 24 0.0
.data 3160 3196 36 1.1
.rodata 81791 81759 -32 -0.0
.text 605220 605380 160 0.0
pump-controller-app LP_CC2652R7 (read only) 669703 669871 168 0.0
(read/write) 182896 182744 -152 -0.1
.bss 81872 81888 16 0.0
.data 3124 3160 36 1.2
.rodata 78127 78095 -32 -0.0
.text 591092 591292 200 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610618 610806 188 0.0
.app_xip_area 517392 517516 124 0.0
.bss 75980 76004 24 0.0
.data 596 632 36 6.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568154 568314 160 0.0
.app_xip_area 476456 476568 112 0.0
.bss 74484 74500 16 0.0
.data 560 596 36 6.4
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579734 579982 248 0.0
.app_xip_area 478404 478592 188 0.0
.bss 83796 83816 20 0.0
.data 500 536 36 7.2
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916048 916136 88 0.0
(read/write) 129728 129784 56 0.0
.bss 127768 127792 24 0.0
.data 1956 1992 36 1.8
.text 916040 916128 88 0.0
BRD4161A+rpc (read only) 943944 944040 96 0.0
(read/write) 145680 145736 56 0.0
.bss 143544 143560 16 0.0
.data 2136 2172 36 1.7
.text 943936 944032 96 0.0
window-app BRD4161A (read only) 851360 851456 96 0.0
(read/write) 127752 127808 56 0.0
.bss 125912 125936 24 0.0
.data 1836 1872 36 2.0
.text 851352 851448 96 0.0
esp32 all-clusters-app c3devkit (read only) 985618 985838 220 0.0
(read/write) 1460570 1460570 0 0.0
.dram0.bss 62920 62944 24 0.0
.dram0.data 14164 14196 32 0.2
.flash.rodata 198000 197952 -48 -0.0
.flash.text 985618 985838 220 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038235 1038371 136 0.0
(read/write) 461584 461600 16 0.0
.dram0.bss 68448 68472 24 0.0
.dram0.data 34024 34056 32 0.1
.flash.rodata 226968 226928 -40 -0.0
.flash.text 1032851 1032987 136 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707852 708012 160 0.0
.bss 77944 77952 8 0.0
.data 1868 1904 36 1.9
.text 622240 622356 116 0.0
lock k32w061+release (read/write) 707260 707452 192 0.0
.bss 77928 77952 24 0.0
.data 1908 1944 36 1.9
.text 621624 621756 132 0.0
linux all-clusters-app debug (read only) 2577057 2579257 2200 0.1
(read/write) 144488 144744 256 0.2
.bss 57536 57632 96 0.2
.data 1328 1440 112 8.4
.data.rel.ro 79736 79784 48 0.1
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220613 220965 352 0.2
.text 2188786 2190466 1680 0.1
bridge-app debug+rpc (read only) 1787533 1789509 1976 0.1
(read/write) 90040 90200 160 0.2
.bss 44520 44552 32 0.1
.data 1984 2048 64 3.2
.data.rel.ro 38448 38520 72 0.2
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147001 147257 256 0.2
.text 1524261 1525813 1552 0.1
chip-tool debug (read only) 10437245 10437661 416 0.0
(read/write) 358680 358680 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 329400 329400 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532237 532237 0 0.0
.text 9112293 9112709 416 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 1003850 624 0.0
(read/write) 478337 478337 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376288 376288 0 0.0
.dynamic 560 560 0 0.0
.got 56784 56784 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506604 506604 0 0.0
.text 8466420 8467044 624 0.0
door-lock-app debug (read only) 2058361 2060513 2152 0.1
(read/write) 117936 118160 224 0.2
.bss 47776 47872 96 0.2
.data 1056 1152 96 9.1
.data.rel.ro 63544 63592 48 0.1
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 184969 185289 320 0.2
.text 1719938 1721602 1664 0.1
lighting-app debug+rpc (read only) 2236593 2238857 2264 0.1
(read/write) 124928 125152 224 0.2
.bss 49120 49184 64 0.1
.data 1504 1600 96 6.4
.data.rel.ro 68616 68680 64 0.1
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179113 179433 320 0.2
.text 1894562 1896338 1776 0.1
ota-provider-app debug (read only) 1996401 1998505 2104 0.1
(read/write) 113536 113760 224 0.2
.bss 47616 47712 96 0.2
.data 1320 1384 64 4.8
.data.rel.ro 58856 58936 80 0.1
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170819 171107 288 0.2
.text 1671218 1672866 1648 0.1
ota-requestor-app debug (read only) 2025433 2027601 2168 0.1
(read/write) 116792 117016 224 0.2
.bss 48608 48704 96 0.2
.data 1544 1608 64 4.1
.data.rel.ro 61064 61128 64 0.1
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167276 167628 352 0.2
.text 1702114 1703762 1648 0.1
shell debug (read only) 2474417 2476313 1896 0.1
(read/write) 148016 148208 192 0.1
.bss 67240 67304 64 0.1
.data 784 848 64 8.2
.data.rel.ro 74264 74328 64 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212434 212722 288 0.1
.text 2103810 2105250 1440 0.1
thermostat-no-ble arm64 (read only) 2311676 2313340 1664 0.1
(read/write) 149249 149361 112 0.1
.bss 62913 62945 32 0.1
.data 1072 1136 64 6.0
.data.rel.ro 77656 77640 -16 -0.0
.dynamic 560 560 0 0.0
.got 4584 4624 40 0.9
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142972 143084 112 0.1
.text 1943232 1944656 1424 0.1
tv-app debug (read only) 2740761 2743073 2312 0.1
(read/write) 249440 249664 224 0.1
.bss 165200 165264 64 0.0
.data 3296 3392 96 2.9
.data.rel.ro 74776 74848 72 0.1
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210699 210955 256 0.1
.text 2352002 2353890 1888 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2359932 2360316 384 0.0
.bss 185020 185036 16 0.0
.data 5752 5784 32 0.6
.text 1322532 1322916 384 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1148875 140 0.0
bss 143048 143060 12 0.0
rodata 143328 143284 -44 -0.0
text 787512 787660 148 0.0
p6 all-clusters-app default (read/write) 2504488 2504448 -40 -0.0
.bss 118456 118472 16 0.0
.data 2632 2672 40 1.5
.text 1462752 1462712 -40 -0.0
light-app default (read/write) 2405648 2405640 -8 -0.0
.bss 111912 111928 16 0.0
.data 2488 2528 40 1.6
.text 1363912 1363904 -8 -0.0
lock-app default (read/write) 2369280 2369296 16 0.0
.bss 111656 111672 16 0.0
.data 2448 2488 40 1.6
.text 1327544 1327560 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 792052 792252 200 0.0
bss 70264 70288 24 0.0
noinit 40416 40416 0 0.0
text 561924 562112 188 0.0

@bzbarsky-apple bzbarsky-apple merged commit 978dcbb into project-chip:master Apr 4, 2022
@bzbarsky-apple bzbarsky-apple deleted the breadcrumb-optionality branch April 4, 2022 20:53
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@bzbarsky-apple @chencheung
Make breadcrumb optional in network commissioning cluster commands. (p…
dc964b6 
…roject-chip#17007)

* Make breadcrumb optional in network commissioning cluster commands.

It's optional in the spec.

* Address review comments

* Fix ZAP job
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@bzbarsky-apple @chencheung
Make breadcrumb optional in network commissioning cluster commands. (p…
53f754b 
…roject-chip#17007)

* Make breadcrumb optional in network commissioning cluster commands.

It's optional in the spec.

* Address review comments

* Fix ZAP job
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@bzbarsky-apple @andrei-menzopol
Make breadcrumb optional in network commissioning cluster commands. (p…
fc00b39 
…roject-chip#17007)

* Make breadcrumb optional in network commissioning cluster commands.

It's optional in the spec.

* Address review comments

* Fix ZAP job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@msandstedt msandstedt Awaiting requested review from msandstedt

@woody-apple woody-apple Awaiting requested review from woody-apple

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @tcarmelveilleux @msandstedt @woody-apple