Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async loopback transport for all tests #17622

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Use async loopback transport for all tests #17622

merged 3 commits into from
Apr 22, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Apr 22, 2022 •
edited
Loading

Problem

The sync loopback transport is tricky, error prone

Change overview

Convert all test-cases use async loopback transport

  • TestContext::Initialize uses async loopback by default, InitializeAsync is not needed any more
  • Extract LoopbackTransportManager class from LoopbackMessagingContext
    • LoopbackTransportManager is a combo of TransportMgr<LoopbackTransport>, Test::IOContext
  • Add DrainAndServiceIO to tests when needed (surprisingly there is only a few places it is needed)
  • In ExchangeContext::HandleMessage, remove alreadyHandlingMessage logic

This is test-only changes.

Follow ups:

Testing

Passed unit-tests

@github-actions
Copy link

github-actions bot commented Apr 22, 2022 •
edited
Loading

PR #17622: Size comparison from 6109d14 to e4b4f2f

Decreases (14 builds for cyw30739, efr32, k32w, linux, p6, telink)
platform target config section 6109d14 e4b4f2f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 618150 618134 -16 -0.0
.app_xip_area 525156 525140 -16 -0.0
lock cyw930739m2evb_01 (read/write) 613098 613082 -16 -0.0
.app_xip_area 521584 521568 -16 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565750 565726 -24 -0.0
.app_xip_area 464648 464624 -24 -0.0
efr32 lighting-app BRD4161A (read only) 905828 905796 -32 -0.0
.text 905820 905788 -32 -0.0
BRD4161A+rpc (read only) 940228 940196 -32 -0.0
.text 940220 940188 -32 -0.0
window-app BRD4161A (read only) 843316 843268 -48 -0.0
.text 843308 843260 -48 -0.0
k32w light k32w061+release (read/write) 684144 684128 -16 -0.0
.text 598688 598672 -16 -0.0
lock k32w061+release (read/write) 725236 725220 -16 -0.0
.text 639188 639172 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10546220 10546108 -112 -0.0
.text 8908244 8908132 -112 -0.0
thermostat-no-ble arm64 (read only) 2361516 2361404 -112 -0.0
.text 1987312 1987200 -112 -0.0
p6 all-clusters-app default (read/write) 2524552 2524504 -48 -0.0
.text 1482816 1482768 -48 -0.0
light-app default (read/write) 2416304 2416256 -48 -0.0
.text 1374568 1374520 -48 -0.0
lock-app default (read/write) 2420496 2420448 -48 -0.0
.text 1378760 1378712 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801080 801048 -32 -0.0
text 570426 570394 -32 -0.0
Full report (15 builds for cyw30739, efr32, k32w, linux, mbed, p6, telink)
platform target config section 6109d14 e4b4f2f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 618150 618134 -16 -0.0
.app_xip_area 525156 525140 -16 -0.0
.bss 75652 75652 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613098 613082 -16 -0.0
.app_xip_area 521584 521568 -16 -0.0
.bss 74204 74204 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565750 565726 -24 -0.0
.app_xip_area 464648 464624 -24 -0.0
.bss 83496 83496 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905828 905796 -32 -0.0
(read/write) 129380 129380 0 0.0
.bss 127336 127336 0 0.0
.data 2044 2044 0 0.0
.text 905820 905788 -32 -0.0
BRD4161A+rpc (read only) 940228 940196 -32 -0.0
(read/write) 146064 146064 0 0.0
.bss 143816 143816 0 0.0
.data 2248 2248 0 0.0
.text 940220 940188 -32 -0.0
window-app BRD4161A (read only) 843316 843268 -48 -0.0
(read/write) 127468 127468 0 0.0
.bss 125512 125512 0 0.0
.data 1956 1956 0 0.0
.text 843308 843260 -48 -0.0
k32w light k32w061+release (read/write) 684144 684128 -16 -0.0
.bss 77656 77656 0 0.0
.data 2000 2000 0 0.0
.text 598688 598672 -16 -0.0
lock k32w061+release (read/write) 725236 725220 -16 -0.0
.bss 78288 78288 0 0.0
.data 1960 1960 0 0.0
.text 639188 639172 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10546220 10546108 -112 -0.0
(read/write) 497633 497633 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393088 393088 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 520316 520316 0 0.0
.text 8908244 8908132 -112 -0.0
thermostat-no-ble arm64 (read only) 2361516 2361404 -112 -0.0
(read/write) 151137 151137 0 0.0
.bss 62897 62897 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78992 78992 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145164 145164 0 0.0
.text 1987312 1987200 -112 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410108 2410108 0 0.0
.bss 184996 184996 0 0.0
.data 5848 5848 0 0.0
.text 1372708 1372708 0 0.0
p6 all-clusters-app default (read/write) 2524552 2524504 -48 -0.0
.bss 118368 118368 0 0.0
.data 2784 2784 0 0.0
.text 1482816 1482768 -48 -0.0
light-app default (read/write) 2416304 2416256 -48 -0.0
.bss 111848 111848 0 0.0
.data 2584 2584 0 0.0
.text 1374568 1374520 -48 -0.0
lock-app default (read/write) 2420496 2420448 -48 -0.0
.bss 111648 111648 0 0.0
.data 2544 2544 0 0.0
.text 1378760 1378712 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801080 801048 -32 -0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570426 570394 -32 -0.0

@github-actions
Copy link

github-actions bot commented Apr 22, 2022 •
edited
Loading

PR #17622: Size comparison from 6109d14 to 1145ead

Increases (2 builds for cc13x2_26x2)
platform target config section 6109d14 1145ead change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161936 161952 16 0.0
lock-ftd LP_CC2652R7 (read/write) 166532 166548 16 0.0
Decreases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 6109d14 1145ead change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690991 690975 -16 -0.0
.text 584496 584480 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 677363 677347 -16 -0.0
.text 578092 578076 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 626115 626099 -16 -0.0
.text 526956 526940 -16 -0.0
pump-app LP_CC2652R7 (read only) 649183 649167 -16 -0.0
.text 573344 573328 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 642171 642155 -16 -0.0
.text 563192 563176 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618150 618134 -16 -0.0
.app_xip_area 525156 525140 -16 -0.0
lock cyw930739m2evb_01 (read/write) 613098 613082 -16 -0.0
.app_xip_area 521584 521568 -16 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565750 565726 -24 -0.0
.app_xip_area 464648 464624 -24 -0.0
efr32 lighting-app BRD4161A (read only) 905828 905796 -32 -0.0
.text 905820 905788 -32 -0.0
BRD4161A+rpc (read only) 940228 940196 -32 -0.0
.text 940220 940188 -32 -0.0
window-app BRD4161A (read only) 843316 843268 -48 -0.0
.text 843308 843260 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 998022 997990 -32 -0.0
.flash.text 998022 997990 -32 -0.0
m5stack (read only) 1052223 1052195 -28 -0.0
.flash.text 1046839 1046811 -28 -0.0
k32w light k32w061+release (read/write) 684144 684128 -16 -0.0
.text 598688 598672 -16 -0.0
lock k32w061+release (read/write) 725236 725220 -16 -0.0
.text 639188 639172 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10546220 10546108 -112 -0.0
.text 8908244 8908132 -112 -0.0
thermostat-no-ble arm64 (read only) 2361516 2361404 -112 -0.0
.text 1987312 1987200 -112 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170643 1170627 -16 -0.0
text 805680 805664 -16 -0.0
p6 all-clusters-app default (read/write) 2524552 2524504 -48 -0.0
.text 1482816 1482768 -48 -0.0
light-app default (read/write) 2416304 2416256 -48 -0.0
.text 1374568 1374520 -48 -0.0
lock-app default (read/write) 2420496 2420448 -48 -0.0
.text 1378760 1378712 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801080 801048 -32 -0.0
text 570426 570394 -32 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6109d14 1145ead change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690991 690975 -16 -0.0
(read/write) 161936 161952 16 0.0
.bss 75912 75912 0 0.0
.data 3396 3396 0 0.0
.rodata 106015 106015 0 0.0
.text 584496 584480 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 677363 677347 -16 -0.0
(read/write) 166532 166548 16 0.0
.bss 73936 73936 0 0.0
.data 3220 3220 0 0.0
.rodata 98787 98787 0 0.0
.text 578092 578076 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 626115 626099 -16 -0.0
(read/write) 146732 146732 0 0.0
.bss 69656 69656 0 0.0
.data 3220 3220 0 0.0
.rodata 98667 98667 0 0.0
.text 526956 526940 -16 -0.0
pump-app LP_CC2652R7 (read only) 649183 649167 -16 -0.0
(read/write) 152500 152500 0 0.0
.bss 74368 74368 0 0.0
.data 3252 3252 0 0.0
.rodata 75351 75351 0 0.0
.text 573344 573328 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 642171 642155 -16 -0.0
(read/write) 151912 151912 0 0.0
.bss 74072 74072 0 0.0
.data 3216 3216 0 0.0
.rodata 78491 78491 0 0.0
.text 563192 563176 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618150 618134 -16 -0.0
.app_xip_area 525156 525140 -16 -0.0
.bss 75652 75652 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613098 613082 -16 -0.0
.app_xip_area 521584 521568 -16 -0.0
.bss 74204 74204 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565750 565726 -24 -0.0
.app_xip_area 464648 464624 -24 -0.0
.bss 83496 83496 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905828 905796 -32 -0.0
(read/write) 129380 129380 0 0.0
.bss 127336 127336 0 0.0
.data 2044 2044 0 0.0
.text 905820 905788 -32 -0.0
BRD4161A+rpc (read only) 940228 940196 -32 -0.0
(read/write) 146064 146064 0 0.0
.bss 143816 143816 0 0.0
.data 2248 2248 0 0.0
.text 940220 940188 -32 -0.0
window-app BRD4161A (read only) 843316 843268 -48 -0.0
(read/write) 127468 127468 0 0.0
.bss 125512 125512 0 0.0
.data 1956 1956 0 0.0
.text 843308 843260 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 998022 997990 -32 -0.0
(read/write) 1468074 1468074 0 0.0
.dram0.bss 62640 62640 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206560 206560 0 0.0
.flash.text 998022 997990 -32 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1052223 1052195 -28 -0.0
(read/write) 470080 470080 0 0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235916 235916 0 0.0
.flash.text 1046839 1046811 -28 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684144 684128 -16 -0.0
.bss 77656 77656 0 0.0
.data 2000 2000 0 0.0
.text 598688 598672 -16 -0.0
lock k32w061+release (read/write) 725236 725220 -16 -0.0
.bss 78288 78288 0 0.0
.data 1960 1960 0 0.0
.text 639188 639172 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10546220 10546108 -112 -0.0
(read/write) 497633 497633 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393088 393088 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 520316 520316 0 0.0
.text 8908244 8908132 -112 -0.0
thermostat-no-ble arm64 (read only) 2361516 2361404 -112 -0.0
(read/write) 151137 151137 0 0.0
.bss 62897 62897 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78992 78992 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145164 145164 0 0.0
.text 1987312 1987200 -112 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410108 2410108 0 0.0
.bss 184996 184996 0 0.0
.data 5848 5848 0 0.0
.text 1372708 1372708 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170643 1170627 -16 -0.0
bss 136264 136264 0 0.0
rodata 150052 150052 0 0.0
text 805680 805664 -16 -0.0
p6 all-clusters-app default (read/write) 2524552 2524504 -48 -0.0
.bss 118368 118368 0 0.0
.data 2784 2784 0 0.0
.text 1482816 1482768 -48 -0.0
light-app default (read/write) 2416304 2416256 -48 -0.0
.bss 111848 111848 0 0.0
.data 2584 2584 0 0.0
.text 1374568 1374520 -48 -0.0
lock-app default (read/write) 2420496 2420448 -48 -0.0
.bss 111648 111648 0 0.0
.data 2544 2544 0 0.0
.text 1378760 1378712 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801080 801048 -32 -0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570426 570394 -32 -0.0

bzbarsky-apple
bzbarsky-apple reviewed Apr 22, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

src/app/tests/TestCommandInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Show resolved Hide resolved
src/messaging/ReliableMessageContext.h Outdated Show resolved Hide resolved
src/messaging/tests/MessagingContext.h Outdated Show resolved Hide resolved
src/protocols/secure_channel/tests/TestMessageCounterManager.cpp Show resolved Hide resolved
src/transport/raw/tests/NetworkTestHelpers.h Show resolved Hide resolved
src/transport/raw/tests/NetworkTestHelpers.h Show resolved Hide resolved
@kghost kghost mentioned this pull request Apr 22, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 22, 2022 •
edited
Loading

PR #17622: Size comparison from 6109d14 to e545fdf

Increases (2 builds for cc13x2_26x2)
platform target config section 6109d14 e545fdf change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161936 161952 16 0.0
lock-ftd LP_CC2652R7 (read/write) 166532 166548 16 0.0
Decreases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 6109d14 e545fdf change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690991 690975 -16 -0.0
.text 584496 584480 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 677363 677347 -16 -0.0
.text 578092 578076 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 626115 626099 -16 -0.0
.text 526956 526940 -16 -0.0
pump-app LP_CC2652R7 (read only) 649183 649167 -16 -0.0
.text 573344 573328 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 642171 642155 -16 -0.0
.text 563192 563176 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618150 618134 -16 -0.0
.app_xip_area 525156 525140 -16 -0.0
lock cyw930739m2evb_01 (read/write) 613098 613082 -16 -0.0
.app_xip_area 521584 521568 -16 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565750 565726 -24 -0.0
.app_xip_area 464648 464624 -24 -0.0
efr32 lighting-app BRD4161A (read only) 905828 905796 -32 -0.0
.text 905820 905788 -32 -0.0
BRD4161A+rpc (read only) 940228 940196 -32 -0.0
.text 940220 940188 -32 -0.0
window-app BRD4161A (read only) 843316 843268 -48 -0.0
.text 843308 843260 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 998022 997990 -32 -0.0
.flash.text 998022 997990 -32 -0.0
m5stack (read only) 1052223 1052195 -28 -0.0
.flash.text 1046839 1046811 -28 -0.0
k32w light k32w061+release (read/write) 684144 684128 -16 -0.0
.text 598688 598672 -16 -0.0
lock k32w061+release (read/write) 725236 725220 -16 -0.0
.text 639188 639172 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10546220 10546108 -112 -0.0
.text 8908244 8908132 -112 -0.0
thermostat-no-ble arm64 (read only) 2361516 2361404 -112 -0.0
.text 1987312 1987200 -112 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170643 1170627 -16 -0.0
text 805680 805664 -16 -0.0
p6 all-clusters-app default (read/write) 2524552 2524504 -48 -0.0
.text 1482816 1482768 -48 -0.0
light-app default (read/write) 2416304 2416256 -48 -0.0
.text 1374568 1374520 -48 -0.0
lock-app default (read/write) 2420496 2420448 -48 -0.0
.text 1378760 1378712 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801080 801048 -32 -0.0
text 570426 570394 -32 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6109d14 e545fdf change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690991 690975 -16 -0.0
(read/write) 161936 161952 16 0.0
.bss 75912 75912 0 0.0
.data 3396 3396 0 0.0
.rodata 106015 106015 0 0.0
.text 584496 584480 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 677363 677347 -16 -0.0
(read/write) 166532 166548 16 0.0
.bss 73936 73936 0 0.0
.data 3220 3220 0 0.0
.rodata 98787 98787 0 0.0
.text 578092 578076 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 626115 626099 -16 -0.0
(read/write) 146732 146732 0 0.0
.bss 69656 69656 0 0.0
.data 3220 3220 0 0.0
.rodata 98667 98667 0 0.0
.text 526956 526940 -16 -0.0
pump-app LP_CC2652R7 (read only) 649183 649167 -16 -0.0
(read/write) 152500 152500 0 0.0
.bss 74368 74368 0 0.0
.data 3252 3252 0 0.0
.rodata 75351 75351 0 0.0
.text 573344 573328 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 642171 642155 -16 -0.0
(read/write) 151912 151912 0 0.0
.bss 74072 74072 0 0.0
.data 3216 3216 0 0.0
.rodata 78491 78491 0 0.0
.text 563192 563176 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618150 618134 -16 -0.0
.app_xip_area 525156 525140 -16 -0.0
.bss 75652 75652 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613098 613082 -16 -0.0
.app_xip_area 521584 521568 -16 -0.0
.bss 74204 74204 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565750 565726 -24 -0.0
.app_xip_area 464648 464624 -24 -0.0
.bss 83496 83496 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905828 905796 -32 -0.0
(read/write) 129380 129380 0 0.0
.bss 127336 127336 0 0.0
.data 2044 2044 0 0.0
.text 905820 905788 -32 -0.0
BRD4161A+rpc (read only) 940228 940196 -32 -0.0
(read/write) 146064 146064 0 0.0
.bss 143816 143816 0 0.0
.data 2248 2248 0 0.0
.text 940220 940188 -32 -0.0
window-app BRD4161A (read only) 843316 843268 -48 -0.0
(read/write) 127468 127468 0 0.0
.bss 125512 125512 0 0.0
.data 1956 1956 0 0.0
.text 843308 843260 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 998022 997990 -32 -0.0
(read/write) 1468074 1468074 0 0.0
.dram0.bss 62640 62640 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206560 206560 0 0.0
.flash.text 998022 997990 -32 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1052223 1052195 -28 -0.0
(read/write) 470080 470080 0 0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235916 235916 0 0.0
.flash.text 1046839 1046811 -28 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684144 684128 -16 -0.0
.bss 77656 77656 0 0.0
.data 2000 2000 0 0.0
.text 598688 598672 -16 -0.0
lock k32w061+release (read/write) 725236 725220 -16 -0.0
.bss 78288 78288 0 0.0
.data 1960 1960 0 0.0
.text 639188 639172 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10546220 10546108 -112 -0.0
(read/write) 497633 497633 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393088 393088 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 520316 520316 0 0.0
.text 8908244 8908132 -112 -0.0
thermostat-no-ble arm64 (read only) 2361516 2361404 -112 -0.0
(read/write) 151137 151137 0 0.0
.bss 62897 62897 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78992 78992 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145164 145164 0 0.0
.text 1987312 1987200 -112 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410108 2410108 0 0.0
.bss 184996 184996 0 0.0
.data 5848 5848 0 0.0
.text 1372708 1372708 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170643 1170627 -16 -0.0
bss 136264 136264 0 0.0
rodata 150052 150052 0 0.0
text 805680 805664 -16 -0.0
p6 all-clusters-app default (read/write) 2524552 2524504 -48 -0.0
.bss 118368 118368 0 0.0
.data 2784 2784 0 0.0
.text 1482816 1482768 -48 -0.0
light-app default (read/write) 2416304 2416256 -48 -0.0
.bss 111848 111848 0 0.0
.data 2584 2584 0 0.0
.text 1374568 1374520 -48 -0.0
lock-app default (read/write) 2420496 2420448 -48 -0.0
.bss 111648 111648 0 0.0
.data 2544 2544 0 0.0
.text 1378760 1378712 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801080 801048 -32 -0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570426 570394 -32 -0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Apr 22, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 22, 2022 •
edited
Loading

PR #17622: Size comparison from 6109d14 to 965169c

Increases (2 builds for cc13x2_26x2)
platform target config section 6109d14 965169c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161936 161952 16 0.0
lock-ftd LP_CC2652R7 (read/write) 166532 166548 16 0.0
Decreases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 6109d14 965169c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690991 690975 -16 -0.0
.text 584496 584480 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 677363 677347 -16 -0.0
.text 578092 578076 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 626115 626099 -16 -0.0
.text 526956 526940 -16 -0.0
pump-app LP_CC2652R7 (read only) 649183 649167 -16 -0.0
.text 573344 573328 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 642171 642155 -16 -0.0
.text 563192 563176 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618150 618134 -16 -0.0
.app_xip_area 525156 525140 -16 -0.0
lock cyw930739m2evb_01 (read/write) 613098 613082 -16 -0.0
.app_xip_area 521584 521568 -16 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565750 565726 -24 -0.0
.app_xip_area 464648 464624 -24 -0.0
efr32 lighting-app BRD4161A (read only) 905828 905796 -32 -0.0
.text 905820 905788 -32 -0.0
BRD4161A+rpc (read only) 940228 940196 -32 -0.0
.text 940220 940188 -32 -0.0
window-app BRD4161A (read only) 843316 843268 -48 -0.0
.text 843308 843260 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 998022 997990 -32 -0.0
.flash.text 998022 997990 -32 -0.0
m5stack (read only) 1052223 1052195 -28 -0.0
.flash.text 1046839 1046811 -28 -0.0
k32w light k32w061+release (read/write) 684144 684128 -16 -0.0
.text 598688 598672 -16 -0.0
lock k32w061+release (read/write) 725236 725220 -16 -0.0
.text 639188 639172 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10546220 10546108 -112 -0.0
.text 8908244 8908132 -112 -0.0
thermostat-no-ble arm64 (read only) 2361516 2361404 -112 -0.0
.text 1987312 1987200 -112 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170643 1170627 -16 -0.0
text 805680 805664 -16 -0.0
p6 all-clusters-app default (read/write) 2524552 2524504 -48 -0.0
.text 1482816 1482768 -48 -0.0
light-app default (read/write) 2416304 2416256 -48 -0.0
.text 1374568 1374520 -48 -0.0
lock-app default (read/write) 2420496 2420448 -48 -0.0
.text 1378760 1378712 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801080 801048 -32 -0.0
text 570426 570394 -32 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6109d14 965169c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690991 690975 -16 -0.0
(read/write) 161936 161952 16 0.0
.bss 75912 75912 0 0.0
.data 3396 3396 0 0.0
.rodata 106015 106015 0 0.0
.text 584496 584480 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 677363 677347 -16 -0.0
(read/write) 166532 166548 16 0.0
.bss 73936 73936 0 0.0
.data 3220 3220 0 0.0
.rodata 98787 98787 0 0.0
.text 578092 578076 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 626115 626099 -16 -0.0
(read/write) 146732 146732 0 0.0
.bss 69656 69656 0 0.0
.data 3220 3220 0 0.0
.rodata 98667 98667 0 0.0
.text 526956 526940 -16 -0.0
pump-app LP_CC2652R7 (read only) 649183 649167 -16 -0.0
(read/write) 152500 152500 0 0.0
.bss 74368 74368 0 0.0
.data 3252 3252 0 0.0
.rodata 75351 75351 0 0.0
.text 573344 573328 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 642171 642155 -16 -0.0
(read/write) 151912 151912 0 0.0
.bss 74072 74072 0 0.0
.data 3216 3216 0 0.0
.rodata 78491 78491 0 0.0
.text 563192 563176 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618150 618134 -16 -0.0
.app_xip_area 525156 525140 -16 -0.0
.bss 75652 75652 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613098 613082 -16 -0.0
.app_xip_area 521584 521568 -16 -0.0
.bss 74204 74204 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565750 565726 -24 -0.0
.app_xip_area 464648 464624 -24 -0.0
.bss 83496 83496 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905828 905796 -32 -0.0
(read/write) 129380 129380 0 0.0
.bss 127336 127336 0 0.0
.data 2044 2044 0 0.0
.text 905820 905788 -32 -0.0
BRD4161A+rpc (read only) 940228 940196 -32 -0.0
(read/write) 146064 146064 0 0.0
.bss 143816 143816 0 0.0
.data 2248 2248 0 0.0
.text 940220 940188 -32 -0.0
window-app BRD4161A (read only) 843316 843268 -48 -0.0
(read/write) 127468 127468 0 0.0
.bss 125512 125512 0 0.0
.data 1956 1956 0 0.0
.text 843308 843260 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 998022 997990 -32 -0.0
(read/write) 1468074 1468074 0 0.0
.dram0.bss 62640 62640 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206560 206560 0 0.0
.flash.text 998022 997990 -32 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1052223 1052195 -28 -0.0
(read/write) 470080 470080 0 0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235916 235916 0 0.0
.flash.text 1046839 1046811 -28 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684144 684128 -16 -0.0
.bss 77656 77656 0 0.0
.data 2000 2000 0 0.0
.text 598688 598672 -16 -0.0
lock k32w061+release (read/write) 725236 725220 -16 -0.0
.bss 78288 78288 0 0.0
.data 1960 1960 0 0.0
.text 639188 639172 -16 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10546220 10546108 -112 -0.0
(read/write) 497633 497633 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393088 393088 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 520316 520316 0 0.0
.text 8908244 8908132 -112 -0.0
thermostat-no-ble arm64 (read only) 2361516 2361404 -112 -0.0
(read/write) 151137 151137 0 0.0
.bss 62897 62897 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78992 78992 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145164 145164 0 0.0
.text 1987312 1987200 -112 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410108 2410108 0 0.0
.bss 184996 184996 0 0.0
.data 5848 5848 0 0.0
.text 1372708 1372708 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170643 1170627 -16 -0.0
bss 136264 136264 0 0.0
rodata 150052 150052 0 0.0
text 805680 805664 -16 -0.0
p6 all-clusters-app default (read/write) 2524552 2524504 -48 -0.0
.bss 118368 118368 0 0.0
.data 2784 2784 0 0.0
.text 1482816 1482768 -48 -0.0
light-app default (read/write) 2416304 2416256 -48 -0.0
.bss 111848 111848 0 0.0
.data 2584 2584 0 0.0
.text 1374568 1374520 -48 -0.0
lock-app default (read/write) 2420496 2420448 -48 -0.0
.bss 111648 111648 0 0.0
.data 2544 2544 0 0.0
.text 1378760 1378712 -48 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801080 801048 -32 -0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570426 570394 -32 -0.0

@andy31415 andy31415 merged commit 4aa0d5f into project-chip:master Apr 22, 2022
@kghost kghost deleted the test-1 branch April 22, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
app controller review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @andy31415 @bzbarsky-apple