Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tests drain all message in loopback transport #17624

Closed
Tracked by #17622
kghost opened this issue Apr 22, 2022 · 1 comment · Fixed by #18709
Closed
Tracked by #17622

Ensure tests drain all message in loopback transport #17624

kghost opened this issue Apr 22, 2022 · 1 comment · Fixed by #18709

Comments

@kghost
Copy link
Contributor

kghost commented Apr 22, 2022

Problem

Some tests leaves messages in async loopback transport after complete, we should ensure that all tests drain all messages after completion.

Proposed Solution

Add DrainAndServiceIO after such test cases.
@kghost kghost mentioned this issue Apr 22, 2022
Merged
2 tasks
@bzbarsky-apple
Copy link
Contributor

#17622 (comment) has one such test that needs fixing.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 21, 2022
@bzbarsky-apple
Fail unit tests that leave messages sitting around undrained.
e192d50 
Tests might be accidentally forgetting to drain their messages, and
hence think messages got delivered when they did not.  Fail the tests
if that happens.

Fixes project-chip#17624
@bzbarsky-apple bzbarsky-apple mentioned this issue May 21, 2022
Merged
Damian-Nordic pushed a commit that referenced this issue May 23, 2022
@bzbarsky-apple
Fail unit tests that leave messages sitting around undrained. (#18709)
ede4262 
Tests might be accidentally forgetting to drain their messages, and
hence think messages got delivered when they did not.  Fail the tests
if that happens.

Fixes #17624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail unit tests that leave messages sitting around undrained. bzbarsky-apple/connectedhomeip
2 participants
@kghost @bzbarsky-apple