-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Allow test suite applications to be launched with custom commandline options #17469
Merged
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ci_test_suite_dict_command_options
Apr 20, 2022
Merged
[CI] Allow test suite applications to be launched with custom commandline options #17469
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ci_test_suite_dict_command_options
Apr 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02,
msandstedt and
mspang
April 18, 2022 20:50
carol-apple
force-pushed
the
ci_test_suite_dict_command_options
branch
2 times, most recently
from
April 19, 2022 03:22
964b87d
to
517c061
Compare
PR #17469: Size comparison from 8793870 to 517c061 Increases (1 build for linux)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
carol-apple
force-pushed
the
ci_test_suite_dict_command_options
branch
from
April 19, 2022 18:31
517c061
to
95fa181
Compare
carol-apple
force-pushed
the
ci_test_suite_dict_command_options
branch
from
April 19, 2022 18:33
95fa181
to
0d7626f
Compare
PR #17469: Size comparison from 03ea72d to 0d7626f Increases (1 build for linux)
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
carol-apple
force-pushed
the
ci_test_suite_dict_command_options
branch
from
April 19, 2022 19:02
0d7626f
to
0937a17
Compare
PR #17469: Size comparison from 03ea72d to 0937a17 Increases (1 build for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
carol-apple
force-pushed
the
ci_test_suite_dict_command_options
branch
from
April 19, 2022 22:27
0937a17
to
d628647
Compare
PR #17469: Size comparison from d06f4a1 to d628647 Increases (1 build for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
vivien-apple
approved these changes
Apr 20, 2022
andy31415
reviewed
Apr 20, 2022
carol-apple
force-pushed
the
ci_test_suite_dict_command_options
branch
from
April 20, 2022 17:53
d628647
to
cd596ef
Compare
carol-apple
force-pushed
the
ci_test_suite_dict_command_options
branch
from
April 20, 2022 17:57
cd596ef
to
aa8ef06
Compare
PR #17469: Size comparison from bd2c21a to aa8ef06 Increases (1 build for linux)
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Apr 20, 2022
andy31415
reviewed
Apr 20, 2022
andy31415
approved these changes
Apr 20, 2022
PR #17469: Size comparison from bd2c21a to e378747 Increases (1 build for linux)
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
carol-apple
force-pushed
the
ci_test_suite_dict_command_options
branch
from
April 20, 2022 19:19
e378747
to
a3547da
Compare
PR #17469: Size comparison from 89a1dde to a3547da Increases (2 builds for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The applications launched in the test suite only takes discriminator as a command line option
Change overview
SystemCommands::Start
andSystemCommand::Reboot
to pass in--discriminator
so that the command line options can be generically generatedTesting
No functional change, tree compiles, test suite tests pass