-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unhelpful ParseArgs help text validation #17394
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
tcarmelveilleux:remove-unneeded-help-checks
Apr 14, 2022
Merged
Remove unhelpful ParseArgs help text validation #17394
bzbarsky-apple
merged 1 commit into
project-chip:master
from
tcarmelveilleux:remove-unneeded-help-checks
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Help text validation when CHIP_CONFIG_ENABLE_ARG_PARSER_VALIDITY_CHECKS are enabled are both unhelpful and unsafe. Unhelpful because such failures are unlikely to get better code delivered, and unsafe because the algorithms used make use of sketchy tricky code with negative indexing that was shown to sometimes fail on ARM builds. This PR removes the help content checks Fixes project-chip#17323
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt and
robszewczyk
April 14, 2022 12:29
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
April 14, 2022 12:29
PR #17394: Size comparison from 01e54b2 to 0a610a5 Decreases (1 build for linux)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Apr 14, 2022
Damian-Nordic
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CHIP_CONFIG_ENABLE_ARG_PARSER_VALIDITY_CHECKS are enabled
are both unhelpful and unsafe. Unhelpful because
such failures are unlikely to get better code delivered,
and unsafe because the algorithms used make use of
sketchy tricky code with negative indexing that was shown
to sometimes fail on ARM builds.
Fixes #17323
Change overview
This PR removes the help content checks
Testing