Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable arg parser validity checks #17375

Closed
wants to merge 1 commit into from
Closed

disable arg parser validity checks #17375

wants to merge 1 commit into from

Conversation

cjandhyala
Copy link
Contributor

What is being fixed?
disabled arg parser validity checks

Change overview

disabled CHIP_CONFIG_ENABLE_ARG_PARSER_VALIDITY_CHECKS

Testing

compiled and provisioned all-cluster-app on raspi platform

@boring-cyborg boring-cyborg bot added the lib label Apr 14, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

andy31415
andy31415 requested changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the summary with why the change is being made

@andy31415
Copy link
Contributor

Note that #17394 is already merged and I understand that fixes some ARM64 abi strangeness (we do not need that validation logic).

Beyond that, this PR does not explain why it does things. Needs an actual answer on What is being fixed? as the description of "disabled arg parser validity checks" is what the PR does rather than a description of what is broken and being fixed.

@stale
Copy link

stale bot commented Apr 22, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 22, 2022
@stale
Copy link

stale bot commented Apr 29, 2022

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 requested changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

Assignees
No one assigned
Labels
lib stale Stale issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjandhyala @CLAassistant @andy31415 @bzbarsky-apple