-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial yaml test for ArmFailSafe timeout test #17367
Add initial yaml test for ArmFailSafe timeout test #17367
Conversation
PR #17367: Size comparison from 3b0302a to f0e510a Full report (20 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
|
src/app/zap-templates/common/simulated-clusters/clusters/CommissionerCommands.js
Outdated
Show resolved
Hide resolved
src/app/zap-templates/common/simulated-clusters/clusters/CommissionerCommands.js
Outdated
Show resolved
Hide resolved
PR #17367: Size comparison from 376ce66 to e9caf9e Full report (21 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
|
PR #17367: Size comparison from 30edacd to d342938 Increases (2 builds for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17367: Size comparison from 0680f21 to a6a043e Increases (2 builds for linux)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17367: Size comparison from 4967c0e to 879a942 Increases (2 builds for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17367: Size comparison from 8793870 to 4ee3b74 Increases (1 build for linux)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17367: Size comparison from d06f4a1 to 3da3e60 Increases (2 builds for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as far as it goes, but it's an extremely indirect test of the failsafe bits....
I just updated the PR and addressed your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, seems fine, but is not actually testing anything about the fail-safe being armed or not armed...
PR #17367: Size comparison from c77810b to 64ea0f2 Increases (2 builds for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Problem
What is being fixed? Examples:
Change overview
Add initial yaml test for ArmFailSafe timeout test
Testing
How was this tested? (at least one bullet point required)