Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml test for FailSafe timeout test #16379

Closed
yufengwangca opened this issue Mar 17, 2022 · 0 comments · Fixed by #17367
Closed

Add yaml test for FailSafe timeout test #16379

yufengwangca opened this issue Mar 17, 2022 · 0 comments · Fixed by #17367
Assignees

Comments

@yufengwangca
Copy link
Contributor

Problem

Also if I am not missing anything that means we need to capture the two "command has been invoked" booleans in the event. Those and the fabric index are the only things this function uses from the failsafe context, and the index is already in the event.

And we should have tests here. Doing AddNOC in yaml is not exactly trivial right now, but if we can add a way to do that, we could presumably test this with a very short failsafe period.....

Proposed Solution

<suggested fix, suggested enhancement>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant