[XML] Correct the PCC cluster xml to reflect the specification #17181

tlykkeberg-grundfos · 2022-04-07T15:57:36Z

Problem

The PCC cluster xml does not fully reflect the specification
Min and max values for some attributes in the PCC was wrong
Add some non-default access priviledges to the PCC
Set the ClusterRevision to be '3'
Fixes Pump configuration cluster attributes that should be nullable are not marked that way in the XML #16550
Fixes Pump Control and Configuration ControlMode and OperationMode should have min/max specified in XML #17112
Fixes Global Attribute Cluster Revision needs to be fixed for Pump Configuration and Control Cluster #9769

Change overview

Added isNullable="true" to the attributes which is specified to have this posibillity
Corrected the min and max for all attributes to reflect the specification
Added RW VM to the LifeTimeRunningHours and LifeTimeConsumedEnergy attribs.
PR Update more cluster access privileges #17115 will re-generate the zzz_generated when this PR is done

Testing

Removed the files in ~/.zap and started ZAP gui tool and loaded the pump-app.zap
Inspected the attributes in the zap tool
Verified that the tool could open without errors
Regenerated all using zap_regen_all.py and verified that it did not fail

mgarb1 · 2022-04-07T16:29:04Z

Also fixes #17112

github-actions · 2022-04-07T16:54:57Z

PR #17181: Size comparison from c73d34f to 2237907

Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`c73d34f`	`2237907`
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	674515	674515
			(read/write)	176964	176964
			.bss	81520	81520
			.data	3216	3216
			.rodata	80563	80563
			.text	593472	593472
	lock-mtd	LP_CC2652R7	(read only)	623651	623651
			(read/write)	154320	154320
			.bss	77248	77248
			.data	3216	3216
			.rodata	80451	80451
			.text	542712	542712
	pump-app	LP_CC2652R7	(read only)	681875	681875
			(read/write)	170780	170780
			.bss	81928	81928
			.data	3248	3248
			.rodata	75243	75243
			.text	606148	606148
	pump-controller-app	LP_CC2652R7	(read only)	676219	676219
			(read/write)	176164	176164
			.bss	81656	81656
			.data	3212	3212
			.rodata	79027	79027
			.text	596708	596708
efr32	lighting-app	BRD4161A	(read only)	904908	904908
			(read/write)	133160	133160
			.bss	131120	131120
			.data	2040	2040
			.text	904900	904900
		BRD4161A+rpc	(read only)	932780	932780
			(read/write)	149108	149108
			.bss	146888	146888
			.data	2220	2220
			.text	932772	932772
	window-app	BRD4161A	(read only)	842196	842196
			(read/write)	131228	131228
			.bss	129280	129280
			.data	1948	1948
			.text	842188	842188
esp32	all-clusters-app	c3devkit	(read only)	991900	991900
			(read/write)	1461762	1461762
			.dram0.bss	62936	62936
			.dram0.data	14356	14356
			.flash.rodata	198984	198984
			.flash.text	991900	991900
			.iram0.text	62572	62572
		m5stack	(read only)	1044615	1044615
			(read/write)	462816	462816
			.dram0.bss	68464	68464
			.dram0.data	34160	34160
			.flash.rodata	228048	228048
			.flash.text	1039231	1039231
			.iram0.text	123415	123415
k32w	light	k32w061+release	(read/write)	685148	685148
			.bss	78208	78208
			.data	2036	2036
			.text	599104	599104
	lock	k32w061+release	(read/write)	689932	689932
			.bss	78784	78784
			.data	1996	1996
			.text	603352	603352
linux	all-clusters-app	debug	(read only)	2622689	2622689
			(read/write)	145640	145640
			.bss	57664	57664
			.data	1824	1824
			.data.rel.ro	80264	80264
			.dynamic	592	592
			.got	4320	4320
			.init	27	27
			.init_array	960	960
			.rodata	222405	222405
			.text	2231410	2231410
	bridge-app	debug+rpc	(read only)	1831421	1831421
			(read/write)	91304	91304
			.bss	44344	44344
			.data	2912	2912
			.data.rel.ro	38936	38936
			.dynamic	592	592
			.got	3936	3936
			.init	27	27
			.init_array	552	552
			.rodata	148281	148281
			.text	1565669	1565669
	chip-tool	debug	(read only)	10678981	10678981
			(read/write)	371736	371736
			.bss	22752	22752
			.data	1104	1104
			.data.rel.ro	341632	341632
			.dynamic	624	624
			.got	4928	4928
			.init	27	27
			.init_array	656	656
			.rodata	538357	538357
			.text	`9311685`	`9311685`
	chip-tool-no-interactive-ipv6only	arm64	(read only)	10280572	10280572
			(read/write)	492145	492145
			.bss	41009	41009
			.data	1168	1168
			.data.rel.ro	388776	388776
			.dynamic	560	560
			.got	57392	57392
			.init	24	24
			.init_array	184	184
			.rodata	512524	512524
			.text	8665012	8665012
	door-lock-app	debug	(read only)	2102513	2102513
			(read/write)	119024	119024
			.bss	47936	47936
			.data	1472	1472
			.data.rel.ro	64056	64056
			.dynamic	592	592
			.got	4264	4264
			.init	27	27
			.init_array	680	680
			.rodata	186313	186313
			.text	1761554	1761554
	lighting-app	debug+rpc	(read only)	2305017	2305017
			(read/write)	127344	127344
			.bss	50144	50144
			.data	1952	1952
			.data.rel.ro	69544	69544
			.dynamic	608	608
			.got	4312	4312
			.init	27	27
			.init_array	776	776
			.rodata	181513	181513
			.text	`1958770`	`1958770`
	ota-provider-app	debug	(read only)	2040353	2040353
			(read/write)	114592	114592
			.bss	47840	47840
			.data	1608	1608
			.data.rel.ro	59384	59384
			.dynamic	608	608
			.got	4464	4464
			.init	27	27
			.init_array	632	632
			.rodata	172323	172323
			.text	`1712466`	`1712466`
	ota-requestor-app	debug	(read only)	2069657	2069657
			(read/write)	117880	117880
			.bss	48800	48800
			.data	1864	1864
			.data.rel.ro	61624	61624
			.dynamic	592	592
			.got	4304	4304
			.init	27	27
			.init_array	656	656
			.rodata	168716	168716
			.text	1743602	1743602
	shell	debug	(read only)	2517473	2517473
			(read/write)	149168	149168
			.bss	67368	67368
			.data	1264	1264
			.data.rel.ro	74808	74808
			.dynamic	592	592
			.got	4168	4168
			.init	27	27
			.init_array	928	928
			.rodata	214002	214002
			.text	2144082	2144082
	thermostat-no-ble	arm64	(read only)	2348476	2348476
			(read/write)	150497	150497
			.bss	63025	63025
			.data	1424	1424
			.data.rel.ro	78264	78264
			.dynamic	560	560
			.got	4768	4768
			.init	24	24
			.init_array	368	368
			.rodata	144428	144428
			.text	1976576	1976576
	tv-app	debug	(read only)	2793393	2793393
			(read/write)	251096	251096
			.bss	165032	165032
			.data	4448	4448
			.data.rel.ro	75408	75408
			.dynamic	592	592
			.got	4680	4680
			.init	27	27
			.init_array	904	904
			.rodata	213291	213291
			.text	2400386	2400386
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2366844	2366844
			.bss	185060	185060
			.data	5840	5840
			.text	`1329444`	`1329444`
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1153375	1153375
			bss	135540	135540
			rodata	145832	145832
			text	793388	793388
p6	all-clusters-app	default	(read/write)	2512552	2512552
			.bss	118464	118464
			.data	2768	2768
			.text	1470816	1470816
	light-app	default	(read/write)	2413576	2413576
			.bss	111960	111960
			.data	2576	2576
			.text	1371840	1371840
	lock-app	default	(read/write)	`2377208`	`2377208`
			.bss	111704	111704
			.data	2536	2536
			.text	`1335472`	`1335472`
telink	lighting-app	tlsr9518adk80d	(read/write)	799240	799240
			bss	70064	70064
			noinit	40416	40416
			text	568274	568274

github-actions · 2022-04-07T18:55:55Z

PR #17181: Size comparison from c73d34f to 974580a

Full report (3 builds for mbed, nrfconnect, telink)

platform	target	config	section	`c73d34f`	`974580a`
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2366844	2366844
			.bss	185060	185060
			.data	5840	5840
			.text	`1329444`	`1329444`
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1153375	1153375
			bss	135540	135540
			rodata	145832	145832
			text	793388	793388
telink	lighting-app	tlsr9518adk80d	(read/write)	799240	799240
			bss	70064	70064
			noinit	40416	40416
			text	568274	568274

…LifetimeEnergyConsumed

github-actions · 2022-04-11T14:48:13Z

PR #17181: Size comparison from 087163c to 93f9e75

Increases above 0.2%:

platform	target	config	section	`087163c`	`93f9e75`	change	% change
linux	chip-tool	debug	(read only)	10677869	10712429	34560	0.3
			.text	`9310517`	`9344597`	34080	0.4
	chip-tool-no-interactive-ipv6only	arm64	(read only)	10279036	`1031119`	32160	0.3
			.got	57392	57536	144	0.3
			.text	8663428	`8694196`	30768	0.4

Increases (9 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6)

platform	target	config	section	`087163c`	`93f9e75`	change	% change
cc13x2_26x2	pump-app	LP_CC2652R7	(read only)	647199	647383	184	0.0
			.rodata	75103	75143	40	0.1
			.text	571608	571752	144	0.0
esp32	all-clusters-app	c3devkit	(read/write)	`1462514`	1462554	40	0.0
			.flash.rodata	199720	199760	40	0.0
		m5stack	(read/write)	463576	463616	40	0.0
			.flash.rodata	228792	228832	40	0.0
linux	all-clusters-app	debug	(read only)	2627169	2627233	64	0.0
			.rodata	222821	222885	64	0.0
	chip-tool	debug	(read only)	10677869	10712429	34560	0.3
			(read/write)	371800	371992	192	0.1
			.data.rel.ro	341680	341872	192	0.1
			.text	`9310517`	`9344597`	34080	0.4
	chip-tool-no-interactive-ipv6only	arm64	(read only)	10279036	`1031119`	32160	0.3
			(read/write)	492193	492625	432	0.1
			.data.rel.ro	388824	389112	288	0.1
			.got	57392	57536	144	0.3
			.rodata	512428	512812	384	0.1
			.text	8663428	`8694196`	30768	0.4
	shell	debug	(read only)	`2521953`	2522017	64	0.0
			.rodata	214418	214482	64	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1154967	1155003	36	0.0
			rodata	146544	146580	36	0.0
p6	all-clusters-app	default	(read/write)	2514152	2514184	32	0.0
			.text	1472416	1472448	32	0.0

Decreases (1 build for esp32)

platform	target	config	section	`087163c`	`93f9e75`	change	% change
esp32	all-clusters-app	m5stack	(read only)	1045591	1045575	-16	-0.0
			.flash.text	1040207	1040191	-16	-0.0

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`087163c`	`93f9e75`	change	% change
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	639379	639379	0	0.0
			(read/write)	151052	151052	0	0.0
			.bss	73984	73984	0	0.0
			.data	3212	3212	0	0.0
			.rodata	79955	79955	0	0.0
			.text	558932	558932	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	588115	588115	0	0.0
			(read/write)	146772	146772	0	0.0
			.bss	69704	69704	0	0.0
			.data	3212	3212	0	0.0
			.rodata	79835	79835	0	0.0
			.text	507788	507788	0	0.0
	pump-app	LP_CC2652R7	(read only)	647199	647383	184	0.0
			(read/write)	152348	152348	0	0.0
			.bss	74480	74480	0	0.0
			.data	3244	3244	0	0.0
			.rodata	75103	75143	40	0.1
			.text	571608	571752	144	0.0
	pump-controller-app	LP_CC2652R7	(read only)	641419	641419	0	0.0
			(read/write)	152016	152016	0	0.0
			.bss	74184	74184	0	0.0
			.data	3208	3208	0	0.0
			.rodata	78763	78763	0	0.0
			.text	562168	562168	0	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	617822	617822	0	0.0
			.app_xip_area	524948	524948	0	0.0
			.bss	75540	75540	0	0.0
			.data	684	684	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	575426	575426	0	0.0
			.app_xip_area	484088	484088	0	0.0
			.bss	74036	74036	0	0.0
			.data	648	648	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	563918	563918	0	0.0
			.app_xip_area	462952	462952	0	0.0
			.bss	83368	83368	0	0.0
			.data	564	564	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	906400	906400	0	0.0
			(read/write)	132920	132920	0	0.0
			.bss	130880	130880	0	0.0
			.data	2040	2040	0	0.0
			.text	906392	906392	0	0.0
		BRD4161A+rpc	(read only)	934272	934272	0	0.0
			(read/write)	148872	148872	0	0.0
			.bss	146648	146648	0	0.0
			.data	2220	2220	0	0.0
			.text	934264	934264	0	0.0
	window-app	BRD4161A	(read only)	843688	843688	0	0.0
			(read/write)	130992	130992	0	0.0
			.bss	129040	129040	0	0.0
			.data	1948	1948	0	0.0
			.text	843680	843680	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	992918	992918	0	0.0
			(read/write)	`1462514`	1462554	40	0.0
			.dram0.bss	62960	62960	0	0.0
			.dram0.data	14364	14364	0	0.0
			.flash.rodata	199720	199760	40	0.0
			.flash.text	992918	992918	0	0.0
			.iram0.text	62572	62572	0	0.0
		m5stack	(read only)	1045591	1045575	-16	-0.0
			(read/write)	463576	463616	40	0.0
			.dram0.bss	68480	68480	0	0.0
			.dram0.data	34160	34160	0	0.0
			.flash.rodata	228792	228832	40	0.0
			.flash.text	1040207	1040191	-16	-0.0
			.iram0.text	123415	123415	0	0.0
k32w	light	k32w061+release	(read/write)	686348	686348	0	0.0
			.bss	77968	77968	0	0.0
			.data	2036	2036	0	0.0
			.text	600544	600544	0	0.0
	lock	k32w061+release	(read/write)	690948	690948	0	0.0
			.bss	78544	78544	0	0.0
			.data	1996	1996	0	0.0
			.text	604608	604608	0	0.0
linux	all-clusters-app	debug	(read only)	2627169	2627233	64	0.0
			(read/write)	146248	146248	0	0.0
			.bss	57664	57664	0	0.0
			.data	1824	1824	0	0.0
			.data.rel.ro	80856	80856	0	0.0
			.dynamic	592	592	0	0.0
			.got	4320	4320	0	0.0
			.init	27	27	0	0.0
			.init_array	960	960	0	0.0
			.rodata	222821	222885	64	0.0
			.text	`2233746`	`2233746`	0	0.0
	bridge-app	debug+rpc	(read only)	1834861	1834861	0	0.0
			(read/write)	91592	91592	0	0.0
			.bss	44344	44344	0	0.0
			.data	2912	2912	0	0.0
			.data.rel.ro	39240	39240	0	0.0
			.dynamic	592	592	0	0.0
			.got	3936	3936	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	148473	148473	0	0.0
			.text	1568053	1568053	0	0.0
	chip-tool	debug	(read only)	10677869	10712429	34560	0.3
			(read/write)	371800	371992	192	0.1
			.bss	22752	22752	0	0.0
			.data	1104	1104	0	0.0
			.data.rel.ro	341680	341872	192	0.1
			.dynamic	624	624	0	0.0
			.got	4936	4936	0	0.0
			.init	27	27	0	0.0
			.init_array	656	656	0	0.0
			.rodata	538165	538165	0	0.0
			.text	`9310517`	`9344597`	34080	0.4
	chip-tool-no-interactive-ipv6only	arm64	(read only)	10279036	`1031119`	32160	0.3
			(read/write)	492193	492625	432	0.1
			.bss	41009	41009	0	0.0
			.data	1168	1168	0	0.0
			.data.rel.ro	388824	389112	288	0.1
			.dynamic	560	560	0	0.0
			.got	57392	57536	144	0.3
			.init	24	24	0	0.0
			.init_array	184	184	0	0.0
			.rodata	512428	512812	384	0.1
			.text	8663428	`8694196`	30768	0.4
	door-lock-app	debug	(read only)	2106209	2106209	0	0.0
			(read/write)	119344	119344	0	0.0
			.bss	47936	47936	0	0.0
			.data	1472	1472	0	0.0
			.data.rel.ro	64392	64392	0	0.0
			.dynamic	592	592	0	0.0
			.got	4264	4264	0	0.0
			.init	27	27	0	0.0
			.init_array	680	680	0	0.0
			.rodata	186665	186665	0	0.0
			.text	1763938	1763938	0	0.0
	lighting-app	debug+rpc	(read only)	2308649	2308649	0	0.0
			(read/write)	127664	127664	0	0.0
			.bss	50144	50144	0	0.0
			.data	1952	1952	0	0.0
			.data.rel.ro	69864	69864	0	0.0
			.dynamic	608	608	0	0.0
			.got	4312	4312	0	0.0
			.init	27	27	0	0.0
			.init_array	776	776	0	0.0
			.rodata	181673	181673	0	0.0
			.text	1961234	1961234	0	0.0
	ota-provider-app	debug	(read only)	2043393	2043393	0	0.0
			(read/write)	114784	114784	0	0.0
			.bss	47840	47840	0	0.0
			.data	1608	1608	0	0.0
			.data.rel.ro	59576	59576	0	0.0
			.dynamic	608	608	0	0.0
			.got	4464	4464	0	0.0
			.init	27	27	0	0.0
			.init_array	632	632	0	0.0
			.rodata	172451	172451	0	0.0
			.text	1714850	1714850	0	0.0
	ota-requestor-app	debug	(read only)	2073145	2073145	0	0.0
			(read/write)	118104	118104	0	0.0
			.bss	48800	48800	0	0.0
			.data	1864	1864	0	0.0
			.data.rel.ro	61832	61832	0	0.0
			.dynamic	592	592	0	0.0
			.got	4304	4304	0	0.0
			.init	27	27	0	0.0
			.init_array	656	656	0	0.0
			.rodata	169132	169132	0	0.0
			.text	1746050	1746050	0	0.0
	shell	debug	(read only)	`2521953`	2522017	64	0.0
			(read/write)	149680	149680	0	0.0
			.bss	67368	67368	0	0.0
			.data	1264	1264	0	0.0
			.data.rel.ro	75336	75336	0	0.0
			.dynamic	592	592	0	0.0
			.got	4168	4168	0	0.0
			.init	27	27	0	0.0
			.init_array	928	928	0	0.0
			.rodata	214418	214482	64	0.0
			.text	2146466	2146466	0	0.0
	thermostat-no-ble	arm64	(read only)	2351724	2351724	0	0.0
			(read/write)	150833	150833	0	0.0
			.bss	63025	63025	0	0.0
			.data	1424	1424	0	0.0
			.data.rel.ro	78600	78600	0	0.0
			.dynamic	560	560	0	0.0
			.got	4768	4768	0	0.0
			.init	24	24	0	0.0
			.init_array	368	368	0	0.0
			.rodata	144652	144652	0	0.0
			.text	`1978592`	`1978592`	0	0.0
	tv-app	debug	(read only)	2796961	2796961	0	0.0
			(read/write)	251576	251576	0	0.0
			.bss	165032	165032	0	0.0
			.data	4448	4448	0	0.0
			.data.rel.ro	75888	75888	0	0.0
			.dynamic	592	592	0	0.0
			.got	4688	4688	0	0.0
			.init	27	27	0	0.0
			.init_array	904	904	0	0.0
			.rodata	213451	213451	0	0.0
			.text	2402306	2402306	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2367996`	`2367996`	0	0.0
			.bss	185076	185076	0	0.0
			.data	5840	5840	0	0.0
			.text	1330596	1330596	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1154967	1155003	36	0.0
			bss	135304	135304	0	0.0
			rodata	146544	146580	36	0.0
			text	794408	794408	0	0.0
p6	all-clusters-app	default	(read/write)	2514152	2514184	32	0.0
			.bss	118480	118480	0	0.0
			.data	2768	2768	0	0.0
			.text	1472416	1472448	32	0.0
	light-app	default	(read/write)	2414840	2414840	0	0.0
			.bss	111976	111976	0	0.0
			.data	2576	2576	0	0.0
			.text	1373104	1373104	0	0.0
	lock-app	default	(read/write)	`2378408`	`2378408`	0	0.0
			.bss	111720	111720	0	0.0
			.data	2536	2536	0	0.0
			.text	1336672	1336672	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	800600	800600	0	0.0
			bss	69828	69828	0	0.0
			noinit	40416	40416	0	0.0
			text	569474	569474	0	0.0

bzbarsky-apple · 2022-04-11T23:09:03Z

@tlykkeberg-grundfos Needs a rebase/merge?

github-actions · 2022-04-12T07:57:30Z

PR #17181: Size comparison from c9350f7 to 001260d

Full report (10 builds for cyw30739, efr32, k32w, mbed, telink)

platform	target	config	section	`c9350f7`	`001260d`
cyw30739	light	cyw930739m2evb_01	(read/write)	618490	618490
			.app_xip_area	525200	525200
			.bss	75956	75956
			.data	684	684
			.rodata	0	0
			.text	0	0
	lock	cyw930739m2evb_01	(read/write)	576102	576102
			.app_xip_area	484348	484348
			.bss	74452	74452
			.data	648	648
			.rodata	0	0
			.text	0	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	564618	564618
			.app_xip_area	463236	463236
			.bss	83784	83784
			.data	564	564
			.rodata	0	0
			.text	112	112
efr32	lighting-app	BRD4161A	(read only)	907004	907004
			(read/write)	133080	133080
			.bss	131040	131040
			.data	2040	2040
			.text	906996	906996
		BRD4161A+rpc	(read only)	934876	934876
			(read/write)	149028	149028
			.bss	146808	146808
			.data	2220	2220
			.text	934868	934868
	window-app	BRD4161A	(read only)	843996	843996
			(read/write)	131148	131148
			.bss	129200	129200
			.data	1948	1948
			.text	843988	843988
k32w	light	k32w061+release	(read/write)	686712	686712
			.bss	78128	78128
			.data	2036	2036
			.text	600748	600748
	lock	k32w061+release	(read/write)	691344	691344
			.bss	78704	78704
			.data	1996	1996
			.text	604844	604844
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2368260	2368260
			.bss	185236	185236
			.data	5840	5840
			.text	1330860	1330860
telink	lighting-app	tlsr9518adk80d	(read/write)	800984	800984
			bss	69988	69988
			noinit	40416	40416
			text	569678	569678

github-actions · 2022-04-12T11:54:14Z

PR #17181: Size comparison from c9350f7 to ceb6b1f

Increases above 0.2%:

platform	target	config	section	`c9350f7`	`ceb6b1f`	change	% change
efr32	lighting-app	BRD4161A+rpc	(read only)	934876	941372	6496	0.7
			(read/write)	149028	149764	736	0.5
			.bss	146808	147520	712	0.5
			.data	2220	2244	24	1.1
			.text	934868	941364	6496	0.7

Increases (7 builds for cyw30739, efr32, k32w, telink)

platform	target	config	section	`c9350f7`	`ceb6b1f`	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	618490	618514	24	0.0
			.app_xip_area	525200	525224	24	0.0
	lock	cyw930739m2evb_01	(read/write)	576102	576126	24	0.0
			.app_xip_area	484348	484372	24	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	564618	564642	24	0.0
			.app_xip_area	463236	463260	24	0.0
efr32	lighting-app	BRD4161A+rpc	(read only)	934876	941372	6496	0.7
			(read/write)	149028	149764	736	0.5
			.bss	146808	147520	712	0.5
			.data	2220	2244	24	1.1
			.text	934868	941364	6496	0.7
k32w	light	k32w061+release	(read/write)	686712	686728	16	0.0
			.text	600748	600764	16	0.0
	lock	k32w061+release	(read/write)	691344	691360	16	0.0
			.text	604844	604860	16	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	800984	800992	8	0.0
			text	569678	569690	12	0.0

Full report (10 builds for cyw30739, efr32, k32w, mbed, telink)

platform	target	config	section	`c9350f7`	`ceb6b1f`	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	618490	618514	24	0.0
			.app_xip_area	525200	525224	24	0.0
			.bss	75956	75956	0	0.0
			.data	684	684	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	576102	576126	24	0.0
			.app_xip_area	484348	484372	24	0.0
			.bss	74452	74452	0	0.0
			.data	648	648	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	564618	564642	24	0.0
			.app_xip_area	463236	463260	24	0.0
			.bss	83784	83784	0	0.0
			.data	564	564	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	907004	907004	0	0.0
			(read/write)	133080	133080	0	0.0
			.bss	131040	131040	0	0.0
			.data	2040	2040	0	0.0
			.text	906996	906996	0	0.0
		BRD4161A+rpc	(read only)	934876	941372	6496	0.7
			(read/write)	149028	149764	736	0.5
			.bss	146808	147520	712	0.5
			.data	2220	2244	24	1.1
			.text	934868	941364	6496	0.7
	window-app	BRD4161A	(read only)	843996	843996	0	0.0
			(read/write)	131148	131148	0	0.0
			.bss	129200	129200	0	0.0
			.data	1948	1948	0	0.0
			.text	843988	843988	0	0.0
k32w	light	k32w061+release	(read/write)	686712	686728	16	0.0
			.bss	78128	78128	0	0.0
			.data	2036	2036	0	0.0
			.text	600748	600764	16	0.0
	lock	k32w061+release	(read/write)	691344	691360	16	0.0
			.bss	78704	78704	0	0.0
			.data	1996	1996	0	0.0
			.text	604844	604860	16	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2368260	2368260	0	0.0
			.bss	185236	185236	0	0.0
			.data	5840	5840	0	0.0
			.text	1330860	1330860	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	800984	800992	8	0.0
			bss	69988	69988	0	0.0
			noinit	40416	40416	0	0.0
			text	569678	569690	12	0.0

mgarb1 · 2022-04-13T17:15:58Z

@mlepage-google if you have no additional comments maybe you can also approve this PR?

github-actions · 2022-04-19T06:50:10Z

PR #17181: Size comparison from 8793870 to eedebb3

Increases (4 builds for cc13x2_26x2, nrfconnect, p6)

platform	target	config	section	`8793870`	`eedebb3`	change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	684759	684791	32
			.rodata	103415	103447	32
	pump-app	LP_CC2652R7	(read only)	649807	649983	176
			.rodata	75719	75751	32
			.text	573600	573744	144
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1164691	1164727	36
			rodata	147572	147608	36
p6	all-clusters-app	default	(read/write)	`2517224`	`2517256`	32
			.text	1475488	1475520	32

Decreases (1 build for cc13x2_26x2)

platform	target	config	section	`8793870`	`eedebb3`	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read/write)	168424	168392	-32	-0.0

Full report (19 builds for cc13x2_26x2, cyw30739, efr32, k32w, mbed, nrfconnect, p6, telink)

platform	target	config	section	`8793870`	`eedebb3`	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	684759	684791	32	0.0
			(read/write)	168424	168392	-32	-0.0
			.bss	76168	76168	0	0.0
			.data	3380	3380	0	0.0
			.rodata	103415	103447	32	0.0
			.text	580864	580864	0	0.0
	lock-ftd	LP_CC2652R7	(read only)	677679	677679	0	0.0
			(read/write)	166448	166448	0	0.0
			.bss	74168	74168	0	0.0
			.data	3212	3212	0	0.0
			.rodata	98903	98903	0	0.0
			.text	578292	578292	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	626423	626423	0	0.0
			(read/write)	146956	146956	0	0.0
			.bss	69888	69888	0	0.0
			.data	3212	3212	0	0.0
			.rodata	98783	98783	0	0.0
			.text	527148	527148	0	0.0
	pump-app	LP_CC2652R7	(read only)	649807	649983	176	0.0
			(read/write)	152492	152492	0	0.0
			.bss	74624	74624	0	0.0
			.data	3244	3244	0	0.0
			.rodata	75719	75751	32	0.0
			.text	573600	573744	144	0.0
	pump-controller-app	LP_CC2652R7	(read only)	643151	643151	0	0.0
			(read/write)	152160	152160	0	0.0
			.bss	74328	74328	0	0.0
			.data	3208	3208	0	0.0
			.rodata	79055	79055	0	0.0
			.text	563608	563608	0	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	619310	619310	0	0.0
			.app_xip_area	526068	526068	0	0.0
			.bss	75908	75908	0	0.0
			.data	684	684	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	613562	613562	0	0.0
			.app_xip_area	521824	521824	0	0.0
			.bss	74436	74436	0	0.0
			.data	648	648	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	566406	566406	0	0.0
			.app_xip_area	465056	465056	0	0.0
			.bss	83752	83752	0	0.0
			.data	564	564	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	909172	909172	0	0.0
			(read/write)	133128	133128	0	0.0
			.bss	131088	131088	0	0.0
			.data	2040	2040	0	0.0
			.text	909164	909164	0	0.0
		BRD4161A+rpc	(read only)	943548	943548	0	0.0
			(read/write)	149812	149812	0	0.0
			.bss	147568	147568	0	0.0
			.data	2244	2244	0	0.0
			.text	943540	943540	0	0.0
	window-app	BRD4161A	(read only)	845540	845540	0	0.0
			(read/write)	131116	131116	0	0.0
			.bss	129168	129168	0	0.0
			.data	1948	1948	0	0.0
			.text	845532	845532	0	0.0
k32w	light	k32w061+release	(read/write)	684868	684868	0	0.0
			.bss	77912	77912	0	0.0
			.data	1992	1992	0	0.0
			.text	599164	599164	0	0.0
	lock	k32w061+release	(read/write)	725716	725716	0	0.0
			.bss	78520	78520	0	0.0
			.data	1952	1952	0	0.0
			.text	639444	639444	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2410300	2410300	0	0.0
			.bss	185228	185228	0	0.0
			.data	5840	5840	0	0.0
			.text	1372900	1372900	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1164691	1164727	36	0.0
			bss	136520	136520	0	0.0
			rodata	147572	147608	36	0.0
			text	801960	801960	0	0.0
p6	all-clusters-app	default	(read/write)	`2517224`	`2517256`	32	0.0
			.bss	118624	118624	0	0.0
			.data	2768	2768	0	0.0
			.text	1475488	1475520	32	0.0
	light-app	default	(read/write)	`2417144`	`2417144`	0	0.0
			.bss	112104	112104	0	0.0
			.data	2576	2576	0	0.0
			.text	1375408	1375408	0	0.0
	lock-app	default	(read/write)	2420608	2420608	0	0.0
			.bss	111880	111880	0	0.0
			.data	2536	2536	0	0.0
			.text	1378872	1378872	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	802236	802236	0	0.0
			bss	69952	69952	0	0.0
			noinit	40416	40416	0	0.0
			text	570790	570790	0	0.0

github-actions · 2022-04-19T07:34:09Z

PR #17181: Size comparison from 8793870 to af20719

Increases (7 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6)

platform	target	config	section	`8793870`	`af20719`	change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	684759	684791	32
			.rodata	103415	103447	32
	pump-app	LP_CC2652R7	(read only)	649807	649983	176
			.rodata	75719	75751	32
			.text	573600	573744	144
esp32	all-clusters-app	c3devkit	(read/write)	1397866	1397898	32
			.flash.rodata	201936	201968	32
		m5stack	(read/write)	465608	465640	32
			.flash.rodata	231508	231540	32
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	10430092	10430988	896
			.text	8804420	8805316	896
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1164691	1164727	36
			rodata	147572	147608	36
p6	all-clusters-app	default	(read/write)	`2517224`	`2517256`	32
			.text	1475488	1475520	32

Decreases (1 build for cc13x2_26x2)

platform	target	config	section	`8793870`	`af20719`	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read/write)	168424	168392	-32	-0.0

Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`8793870`	`af20719`	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	684759	684791	32	0.0
			(read/write)	168424	168392	-32	-0.0
			.bss	76168	76168	0	0.0
			.data	3380	3380	0	0.0
			.rodata	103415	103447	32	0.0
			.text	580864	580864	0	0.0
	lock-ftd	LP_CC2652R7	(read only)	677679	677679	0	0.0
			(read/write)	166448	166448	0	0.0
			.bss	74168	74168	0	0.0
			.data	3212	3212	0	0.0
			.rodata	98903	98903	0	0.0
			.text	578292	578292	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	626423	626423	0	0.0
			(read/write)	146956	146956	0	0.0
			.bss	69888	69888	0	0.0
			.data	3212	3212	0	0.0
			.rodata	98783	98783	0	0.0
			.text	527148	527148	0	0.0
	pump-app	LP_CC2652R7	(read only)	649807	649983	176	0.0
			(read/write)	152492	152492	0	0.0
			.bss	74624	74624	0	0.0
			.data	3244	3244	0	0.0
			.rodata	75719	75751	32	0.0
			.text	573600	573744	144	0.0
	pump-controller-app	LP_CC2652R7	(read only)	643151	643151	0	0.0
			(read/write)	152160	152160	0	0.0
			.bss	74328	74328	0	0.0
			.data	3208	3208	0	0.0
			.rodata	79055	79055	0	0.0
			.text	563608	563608	0	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	619310	619310	0	0.0
			.app_xip_area	526068	526068	0	0.0
			.bss	75908	75908	0	0.0
			.data	684	684	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	613562	613562	0	0.0
			.app_xip_area	521824	521824	0	0.0
			.bss	74436	74436	0	0.0
			.data	648	648	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	566406	566406	0	0.0
			.app_xip_area	465056	465056	0	0.0
			.bss	83752	83752	0	0.0
			.data	564	564	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	909172	909172	0	0.0
			(read/write)	133128	133128	0	0.0
			.bss	131088	131088	0	0.0
			.data	2040	2040	0	0.0
			.text	909164	909164	0	0.0
		BRD4161A+rpc	(read only)	943548	943548	0	0.0
			(read/write)	149812	149812	0	0.0
			.bss	147568	147568	0	0.0
			.data	2244	2244	0	0.0
			.text	943540	943540	0	0.0
	window-app	BRD4161A	(read only)	845540	845540	0	0.0
			(read/write)	131116	131116	0	0.0
			.bss	129168	129168	0	0.0
			.data	1948	1948	0	0.0
			.text	845532	845532	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	980742	980742	0	0.0
			(read/write)	1397866	1397898	32	0.0
			.dram0.bss	62600	62600	0	0.0
			.dram0.data	14412	14412	0	0.0
			.flash.rodata	201936	201968	32	0.0
			.flash.text	980742	980742	0	0.0
			.iram0.text	62016	62016	0	0.0
		m5stack	(read only)	`1036127`	`1036127`	0	0.0
			(read/write)	465608	465640	32	0.0
			.dram0.bss	68112	68112	0	0.0
			.dram0.data	34152	34152	0	0.0
			.flash.rodata	231508	231540	32	0.0
			.flash.text	1030743	1030743	0	0.0
			.iram0.text	123107	123107	0	0.0
k32w	light	k32w061+release	(read/write)	684868	684868	0	0.0
			.bss	77912	77912	0	0.0
			.data	1992	1992	0	0.0
			.text	599164	599164	0	0.0
	lock	k32w061+release	(read/write)	725716	725716	0	0.0
			.bss	78520	78520	0	0.0
			.data	1952	1952	0	0.0
			.text	639444	639444	0	0.0
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	10430092	10430988	896	0.0
			(read/write)	494193	494193	0	0.0
			.bss	40865	40865	0	0.0
			.data	1184	1184	0	0.0
			.data.rel.ro	390440	390440	0	0.0
			.dynamic	560	560	0	0.0
			.got	57904	57904	0	0.0
			.init	24	24	0	0.0
			.init_array	184	184	0	0.0
			.rodata	516652	516652	0	0.0
			.text	8804420	8805316	896	0.0
	thermostat-no-ble	arm64	(read only)	2359996	2359996	0	0.0
			(read/write)	151137	151137	0	0.0
			.bss	62945	62945	0	0.0
			.data	1440	1440	0	0.0
			.data.rel.ro	78984	78984	0	0.0
			.dynamic	560	560	0	0.0
			.got	4752	4752	0	0.0
			.init	24	24	0	0.0
			.init_array	368	368	0	0.0
			.rodata	145356	145356	0	0.0
			.text	1985648	1985648	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2410300	2410300	0	0.0
			.bss	185228	185228	0	0.0
			.data	5840	5840	0	0.0
			.text	1372900	1372900	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1164691	1164727	36	0.0
			bss	136520	136520	0	0.0
			rodata	147572	147608	36	0.0
			text	801960	801960	0	0.0
p6	all-clusters-app	default	(read/write)	`2517224`	`2517256`	32	0.0
			.bss	118624	118624	0	0.0
			.data	2768	2768	0	0.0
			.text	1475488	1475520	32	0.0
	light-app	default	(read/write)	`2417144`	`2417144`	0	0.0
			.bss	112104	112104	0	0.0
			.data	2576	2576	0	0.0
			.text	1375408	1375408	0	0.0
	lock-app	default	(read/write)	2420608	2420608	0	0.0
			.bss	111880	111880	0	0.0
			.data	2536	2536	0	0.0
			.text	1378872	1378872	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	802236	802236	0	0.0
			bss	69952	69952	0	0.0
			noinit	40416	40416	0	0.0
			text	570790	570790	0	0.0

…s in the PCC XML * Re-generate zap with zap_regen_all.py

…CC cluster server

Correct the PCC cluster xml to reflect the specification

2237907

boring-cyborg bot added the app label Apr 7, 2022

tlykkeberg-grundfos changed the title ~~Correct the PCC cluster xml to reflect the specification~~ [XML] Correct the PCC cluster xml to reflect the specification Apr 7, 2022

mlepage-google mentioned this pull request Apr 7, 2022

Add custom required privilege definitions for clusters that need them #14419

Closed

* Updated with small corrections to min/max

974580a

* Added special RW VM access priviledges to LifetimerunningHours and …

a891dc1

…LifetimeEnergyConsumed

tlykkeberg-grundfos marked this pull request as ready for review April 7, 2022 18:59

tlykkeberg-grundfos mentioned this pull request Apr 11, 2022

[TC_PCC_2_3] Re-enabled disabled TC's #17189

Closed

* Set the LifetimeRunningHours and LifetimeEnergyConsumed to Nullable

bf38ba4

restyled-io bot mentioned this pull request Apr 11, 2022

Restyle [XML] Correct the PCC cluster xml to reflect the specification #17248

Closed

tlykkeberg-grundfos and others added 2 commits April 11, 2022 16:11

Merge branch 'master' into bugfix/missing-isnullable-in-pcc-xml

4175f79

Restyled by clang-format

93f9e75

tlykkeberg-grundfos and others added 2 commits April 12, 2022 09:29

Merge branch 'master' into bugfix/missing-isnullable-in-pcc-xml

001260d

Restyled by clang-format

ceb6b1f

restyled-io bot mentioned this pull request Apr 12, 2022

Restyle [XML] Correct the PCC cluster xml to reflect the specification #17274

Closed

Fix error in PCC server implementation: use correct attribute types

49e7e4f

Merge branch 'master' into bugfix/missing-isnullable-in-pcc-xml

eedebb3

tlykkeberg-grundfos and others added 2 commits April 19, 2022 09:06

Changed back to ENUM8 as type in XML files for PCC

77e0a98

Restyled by clang-format

af20719

restyled-io bot mentioned this pull request Apr 19, 2022

Restyle [XML] Correct the PCC cluster xml to reflect the specification #17488

Closed

tlykkeberg-grundfos added 2 commits April 19, 2022 18:50

* Re-inserted the PumpOperationMode and PumpControlMode as valid type…

fe3568d

…s in the PCC XML * Re-generate zap with zap_regen_all.py

* Corrected missing use of PumpOperationMode and PumpControlMonde i P…

d51eee9

…CC cluster server

tlykkeberg-grundfos requested a review from mlepage-google April 20, 2022 11:20

andy31415 approved these changes Apr 20, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Apr 20, 2022

andy31415 merged commit 8f6ba74 into project-chip:master Apr 20, 2022

tlykkeberg-grundfos deleted the bugfix/missing-isnullable-in-pcc-xml branch April 21, 2022 06:39

tlykkeberg-grundfos mentioned this pull request Apr 21, 2022

Pump Configuration Control Cluster: operation-mode Write action not changing effective-operation-mode attribute value #11338

Closed

bzbarsky-apple mentioned this pull request May 4, 2022

[TC-PCC-2.2] Values written to EffectiveOperationMode attribute do not reflect back on read. #10951

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XML] Correct the PCC cluster xml to reflect the specification #17181

[XML] Correct the PCC cluster xml to reflect the specification #17181

tlykkeberg-grundfos commented Apr 7, 2022 •

edited

Loading

mgarb1 commented Apr 7, 2022

github-actions bot commented Apr 7, 2022 •

edited

Loading

github-actions bot commented Apr 7, 2022

github-actions bot commented Apr 11, 2022 •

edited

Loading

bzbarsky-apple commented Apr 11, 2022

github-actions bot commented Apr 12, 2022 •

edited

Loading

github-actions bot commented Apr 12, 2022 •

edited

Loading

mgarb1 commented Apr 13, 2022

github-actions bot commented Apr 19, 2022 •

edited

Loading

github-actions bot commented Apr 19, 2022 •

edited

Loading

[XML] Correct the PCC cluster xml to reflect the specification #17181

[XML] Correct the PCC cluster xml to reflect the specification #17181

Conversation

tlykkeberg-grundfos commented Apr 7, 2022 • edited Loading

Problem

Change overview

Testing

mgarb1 commented Apr 7, 2022

github-actions bot commented Apr 7, 2022 • edited Loading

github-actions bot commented Apr 7, 2022

github-actions bot commented Apr 11, 2022 • edited Loading

bzbarsky-apple commented Apr 11, 2022

github-actions bot commented Apr 12, 2022 • edited Loading

github-actions bot commented Apr 12, 2022 • edited Loading

mgarb1 commented Apr 13, 2022

github-actions bot commented Apr 19, 2022 • edited Loading

github-actions bot commented Apr 19, 2022 • edited Loading

tlykkeberg-grundfos commented Apr 7, 2022 •

edited

Loading

github-actions bot commented Apr 7, 2022 •

edited

Loading

github-actions bot commented Apr 11, 2022 •

edited

Loading

github-actions bot commented Apr 12, 2022 •

edited

Loading

github-actions bot commented Apr 12, 2022 •

edited

Loading

github-actions bot commented Apr 19, 2022 •

edited

Loading

github-actions bot commented Apr 19, 2022 •

edited

Loading