Remove all dead config options from SDK #17119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All `CHIP_CONFIG_*` that came from OpenWeave and had no current usage outside CHIPProjectConfig.h or were always disabled in common code for > 1 year and have obviously no use anymore, were removed. Fixes project-chip#17118
tcarmelveilleux
commented
Apr 6, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost and
kpschoedel
pullapprove
bot
requested review from
mspang,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
mspang
approved these changes
Apr 6, 2022
andy31415
approved these changes
Apr 6, 2022
msandstedt
approved these changes
Apr 6, 2022
emargolis
reviewed
Apr 6, 2022
emargolis
approved these changes
Apr 6, 2022
Co-authored-by: Evgeny Margolis <[email protected]>
|
PR #17119: Size comparison from cd29bba to d37f3e3 Increases (4 builds for cc13x2_26x2, esp32)
Decreases (17 builds for cc13x2_26x2, esp32, k32w, nrfconnect, telink)
Full report (36 builds for cc13x2_26x2, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #17119: Size comparison from 6da0db8 to b0bf296 Increases (4 builds for cc13x2_26x2, esp32)
Decreases (20 builds for cc13x2_26x2, efr32, esp32, k32w, nrfconnect, telink)
Full report (39 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #17119: Size comparison from b06bd8c to 1ef5cfd Increases (4 builds for cc13x2_26x2, esp32)
Decreases (20 builds for cc13x2_26x2, efr32, esp32, k32w, nrfconnect, telink)
Full report (39 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Remove all dead config options from SDK - All `CHIP_CONFIG_*` that came from OpenWeave and had no current usage outside CHIPProjectConfig.h or were always disabled in common code for > 1 year and have obviously no use anymore, were removed. Fixes project-chip#17118 * Update src/lib/core/CHIPConfig.h Co-authored-by: Evgeny Margolis <[email protected]> * Restyled by clang-format * Fix missing dependency Co-authored-by: Evgeny Margolis <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
2 years ago, when OpenWeave was imported as a baseline, its config.h system was included verbatim. Since then, 90%+ of the code has been rewritten at the message layer. Many of the config constants are orphaned and confusing. This is made worse by the fact that "weave" was globally replaced with "chip" at the time to smooth things over, which lost some of the pedigree.
Change overview
CHIP_CONFIG_*that came from OpenWeave and had no current usageoutside CHIPProjectConfig.h or were always disabled in common code for
Fixes #17118
Testing