Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK has tons of OpenWeave-based dead configs #17118

Closed
tcarmelveilleux opened this issue Apr 6, 2022 · 0 comments · Fixed by #17119
Closed

SDK has tons of OpenWeave-based dead configs #17118

tcarmelveilleux opened this issue Apr 6, 2022 · 0 comments · Fixed by #17119
Labels
documentation Improvements or additions to documentation V1.0

Comments

@tcarmelveilleux
Copy link
Contributor

Problem

  • 2 years ago, when OpenWeave was imported as a baseline, its config.h system was included verbatim. Since then, 90%+ of the code has been rewritten at the message layer. Many of the config constants are orphaned and confusing. This is made worse by the fact that "weave" was globally replaced with "chip" at the time to smooth things over, which lost some of the pedigree.

Proposed Solution

  • remove all the config dead variables
@tcarmelveilleux tcarmelveilleux added documentation Improvements or additions to documentation V1.0 labels Apr 6, 2022
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Apr 6, 2022
@tcarmelveilleux
Remove all dead config options from SDK
1f7176e 
- All `CHIP_CONFIG_*` that came from OpenWeave and had no current usage
  outside CHIPProjectConfig.h or were always disabled in common code for
  > 1 year and have obviously no use anymore, were removed.

Fixes project-chip#17118
@tcarmelveilleux tcarmelveilleux mentioned this issue Apr 6, 2022
Merged
tcarmelveilleux added a commit that referenced this issue Apr 7, 2022
@tcarmelveilleux @emargolis @restyled-commits
Remove all dead config options from SDK (#17119)
6ba2a09 
* Remove all dead config options from SDK

- All `CHIP_CONFIG_*` that came from OpenWeave and had no current usage
  outside CHIPProjectConfig.h or were always disabled in common code for
  > 1 year and have obviously no use anymore, were removed.

Fixes #17118

* Update src/lib/core/CHIPConfig.h

Co-authored-by: Evgeny Margolis <[email protected]>

* Restyled by clang-format

* Fix missing dependency

Co-authored-by: Evgeny Margolis <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue Apr 14, 2022
@tcarmelveilleux @emargolis
@restyled-commits @andrei-menzopol
Remove all dead config options from SDK (project-chip#17119)
0a6b0f3 
* Remove all dead config options from SDK

- All `CHIP_CONFIG_*` that came from OpenWeave and had no current usage
  outside CHIPProjectConfig.h or were always disabled in common code for
  > 1 year and have obviously no use anymore, were removed.

Fixes project-chip#17118

* Update src/lib/core/CHIPConfig.h

Co-authored-by: Evgeny Margolis <[email protected]>

* Restyled by clang-format

* Fix missing dependency

Co-authored-by: Evgeny Margolis <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all dead config options from SDK tcarmelveilleux/connectedhomeip
1 participant
@tcarmelveilleux