Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the onoff-cluster.xml to use the specifications type definitions, instead of using the enum* directly. See issue #15528. #16466

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Updated the onoff-cluster.xml to use the specifications type definitions, instead of using the enum* directly. See issue #15528. #16466

merged 1 commit into from
Mar 24, 2022

Conversation

hubTab
Copy link
Contributor

@hubTab hubTab commented Mar 18, 2022 •
edited
Loading

Updated the OnOff Cluster XML to use type definitions.

Problem
What is being fixed?

The onoff-cluster.xml should use the specifications type definitions, instead of using the enum* directly.
Partially Fixes #15528, by updating the onoff-cluster.xml file to use the specifications type definitions.

Change overview
What's in this PR

Updated the onoff-cluster.xml to use the specifications type definitions, instead of using the enum* directly. See issue #15528.
Added the DlStartUpOnOff enum.
Updated src/app/clusters/on-off-server/on-off-server.cpp to use the DlStartUpOnOff type definition.

Matter Specifications Relationships
OnOff cluster Specifications Issue: https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/5043
OnOff cluster Specifications PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5044

Testing
How was this tested? (at least one bullet point required)

Re-generated zzz files, and verified by rebuilding the all-clusters-app, chip-tool applications.
Restyle the code by running ./scripts/helpers/restyle-diff.sh.

@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16466: Size comparison from 5028b58 to 28abb25

Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5028b58 28abb25 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603874 603882 8 0.0
.app_xip_area 510972 510980 8 0.0
lock cyw930739m2evb_01 (read/write) 561654 561662 8 0.0
.app_xip_area 470280 470288 8 0.0
efr32 lighting-app BRD4161A (read only) 921992 922008 16 0.0
.text 921984 922000 16 0.0
BRD4161A+rpc (read only) 950812 950828 16 0.0
.text 950804 950820 16 0.0
esp32 all-clusters-app c3devkit (read/write) 1393258 1393282 24 0.0
.flash.rodata 198096 198120 24 0.0
m5stack (read/write) 461100 461124 24 0.0
.flash.rodata 227664 227688 24 0.0
k32w lock k32w061+release (read/write) 700964 700972 8 0.0
.text 615632 615640 8 0.0
linux all-clusters-app debug (read only) 2476433 2476657 224 0.0
.rodata 211557 211621 64 0.0
.text 2101426 2101538 112 0.0
bridge-app debug+rpc (read only) 1752749 1752861 112 0.0
.text 1492981 1493093 112 0.0
chip-tool debug (read only) 10145781 10158741 12960 0.1
(read/write) 354848 354944 96 0.0
.data.rel.ro 325408 325504 96 0.0
.text 8845109 8857829 12720 0.1
chip-tool-ipv6only arm64 (read only) 9769244 9781100 11856 0.1
(read/write) 472689 472881 192 0.0
.data.rel.ro 371824 371968 144 0.0
.got 55328 55376 48 0.1
.rodata 493780 493876 96 0.0
.text 8224100 8235428 11328 0.1
lighting-app debug+rpc (read only) 2135353 2135521 168 0.0
.rodata 173052 173084 32 0.0
.text 1805618 1805730 112 0.0
shell debug (read only) 2426593 2426817 224 0.0
.rodata 209458 209522 64 0.0
.text 2060434 2060546 112 0.0
tv-app debug (read only) 2676905 2677033 128 0.0
.text 2295250 2295378 128 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353460 2353476 16 0.0
.text 1316060 1316076 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155763 1155787 24 0.0
rodata 145892 145916 24 0.0
p6 all-clusters-app default (read/write) 2492784 2492808 24 0.0
.text 1451048 1451072 24 0.0
light-app default (read/write) 2396352 2396360 8 0.0
.text 1354616 1354624 8 0.0
lock-app default (read/write) 2359912 2359920 8 0.0
.text 1318176 1318184 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 895702 895714 12 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5028b58 28abb25 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603874 603882 8 0.0
.app_xip_area 510972 510980 8 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561654 561662 8 0.0
.app_xip_area 470280 470288 8 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571506 571506 0 0.0
.app_xip_area 470484 470484 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921992 922008 16 0.0
(read/write) 128760 128760 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 921984 922000 16 0.0
BRD4161A+rpc (read only) 950812 950828 16 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 950804 950820 16 0.0
window-app BRD4161A (read only) 852296 852296 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124848 124848 0 0.0
.data 1864 1864 0 0.0
.text 852288 852288 0 0.0
esp32 all-clusters-app c3devkit (read only) 961922 961922 0 0.0
(read/write) 1393258 1393282 24 0.0
.dram0.bss 62056 62056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198096 198120 24 0.0
.flash.text 961922 961922 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1018007 1018007 0 0.0
(read/write) 461100 461124 24 0.0
.dram0.bss 67584 67584 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227664 227688 24 0.0
.flash.text 1012623 1012623 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701104 701104 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 615780 615780 0 0.0
lock k32w061+release (read/write) 700964 700972 8 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615632 615640 8 0.0
linux all-clusters-app debug (read only) 2476433 2476657 224 0.0
(read/write) 143152 143152 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211557 211621 64 0.0
.text 2101426 2101538 112 0.0
bridge-app debug+rpc (read only) 1752749 1752861 112 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144556 144556 0 0.0
.text 1492981 1493093 112 0.0
chip-tool debug (read only) 10145781 10158741 12960 0.1
(read/write) 354848 354944 96 0.0
.bss 22304 22304 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325408 325504 96 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 518069 518069 0 0.0
.text 8845109 8857829 12720 0.1
chip-tool-ipv6only arm64 (read only) 9769244 9781100 11856 0.1
(read/write) 472689 472881 192 0.0
.bss 40609 40609 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371968 144 0.0
.dynamic 560 560 0 0.0
.got 55328 55376 48 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493780 493876 96 0.0
.text 8224100 8235428 11328 0.1
door-lock-app debug (read only) 2004073 2004073 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180796 180796 0 0.0
.text 1673618 1673618 0 0.0
lighting-app debug+rpc (read only) 2135353 2135521 168 0.0
(read/write) 122120 122120 0 0.0
.bss 48352 48352 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 173052 173084 32 0.0
.text 1805618 1805730 112 0.0
ota-provider-app debug (read only) 1938561 1938561 0 0.0
(read/write) 112624 112624 0 0.0
.bss 47488 47488 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166315 166315 0 0.0
.text 1620482 1620482 0 0.0
ota-requestor-app debug (read only) 1968585 1968585 0 0.0
(read/write) 115592 115592 0 0.0
.bss 48480 48480 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162564 162564 0 0.0
.text 1654034 1654034 0 0.0
shell debug (read only) 2426593 2426817 224 0.0
(read/write) 147208 147208 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209458 209522 64 0.0
.text 2060434 2060546 112 0.0
thermostat-no-ble arm64 (read only) 2223828 2223828 0 0.0
(read/write) 146385 146385 0 0.0
.bss 62289 62289 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 138148 138148 0 0.0
.text 1865616 1865616 0 0.0
tv-app debug (read only) 2676905 2677033 128 0.0
(read/write) 247712 247712 0 0.0
.bss 164384 164384 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206805 206805 0 0.0
.text 2295250 2295378 128 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353460 2353476 16 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316060 1316076 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155763 1155787 24 0.0
bss 146724 146724 0 0.0
rodata 145892 145916 24 0.0
text 787992 787992 0 0.0
p6 all-clusters-app default (read/write) 2492784 2492808 24 0.0
.bss 118080 118080 0 0.0
.data 2632 2632 0 0.0
.text 1451048 1451072 24 0.0
light-app default (read/write) 2396352 2396360 8 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1354616 1354624 8 0.0
lock-app default (read/write) 2359912 2359920 8 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318176 1318184 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 895702 895714 12 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 633326 633326 0 0.0

@hubTab hubTab force-pushed the OnOff_Type_Update_Issue_15528 branch from 28abb25 to 03447f6 Compare March 22, 2022 18:12
@github-actions
Copy link

github-actions bot commented Mar 22, 2022 •
edited
Loading

PR #16466: Size comparison from ca56d6b to 03447f6

Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ca56d6b 03447f63 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604166 604182 16 0.0
.app_xip_area 511264 511280 16 0.0
lock cyw930739m2evb_01 (read/write) 561946 561962 16 0.0
.app_xip_area 470572 470588 16 0.0
efr32 lighting-app BRD4161A (read only) 922424 922440 16 0.0
.text 922416 922432 16 0.0
BRD4161A+rpc (read only) 951236 951252 16 0.0
.text 951228 951244 16 0.0
esp32 all-clusters-app c3devkit (read/write) 1393690 1393714 24 0.0
.flash.rodata 198512 198536 24 0.0
m5stack (read only) 1020579 1020583 4 0.0
(read/write) 461460 461484 24 0.0
.flash.rodata 228016 228040 24 0.0
.flash.text 1015195 1015199 4 0.0
k32w lock k32w061+release (read/write) 701252 701260 8 0.0
.text 615920 615928 8 0.0
linux all-clusters-app debug (read only) 2477649 2478289 640 0.0
.rodata 211877 211941 64 0.0
.text 2102322 2102850 528 0.0
bridge-app debug+rpc (read only) 1753229 1753741 512 0.0
.text 1493429 1493941 512 0.0
chip-tool debug (read only) 10154061 10169981 15920 0.2
(read/write) 354912 355008 96 0.0
.data.rel.ro 325472 325568 96 0.0
.text 8853141 8868821 15680 0.2
chip-tool-ipv6only arm64 (read only) 9776252 9790748 14496 0.1
(read/write) 472801 472993 192 0.0
.data.rel.ro 371880 372024 144 0.0
.got 55384 55432 48 0.1
.rodata 493876 493972 96 0.0
.text 8230724 8244692 13968 0.2
lighting-app debug+rpc (read only) 2178681 2179249 568 0.0
.rodata 175324 175356 32 0.0
.text 1844338 1844850 512 0.0
shell debug (read only) 2426993 2427617 624 0.0
.rodata 209298 209362 64 0.0
.text 2060994 2061506 512 0.0
tv-app debug (read only) 2678265 2678777 512 0.0
.text 2296130 2296642 512 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353708 2353716 8 0.0
.text 1316308 1316316 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156275 1156299 24 0.0
rodata 145956 145980 24 0.0
p6 all-clusters-app default (read/write) 2493408 2493432 24 0.0
.text 1451672 1451696 24 0.0
light-app default (read/write) 2396808 2396816 8 0.0
.text 1355072 1355080 8 0.0
lock-app default (read/write) 2360344 2360352 8 0.0
.text 1318608 1318616 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 896142 896154 12 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ca56d6b 03447f63 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604166 604182 16 0.0
.app_xip_area 511264 511280 16 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561946 561962 16 0.0
.app_xip_area 470572 470588 16 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571790 571790 0 0.0
.app_xip_area 470768 470768 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922424 922440 16 0.0
(read/write) 128760 128760 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922416 922432 16 0.0
BRD4161A+rpc (read only) 951236 951252 16 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951228 951244 16 0.0
window-app BRD4161A (read only) 852800 852800 0 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852792 852792 0 0.0
esp32 all-clusters-app c3devkit (read only) 964026 964026 0 0.0
(read/write) 1393690 1393714 24 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198512 198536 24 0.0
.flash.text 964026 964026 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020579 1020583 4 0.0
(read/write) 461460 461484 24 0.0
.dram0.bss 67592 67592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 228016 228040 24 0.0
.flash.text 1015195 1015199 4 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701380 701380 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 616056 616056 0 0.0
lock k32w061+release (read/write) 701252 701260 8 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615920 615928 8 0.0
linux all-clusters-app debug (read only) 2477649 2478289 640 0.0
(read/write) 143152 143152 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211877 211941 64 0.0
.text 2102322 2102850 528 0.0
bridge-app debug+rpc (read only) 1753229 1753741 512 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144588 144588 0 0.0
.text 1493429 1493941 512 0.0
chip-tool debug (read only) 10154061 10169981 15920 0.2
(read/write) 354912 355008 96 0.0
.bss 22304 22304 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325472 325568 96 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 518197 518197 0 0.0
.text 8853141 8868821 15680 0.2
chip-tool-ipv6only arm64 (read only) 9776252 9790748 14496 0.1
(read/write) 472801 472993 192 0.0
.bss 40609 40609 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371880 372024 144 0.0
.dynamic 560 560 0 0.0
.got 55384 55432 48 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493876 493972 96 0.0
.text 8230724 8244692 13968 0.2
door-lock-app debug (read only) 2005033 2005033 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181052 181052 0 0.0
.text 1674322 1674322 0 0.0
lighting-app debug+rpc (read only) 2178681 2179249 568 0.0
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175324 175356 32 0.0
.text 1844338 1844850 512 0.0
ota-provider-app debug (read only) 1939425 1939425 0 0.0
(read/write) 112624 112624 0 0.0
.bss 47488 47488 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166475 166475 0 0.0
.text 1621186 1621186 0 0.0
ota-requestor-app debug (read only) 1969593 1969593 0 0.0
(read/write) 115592 115592 0 0.0
.bss 48480 48480 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162884 162884 0 0.0
.text 1654722 1654722 0 0.0
shell debug (read only) 2426993 2427617 624 0.0
(read/write) 147208 147208 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209298 209362 64 0.0
.text 2060994 2061506 512 0.0
thermostat-no-ble arm64 (read only) 2262724 2262724 0 0.0
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139844 139844 0 0.0
.text 1899568 1899568 0 0.0
tv-app debug (read only) 2678265 2678777 512 0.0
(read/write) 247712 247712 0 0.0
.bss 164384 164384 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207285 207285 0 0.0
.text 2296130 2296642 512 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353708 2353716 8 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316308 1316316 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156275 1156299 24 0.0
bss 146716 146716 0 0.0
rodata 145956 145980 24 0.0
text 788432 788432 0 0.0
p6 all-clusters-app default (read/write) 2493408 2493432 24 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451672 1451696 24 0.0
light-app default (read/write) 2396808 2396816 8 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355072 1355080 8 0.0
lock-app default (read/write) 2360344 2360352 8 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318608 1318616 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 896142 896154 12 0.0
bss 87424 87424 0 0.0
noinit 37160 37160 0 0.0
text 633718 633718 0 0.0

@hubTab hubTab force-pushed the OnOff_Type_Update_Issue_15528 branch from 03447f6 to 347f346 Compare March 23, 2022 15:01
@hubTab
Copy link
Contributor Author

hubTab commented Mar 23, 2022

It looks like the checks on this PR have been pending for some time this morning. Would someone with admin rights be able to provide some insight as to why it is happening? Thank you!

cc: @bzbarsky-apple , @mrjerryjohns

@mrjerryjohns
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the OnOff_Type_Update_Issue_15528 branch from 347f346 to 3545ae1 Compare March 23, 2022 21:48
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16466: Size comparison from c7b4913 to 3545ae1

Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c7b4913 3545ae1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603334 603350 16 0.0
.app_xip_area 510424 510440 16 0.0
lock cyw930739m2evb_01 (read/write) 561122 561138 16 0.0
.app_xip_area 469740 469756 16 0.0
efr32 lighting-app BRD4161A (read only) 922876 922884 8 0.0
.text 922868 922876 8 0.0
BRD4161A+rpc (read only) 951684 951700 16 0.0
.text 951676 951692 16 0.0
esp32 all-clusters-app c3devkit (read/write) 1393842 1393866 24 0.0
.flash.rodata 198648 198672 24 0.0
m5stack (read/write) 461620 461644 24 0.0
.flash.rodata 228160 228184 24 0.0
k32w lock k32w061+release (read/write) 700936 700952 16 0.0
.text 615596 615612 16 0.0
linux all-clusters-app debug (read only) 2478273 2478897 624 0.0
.rodata 211845 211909 64 0.0
.text 2103026 2103538 512 0.0
bridge-app debug+rpc (read only) 1753061 1753573 512 0.0
.text 1493621 1494133 512 0.0
chip-tool debug (read only) 10186893 10202813 15920 0.2
(read/write) 355072 355168 96 0.0
.data.rel.ro 325496 325592 96 0.0
.text 8883301 8898981 15680 0.2
chip-tool-ipv6only arm64 (read only) 9806636 9821132 14496 0.1
(read/write) 473297 473489 192 0.0
.data.rel.ro 371968 372112 144 0.0
.got 55704 55752 48 0.1
.rodata 495780 495876 96 0.0
.text 8258020 8271988 13968 0.2
lighting-app debug+rpc (read only) 2178497 2179065 568 0.0
.rodata 174940 174972 32 0.0
.text 1844610 1845122 512 0.0
shell debug (read only) 2427633 2428273 640 0.0
.rodata 209298 209362 64 0.0
.text 2061682 2062210 528 0.0
tv-app debug (read only) 2678929 2679441 512 0.0
.text 2297250 2297762 512 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353428 2353444 16 0.0
.text 1316028 1316044 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139283 1139307 24 0.0
rodata 141508 141532 24 0.0
p6 all-clusters-app default (read/write) 2493816 2493840 24 0.0
.text 1452080 1452104 24 0.0
light-app default (read/write) 2396752 2396768 16 0.0
.text 1355016 1355032 16 0.0
lock-app default (read/write) 2360288 2360304 16 0.0
.text 1318552 1318568 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 896794 896806 12 0.0
Decreases (1 build for esp32)
platform target config section c7b4913 3545ae1 change % change
esp32 all-clusters-app m5stack (read only) 1020723 1020711 -12 -0.0
.flash.text 1015339 1015327 -12 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c7b4913 3545ae1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603334 603350 16 0.0
.app_xip_area 510424 510440 16 0.0
.bss 75656 75656 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561122 561138 16 0.0
.app_xip_area 469740 469756 16 0.0
.bss 74160 74160 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573206 573206 0 0.0
.app_xip_area 472176 472176 0 0.0
.bss 83488 83488 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 922884 8 0.0
(read/write) 128756 128756 0 0.0
.bss 126760 126760 0 0.0
.data 1996 1996 0 0.0
.text 922868 922876 8 0.0
BRD4161A+rpc (read only) 951684 951700 16 0.0
(read/write) 144712 144712 0 0.0
.bss 142536 142536 0 0.0
.data 2176 2176 0 0.0
.text 951676 951692 16 0.0
window-app BRD4161A (read only) 852680 852680 0 0.0
(read/write) 126728 126728 0 0.0
.bss 124856 124856 0 0.0
.data 1872 1872 0 0.0
.text 852672 852672 0 0.0
esp32 all-clusters-app c3devkit (read only) 964186 964186 0 0.0
(read/write) 1393842 1393866 24 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 198648 198672 24 0.0
.flash.text 964186 964186 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020723 1020711 -12 -0.0
(read/write) 461620 461644 24 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228160 228184 24 0.0
.flash.text 1015339 1015327 -12 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701500 701500 0 0.0
.bss 77648 77648 0 0.0
.data 1876 1876 0 0.0
.text 616176 616176 0 0.0
lock k32w061+release (read/write) 700936 700952 16 0.0
.bss 77624 77624 0 0.0
.data 1916 1916 0 0.0
.text 615596 615612 16 0.0
linux all-clusters-app debug (read only) 2478273 2478897 624 0.0
(read/write) 143184 143184 0 0.0
.bss 57312 57312 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78872 78872 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211845 211909 64 0.0
.text 2103026 2103538 512 0.0
bridge-app debug+rpc (read only) 1753061 1753573 512 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37912 37912 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144300 144300 0 0.0
.text 1493621 1494133 512 0.0
chip-tool debug (read only) 10186893 10202813 15920 0.2
(read/write) 355072 355168 96 0.0
.bss 22400 22400 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325496 325592 96 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520405 520405 0 0.0
.text 8883301 8898981 15680 0.2
chip-tool-ipv6only arm64 (read only) 9806636 9821132 14496 0.1
(read/write) 473297 473489 192 0.0
.bss 40673 40673 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 371968 372112 144 0.0
.dynamic 560 560 0 0.0
.got 55704 55752 48 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 495780 495876 96 0.0
.text 8258020 8271988 13968 0.2
door-lock-app debug (read only) 2005121 2005121 0 0.0
(read/write) 116800 116800 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62824 62824 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180956 180956 0 0.0
.text 1674578 1674578 0 0.0
lighting-app debug+rpc (read only) 2178497 2179065 568 0.0
(read/write) 123760 123760 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 174940 174972 32 0.0
.text 1844610 1845122 512 0.0
ota-provider-app debug (read only) 1946169 1946169 0 0.0
(read/write) 112528 112528 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58168 58168 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166699 166699 0 0.0
.text 1627826 1627826 0 0.0
ota-requestor-app debug (read only) 1972977 1972977 0 0.0
(read/write) 115784 115784 0 0.0
.bss 48448 48448 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60392 60392 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162692 162692 0 0.0
.text 1657730 1657730 0 0.0
shell debug (read only) 2427633 2428273 640 0.0
(read/write) 147240 147240 0 0.0
.bss 67240 67240 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73504 73504 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209298 209362 64 0.0
.text 2061682 2062210 528 0.0
thermostat-no-ble arm64 (read only) 2262588 2262588 0 0.0
(read/write) 148257 148257 0 0.0
.bss 62753 62753 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139564 139564 0 0.0
.text 1899776 1899776 0 0.0
tv-app debug (read only) 2678929 2679441 512 0.0
(read/write) 247712 247712 0 0.0
.bss 164416 164416 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74104 74104 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206901 206901 0 0.0
.text 2297250 2297762 512 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353428 2353444 16 0.0
.bss 184652 184652 0 0.0
.data 5760 5760 0 0.0
.text 1316028 1316044 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139283 1139307 24 0.0
bss 142588 142588 0 0.0
rodata 141508 141532 24 0.0
text 780416 780416 0 0.0
p6 all-clusters-app default (read/write) 2493816 2493840 24 0.0
.bss 118072 118072 0 0.0
.data 2640 2640 0 0.0
.text 1452080 1452104 24 0.0
light-app default (read/write) 2396752 2396768 16 0.0
.bss 111544 111544 0 0.0
.data 2496 2496 0 0.0
.text 1355016 1355032 16 0.0
lock-app default (read/write) 2360288 2360304 16 0.0
.bss 111288 111288 0 0.0
.data 2456 2456 0 0.0
.text 1318552 1318568 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 896794 896806 12 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634212 634212 0 0.0

@andy31415 andy31415 merged commit cf6522f into project-chip:master Mar 24, 2022
@hubTab hubTab mentioned this pull request Mar 31, 2022
Closed
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@hubTab @andrei-menzopol
Updated the onoff-cluster.xml to use the specifications type definiti…
18b7b79 
…ons, instead of using the enum* directly. See issue project-chip#15528. (project-chip#16466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App cluster XMLs should use original type definitions instead of BITMAP* directly
5 participants
@hubTab @mrjerryjohns @bzbarsky-apple @jmeg-sfy @andy31415