-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App cluster XMLs should use original type definitions instead of BITMAP* directly #15528
Labels
app-clusters
Application cluster work
Comments
PR #15600 has been created to address the fix for the Door Lock cluster. |
hubTab
pushed a commit
to hubTab/connectedhomeip
that referenced
this issue
Mar 14, 2022
…ecifications type definitions, instead of using the enum* directly (project-chip#15528). Fixed the ManualOperationEventMask comment. Rebuilt all-clusters-app, chip-tool, and re-generated zzz files. Note: In the review process, it has been noted that the GetLogRecordResponse command documents the EventType as an enum8. However the spec does not define the EventTypeEnum, which could be easily added to the spec as the Event Type is a textual description.
hubTab
pushed a commit
to hubTab/connectedhomeip
that referenced
this issue
Mar 14, 2022
…ecifications type definitions, instead of using the enum* directly (project-chip#15528). Fixed the ManualOperationEventMask comment. Rebuilt all-clusters-app, chip-tool, and re-generated zzz files. Note: In the review process, it has been noted that the GetLogRecordResponse command documents the EventType as an enum8. However the spec does not define the EventTypeEnum, which could be easily added to the spec as the Event Type is a textual description.
mrjerryjohns
pushed a commit
that referenced
this issue
Mar 15, 2022
…ecifications type definitions, instead of using the enum* directly (#15528). (#15600) Fixed the ManualOperationEventMask comment. Rebuilt all-clusters-app, chip-tool, and re-generated zzz files. Note: In the review process, it has been noted that the GetLogRecordResponse command documents the EventType as an enum8. However the spec does not define the EventTypeEnum, which could be easily added to the spec as the Event Type is a textual description.
hubTab
pushed a commit
to hubTab/connectedhomeip
that referenced
this issue
Mar 18, 2022
…ons, instead of using the enum* directly. See issue project-chip#15528. Rebuilt all-clusters-app, chip-tool, and re-generated zzz files.
hubTab
pushed a commit
to hubTab/connectedhomeip
that referenced
this issue
Mar 18, 2022
…ons, instead of using the enum* directly. See issue project-chip#15528. Added the DlStartUpOnOff enum. Updated src/app/clusters/on-off-server/on-off-server.cpp to use the DlStartUpOnOff type definition. Re-generated zzz files, and verified by rebuilding the all-clusters-app, chip-tool applications.
hubTab
pushed a commit
to hubTab/connectedhomeip
that referenced
this issue
Mar 23, 2022
…ons, instead of using the enum* directly. See issue project-chip#15528.
woody-apple
pushed a commit
to hubTab/connectedhomeip
that referenced
this issue
Mar 23, 2022
…ons, instead of using the enum* directly. See issue project-chip#15528.
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this issue
Apr 14, 2022
…ecifications type definitions, instead of using the enum* directly (project-chip#15528). (project-chip#15600) Fixed the ManualOperationEventMask comment. Rebuilt all-clusters-app, chip-tool, and re-generated zzz files. Note: In the review process, it has been noted that the GetLogRecordResponse command documents the EventType as an enum8. However the spec does not define the EventTypeEnum, which could be easily added to the spec as the Event Type is a textual description.
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this issue
Apr 14, 2022
…ons, instead of using the enum* directly. See issue project-chip#15528. (project-chip#16466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Various app cluster XMLs define bitmaps with their underlying enum-like definitions:
e.g
However, they actually lose the type information when instantiating these in various instances:
Solution
Update the various app cluster XMLs to use the original type that is eventually backed by a BITMAP*
The text was updated successfully, but these errors were encountered: