-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign fabrics to Alice and Bob in MessingContext test class #16214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang and
sagar-apple
March 15, 2022 09:38
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 15, 2022 09:38
PR #16214: Size comparison from b18b03a to 3b0433c Increases (2 builds for k32w)
Decreases (1 build for telink)
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
kghost
force-pushed
the
test-context-fabric
branch
from
March 15, 2022 10:29
3b0433c
to
6a7f074
Compare
PR #16214: Size comparison from b18b03a to 6a7f074 Increases (2 builds for k32w)
Decreases (2 builds for esp32, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 16, 2022
andy31415
reviewed
Mar 16, 2022
andy31415
approved these changes
Mar 16, 2022
kghost
force-pushed
the
test-context-fabric
branch
from
March 17, 2022 07:14
6a7f074
to
4ef2ea7
Compare
PR #16214: Size comparison from 4522ebe to 4ef2ea7 Increases (3 builds for cyw30739, esp32, k32w)
Decreases (2 builds for esp32, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
ArekBalysNordic
pushed a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Mar 17, 2022
…-chip#16214) * Assign fabrics to Alice and Bob in MessingContext test class * Resolve comments
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…-chip#16214) * Assign fabrics to Alice and Bob in MessingContext test class * Resolve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Without fabric for Alice and Bob blocks #16098
The source node id in fabric is used to construct crypto IV.
Change overview
Create and assign fabric for Alice and Bob
Testing
Passed unit-tests