Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypto: Fix node id in IV #16098

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Crypto: Fix node id in IV #16098

merged 3 commits into from
Mar 24, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Mar 11, 2022

Problem

Fixes #15317

Change overview

Compute correct IV for secure packets.

Testing

WIP

@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

PR #16098: Size comparison from 10b8046 to 347a71b

Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 10b8046 347a71b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599174 72 0.0
.app_xip_area 506700 506772 72 0.0
lock cyw930739m2evb_01 (read/write) 556986 557058 72 0.0
.app_xip_area 466112 466184 72 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566878 566958 80 0.0
.app_xip_area 466316 466396 80 0.0
efr32 lighting-app BRD4161A (read only) 921192 921304 112 0.0
.text 921184 921296 112 0.0
BRD4161A+rpc (read only) 950020 950116 96 0.0
.text 950012 950108 96 0.0
window-app BRD4161A (read only) 853732 853844 112 0.0
.text 853724 853836 112 0.0
esp32 all-clusters-app c3devkit (read only) 958524 958594 70 0.0
.flash.text 958524 958594 70 0.0
m5stack (read only) 1014127 1014219 92 0.0
.flash.text 1008743 1008835 92 0.0
k32w light k32w061+release (read/write) 695516 695580 64 0.0
.text 610644 610708 64 0.0
lock k32w061+release (read/write) 696360 696440 80 0.0
.text 611528 611608 80 0.0
linux all-clusters-app debug (read only) 2436881 2437601 720 0.0
.text 2067730 2068546 816 0.0
bridge-app debug+rpc (read only) 1742165 1742869 704 0.0
.text 1483893 1484693 800 0.1
chip-tool debug (read only) 10096133 10096901 768 0.0
(read/write) 357976 358040 64 0.0
.data.rel.ro 325208 325256 48 0.0
.text 8799365 8800165 800 0.0
chip-tool-ipv6only arm64 (read only) 9729660 9730436 776 0.0
.rodata 492148 492156 8 0.0
.text 8186868 8187636 768 0.0
door-lock-app debug (read only) 1956545 1957297 752 0.0
.text 1633618 1634434 816 0.0
lighting-app debug+rpc (read only) 2088681 2089433 752 0.0
.text 1766578 1767394 816 0.0
ota-provider-app debug (read only) 1889961 1890665 704 0.0
.text 1579746 1580546 800 0.1
ota-requestor-app debug (read only) 1917801 1918505 704 0.0
.text 1611474 1612274 800 0.0
shell debug (read only) 2402881 2403601 720 0.0
.text 2040194 2041010 816 0.0
thermostat-no-ble arm64 (read only) 2181588 2182372 784 0.0
.rodata 133444 133460 16 0.0
.text 1829984 1830752 768 0.0
tv-app debug (read only) 2628553 2629313 760 0.0
.text 2254706 2255522 816 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351012 2351076 64 0.0
.text 1313612 1313676 64 0.0
p6 all-clusters-app default (read/write) 2495680 2495792 112 0.0
.text 1453944 1454056 112 0.0
light-app default (read/write) 2399680 2399792 112 0.0
.text 1357944 1358056 112 0.0
lock-app default (read/write) 2363240 2363352 112 0.0
.text 1321504 1321616 112 0.0
telink lighting-app tlsr9518adk80d (read/write) 889766 889846 80 0.0
text 628970 629054 84 0.0
Decreases (9 builds for linux)
platform target config section 10b8046 347a71b change % change
linux all-clusters-app debug .rodata 206213 206117 -96 -0.0
bridge-app debug+rpc .rodata 142348 142252 -96 -0.1
chip-tool debug .rodata 514516 514484 -32 -0.0
door-lock-app debug .rodata 174332 174268 -64 -0.0
lighting-app debug+rpc .rodata 166492 166428 -64 -0.0
ota-provider-app debug .rodata 159539 159443 -96 -0.1
ota-requestor-app debug .rodata 155500 155404 -96 -0.1
shell debug .rodata 206162 206066 -96 -0.0
tv-app debug .rodata 199805 199749 -56 -0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 10b8046 347a71b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599174 72 0.0
.app_xip_area 506700 506772 72 0.0
.bss 75108 75108 0 0.0
.data 640 640 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556986 557058 72 0.0
.app_xip_area 466112 466184 72 0.0
.bss 73612 73612 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566878 566958 80 0.0
.app_xip_area 466316 466396 80 0.0
.bss 82980 82980 0 0.0
.data 540 540 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921192 921304 112 0.0
(read/write) 128256 128256 0 0.0
.bss 126224 126224 0 0.0
.data 2028 2028 0 0.0
.text 921184 921296 112 0.0
BRD4161A+rpc (read only) 950020 950116 96 0.0
(read/write) 144208 144208 0 0.0
.bss 142000 142000 0 0.0
.data 2208 2208 0 0.0
.text 950012 950108 96 0.0
window-app BRD4161A (read only) 853732 853844 112 0.0
(read/write) 126216 126216 0 0.0
.bss 124312 124312 0 0.0
.data 1904 1904 0 0.0
.text 853724 853836 112 0.0
esp32 all-clusters-app c3devkit (read only) 958524 958594 70 0.0
(read/write) 1393858 1393858 0 0.0
.dram0.bss 63584 63584 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197144 197144 0 0.0
.flash.text 958524 958594 70 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014127 1014219 92 0.0
(read/write) 461092 461092 0 0.0
.dram0.bss 69104 69104 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 226104 226104 0 0.0
.flash.text 1008743 1008835 92 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695516 695580 64 0.0
.bss 77160 77160 0 0.0
.data 1912 1912 0 0.0
.text 610644 610708 64 0.0
lock k32w061+release (read/write) 696360 696440 80 0.0
.bss 77080 77080 0 0.0
.data 1952 1952 0 0.0
.text 611528 611608 80 0.0
linux all-clusters-app debug (read only) 2436881 2437601 720 0.0
(read/write) 145840 145840 0 0.0
.bss 60352 60352 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 206213 206117 -96 -0.0
.text 2067730 2068546 816 0.0
bridge-app debug+rpc (read only) 1742165 1742869 704 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 142348 142252 -96 -0.1
.text 1483893 1484693 800 0.1
chip-tool debug (read only) 10096133 10096901 768 0.0
(read/write) 357976 358040 64 0.0
.bss 25640 25640 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 325208 325256 48 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514516 514484 -32 -0.0
.text 8799365 8800165 800 0.0
chip-tool-ipv6only arm64 (read only) 9729660 9730436 776 0.0
(read/write) 475729 475729 0 0.0
.bss 43953 43953 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 371520 371520 0 0.0
.dynamic 560 560 0 0.0
.got 55280 55280 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492156 8 0.0
.text 8186868 8187636 768 0.0
door-lock-app debug (read only) 1956545 1957297 752 0.0
(read/write) 119264 119264 0 0.0
.bss 50656 50656 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 174332 174268 -64 -0.0
.text 1633618 1634434 816 0.0
lighting-app debug+rpc (read only) 2088681 2089433 752 0.0
(read/write) 124584 124584 0 0.0
.bss 51456 51456 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166492 166428 -64 -0.0
.text 1766578 1767394 816 0.0
ota-provider-app debug (read only) 1889961 1890665 704 0.0
(read/write) 114896 114896 0 0.0
.bss 50496 50496 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159539 159443 -96 -0.1
.text 1579746 1580546 800 0.1
ota-requestor-app debug (read only) 1917801 1918505 704 0.0
(read/write) 117992 117992 0 0.0
.bss 51584 51584 0 0.0
.data 1448 1448 0 0.0
.data.rel.ro 59512 59512 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155500 155404 -96 -0.1
.text 1611474 1612274 800 0.0
shell debug (read only) 2402881 2403601 720 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 848 848 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206162 206066 -96 -0.0
.text 2040194 2041010 816 0.0
thermostat-no-ble arm64 (read only) 2181588 2182372 784 0.0
(read/write) 148625 148625 0 0.0
.bss 65409 65409 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 74968 74968 0 0.0
.dynamic 560 560 0 0.0
.got 4256 4256 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133444 133460 16 0.0
.text 1829984 1830752 768 0.0
tv-app debug (read only) 2628553 2629313 760 0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199805 199749 -56 -0.0
.text 2254706 2255522 816 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351012 2351076 64 0.0
.bss 186212 186212 0 0.0
.data 5784 5784 0 0.0
.text 1313612 1313676 64 0.0
p6 all-clusters-app default (read/write) 2495680 2495792 112 0.0
.bss 119640 119640 0 0.0
.data 2672 2672 0 0.0
.text 1453944 1454056 112 0.0
light-app default (read/write) 2399680 2399792 112 0.0
.bss 113104 113104 0 0.0
.data 2528 2528 0 0.0
.text 1357944 1358056 112 0.0
lock-app default (read/write) 2363240 2363352 112 0.0
.bss 112848 112848 0 0.0
.data 2488 2488 0 0.0
.text 1321504 1321616 112 0.0
telink lighting-app tlsr9518adk80d (read/write) 889766 889846 80 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 628970 629054 84 0.0

This was referenced Mar 15, 2022
Merged
Merged
@kghost kghost marked this pull request as ready for review March 18, 2022 05:18
@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16098: Size comparison from fe5ec84 to 8e1185c

Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fe5ec84 8e1185c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603538 603610 72 0.0
.app_xip_area 510636 510708 72 0.0
lock cyw930739m2evb_01 (read/write) 561326 561398 72 0.0
.app_xip_area 469952 470024 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571130 80 0.0
.app_xip_area 470028 470108 80 0.0
efr32 lighting-app BRD4161A (read only) 921384 921480 96 0.0
.text 921376 921472 96 0.0
BRD4161A+rpc (read only) 950188 950284 96 0.0
.text 950180 950276 96 0.0
window-app BRD4161A (read only) 851944 852056 112 0.0
.text 851936 852048 112 0.0
esp32 all-clusters-app c3devkit (read only) 961498 961568 70 0.0
.flash.text 961498 961568 70 0.0
m5stack (read only) 1017639 1017715 76 0.0
.flash.text 1012255 1012331 76 0.0
k32w light k32w061+release (read/write) 700516 700596 80 0.0
.text 615196 615276 80 0.0
lock k32w061+release (read/write) 700652 700716 64 0.0
.text 615320 615384 64 0.0
linux chip-tool-ipv6only arm64 (read only) 9767292 9768076 784 0.0
.rodata 493620 493636 16 0.0
.text 8222308 8223076 768 0.0
thermostat-no-ble arm64 (read only) 2221188 2221972 784 0.0
.rodata 137956 137972 16 0.0
.text 1863168 1863936 768 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352508 2352572 64 0.0
.text 1315108 1315172 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155239 1155303 64 0.0
text 787588 787656 68 0.0
p6 all-clusters-app default (read/write) 2492120 2492232 112 0.0
.text 1450384 1450496 112 0.0
light-app default (read/write) 2395704 2395800 96 0.0
.text 1353968 1354064 96 0.0
lock-app default (read/write) 2359248 2359344 96 0.0
.text 1317512 1317608 96 0.0
telink lighting-app tlsr9518adk80d (read/write) 895306 895394 88 0.0
text 632968 633052 84 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fe5ec84 8e1185c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603538 603610 72 0.0
.app_xip_area 510636 510708 72 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561326 561398 72 0.0
.app_xip_area 469952 470024 72 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571130 80 0.0
.app_xip_area 470028 470108 80 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921384 921480 96 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 921376 921472 96 0.0
BRD4161A+rpc (read only) 950188 950284 96 0.0
(read/write) 144708 144708 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 950180 950276 96 0.0
window-app BRD4161A (read only) 851944 852056 112 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851936 852048 112 0.0
esp32 all-clusters-app c3devkit (read only) 961498 961568 70 0.0
(read/write) 1395034 1395034 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197888 197888 0 0.0
.flash.text 961498 961568 70 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017639 1017715 76 0.0
(read/write) 462892 462892 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227464 227464 0 0.0
.flash.text 1012255 1012331 76 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700516 700596 80 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 615196 615276 80 0.0
lock k32w061+release (read/write) 700652 700716 64 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615320 615384 64 0.0
linux chip-tool-ipv6only arm64 (read only) 9767292 9768076 784 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493636 16 0.0
.text 8222308 8223076 768 0.0
thermostat-no-ble arm64 (read only) 2221188 2221972 784 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137956 137972 16 0.0
.text 1863168 1863936 768 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352508 2352572 64 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315108 1315172 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155239 1155303 64 0.0
bss 146724 146724 0 0.0
rodata 145768 145768 0 0.0
text 787588 787656 68 0.0
p6 all-clusters-app default (read/write) 2492120 2492232 112 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450384 1450496 112 0.0
light-app default (read/write) 2395704 2395800 96 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353968 1354064 96 0.0
lock-app default (read/write) 2359248 2359344 96 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317512 1317608 96 0.0
telink lighting-app tlsr9518adk80d (read/write) 895306 895394 88 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632968 633052 84 0.0

@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16098: Size comparison from b24efd9 to 352ff04

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b24efd9 352ff04 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603790 312 0.1
.app_xip_area 510576 510888 312 0.1
lock cyw930739m2evb_01 (read/write) 561274 561586 312 0.1
.app_xip_area 469900 470212 312 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573358 573454 96 0.0
.app_xip_area 472336 472432 96 0.0
efr32 lighting-app BRD4161A (read only) 922876 923324 448 0.0
.text 922868 923316 448 0.0
BRD4161A+rpc (read only) 951708 952156 448 0.0
.text 951700 952148 448 0.0
window-app BRD4161A (read only) 852672 853120 448 0.1
.text 852664 853112 448 0.1
esp32 all-clusters-app c3devkit (read only) 964156 964418 262 0.0
(read/write) 1393714 1393858 144 0.0
.flash.rodata 198536 198680 144 0.1
.flash.text 964156 964418 262 0.0
m5stack (read only) 1020691 1020935 244 0.0
(read/write) 461492 461628 136 0.0
.flash.rodata 228040 228176 136 0.1
.flash.text 1015307 1015551 244 0.0
k32w light k32w061+release (read/write) 701652 702052 400 0.1
.text 616336 616736 400 0.1
lock k32w061+release (read/write) 701088 701488 400 0.1
.text 615756 616156 400 0.1
linux all-clusters-app debug (read only) 2478313 2479689 1376 0.1
.rodata 211941 212005 64 0.0
.text 2102898 2104210 1312 0.1
bridge-app debug+rpc (read only) 1753357 1754733 1376 0.1
.rodata 144556 144620 64 0.0
.text 1493589 1494901 1312 0.1
chip-tool debug (read only) 10180709 10182101 1392 0.0
(read/write) 354976 355008 32 0.0
.data.rel.ro 325520 325536 16 0.0
.rodata 520213 520309 96 0.0
.text 8877653 8878949 1296 0.0
chip-tool-ipv6only arm64 (read only) 9799868 9801212 1344 0.0
.rodata 495764 495924 160 0.0
.text 8251428 8252612 1184 0.0
door-lock-app debug (read only) 2005113 2006521 1408 0.1
.rodata 180988 181084 96 0.1
.text 1674466 1675778 1312 0.1
lighting-app debug+rpc (read only) 2178761 2180169 1408 0.1
.rodata 175164 175260 96 0.1
.text 1844578 1845890 1312 0.1
ota-provider-app debug (read only) 1946497 1947889 1392 0.1
.rodata 166987 167051 64 0.0
.text 1627794 1629122 1328 0.1
ota-requestor-app debug (read only) 1973305 1974697 1392 0.1
.rodata 162980 163044 64 0.0
.text 1657698 1659026 1328 0.1
shell debug (read only) 2427657 2429049 1392 0.1
.rodata 209362 209458 96 0.0
.text 2061570 2062866 1296 0.1
thermostat-no-ble arm64 (read only) 2262692 2264052 1360 0.1
.rodata 139780 139940 160 0.1
.text 1899600 1900800 1200 0.1
tv-app debug (read only) 2679225 2680625 1400 0.1
.rodata 207157 207261 104 0.1
.text 2297218 2298514 1296 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353636 2354036 400 0.0
.text 1316236 1316636 400 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139467 1139863 396 0.0
rodata 141588 141728 140 0.1
text 780524 780788 264 0.0
p6 all-clusters-app default (read/write) 2493592 2494040 448 0.0
.text 1451856 1452304 448 0.0
light-app default (read/write) 2396776 2397208 432 0.0
.text 1355040 1355472 432 0.0
lock-app default (read/write) 2360312 2360744 432 0.0
.text 1318576 1319008 432 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 897378 424 0.0
text 634304 634578 274 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b24efd9 352ff04 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603790 312 0.1
.app_xip_area 510576 510888 312 0.1
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561274 561586 312 0.1
.app_xip_area 469900 470212 312 0.1
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573358 573454 96 0.0
.app_xip_area 472336 472432 96 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 923324 448 0.0
(read/write) 128748 128748 0 0.0
.bss 126760 126760 0 0.0
.data 1988 1988 0 0.0
.text 922868 923316 448 0.0
BRD4161A+rpc (read only) 951708 952156 448 0.0
(read/write) 144704 144704 0 0.0
.bss 142536 142536 0 0.0
.data 2168 2168 0 0.0
.text 951700 952148 448 0.0
window-app BRD4161A (read only) 852672 853120 448 0.1
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852664 853112 448 0.1
esp32 all-clusters-app c3devkit (read only) 964156 964418 262 0.0
(read/write) 1393714 1393858 144 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198536 198680 144 0.1
.flash.text 964156 964418 262 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020691 1020935 244 0.0
(read/write) 461492 461628 136 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 228040 228176 136 0.1
.flash.text 1015307 1015551 244 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701652 702052 400 0.1
.bss 77648 77648 0 0.0
.data 1868 1868 0 0.0
.text 616336 616736 400 0.1
lock k32w061+release (read/write) 701088 701488 400 0.1
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615756 616156 400 0.1
linux all-clusters-app debug (read only) 2478313 2479689 1376 0.1
(read/write) 143216 143216 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78904 78904 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211941 212005 64 0.0
.text 2102898 2104210 1312 0.1
bridge-app debug+rpc (read only) 1753357 1754733 1376 0.1
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144556 144620 64 0.0
.text 1493589 1494901 1312 0.1
chip-tool debug (read only) 10180709 10182101 1392 0.0
(read/write) 354976 355008 32 0.0
.bss 22336 22336 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325520 325536 16 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520213 520309 96 0.0
.text 8877653 8878949 1296 0.0
chip-tool-ipv6only arm64 (read only) 9799868 9801212 1344 0.0
(read/write) 473185 473185 0 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371960 371960 0 0.0
.dynamic 560 560 0 0.0
.got 55680 55680 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 495764 495924 160 0.0
.text 8251428 8252612 1184 0.0
door-lock-app debug (read only) 2005113 2006521 1408 0.1
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180988 181084 96 0.1
.text 1674466 1675778 1312 0.1
lighting-app debug+rpc (read only) 2178761 2180169 1408 0.1
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175164 175260 96 0.1
.text 1844578 1845890 1312 0.1
ota-provider-app debug (read only) 1946497 1947889 1392 0.1
(read/write) 112560 112560 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166987 167051 64 0.0
.text 1627794 1629122 1328 0.1
ota-requestor-app debug (read only) 1973305 1974697 1392 0.1
(read/write) 115784 115784 0 0.0
.bss 48448 48448 0 0.0
.data 1448 1448 0 0.0
.data.rel.ro 60424 60424 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162980 163044 64 0.0
.text 1657698 1659026 1328 0.1
shell debug (read only) 2427657 2429049 1392 0.1
(read/write) 147272 147272 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209362 209458 96 0.0
.text 2061570 2062866 1296 0.1
thermostat-no-ble arm64 (read only) 2262692 2264052 1360 0.1
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139940 160 0.1
.text 1899600 1900800 1200 0.1
tv-app debug (read only) 2679225 2680625 1400 0.1
(read/write) 247744 247744 0 0.0
.bss 164416 164416 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207157 207261 104 0.1
.text 2297218 2298514 1296 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2354036 400 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316236 1316636 400 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139467 1139863 396 0.0
bss 142588 142588 0 0.0
rodata 141588 141728 140 0.1
text 780524 780788 264 0.0
p6 all-clusters-app default (read/write) 2493592 2494040 448 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451856 1452304 448 0.0
light-app default (read/write) 2396776 2397208 432 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355040 1355472 432 0.0
lock-app default (read/write) 2360312 2360744 432 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318576 1319008 432 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 897378 424 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634304 634578 274 0.0

@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16098: Size comparison from 2b7a67e to cbc5a31

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2b7a67e cbc5a31 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603790 312 0.1
.app_xip_area 510576 510888 312 0.1
lock cyw930739m2evb_01 (read/write) 561274 561586 312 0.1
.app_xip_area 469900 470212 312 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573358 573454 96 0.0
.app_xip_area 472336 472432 96 0.0
efr32 lighting-app BRD4161A (read only) 922876 923324 448 0.0
.text 922868 923316 448 0.0
BRD4161A+rpc (read only) 951708 952156 448 0.0
.text 951700 952148 448 0.0
window-app BRD4161A (read only) 852672 853120 448 0.1
.text 852664 853112 448 0.1
esp32 all-clusters-app c3devkit (read only) 964156 964418 262 0.0
(read/write) 1393714 1393858 144 0.0
.flash.rodata 198536 198680 144 0.1
.flash.text 964156 964418 262 0.0
m5stack (read only) 1020691 1020935 244 0.0
(read/write) 461492 461628 136 0.0
.flash.rodata 228040 228176 136 0.1
.flash.text 1015307 1015551 244 0.0
k32w light k32w061+release (read/write) 701652 702052 400 0.1
.text 616336 616736 400 0.1
lock k32w061+release (read/write) 701088 701488 400 0.1
.text 615756 616156 400 0.1
linux all-clusters-app debug (read only) 2478313 2479689 1376 0.1
.rodata 211941 212005 64 0.0
.text 2102898 2104210 1312 0.1
bridge-app debug+rpc (read only) 1753357 1754733 1376 0.1
.rodata 144556 144620 64 0.0
.text 1493589 1494901 1312 0.1
chip-tool debug (read only) 10180709 10182101 1392 0.0
(read/write) 354976 355008 32 0.0
.data.rel.ro 325520 325536 16 0.0
.rodata 520213 520309 96 0.0
.text 8877653 8878949 1296 0.0
chip-tool-ipv6only arm64 (read only) 9799868 9801212 1344 0.0
.rodata 495764 495924 160 0.0
.text 8251428 8252612 1184 0.0
door-lock-app debug (read only) 2005113 2006521 1408 0.1
.rodata 180988 181084 96 0.1
.text 1674466 1675778 1312 0.1
lighting-app debug+rpc (read only) 2178761 2180169 1408 0.1
.rodata 175164 175260 96 0.1
.text 1844578 1845890 1312 0.1
ota-provider-app debug (read only) 1946497 1947889 1392 0.1
.rodata 166987 167051 64 0.0
.text 1627794 1629122 1328 0.1
ota-requestor-app debug (read only) 1973305 1974697 1392 0.1
.rodata 162980 163044 64 0.0
.text 1657698 1659026 1328 0.1
shell debug (read only) 2427657 2429049 1392 0.1
.rodata 209362 209458 96 0.0
.text 2061570 2062866 1296 0.1
thermostat-no-ble arm64 (read only) 2262692 2264052 1360 0.1
.rodata 139780 139940 160 0.1
.text 1899600 1900800 1200 0.1
tv-app debug (read only) 2679225 2680625 1400 0.1
.rodata 207157 207261 104 0.1
.text 2297218 2298514 1296 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353636 2354036 400 0.0
.text 1316236 1316636 400 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139467 1139863 396 0.0
rodata 141588 141728 140 0.1
text 780524 780788 264 0.0
p6 all-clusters-app default (read/write) 2493592 2494040 448 0.0
.text 1451856 1452304 448 0.0
light-app default (read/write) 2396776 2397208 432 0.0
.text 1355040 1355472 432 0.0
lock-app default (read/write) 2360312 2360744 432 0.0
.text 1318576 1319008 432 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 897378 424 0.0
text 634304 634578 274 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2b7a67e cbc5a31 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603790 312 0.1
.app_xip_area 510576 510888 312 0.1
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561274 561586 312 0.1
.app_xip_area 469900 470212 312 0.1
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573358 573454 96 0.0
.app_xip_area 472336 472432 96 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 923324 448 0.0
(read/write) 128748 128748 0 0.0
.bss 126760 126760 0 0.0
.data 1988 1988 0 0.0
.text 922868 923316 448 0.0
BRD4161A+rpc (read only) 951708 952156 448 0.0
(read/write) 144704 144704 0 0.0
.bss 142536 142536 0 0.0
.data 2168 2168 0 0.0
.text 951700 952148 448 0.0
window-app BRD4161A (read only) 852672 853120 448 0.1
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852664 853112 448 0.1
esp32 all-clusters-app c3devkit (read only) 964156 964418 262 0.0
(read/write) 1393714 1393858 144 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198536 198680 144 0.1
.flash.text 964156 964418 262 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020691 1020935 244 0.0
(read/write) 461492 461628 136 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 228040 228176 136 0.1
.flash.text 1015307 1015551 244 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701652 702052 400 0.1
.bss 77648 77648 0 0.0
.data 1868 1868 0 0.0
.text 616336 616736 400 0.1
lock k32w061+release (read/write) 701088 701488 400 0.1
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615756 616156 400 0.1
linux all-clusters-app debug (read only) 2478313 2479689 1376 0.1
(read/write) 143216 143216 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78904 78904 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211941 212005 64 0.0
.text 2102898 2104210 1312 0.1
bridge-app debug+rpc (read only) 1753357 1754733 1376 0.1
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144556 144620 64 0.0
.text 1493589 1494901 1312 0.1
chip-tool debug (read only) 10180709 10182101 1392 0.0
(read/write) 354976 355008 32 0.0
.bss 22336 22336 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325520 325536 16 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520213 520309 96 0.0
.text 8877653 8878949 1296 0.0
chip-tool-ipv6only arm64 (read only) 9799868 9801212 1344 0.0
(read/write) 473185 473185 0 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371960 371960 0 0.0
.dynamic 560 560 0 0.0
.got 55680 55680 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 495764 495924 160 0.0
.text 8251428 8252612 1184 0.0
door-lock-app debug (read only) 2005113 2006521 1408 0.1
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180988 181084 96 0.1
.text 1674466 1675778 1312 0.1
lighting-app debug+rpc (read only) 2178761 2180169 1408 0.1
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175164 175260 96 0.1
.text 1844578 1845890 1312 0.1
ota-provider-app debug (read only) 1946497 1947889 1392 0.1
(read/write) 112560 112560 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166987 167051 64 0.0
.text 1627794 1629122 1328 0.1
ota-requestor-app debug (read only) 1973305 1974697 1392 0.1
(read/write) 115784 115784 0 0.0
.bss 48448 48448 0 0.0
.data 1448 1448 0 0.0
.data.rel.ro 60424 60424 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162980 163044 64 0.0
.text 1657698 1659026 1328 0.1
shell debug (read only) 2427657 2429049 1392 0.1
(read/write) 147272 147272 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209362 209458 96 0.0
.text 2061570 2062866 1296 0.1
thermostat-no-ble arm64 (read only) 2262692 2264052 1360 0.1
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139940 160 0.1
.text 1899600 1900800 1200 0.1
tv-app debug (read only) 2679225 2680625 1400 0.1
(read/write) 247744 247744 0 0.0
.bss 164416 164416 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207157 207261 104 0.1
.text 2297218 2298514 1296 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2354036 400 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316236 1316636 400 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139467 1139863 396 0.0
bss 142588 142588 0 0.0
rodata 141588 141728 140 0.1
text 780524 780788 264 0.0
p6 all-clusters-app default (read/write) 2493592 2494040 448 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451856 1452304 448 0.0
light-app default (read/write) 2396776 2397208 432 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355040 1355472 432 0.0
lock-app default (read/write) 2360312 2360744 432 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318576 1319008 432 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 897378 424 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634304 634578 274 0.0

@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

PR #16098: Size comparison from 07fc8cd to 41fe331

Increases (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 07fc8cd 41fe331 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603578 603682 104 0.0
.app_xip_area 510748 510852 104 0.0
lock cyw930739m2evb_01 (read/write) 561366 561470 104 0.0
.app_xip_area 470064 470168 104 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573442 573538 96 0.0
.app_xip_area 472492 472588 96 0.0
efr32 lighting-app BRD4161A (read only) 923448 923608 160 0.0
.text 923440 923600 160 0.0
BRD4161A+rpc (read only) 952272 952416 144 0.0
.text 952264 952408 144 0.0
window-app BRD4161A (read only) 853236 853396 160 0.0
.text 853228 853388 160 0.0
k32w light k32w061+release (read/write) 701720 701832 112 0.0
.text 616476 616588 112 0.0
lock k32w061+release (read/write) 701172 701284 112 0.0
.text 615912 616024 112 0.0
linux chip-tool-ipv6only arm64 (read only) 9830844 9831740 896 0.0
.rodata 496452 496468 16 0.0
.text 8280292 8281172 880 0.0
thermostat-no-ble arm64 (read only) 2266140 2267052 912 0.0
.rodata 139708 139724 16 0.0
.text 1903024 1903920 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353772 2353836 64 0.0
.text 1316372 1316436 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140119 1140231 112 0.0
text 780852 780956 104 0.0
p6 all-clusters-app default (read/write) 2494952 2495096 144 0.0
.text 1453216 1453360 144 0.0
light-app default (read/write) 2397312 2397456 144 0.0
.text 1355576 1355720 144 0.0
lock-app default (read/write) 2360840 2360984 144 0.0
.text 1319104 1319248 144 0.0
telink lighting-app tlsr9518adk80d (read/write) 897102 897222 120 0.0
text 634432 634550 118 0.0
Full report (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 07fc8cd 41fe331 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603578 603682 104 0.0
.app_xip_area 510748 510852 104 0.0
.bss 75576 75576 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561366 561470 104 0.0
.app_xip_area 470064 470168 104 0.0
.bss 74080 74080 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573442 573538 96 0.0
.app_xip_area 472492 472588 96 0.0
.bss 83408 83408 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 923448 923608 160 0.0
(read/write) 128680 128680 0 0.0
.bss 126680 126680 0 0.0
.data 1996 1996 0 0.0
.text 923440 923600 160 0.0
BRD4161A+rpc (read only) 952272 952416 144 0.0
(read/write) 144632 144632 0 0.0
.bss 142456 142456 0 0.0
.data 2176 2176 0 0.0
.text 952264 952408 144 0.0
window-app BRD4161A (read only) 853236 853396 160 0.0
(read/write) 126648 126648 0 0.0
.bss 124776 124776 0 0.0
.data 1872 1872 0 0.0
.text 853228 853388 160 0.0
k32w light k32w061+release (read/write) 701720 701832 112 0.0
.bss 77568 77568 0 0.0
.data 1876 1876 0 0.0
.text 616476 616588 112 0.0
lock k32w061+release (read/write) 701172 701284 112 0.0
.bss 77544 77544 0 0.0
.data 1916 1916 0 0.0
.text 615912 616024 112 0.0
linux chip-tool-ipv6only arm64 (read only) 9830844 9831740 896 0.0
(read/write) 473889 473889 0 0.0
.bss 40769 40769 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372312 372312 0 0.0
.dynamic 560 560 0 0.0
.got 55864 55864 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 496452 496468 16 0.0
.text 8280292 8281172 880 0.0
thermostat-no-ble arm64 (read only) 2266140 2267052 912 0.0
(read/write) 148401 148401 0 0.0
.bss 62849 62849 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139708 139724 16 0.0
.text 1903024 1903920 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353772 2353836 64 0.0
.bss 184572 184572 0 0.0
.data 5760 5760 0 0.0
.text 1316372 1316436 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140119 1140231 112 0.0
bss 142508 142508 0 0.0
rodata 141912 141912 0 0.0
text 780852 780956 104 0.0
p6 all-clusters-app default (read/write) 2494952 2495096 144 0.0
.bss 117992 117992 0 0.0
.data 2640 2640 0 0.0
.text 1453216 1453360 144 0.0
light-app default (read/write) 2397312 2397456 144 0.0
.bss 111464 111464 0 0.0
.data 2496 2496 0 0.0
.text 1355576 1355720 144 0.0
lock-app default (read/write) 2360840 2360984 144 0.0
.bss 111208 111208 0 0.0
.data 2456 2456 0 0.0
.text 1319104 1319248 144 0.0
telink lighting-app tlsr9518adk80d (read/write) 897102 897222 120 0.0
bss 87364 87364 0 0.0
noinit 37160 37160 0 0.0
text 634432 634550 118 0.0

@restyled-io restyled-io bot mentioned this pull request Mar 24, 2022
Closed
@kghost kghost mentioned this pull request Mar 24, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

PR #16098: Size comparison from 07fc8cd to 3abe59f

Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 07fc8cd 3abe59f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603578 603682 104 0.0
.app_xip_area 510748 510852 104 0.0
lock cyw930739m2evb_01 (read/write) 561366 561470 104 0.0
.app_xip_area 470064 470168 104 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573442 573538 96 0.0
.app_xip_area 472492 472588 96 0.0
efr32 lighting-app BRD4161A (read only) 923448 923608 160 0.0
.text 923440 923600 160 0.0
BRD4161A+rpc (read only) 952272 952416 144 0.0
.text 952264 952408 144 0.0
window-app BRD4161A (read only) 853236 853396 160 0.0
.text 853228 853388 160 0.0
esp32 all-clusters-app c3devkit (read only) 964750 964856 106 0.0
.flash.text 964750 964856 106 0.0
m5stack (read only) 1021079 1021191 112 0.0
.flash.text 1015695 1015807 112 0.0
k32w light k32w061+release (read/write) 701720 701832 112 0.0
.text 616476 616588 112 0.0
lock k32w061+release (read/write) 701172 701284 112 0.0
.text 615912 616024 112 0.0
linux chip-tool-ipv6only arm64 (read only) 9830844 9831740 896 0.0
.rodata 496452 496468 16 0.0
.text 8280292 8281172 880 0.0
thermostat-no-ble arm64 (read only) 2266140 2267052 912 0.0
.rodata 139708 139724 16 0.0
.text 1903024 1903920 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353772 2353836 64 0.0
.text 1316372 1316436 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140119 1140231 112 0.0
text 780852 780956 104 0.0
p6 all-clusters-app default (read/write) 2494952 2495096 144 0.0
.text 1453216 1453360 144 0.0
light-app default (read/write) 2397312 2397456 144 0.0
.text 1355576 1355720 144 0.0
lock-app default (read/write) 2360840 2360984 144 0.0
.text 1319104 1319248 144 0.0
telink lighting-app tlsr9518adk80d (read/write) 897102 897222 120 0.0
text 634432 634550 118 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 07fc8cd 3abe59f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603578 603682 104 0.0
.app_xip_area 510748 510852 104 0.0
.bss 75576 75576 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561366 561470 104 0.0
.app_xip_area 470064 470168 104 0.0
.bss 74080 74080 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573442 573538 96 0.0
.app_xip_area 472492 472588 96 0.0
.bss 83408 83408 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 923448 923608 160 0.0
(read/write) 128680 128680 0 0.0
.bss 126680 126680 0 0.0
.data 1996 1996 0 0.0
.text 923440 923600 160 0.0
BRD4161A+rpc (read only) 952272 952416 144 0.0
(read/write) 144632 144632 0 0.0
.bss 142456 142456 0 0.0
.data 2176 2176 0 0.0
.text 952264 952408 144 0.0
window-app BRD4161A (read only) 853236 853396 160 0.0
(read/write) 126648 126648 0 0.0
.bss 124776 124776 0 0.0
.data 1872 1872 0 0.0
.text 853228 853388 160 0.0
esp32 all-clusters-app c3devkit (read only) 964750 964856 106 0.0
(read/write) 1394194 1394194 0 0.0
.dram0.bss 61992 61992 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 199064 199064 0 0.0
.flash.text 964750 964856 106 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1021079 1021191 112 0.0
(read/write) 461940 461940 0 0.0
.dram0.bss 67520 67520 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228560 228560 0 0.0
.flash.text 1015695 1015807 112 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701720 701832 112 0.0
.bss 77568 77568 0 0.0
.data 1876 1876 0 0.0
.text 616476 616588 112 0.0
lock k32w061+release (read/write) 701172 701284 112 0.0
.bss 77544 77544 0 0.0
.data 1916 1916 0 0.0
.text 615912 616024 112 0.0
linux chip-tool-ipv6only arm64 (read only) 9830844 9831740 896 0.0
(read/write) 473889 473889 0 0.0
.bss 40769 40769 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372312 372312 0 0.0
.dynamic 560 560 0 0.0
.got 55864 55864 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 496452 496468 16 0.0
.text 8280292 8281172 880 0.0
thermostat-no-ble arm64 (read only) 2266140 2267052 912 0.0
(read/write) 148401 148401 0 0.0
.bss 62849 62849 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139708 139724 16 0.0
.text 1903024 1903920 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353772 2353836 64 0.0
.bss 184572 184572 0 0.0
.data 5760 5760 0 0.0
.text 1316372 1316436 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140119 1140231 112 0.0
bss 142508 142508 0 0.0
rodata 141912 141912 0 0.0
text 780852 780956 104 0.0
p6 all-clusters-app default (read/write) 2494952 2495096 144 0.0
.bss 117992 117992 0 0.0
.data 2640 2640 0 0.0
.text 1453216 1453360 144 0.0
light-app default (read/write) 2397312 2397456 144 0.0
.bss 111464 111464 0 0.0
.data 2496 2496 0 0.0
.text 1355576 1355720 144 0.0
lock-app default (read/write) 2360840 2360984 144 0.0
.bss 111208 111208 0 0.0
.data 2456 2456 0 0.0
.text 1319104 1319248 144 0.0
telink lighting-app tlsr9518adk80d (read/write) 897102 897222 120 0.0
bss 87364 87364 0 0.0
noinit 37160 37160 0 0.0
text 634432 634550 118 0.0

@kghost @tcarmelveilleux
Apply suggestions from code review
a1a0506 
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

PR #16098: Size comparison from 07fc8cd to a1a0506

Increases (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
platform target config section 07fc8cd a1a0506 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603578 603634 56 0.0
.app_xip_area 510748 510804 56 0.0
lock cyw930739m2evb_01 (read/write) 561366 561422 56 0.0
.app_xip_area 470064 470120 56 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573442 573522 80 0.0
.app_xip_area 472492 472572 80 0.0
efr32 lighting-app BRD4161A (read only) 923448 923536 88 0.0
.text 923440 923528 88 0.0
BRD4161A+rpc (read only) 952272 952344 72 0.0
.text 952264 952336 72 0.0
window-app BRD4161A (read only) 853236 853340 104 0.0
.text 853228 853332 104 0.0
esp32 all-clusters-app c3devkit (read only) 964750 964910 160 0.0
.flash.text 964750 964910 160 0.0
m5stack (read only) 1021079 1021219 140 0.0
.flash.text 1015695 1015835 140 0.0
k32w light k32w061+release (read/write) 701720 701776 56 0.0
.text 616476 616532 56 0.0
lock k32w061+release (read/write) 701172 701228 56 0.0
.text 615912 615968 56 0.0
linux chip-tool-ipv6only arm64 (read only) 9830844 9833532 2688 0.0
.rodata 496452 496500 48 0.0
.text 8280292 8282932 2640 0.0
thermostat-no-ble arm64 (read only) 2266140 2267020 880 0.0
.text 1903024 1903920 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353772 2353868 96 0.0
.text 1316372 1316468 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 142508 142512 4 0.0
text 780852 780868 16 0.0
p6 all-clusters-app default (read/write) 2494952 2495088 136 0.0
.text 1453216 1453352 136 0.0
light-app default (read/write) 2397312 2397464 152 0.0
.text 1355576 1355728 152 0.0
lock-app default (read/write) 2360840 2360992 152 0.0
.text 1319104 1319256 152 0.0
Decreases (5 builds for esp32, linux, nrfconnect, telink)
platform target config section 07fc8cd a1a0506 change % change
esp32 all-clusters-app c3devkit (read/write) 1394194 1394154 -40 -0.0
.flash.rodata 199064 199024 -40 -0.0
m5stack (read/write) 461940 461900 -40 -0.0
.flash.rodata 228560 228520 -40 -0.0
linux thermostat-no-ble arm64 (read/write) 148401 148385 -16 -0.0
.bss 62849 62833 -16 -0.0
.rodata 139708 139692 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140119 1140095 -24 -0.0
rodata 141912 141872 -40 -0.0
telink lighting-app tlsr9518adk80d (read/write) 897102 896686 -416 -0.0
bss 87364 87356 -8 -0.0
text 634432 634102 -330 -0.1
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 07fc8cd a1a0506 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603578 603634 56 0.0
.app_xip_area 510748 510804 56 0.0
.bss 75576 75576 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561366 561422 56 0.0
.app_xip_area 470064 470120 56 0.0
.bss 74080 74080 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573442 573522 80 0.0
.app_xip_area 472492 472572 80 0.0
.bss 83408 83408 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 923448 923536 88 0.0
(read/write) 128680 128680 0 0.0
.bss 126680 126680 0 0.0
.data 1996 1996 0 0.0
.text 923440 923528 88 0.0
BRD4161A+rpc (read only) 952272 952344 72 0.0
(read/write) 144632 144632 0 0.0
.bss 142456 142456 0 0.0
.data 2176 2176 0 0.0
.text 952264 952336 72 0.0
window-app BRD4161A (read only) 853236 853340 104 0.0
(read/write) 126648 126648 0 0.0
.bss 124776 124776 0 0.0
.data 1872 1872 0 0.0
.text 853228 853332 104 0.0
esp32 all-clusters-app c3devkit (read only) 964750 964910 160 0.0
(read/write) 1394194 1394154 -40 -0.0
.dram0.bss 61992 61992 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 199064 199024 -40 -0.0
.flash.text 964750 964910 160 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1021079 1021219 140 0.0
(read/write) 461940 461900 -40 -0.0
.dram0.bss 67520 67520 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228560 228520 -40 -0.0
.flash.text 1015695 1015835 140 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701720 701776 56 0.0
.bss 77568 77568 0 0.0
.data 1876 1876 0 0.0
.text 616476 616532 56 0.0
lock k32w061+release (read/write) 701172 701228 56 0.0
.bss 77544 77544 0 0.0
.data 1916 1916 0 0.0
.text 615912 615968 56 0.0
linux chip-tool-ipv6only arm64 (read only) 9830844 9833532 2688 0.0
(read/write) 473889 473889 0 0.0
.bss 40769 40769 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372312 372312 0 0.0
.dynamic 560 560 0 0.0
.got 55864 55864 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 496452 496500 48 0.0
.text 8280292 8282932 2640 0.0
thermostat-no-ble arm64 (read only) 2266140 2267020 880 0.0
(read/write) 148401 148385 -16 -0.0
.bss 62849 62833 -16 -0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139708 139692 -16 -0.0
.text 1903024 1903920 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353772 2353868 96 0.0
.bss 184572 184572 0 0.0
.data 5760 5760 0 0.0
.text 1316372 1316468 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140119 1140095 -24 -0.0
bss 142508 142512 4 0.0
rodata 141912 141872 -40 -0.0
text 780852 780868 16 0.0
p6 all-clusters-app default (read/write) 2494952 2495088 136 0.0
.bss 117992 117992 0 0.0
.data 2640 2640 0 0.0
.text 1453216 1453352 136 0.0
light-app default (read/write) 2397312 2397464 152 0.0
.bss 111464 111464 0 0.0
.data 2496 2496 0 0.0
.text 1355576 1355728 152 0.0
lock-app default (read/write) 2360840 2360992 152 0.0
.bss 111208 111208 0 0.0
.data 2456 2456 0 0.0
.text 1319104 1319256 152 0.0
telink lighting-app tlsr9518adk80d (read/write) 897102 896686 -416 -0.0
bss 87364 87356 -8 -0.0
noinit 37160 37160 0 0.0
text 634432 634102 -330 -0.1

@kghost kghost merged commit 20f8b95 into project-chip:master Mar 24, 2022
@kghost kghost deleted the crypto-iv branch March 24, 2022 18:06
@bzbarsky-apple bzbarsky-apple mentioned this pull request Mar 29, 2022
Closed
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@kghost @tcarmelveilleux @andrei-menzopol
Crypto: Fix node id in IV (project-chip#16098)
d5ef847 
* Skip calling OnFabricRetrievedFromStorage when the fabric is already initialized

* Crypto: Fix node id in nonce

* Apply suggestions from code review

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 5, 2022
Closed
@turon turon mentioned this pull request May 24, 2022
Closed
@turon turon mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turon turon turon left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib message layer review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[security] GetIV must generate nonce using source id from session context
4 participants
@kghost @turon @tcarmelveilleux @bzbarsky-apple