Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow runtime init of some Server members (1/2) #16065

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Allow runtime init of some Server members (1/2) #16065

merged 3 commits into from
Mar 10, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

This PR is on the path towards having Server::Server no longer
statically initialize its members with storage, and instead
relying on Server::Init(). This will simplify organization
of unit tests and also the convergence of Controller/Server
storage to address issue #16028

Issue #16028

Change overview

  • Change several places where constructors receive a PersistentStorageDelegate to using an Init() argument instead
  • This is a minor structural change with no functional changes

Testing

  • Ran cert tests, still pass
  • Ran unit tests, still pass

@tcarmelveilleux
Allow runtime init of some Server members (1/2)
6a8a2bf 
This PR is on the path towards having Server::Server no longer
statically initialize its members with storage, and instead
relying on Server::Init(). This will simplify organization
of unit tests and also the convergence of Controller/Server
storage to address issue project-chip#16028

Issue project-chip#16028
@boring-cyborg boring-cyborg bot added the app label Mar 10, 2022
@restyled-io restyled-io bot mentioned this pull request Mar 10, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 10, 2022 •
edited
Loading

PR #16065: Size comparison from c49b115 to 1270278

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 1270278 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598218 116 0.0
.app_xip_area 505684 505800 116 0.0
lock cyw930739m2evb_01 (read/write) 555970 556094 124 0.0
.app_xip_area 465088 465212 124 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565978 565986 8 0.0
.app_xip_area 465408 465416 8 0.0
efr32 lighting-app BRD4161A (read only) 919808 919944 136 0.0
.text 919800 919936 136 0.0
BRD4161A+rpc (read only) 948620 948772 152 0.0
.text 948612 948764 152 0.0
window-app BRD4161A (read only) 852364 852500 136 0.0
.text 852356 852492 136 0.0
esp32 all-clusters-app c3devkit (read only) 957766 957818 52 0.0
(read/write) 1393810 1393850 40 0.0
.flash.rodata 197096 197136 40 0.0
.flash.text 957766 957818 52 0.0
m5stack (read only) 1012875 1012943 68 0.0
(read/write) 461052 461084 32 0.0
.flash.rodata 226056 226088 32 0.0
.flash.text 1007491 1007559 68 0.0
k32w light k32w061+release (read/write) 694464 694580 116 0.0
.text 609588 609704 116 0.0
lock k32w061+release (read/write) 695324 695456 132 0.0
.text 610488 610620 132 0.0
linux all-clusters-app debug (read only) 2430753 2431697 944 0.0
.rodata 205797 206021 224 0.1
.text 2061970 2062690 720 0.0
bridge-app debug+rpc (read only) 1736053 1736965 912 0.1
.rodata 141964 142188 224 0.2
.text 1478117 1478805 688 0.0
chip-tool debug (read only) 10093029 10093221 192 0.0
.rodata 514388 514420 32 0.0
.text 8795957 8796117 160 0.0
chip-tool-ipv6only arm64 (read only) 9728988 9729164 176 0.0
.rodata 492084 492116 32 0.0
.text 8185732 8185876 144 0.0
door-lock-app debug (read only) 1950353 1951313 960 0.0
.rodata 173884 174140 256 0.1
.text 1627826 1628530 704 0.0
lighting-app debug+rpc (read only) 2082521 2083481 960 0.0
.rodata 166076 166332 256 0.2
.text 1760786 1761490 704 0.0
ota-provider-app debug (read only) 1883753 1884729 976 0.1
.rodata 159091 159347 256 0.2
.text 1573938 1574658 720 0.0
ota-requestor-app debug (read only) 1911497 1912457 960 0.1
.rodata 155084 155340 256 0.2
.text 1605538 1606242 704 0.0
shell debug (read only) 2396769 2397729 960 0.0
.rodata 205746 206002 256 0.1
.text 2034450 2035154 704 0.0
thermostat-no-ble arm64 (read only) 2178892 2179820 928 0.0
.rodata 133132 133372 240 0.2
.text 1827184 1827872 688 0.0
tv-app debug (read only) 2622457 2623385 928 0.0
.rodata 199389 199613 224 0.1
.text 2248978 2249682 704 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351484 2351580 96 0.0
.text 1314084 1314180 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1151783 108 0.0
rodata 144452 144480 28 0.0
text 785760 785852 92 0.0
p6 all-clusters-app default (read/write) 2494296 2494448 152 0.0
.text 1452560 1452712 152 0.0
light-app default (read/write) 2398312 2398464 152 0.0
.text 1356576 1356728 152 0.0
lock-app default (read/write) 2361856 2362008 152 0.0
.text 1320120 1320272 152 0.0
telink lighting-app tlsr9518adk80d (read/write) 888878 888962 84 0.0
text 628158 628214 56 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 1270278 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598218 116 0.0
.app_xip_area 505684 505800 116 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555970 556094 124 0.0
.app_xip_area 465088 465212 124 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565978 565986 8 0.0
.app_xip_area 465408 465416 8 0.0
.bss 82980 82980 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919808 919944 136 0.0
(read/write) 128256 128256 0 0.0
.bss 126216 126216 0 0.0
.data 2040 2040 0 0.0
.text 919800 919936 136 0.0
BRD4161A+rpc (read only) 948620 948772 152 0.0
(read/write) 144212 144212 0 0.0
.bss 141992 141992 0 0.0
.data 2220 2220 0 0.0
.text 948612 948764 152 0.0
window-app BRD4161A (read only) 852364 852500 136 0.0
(read/write) 126220 126220 0 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 852356 852492 136 0.0
esp32 all-clusters-app c3devkit (read only) 957766 957818 52 0.0
(read/write) 1393810 1393850 40 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197096 197136 40 0.0
.flash.text 957766 957818 52 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012875 1012943 68 0.0
(read/write) 461052 461084 32 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226056 226088 32 0.0
.flash.text 1007491 1007559 68 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694464 694580 116 0.0
.bss 77152 77152 0 0.0
.data 1924 1924 0 0.0
.text 609588 609704 116 0.0
lock k32w061+release (read/write) 695324 695456 132 0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 610488 610620 132 0.0
linux all-clusters-app debug (read only) 2430753 2431697 944 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205797 206021 224 0.1
.text 2061970 2062690 720 0.0
bridge-app debug+rpc (read only) 1736053 1736965 912 0.1
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141964 142188 224 0.2
.text 1478117 1478805 688 0.0
chip-tool debug (read only) 10093029 10093221 192 0.0
(read/write) 358168 358168 0 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 325352 325352 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514388 514420 32 0.0
.text 8795957 8796117 160 0.0
chip-tool-ipv6only arm64 (read only) 9728988 9729164 176 0.0
(read/write) 475953 475953 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371712 371712 0 0.0
.dynamic 560 560 0 0.0
.got 55296 55296 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492084 492116 32 0.0
.text 8185732 8185876 144 0.0
door-lock-app debug (read only) 1950353 1951313 960 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173884 174140 256 0.1
.text 1627826 1628530 704 0.0
lighting-app debug+rpc (read only) 2082521 2083481 960 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166076 166332 256 0.2
.text 1760786 1761490 704 0.0
ota-provider-app debug (read only) 1883753 1884729 976 0.1
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159091 159347 256 0.2
.text 1573938 1574658 720 0.0
ota-requestor-app debug (read only) 1911497 1912457 960 0.1
(read/write) 117992 117992 0 0.0
.bss 51552 51552 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59512 59512 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155084 155340 256 0.2
.text 1605538 1606242 704 0.0
shell debug (read only) 2396769 2397729 960 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205746 206002 256 0.1
.text 2034450 2035154 704 0.0
thermostat-no-ble arm64 (read only) 2178892 2179820 928 0.0
(read/write) 148801 148801 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4232 4232 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133132 133372 240 0.2
.text 1827184 1827872 688 0.0
tv-app debug (read only) 2622457 2623385 928 0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 199613 224 0.1
.text 2248978 2249682 704 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351484 2351580 96 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1314084 1314180 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1151783 108 0.0
bss 146208 146208 0 0.0
rodata 144452 144480 28 0.0
text 785760 785852 92 0.0
p6 all-clusters-app default (read/write) 2494296 2494448 152 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1452560 1452712 152 0.0
light-app default (read/write) 2398312 2398464 152 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1356576 1356728 152 0.0
lock-app default (read/write) 2361856 2362008 152 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320120 1320272 152 0.0
telink lighting-app tlsr9518adk80d (read/write) 888878 888962 84 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628158 628214 56 0.0

@github-actions
Copy link

github-actions bot commented Mar 10, 2022 •
edited
Loading

PR #16065: Size comparison from c49b115 to 780fdad

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 780fdad change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598218 116 0.0
.app_xip_area 505684 505800 116 0.0
lock cyw930739m2evb_01 (read/write) 555970 556094 124 0.0
.app_xip_area 465088 465212 124 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565978 565994 16 0.0
.app_xip_area 465408 465424 16 0.0
efr32 lighting-app BRD4161A (read only) 919808 919960 152 0.0
.text 919800 919952 152 0.0
BRD4161A+rpc (read only) 948620 948788 168 0.0
.text 948612 948780 168 0.0
window-app BRD4161A (read only) 852364 852500 136 0.0
.text 852356 852492 136 0.0
esp32 all-clusters-app c3devkit (read only) 957766 957818 52 0.0
(read/write) 1393810 1393850 40 0.0
.flash.rodata 197096 197136 40 0.0
.flash.text 957766 957818 52 0.0
m5stack (read only) 1012875 1012943 68 0.0
(read/write) 461052 461084 32 0.0
.flash.rodata 226056 226088 32 0.0
.flash.text 1007491 1007559 68 0.0
k32w light k32w061+release (read/write) 694464 694596 132 0.0
.text 609588 609720 132 0.0
lock k32w061+release (read/write) 695324 695456 132 0.0
.text 610488 610620 132 0.0
linux all-clusters-app debug (read only) 2430753 2431697 944 0.0
.rodata 205797 206021 224 0.1
.text 2061970 2062690 720 0.0
bridge-app debug+rpc (read only) 1736053 1736965 912 0.1
.rodata 141964 142188 224 0.2
.text 1478117 1478805 688 0.0
chip-tool debug (read only) 10093029 10093221 192 0.0
.rodata 514388 514420 32 0.0
.text 8795957 8796117 160 0.0
chip-tool-ipv6only arm64 (read only) 9728988 9729164 176 0.0
.rodata 492084 492116 32 0.0
.text 8185732 8185876 144 0.0
door-lock-app debug (read only) 1950353 1951313 960 0.0
.rodata 173884 174140 256 0.1
.text 1627826 1628530 704 0.0
lighting-app debug+rpc (read only) 2082521 2083481 960 0.0
.rodata 166076 166332 256 0.2
.text 1760786 1761490 704 0.0
ota-provider-app debug (read only) 1883753 1884729 976 0.1
.rodata 159091 159347 256 0.2
.text 1573938 1574658 720 0.0
ota-requestor-app debug (read only) 1911497 1912601 1104 0.1
.rodata 155084 155340 256 0.2
.text 1605538 1606386 848 0.1
shell debug (read only) 2396769 2397729 960 0.0
.rodata 205746 206002 256 0.1
.text 2034450 2035154 704 0.0
thermostat-no-ble arm64 (read only) 2178892 2179820 928 0.0
.rodata 133132 133372 240 0.2
.text 1827184 1827872 688 0.0
tv-app debug (read only) 2622457 2623385 928 0.0
.rodata 199389 199613 224 0.1
.text 2248978 2249682 704 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351484 2351580 96 0.0
.text 1314084 1314180 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1151815 140 0.0
rodata 144452 144480 28 0.0
text 785760 785872 112 0.0
p6 all-clusters-app default (read/write) 2494296 2494448 152 0.0
.text 1452560 1452712 152 0.0
light-app default (read/write) 2398312 2398464 152 0.0
.text 1356576 1356728 152 0.0
lock-app default (read/write) 2361856 2362008 152 0.0
.text 1320120 1320272 152 0.0
telink lighting-app tlsr9518adk80d (read/write) 888878 888962 84 0.0
text 628158 628214 56 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 780fdad change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598218 116 0.0
.app_xip_area 505684 505800 116 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555970 556094 124 0.0
.app_xip_area 465088 465212 124 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565978 565994 16 0.0
.app_xip_area 465408 465424 16 0.0
.bss 82980 82980 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919808 919960 152 0.0
(read/write) 128256 128256 0 0.0
.bss 126216 126216 0 0.0
.data 2040 2040 0 0.0
.text 919800 919952 152 0.0
BRD4161A+rpc (read only) 948620 948788 168 0.0
(read/write) 144212 144212 0 0.0
.bss 141992 141992 0 0.0
.data 2220 2220 0 0.0
.text 948612 948780 168 0.0
window-app BRD4161A (read only) 852364 852500 136 0.0
(read/write) 126220 126220 0 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 852356 852492 136 0.0
esp32 all-clusters-app c3devkit (read only) 957766 957818 52 0.0
(read/write) 1393810 1393850 40 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197096 197136 40 0.0
.flash.text 957766 957818 52 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012875 1012943 68 0.0
(read/write) 461052 461084 32 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226056 226088 32 0.0
.flash.text 1007491 1007559 68 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694464 694596 132 0.0
.bss 77152 77152 0 0.0
.data 1924 1924 0 0.0
.text 609588 609720 132 0.0
lock k32w061+release (read/write) 695324 695456 132 0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 610488 610620 132 0.0
linux all-clusters-app debug (read only) 2430753 2431697 944 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205797 206021 224 0.1
.text 2061970 2062690 720 0.0
bridge-app debug+rpc (read only) 1736053 1736965 912 0.1
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141964 142188 224 0.2
.text 1478117 1478805 688 0.0
chip-tool debug (read only) 10093029 10093221 192 0.0
(read/write) 358168 358168 0 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 325352 325352 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514388 514420 32 0.0
.text 8795957 8796117 160 0.0
chip-tool-ipv6only arm64 (read only) 9728988 9729164 176 0.0
(read/write) 475953 475953 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371712 371712 0 0.0
.dynamic 560 560 0 0.0
.got 55296 55296 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492084 492116 32 0.0
.text 8185732 8185876 144 0.0
door-lock-app debug (read only) 1950353 1951313 960 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173884 174140 256 0.1
.text 1627826 1628530 704 0.0
lighting-app debug+rpc (read only) 2082521 2083481 960 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166076 166332 256 0.2
.text 1760786 1761490 704 0.0
ota-provider-app debug (read only) 1883753 1884729 976 0.1
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159091 159347 256 0.2
.text 1573938 1574658 720 0.0
ota-requestor-app debug (read only) 1911497 1912601 1104 0.1
(read/write) 117992 117992 0 0.0
.bss 51552 51552 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59512 59512 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155084 155340 256 0.2
.text 1605538 1606386 848 0.1
shell debug (read only) 2396769 2397729 960 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205746 206002 256 0.1
.text 2034450 2035154 704 0.0
thermostat-no-ble arm64 (read only) 2178892 2179820 928 0.0
(read/write) 148801 148801 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4232 4232 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133132 133372 240 0.2
.text 1827184 1827872 688 0.0
tv-app debug (read only) 2622457 2623385 928 0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 199613 224 0.1
.text 2248978 2249682 704 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351484 2351580 96 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1314084 1314180 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1151815 140 0.0
bss 146208 146208 0 0.0
rodata 144452 144480 28 0.0
text 785760 785872 112 0.0
p6 all-clusters-app default (read/write) 2494296 2494448 152 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1452560 1452712 152 0.0
light-app default (read/write) 2398312 2398464 152 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1356576 1356728 152 0.0
lock-app default (read/write) 2361856 2362008 152 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320120 1320272 152 0.0
telink lighting-app tlsr9518adk80d (read/write) 888878 888962 84 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628158 628214 56 0.0

@tcarmelveilleux tcarmelveilleux merged commit 665a4ae into project-chip:master Mar 10, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@tcarmelveilleux @restyled-commits @andrei-menzopol
Allow runtime init of some Server members (1/2) (project-chip#16065)
b77f454 
* Allow runtime init of some `Server` members (1/2)

This PR is on the path towards having Server::Server no longer
statically initialize its members with storage, and instead
relying on Server::Init(). This will simplify organization
of unit tests and also the convergence of Controller/Server
storage to address issue project-chip#16028

Issue project-chip#16028

* Restyled by clang-format

* Move a comment to the correct place

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagar-apple sagar-apple sagar-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tcarmelveilleux @andy31415 @msandstedt @mrjerryjohns @sagar-apple @restyled-commits