Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CI split between master (full) and PR (smoke) for ESP32" #15773

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

woody-apple
Copy link
Contributor

Reverts #15605

Testing revert, given this is causing master failures.

@woody-apple
Copy link
Contributor Author

Hotfixing, pending discussion. This is causing failures on merge, that are causing reverts - thus adding to CI time.

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

PR #15773: Size comparison from 1fd382d to df818eb

Full report (3 builds for cyw30739)
platform target config section 1fd382d df818eb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600618 600618 0 0.0
.app_xip_area 505392 505392 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558614 558614 0 0.0
.app_xip_area 464924 464924 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 579394 579394 0 0.0
.app_xip_area 476008 476008 0 0.0
.bss 85780 85780 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0

@woody-apple woody-apple merged commit 66aef3e into master Mar 3, 2022
@woody-apple woody-apple deleted the revert-15605-lessci/esp32 branch March 3, 2022 07:09
andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Mar 4, 2022
…32 (project-chip#15605)" (project-chip#15773)"

This reverts commit 66aef3e.

Adding back the split to remove queueing time. Please do not revert and
rather work to adding appropriate splits or logic as done in project-chip#15791
or add additional builds as needed.

The split decreases PR queue time (not as affected) and has a global
timeout which seems easier to track than the timeout we are experiencing
in locations like:

https://github.com/project-chip/connectedhomeip/runs/5422883482?check_suite_focus=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github hotfix urgent fix needed, can bypass review review - pending workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant