CI split between master (full) and PR (smoke) for ESP32 #15605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13 and
hawk248
pullapprove
bot
requested review from
yufengwangca,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #15605: Size comparison from c1d14cc to c4e0675 Full report (44 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mrjerryjohns
approved these changes
Feb 25, 2022
|
PR #15605: Size comparison from fd915e5 to 7ae8fcc Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #15605: Size comparison from fd915e5 to 447e04a Increases above 0.2%:
Increases (11 builds for cyw30739, esp32, linux, nrfconnect, qpg, telink)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
/rebase |
woody-apple
force-pushed
the
lessci/esp32
branch
from
447e04a to
707f10a
Compare
|
PR #15605: Size comparison from 7421db3 to 707f10a Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
/rebase |
woody-apple
force-pushed
the
lessci/esp32
branch
from
707f10a to
ec72ef8
Compare
|
PR #15605: Size comparison from 4ba01f6 to ec72ef8 Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
added a commit
that referenced
this pull request
Mar 3, 2022
…)" This reverts commit 59139c4.
|
These split CI's have caused issues today twice now, and missed build coverage. Suggest reverting, given this is only saving an hour or so of 12-14 hours of CI time. |
woody-apple
added a commit
that referenced
this pull request
Mar 3, 2022
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Mar 4, 2022
…32 (project-chip#15605)" (project-chip#15773)" This reverts commit 66aef3e. Adding back the split to remove queueing time. Please do not revert and rather work to adding appropriate splits or logic as done in project-chip#15791 or add additional builds as needed. The split decreases PR queue time (not as affected) and has a global timeout which seems easier to track than the timeout we are experiencing in locations like: https://github.com/project-chip/connectedhomeip/runs/5422883482?check_suite_focus=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We spend a lot of time waiting for PR CI.
Change overview
Moved full ESP32 separate builds(about 1h each, 2h combined) into master builds only, moved the PR builds as a "smoke test" only that is expected to finish faster (under 30 min).
Consolidated ESP32 into only one build instead of trying to parallelize.
Testing
CI will validate.