-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix BLE commissioning on commissionable Matter TVs #15525
Conversation
PR #15525: Size comparison from 960eba3 to 1c10bf8 Increases (5 builds for linux, mbed)
Full report (8 builds for linux, mbed, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified BLE commissioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a cleaner way of getting to the BLE layer. Using GetImplAtIndex does not seem right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to approve as an unblocking for TV.
From a separate chat with @chrisdecenzo , the situation we have is:
- ControllerFactory creates a transportmgr shared by all controllers
- Server creates a transport for server stuff
These two conflict and generally the BLE on the server is only needed for commissioning and before commissioning, the controller side would not be functional. There should be a way for either sharing the same trasnport (so BLE does not conflict) or sequencing initializations (do server first, once commissioned, start the controller side).
This needs revision and Chris agreed to take a look at it while working on "make TVs run without comissioness" with a rough estimate of before 8 weeks (i.e. should happen reasonably soon).
Created issue #15732 to remove this workaround for manually changing the BleLayer transport from CHIPDeviceControlleer (see issue for proposed solution). |
/rebase |
PR #15525: Size comparison from 1ccc2af to d9f7211 Increases above 0.2%:
Increases (6 builds for esp32, mbed, nrfconnect, p6)
Full report (6 builds for esp32, mbed, nrfconnect, p6)
|
Problem
What is being fixed? Examples:
Change overview
By default, when there is more than one BleBase transport, the second to initialize overrides the global BleLayer transport with itself. This fix adds Ble transport initialization parameters so that this override behavior can be managed, and the default behavior is to only set the global BleLayer transport if it is not already set.
Testing