Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow platform DNS-SD resolve to provide more than one IP address in the ResolvedNodeData #15239

Merged
merged 3 commits into from
Feb 19, 2022
Merged

Allow platform DNS-SD resolve to provide more than one IP address in the ResolvedNodeData #15239

merged 3 commits into from
Feb 19, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 16, 2022 •
edited
Loading

Problem

DnssdResolveCallback just takes a single DnssdService *, which can only provide one IP address.

Change overview

Change DnssdResolveCallback to take an additional Span<IPAddress> for extra addresses and fix the Darwin impl to handle kDNSServiceFlagsMoreComing correctly by buffering up the results and delivering them to the callback all together.

Testing

Ran chip-tool discover resolve node-id fabric-id for all-clusters-app running on localhost and saw that instead of just returning ::1 like it used to it now returns fe80::1 as well.

Fixes #13274 as filed I believe. @msandstedt, could you confirm?

We may want followups for the other platform impls (avahi, openthread, Android, Tizen) to fix things as well, now that the API supports it.

@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

PR #15239: Size comparison from d671a52 to 75be11e

Full report (22 builds for esp32, linux, mbed, p6, telink)
platform target config section d671a52 75be11e change % change
esp32 all-clusters-app c3devkit (read only) 946454 946454 0 0.0
(read/write) 1398818 1398818 0 0.0
.dram0.bss 66208 66208 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199448 199448 0 0.0
.flash.text 946454 946454 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 996279 996279 0 0.0
(read/write) 464080 464080 0 0.0
.dram0.bss 71344 71344 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226544 226544 0 0.0
.flash.text 990895 990895 0 0.0
.iram0.text 123399 123399 0 0.0
linux all-clusters-app debug (read only) 2367177 2367177 0 0.0
(read/write) 142144 142144 0 0.0
.bss 56480 56480 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78664 78664 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206245 206245 0 0.0
.text 1998274 1998274 0 0.0
bridge-app debug+rpc (read only) 1728589 1728589 0 0.0
(read/write) 85672 85672 0 0.0
.bss 40400 40400 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141964 141964 0 0.0
.text 1470005 1470005 0 0.0
chip-tool debug (read only) 8575653 8575653 0 0.0
(read/write) 245952 245952 0 0.0
.bss 31816 31816 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206896 206896 0 0.0
.dynamic 608 608 0 0.0
.got 4792 4792 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459637 459637 0 0.0
.text 7599525 7599525 0 0.0
chip-tool-ipv6only arm64 (read only) 8328468 8328468 0 0.0
(read/write) 353745 353745 0 0.0
.bss 50113 50113 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49256 49256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 435500 435500 0 0.0
.text 7130292 7130292 0 0.0
door-lock-app debug (read only) 1933889 1933889 0 0.0
(read/write) 111576 111576 0 0.0
.bss 43088 43088 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173426 173426 0 0.0
.text 1611874 1611874 0 0.0
lighting-app debug+rpc (read only) 2060113 2060113 0 0.0
(read/write) 116920 116920 0 0.0
.bss 44192 44192 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166033 166033 0 0.0
.text 1739266 1739266 0 0.0
ota-provider-app debug (read only) 1867321 1867321 0 0.0
(read/write) 107320 107320 0 0.0
.bss 42976 42976 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 158283 158283 0 0.0
.text 1558354 1558354 0 0.0
ota-requestor-app debug (read only) 1880425 1880425 0 0.0
(read/write) 108736 108736 0 0.0
.bss 43392 43392 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153052 153052 0 0.0
.text 1578194 1578194 0 0.0
shell debug (read only) 2346313 2346313 0 0.0
(read/write) 144560 144560 0 0.0
.bss 64832 64832 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73224 73224 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 207090 207090 0 0.0
.text 1982418 1982418 0 0.0
thermostat-no-ble arm64 (read only) 2153276 2153276 0 0.0
(read/write) 141825 141825 0 0.0
.bss 58641 58641 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4160 4160 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 133052 133052 0 0.0
.text 1801920 1801920 0 0.0
tv-app debug (read only) 2531385 2531385 0 0.0
(read/write) 142560 142560 0 0.0
.bss 60320 60320 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197765 197765 0 0.0
.text 2160578 2160578 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427148 2427148 0 0.0
.bss 189252 189252 0 0.0
.data 5328 5328 0 0.0
.text 1389720 1389720 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390284 2390284 0 0.0
.bss 181784 181784 0 0.0
.data 5624 5624 0 0.0
.text 1352856 1352856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2325728 2325728 0 0.0
.bss 180760 180760 0 0.0
.data 5600 5600 0 0.0
.text 1288328 1288328 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316556 2316556 0 0.0
.bss 179308 179308 0 0.0
.data 5432 5432 0 0.0
.text 1279128 1279128 0 0.0
p6 all-clusters-app default (read/write) 2484408 2484408 0 0.0
.bss 117568 117568 0 0.0
.data 2672 2672 0 0.0
.text 1442672 1442672 0 0.0
light-app default (read/write) 2391288 2391288 0 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349552 1349552 0 0.0
lock-app default (read/write) 2354752 2354752 0 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1313016 1313016 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877166 877166 0 0.0
bss 88600 88600 0 0.0
noinit 37160 37160 0 0.0
text 616816 616816 0 0.0

@Damian-Nordic Damian-Nordic mentioned this pull request Feb 16, 2022
Merged
@bzbarsky-apple bzbarsky-apple force-pushed the multiple-results-for-resolve branch from 75be11e to 711d868 Compare February 16, 2022 20:19
@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

PR #15239: Size comparison from 68f6935 to 711d868

Full report (20 builds for esp32, linux, mbed, p6, telink)
platform target config section 68f69352 711d868 change % change
esp32 all-clusters-app c3devkit (read only) 947652 947652 0 0.0
(read/write) 1401130 1401130 0 0.0
.dram0.bss 68296 68296 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199664 199664 0 0.0
.flash.text 947652 947652 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 997443 997443 0 0.0
(read/write) 466380 466380 0 0.0
.dram0.bss 73432 73432 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226756 226756 0 0.0
.flash.text 992059 992059 0 0.0
.iram0.text 123399 123399 0 0.0
linux all-clusters-app debug (read only) 2375201 2375201 0 0.0
(read/write) 151072 151072 0 0.0
.bss 65376 65376 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78664 78664 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206181 206181 0 0.0
.text 2006082 2006082 0 0.0
bridge-app debug+rpc (read only) 1730269 1730269 0 0.0
(read/write) 94536 94536 0 0.0
.bss 49296 49296 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 142092 142092 0 0.0
.text 1471845 1471845 0 0.0
chip-tool debug (read only) 8579029 8579029 0 0.0
(read/write) 254816 254816 0 0.0
.bss 40712 40712 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206896 206896 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459701 459701 0 0.0
.text 7602917 7602917 0 0.0
door-lock-app debug (read only) 1941985 1941985 0 0.0
(read/write) 120504 120504 0 0.0
.bss 51984 51984 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173394 173394 0 0.0
.text 1619730 1619730 0 0.0
lighting-app debug+rpc (read only) 2068249 2068249 0 0.0
(read/write) 125784 125784 0 0.0
.bss 53024 53024 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166033 166033 0 0.0
.text 1747122 1747122 0 0.0
ota-provider-app debug (read only) 1875449 1875449 0 0.0
(read/write) 116216 116216 0 0.0
.bss 51840 51840 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 158275 158275 0 0.0
.text 1566210 1566210 0 0.0
ota-requestor-app debug (read only) 1888537 1888537 0 0.0
(read/write) 117632 117632 0 0.0
.bss 52256 52256 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4200 4200 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153044 153044 0 0.0
.text 1586034 1586034 0 0.0
shell debug (read only) 2349897 2349897 0 0.0
(read/write) 153424 153424 0 0.0
.bss 73696 73696 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73224 73224 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 207186 207186 0 0.0
.text 1985906 1985906 0 0.0
tv-app debug (read only) 2537193 2537193 0 0.0
(read/write) 151456 151456 0 0.0
.bss 69184 69184 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 198197 198197 0 0.0
.text 2165682 2165682 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2428412 2428412 0 0.0
.bss 195916 195916 0 0.0
.data 5328 5328 0 0.0
.text 1390984 1390984 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391612 2391612 0 0.0
.bss 188448 188448 0 0.0
.data 5632 5632 0 0.0
.text 1354184 1354184 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327056 2327056 0 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1289656 1289656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317820 2317820 0 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280392 1280392 0 0.0
p6 all-clusters-app default (read/write) 2485872 2485872 0 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1444136 1444136 0 0.0
light-app default (read/write) 2392760 2392760 0 0.0
.bss 113912 113912 0 0.0
.data 2528 2528 0 0.0
.text 1351024 1351024 0 0.0
lock-app default (read/write) 2356240 2356240 0 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1314504 1314504 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877506 877506 0 0.0
bss 87520 87520 0 0.0
noinit 37160 37160 0 0.0
text 617996 617996 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the multiple-results-for-resolve branch from 711d868 to dffc7ae Compare February 16, 2022 21:38
@restyled-io restyled-io bot mentioned this pull request Feb 16, 2022
Closed
@bzbarsky-apple bzbarsky-apple force-pushed the multiple-results-for-resolve branch from dffc7ae to e5727dc Compare February 16, 2022 22:21
@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

PR #15239: Size comparison from 72896fc to e5727dc

Increases (10 builds for cyw30739, efr32, k32w, qpg)
platform target config section 72896fc e5727dc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 597326 597530 204 0.0
.app_xip_area 501244 501448 204 0.0
lock cyw930739m2evb_01 (read/write) 555266 555470 204 0.0
.app_xip_area 460752 460956 204 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576378 576582 204 0.0
.app_xip_area 472432 472636 204 0.0
efr32 lighting-app BRD4161A (read only) 914204 914404 200 0.0
.text 914196 914396 200 0.0
BRD4161A+rpc (read only) 942896 943112 216 0.0
.text 942888 943104 216 0.0
window-app BRD4161A (read only) 848064 848260 196 0.0
.text 848056 848252 196 0.0
k32w light k32w061+release (read/write) 691332 691540 208 0.0
.text 605236 605444 208 0.0
lock k32w061+release (read/write) 693964 694172 208 0.0
.text 607612 607820 208 0.0
qpg lighting-app qpg6105+debug (read only) 598816 599016 200 0.0
.text 593496 593696 200 0.0
lock-app qpg6105+debug (read only) 564440 564640 200 0.0
.text 559120 559320 200 0.0
Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 72896fc e5727dc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 597326 597530 204 0.0
.app_xip_area 501244 501448 204 0.0
.bss 78780 78780 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555266 555470 204 0.0
.app_xip_area 460752 460956 204 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576378 576582 204 0.0
.app_xip_area 472432 472636 204 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914204 914404 200 0.0
(read/write) 129524 129524 0 0.0
.bss 127488 127488 0 0.0
.data 2036 2036 0 0.0
.text 914196 914396 200 0.0
BRD4161A+rpc (read only) 942896 943112 216 0.0
(read/write) 146440 146440 0 0.0
.bss 144264 144264 0 0.0
.data 2176 2176 0 0.0
.text 942888 943104 216 0.0
window-app BRD4161A (read only) 848064 848260 196 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848056 848252 196 0.0
k32w light k32w061+release (read/write) 691332 691540 208 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605236 605444 208 0.0
lock k32w061+release (read/write) 693964 694172 208 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 607612 607820 208 0.0
linux chip-tool-ipv6only arm64 (read only) 8332420 8332420 0 0.0
(read/write) 362609 362609 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49272 49272 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435804 435804 0 0.0
.text 7133924 7133924 0 0.0
thermostat-no-ble arm64 (read only) 2162268 2162268 0 0.0
(read/write) 150737 150737 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133580 133580 0 0.0
.text 1810064 1810064 0 0.0
p6 all-clusters-app default (read/write) 2485928 2485928 0 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1444192 1444192 0 0.0
light-app default (read/write) 2392816 2392816 0 0.0
.bss 113912 113912 0 0.0
.data 2528 2528 0 0.0
.text 1351080 1351080 0 0.0
lock-app default (read/write) 2356280 2356280 0 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1314544 1314544 0 0.0
qpg lighting-app qpg6105+debug (read only) 598816 599016 200 0.0
(read/write) 146940 146940 0 0.0
.bss 90744 90744 0 0.0
.data 1112 1112 0 0.0
.text 593496 593696 200 0.0
lock-app qpg6105+debug (read only) 564440 564640 200 0.0
(read/write) 146940 146940 0 0.0
.bss 90728 90728 0 0.0
.data 1064 1064 0 0.0
.text 559120 559320 200 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877618 877618 0 0.0
bss 87520 87520 0 0.0
noinit 37160 37160 0 0.0
text 618038 618038 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the multiple-results-for-resolve branch from e5727dc to d94698c Compare February 16, 2022 23:03
@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

PR #15239: Size comparison from 72896fc to d94698c

Increases (19 builds for cyw30739, efr32, k32w, nrfconnect, qpg)
platform target config section 72896fc d94698c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 597326 597530 204 0.0
.app_xip_area 501244 501448 204 0.0
lock cyw930739m2evb_01 (read/write) 555266 555470 204 0.0
.app_xip_area 460752 460956 204 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576378 576582 204 0.0
.app_xip_area 472432 472636 204 0.0
efr32 lighting-app BRD4161A (read only) 914204 914404 200 0.0
.text 914196 914396 200 0.0
BRD4161A+rpc (read only) 942896 943112 216 0.0
.text 942888 943104 216 0.0
window-app BRD4161A (read only) 848064 848260 196 0.0
.text 848056 848252 196 0.0
k32w light k32w061+release (read/write) 691332 691540 208 0.0
.text 605236 605444 208 0.0
lock k32w061+release (read/write) 693964 694172 208 0.0
.text 607612 607820 208 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022279 1022503 224 0.0
rodata 120660 120740 80 0.1
text 699076 699212 136 0.0
nrf52840dk_nrf52840+rpc (read/write) 991571 991795 224 0.0
rodata 112184 112264 80 0.1
text 678976 679112 136 0.0
nrf52840dongle_nrf52840 (read/write) 1037095 1037319 224 0.0
rodata 119472 119552 80 0.1
text 702968 703104 136 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 928890 929114 224 0.0
rodata 113900 113980 80 0.1
text 614088 614224 136 0.0
lock-app nrf52840dk_nrf52840 (read/write) 950983 951207 224 0.0
rodata 109356 109436 80 0.1
text 641268 641404 136 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858442 858650 208 0.0
rodata 102524 102604 80 0.1
text 557056 557192 136 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949431 949655 224 0.0
rodata 108308 108388 80 0.1
text 641088 641224 136 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945519 945727 208 0.0
rodata 108004 108084 80 0.1
text 637328 637464 136 0.0
shell nrf52840dk_nrf52840 (read/write) 810767 810991 224 0.0
rodata 79348 79428 80 0.1
text 540444 540576 132 0.0
qpg lighting-app qpg6105+debug (read only) 598816 599016 200 0.0
.text 593496 593696 200 0.0
lock-app qpg6105+debug (read only) 564440 564640 200 0.0
.text 559120 559320 200 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 72896fc d94698c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 597326 597530 204 0.0
.app_xip_area 501244 501448 204 0.0
.bss 78780 78780 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555266 555470 204 0.0
.app_xip_area 460752 460956 204 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576378 576582 204 0.0
.app_xip_area 472432 472636 204 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914204 914404 200 0.0
(read/write) 129524 129524 0 0.0
.bss 127488 127488 0 0.0
.data 2036 2036 0 0.0
.text 914196 914396 200 0.0
BRD4161A+rpc (read only) 942896 943112 216 0.0
(read/write) 146440 146440 0 0.0
.bss 144264 144264 0 0.0
.data 2176 2176 0 0.0
.text 942888 943104 216 0.0
window-app BRD4161A (read only) 848064 848260 196 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848056 848252 196 0.0
esp32 all-clusters-app c3devkit (read only) 947660 947660 0 0.0
(read/write) 1401170 1401170 0 0.0
.dram0.bss 68296 68296 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199704 199704 0 0.0
.flash.text 947660 947660 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 997411 997411 0 0.0
(read/write) 466412 466412 0 0.0
.dram0.bss 73432 73432 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226788 226788 0 0.0
.flash.text 992027 992027 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691332 691540 208 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605236 605444 208 0.0
lock k32w061+release (read/write) 693964 694172 208 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 607612 607820 208 0.0
linux chip-tool-ipv6only arm64 (read only) 8332420 8332420 0 0.0
(read/write) 362609 362609 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49272 49272 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435804 435804 0 0.0
.text 7133924 7133924 0 0.0
thermostat-no-ble arm64 (read only) 2162268 2162268 0 0.0
(read/write) 150737 150737 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133580 133580 0 0.0
.text 1810064 1810064 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2428444 2428444 0 0.0
.bss 195916 195916 0 0.0
.data 5328 5328 0 0.0
.text 1391016 1391016 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391644 2391644 0 0.0
.bss 188448 188448 0 0.0
.data 5632 5632 0 0.0
.text 1354216 1354216 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327080 2327080 0 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1289680 1289680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317916 2317916 0 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280488 1280488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022279 1022503 224 0.0
bss 123548 123548 0 0.0
rodata 120660 120740 80 0.1
text 699076 699212 136 0.0
nrf52840dk_nrf52840+rpc (read/write) 991571 991795 224 0.0
bss 120736 120736 0 0.0
rodata 112184 112264 80 0.1
text 678976 679112 136 0.0
nrf52840dongle_nrf52840 (read/write) 1037095 1037319 224 0.0
bss 124768 124768 0 0.0
rodata 119472 119552 80 0.1
text 702968 703104 136 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 928890 929114 224 0.0
bss 120112 120112 0 0.0
rodata 113900 113980 80 0.1
text 614088 614224 136 0.0
lock-app nrf52840dk_nrf52840 (read/write) 950983 951207 224 0.0
bss 121752 121752 0 0.0
rodata 109356 109436 80 0.1
text 641268 641404 136 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858442 858650 208 0.0
bss 118344 118344 0 0.0
rodata 102524 102604 80 0.1
text 557056 557192 136 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949431 949655 224 0.0
bss 121472 121472 0 0.0
rodata 108308 108388 80 0.1
text 641088 641224 136 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945519 945727 208 0.0
bss 121476 121476 0 0.0
rodata 108004 108084 80 0.1
text 637328 637464 136 0.0
shell nrf52840dk_nrf52840 (read/write) 810767 810991 224 0.0
bss 113324 113324 0 0.0
rodata 79348 79428 80 0.1
text 540444 540576 132 0.0
p6 all-clusters-app default (read/write) 2485928 2485928 0 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1444192 1444192 0 0.0
light-app default (read/write) 2392816 2392816 0 0.0
.bss 113912 113912 0 0.0
.data 2528 2528 0 0.0
.text 1351080 1351080 0 0.0
lock-app default (read/write) 2356280 2356280 0 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1314544 1314544 0 0.0
qpg lighting-app qpg6105+debug (read only) 598816 599016 200 0.0
(read/write) 146940 146940 0 0.0
.bss 90744 90744 0 0.0
.data 1112 1112 0 0.0
.text 593496 593696 200 0.0
lock-app qpg6105+debug (read only) 564440 564640 200 0.0
(read/write) 146940 146940 0 0.0
.bss 90728 90728 0 0.0
.data 1064 1064 0 0.0
.text 559120 559320 200 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877618 877618 0 0.0
bss 87520 87520 0 0.0
noinit 37160 37160 0 0.0
text 618038 618038 0 0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 17, 2022
Closed
@bzbarsky-apple bzbarsky-apple merged commit 0e027df into project-chip:master Feb 19, 2022
@bzbarsky-apple bzbarsky-apple deleted the multiple-results-for-resolve branch February 19, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@msandstedt msandstedt Awaiting requested review from msandstedt

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin lib linux openthread platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Darwin browse+resolve does not properly collect multiple IP addresses
3 participants
@bzbarsky-apple @andy31415 @woody-apple