Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider passing all the IPs for platform dns-sd resolve in the IP span #15279

Closed
bzbarsky-apple opened this issue Feb 16, 2022 · 0 comments · Fixed by #18708
Closed

Consider passing all the IPs for platform dns-sd resolve in the IP span #15279

bzbarsky-apple opened this issue Feb 16, 2022 · 0 comments · Fixed by #18708
Labels
V1.X

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Feb 16, 2022 •
edited
Loading

Problem

Right now we pass the first one (if any) in the DnssdService, and the rest as a Span<IPAddress>, after #15239.

Proposed Solution

Just pass them all in the Span<IPAddress>.
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 16, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 21, 2022
@bzbarsky-apple
Stop passing our addresses from resolve in two different places.
7a94d9e 
We used to pass some in the DnssdService and some in a Span.  Now just
pass them all in the Span.

Fixes project-chip#15279
@bzbarsky-apple bzbarsky-apple mentioned this issue May 21, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 21, 2022
@bzbarsky-apple
Stop passing our addresses from resolve in two different places.
b28415f 
We used to pass some in the DnssdService and some in a Span.  Now just
pass them all in the Span.

Fixes project-chip#15279
andy31415 pushed a commit that referenced this issue May 24, 2022
@bzbarsky-apple
Stop passing our addresses from resolve in two different places. (#18708
09bb6fd 
)

We used to pass some in the DnssdService and some in a Span.  Now just
pass them all in the Span.

Fixes #15279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
V1.X
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop passing our addresses from resolve in two different places. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple