Add emberAf functions definition for the new network commissioning cluster #15189
Conversation
…atterNetworkCommissioningPluginServerInitCallback
|
PR #15189: Size comparison from a35b95a to ed8b330 Decreases (3 builds for esp32, telink)
Full report (3 builds for esp32, telink)
|
| @@ -468,3 +468,47 @@ void Instance::OnCommissioningComplete(CHIP_ERROR err) | |||
| } // namespace Clusters | |||
| } // namespace app | |||
| } // namespace chip | |||
|
|
|||
| bool emberAfNetworkCommissioningClusterAddOrUpdateThreadNetworkCallback( | |||
There was a problem hiding this comment.
Shouldn't we do something to not generate calls to these at all, since it's a waste of codesize? Followup needed for that.
There was a problem hiding this comment.
Agree, but now there are still platforms which don't have full network commissioning driver support, and they need these functions. We could remove the generate calls after all the platforms add the updated network commissioning driver and the network-commissioning-old is removed.
There was a problem hiding this comment.
That is why I said "followup needed".
| return false; | ||
| } | ||
|
|
||
| void MatterNetworkCommissioningPluginServerInitCallback() {} |
There was a problem hiding this comment.
This should probably go over where the other stubs like this live.
There was a problem hiding this comment.
Should I move this function to callback-stub.cpp?
There was a problem hiding this comment.
No, these are in src/app/util/util.cpp around line 240.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
LuDuda,
lzgrablic02,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
| @@ -96,8 +96,6 @@ target_sources(app PRIVATE | |||
| ${CHIP_ROOT}/src/app/clusters/color-control-server/color-control-server.cpp | |||
| ${CHIP_ROOT}/src/app/clusters/occupancy-sensor-server/occupancy-sensor-server.cpp | |||
| ${CHIP_ROOT}/src/app/clusters/network-commissioning/network-commissioning.cpp | |||
| ${CHIP_ROOT}/src/app/clusters/network-commissioning-old/network-commissioning-ember.cpp | |||
There was a problem hiding this comment.
A bit confused for the change to telink build file since other files are all under esp32 domain.
|
Close this PR since #15184 merged. |
Problem
The updated network commissioning needs definitions of the
emberAffunctions andMatterNetworkCommissioningPluginServerInitCallback.Change overview
Add the definitions for the new network commissioning cluster
Testing
Tested on ESP32C3 with all-clusters-app, the commissioning works well and the
scannetworkcommand also works.