-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Network Commissioning] Remove old network commissioning driver #15184
Merged
andy31415
merged 1 commit into
project-chip:master
from
erjiaqing:nwproc/remove-nwprov-old
Feb 22, 2022
Merged
[Network Commissioning] Remove old network commissioning driver #15184
andy31415
merged 1 commit into
project-chip:master
from
erjiaqing:nwproc/remove-nwprov-old
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erjiaqing
force-pushed
the
nwproc/remove-nwprov-old
branch
3 times, most recently
from
February 16, 2022 06:03
55e85a9
to
01c8362
Compare
PR #15184: Size comparison from fbf8bab to 01c8362 Decreases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
erjiaqing
force-pushed
the
nwproc/remove-nwprov-old
branch
from
February 22, 2022 04:02
01c8362
to
510addb
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple and
jelderton
February 22, 2022 04:02
pullapprove
bot
requested review from
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
February 22, 2022 04:02
erjiaqing
force-pushed
the
nwproc/remove-nwprov-old
branch
from
February 22, 2022 04:16
510addb
to
45bb10d
Compare
PR #15184: Size comparison from 944425f to 45bb10d Decreases (27 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Feb 22, 2022
andy31415
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Remove all code related to the old network commissioning cluster
Testing
CI should pass after implementing all platform drivers.