-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[esp] Add status screen to all-clusters-app on M5Stack #14986
Conversation
PR #14986: Size comparison from 14bab88 to e8764af Increases (2 builds for esp32, linux)
Decreases (1 build for linux)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #14986: Size comparison from 14bab88 to 4794e53 Increases above 0.2%:
Increases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for nrfconnect)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
4794e53
to
d63c1a5
Compare
PR #14986: Size comparison from a08613b to d63c1a5 Increases above 0.2%:
Increases (1 build for esp32)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #14986: Size comparison from a08613b to 5681964 Increases above 0.2%:
Increases (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, qpg, telink)
Decreases (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
Use simplified call to `IPAddress::ToString()`. Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #14986: Size comparison from a08613b to 1626d5c Increases above 0.2%:
Increases (18 builds for efr32, esp32, mbed, nrfconnect)
Decreases (7 builds for efr32, esp32, mbed)
Full report (20 builds for efr32, esp32, mbed, nrfconnect)
|
switch (i) | ||
{ | ||
case kStatusItemFabricIndex: { | ||
for (const auto & fb : Server::GetInstance().GetFabricTable()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem
It can be difficult to glean basic information about a physical Matter node.
Change overview
Add a "Status" screen to ESP / M5Stack platform.
This screen displays whether the device is commissioned or not, and if it is shows info about the first fabric in the table:
Testing
Tested manually on desk:
Verify Fabric : none
Verify IP : none
Verify Fabric : 1
Verify IP : [live address]
Verify Fabric : none
Verify IP : none
Verify Fabric : 1
Verify IP : [live address]
CI should cover the rest.