Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fabric table] Rename PeerId API to OperationalId #15049

Closed
turon opened this issue Feb 10, 2022 · 2 comments
Closed

[fabric table] Rename PeerId API to OperationalId #15049

turon opened this issue Feb 10, 2022 · 2 comments
Labels
stale Stale issue or PR

Comments

@turon
Copy link
Contributor

turon commented Feb 10, 2022

There is general confusion around what a PeerId is as provided by the FabricTable. Consider renaming it to OperationalId to properly capture that it is a tuple on information that includes NodeId and associated fabric references.

Originally posted by @cecille in #14986 (comment)
@turon turon mentioned this issue Feb 10, 2022
Merged
turon added a commit to turon/connectedhomeip that referenced this issue Feb 10, 2022
@turon
[m5] Reference issue project-chip#15049 deferral.
5681964
andy31415 pushed a commit that referenced this issue Feb 10, 2022
@turon @bzbarsky-apple
[esp] Add status screen to all-clusters-app on M5Stack (#14986)
d0e88bb 
* [m5] Add status screen to M5Stack.

* [m5] Add status screen to esp for FabricId/Idx, NodeId, and IP addresses.

* [m5] Correct some comments.

* [m5] Use lib defined Inet::IPAddress::kMaxStringLength.

* [m5] Update comment on what screen displays.

* [m5] Reference issue #15049 deferral.

* Apply suggestions from code review

Use simplified call to `IPAddress::ToString()`.

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Boris Zbarsky <[email protected]>
@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 12, 2022
@stale
Copy link

stale bot commented Oct 9, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Stale issue or PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turon