-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ConcreteClusterPath. #14927
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:cluster-path
Feb 9, 2022
Merged
Introduce ConcreteClusterPath. #14927
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:cluster-path
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
sagar-apple and
saurabhst
February 9, 2022 03:55
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 9, 2022 03:55
PR #14927: Size comparison from cab1ff9 to 900ab4e Increases (2 builds for esp32, telink)
Full report (32 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
Will be useful in places where we just need an endpoint+cluster. Fixes project-chip#14820
bzbarsky-apple
force-pushed
the
cluster-path
branch
from
February 9, 2022 05:29
900ab4e
to
2e1bdce
Compare
yunhanw-google
approved these changes
Feb 9, 2022
PR #14927: Size comparison from 5158095 to 2e1bdce Increases (13 builds for esp32, linux, telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be useful in places where we just need an endpoint+cluster.
Fixes #14820
Problem
We end up converting between paths and multiple args representing endpoint + cluster.
Change overview
Allow us to just pass paths along as needed.
Testing
No behavior changes.