Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TSan failures in CI fatal. #14732

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Make TSan failures in CI fatal. #14732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
env:
BUILD_VARIANT: ${{matrix.build_variant}}
CHIP_TOOL_VARIANT: ${{matrix.chip_tool}}
TSAN_OPTIONS: "halt_on_error=1 suppressions=scripts/tests/chiptest/tsan-linux-suppressions.txt"

if: github.actor != 'restyled-io[bot]'
runs-on: ubuntu-latest
Expand Down Expand Up @@ -124,6 +125,7 @@ jobs:
env:
BUILD_VARIANT: ${{matrix.build_variant}}
CHIP_TOOL_VARIANT: ${{matrix.chip_tool}}
TSAN_OPTIONS: "halt_on_error=1"

if: github.actor != 'restyled-io[bot]'
runs-on: macos-latest
Expand Down
10 changes: 10 additions & 0 deletions scripts/tests/chiptest/tsan-linux-suppressions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# The Linux server app ends up with a data race in libglib. A race_top
# suppression does not work, since the actual race is inside a memset, so the
# thing on top of the stack is memset. called_from_lib is a narrower
# suppression than a "race" suppression (which would be "libglib anywhere on the
# stack", as opposed to "inside a function TSan intercepts, which was called
# from libglib).
#
# See https://github.com/project-chip/connectedhomeip/issues/14710 for
# addressing this.
called_from_lib:libglib