Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TSan failures in CI fatal. #14732

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Right now warnings are logged and exiting the app would do so with a
failure status, but for the server app we never exit it, so never
discover that warnings happened.

The fix is to just fail on the very first warning.

The suppression added on Linux is to enable us to do this without
immediately failing tests.

Problem

See above.

Change overview

See above.

Testing

Verified that without the suppression the Linux Tests job fails, and with it passes. Also verified that if I mis-spell "libglib" as "libglig" in the suppression the job fails again.

Right now warnings are logged and exiting the app would do so with a
failure status, but for the server app we never exit it, so never
discover that warnings happened.

The fix is to just fail on the very first warning.

The suppression added on Linux is to enable us to do this without
immediately failing tests.
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

PR #14732: Size comparison from 8881290 to a54fd10

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8881290 a54fd10 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577390 577390 0 0.0
.app_xip_area 484884 484884 0 0.0
.bss 75252 75252 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535134 535134 0 0.0
.app_xip_area 444196 444196 0 0.0
.bss 73724 73724 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559618 559618 0 0.0
.app_xip_area 459360 459360 0 0.0
.bss 82716 82716 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 844328 844328 0 0.0
(read/write) 124792 124792 0 0.0
.bss 122896 122896 0 0.0
.data 1892 1892 0 0.0
.text 844320 844320 0 0.0
BRD4161A+rpc (read only) 831704 831704 0 0.0
(read/write) 141448 141448 0 0.0
.bss 139456 139456 0 0.0
.data 1992 1992 0 0.0
.text 831696 831696 0 0.0
window-app BRD4161A (read only) 816404 816404 0 0.0
(read/write) 123412 123412 0 0.0
.bss 121564 121564 0 0.0
.data 1848 1848 0 0.0
.text 816396 816396 0 0.0
esp32 all-clusters-app c3devkit (read only) 934598 934598 0 0.0
(read/write) 1401002 1401002 0 0.0
.dram0.bss 70048 70048 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 197792 197792 0 0.0
.flash.text 934598 934598 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982723 982723 0 0.0
(read/write) 465360 465360 0 0.0
.dram0.bss 74808 74808 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224400 224400 0 0.0
.flash.text 977339 977339 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661620 661620 0 0.0
.bss 74948 74948 0 0.0
.data 1852 1852 0 0.0
.text 579020 579020 0 0.0
lock k32w061+release (read/write) 662880 662880 0 0.0
.bss 75268 75268 0 0.0
.data 1892 1892 0 0.0
.text 579920 579920 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7120532 7120532 0 0.0
(read/write) 284545 284545 0 0.0
.bss 47585 47585 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186712 186712 0 0.0
.dynamic 560 560 0 0.0
.got 45336 45336 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 391564 391564 0 0.0
.text 6127236 6127236 0 0.0
thermostat-no-ble arm64 (read only) 2091484 2091484 0 0.0
(read/write) 140401 140401 0 0.0
.bss 57713 57713 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130764 130764 0 0.0
.text 1743008 1743008 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386056 2386056 0 0.0
.bss 188964 188964 0 0.0
.data 5288 5288 0 0.0
.text 1348656 1348656 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338744 2338744 0 0.0
.bss 177888 177888 0 0.0
.data 5568 5568 0 0.0
.text 1301344 1301344 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302600 2302600 0 0.0
.bss 177776 177776 0 0.0
.data 5544 5544 0 0.0
.text 1265200 1265200 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2292980 0 0.0
.bss 175052 175052 0 0.0
.data 5368 5368 0 0.0
.text 1255552 1255552 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980975 980975 0 0.0
bss 118260 118260 0 0.0
rodata 116324 116324 0 0.0
text 668596 668596 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966535 966535 0 0.0
bss 115304 115304 0 0.0
rodata 107796 107796 0 0.0
text 665040 665040 0 0.0
nrf52840dongle_nrf52840 (read/write) 997039 997039 0 0.0
bss 119432 119432 0 0.0
rodata 115168 115168 0 0.0
text 673972 673972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890190 890190 0 0.0
bss 115044 115044 0 0.0
rodata 109616 109616 0 0.0
text 584788 584788 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913319 913319 0 0.0
bss 116620 116620 0 0.0
rodata 104596 104596 0 0.0
text 614704 614704 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823350 823350 0 0.0
bss 113440 113440 0 0.0
rodata 97800 97800 0 0.0
text 531672 531672 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915987 915987 0 0.0
bss 116380 116380 0 0.0
rodata 105112 105112 0 0.0
text 617048 617048 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911195 911195 0 0.0
bss 116388 116388 0 0.0
rodata 104216 104216 0 0.0
text 613104 613104 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798875 798875 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 534248 534248 0 0.0
p6 all-clusters-app default (read/write) 2447224 2447224 0 0.0
.bss 117116 117116 0 0.0
.data 2576 2576 0 0.0
.text 1405488 1405488 0 0.0
light-app default (read/write) 2340864 2340864 0 0.0
.bss 103084 103084 0 0.0
.data 2400 2400 0 0.0
.text 1299128 1299128 0 0.0
lock-app default (read/write) 2305896 2305896 0 0.0
.bss 102804 102804 0 0.0
.data 2360 2360 0 0.0
.text 1264160 1264160 0 0.0
qpg lighting-app qpg6105+debug (read only) 571244 571244 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 1056 1056 0 0.0
.text 565924 565924 0 0.0
lock-app qpg6105+debug (read only) 517084 517084 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86680 86680 0 0.0
.data 992 992 0 0.0
.text 511764 511764 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845594 845594 0 0.0
bss 85288 85288 0 0.0
noinit 37160 37160 0 0.0
text 592830 592830 0 0.0

@andy31415 andy31415 merged commit ac410fb into project-chip:master Feb 3, 2022
@bzbarsky-apple bzbarsky-apple deleted the tsan-fatal branch February 3, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants