[nrf5] Add nRF5 Lighting Example App #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Jul 3, 2020
|
|
||
| #include <platform/CHIPDeviceLayer.h> | ||
|
|
||
| #define FACTORY_RESET_TRIGGER_TIMEOUT 3000 |
There was a problem hiding this comment.
nit: since this is C++, maybe consider for files:
- constexpr instead of #defines
- anonymous namespace to avoid 'static' everywhere.
|
|
erjiaqing
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
jelderton
approved these changes
Jul 8, 2020
saurabhst
approved these changes
Jul 8, 2020
woody-apple
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, we have a nRF5 lock app as a example, however, we does not have related ZCLs along with the code, however, we have On-Off cluster and Level Control Cluster, which is quite suitable for an example lighting app.
The code modification should not be large since most of the code should be same, however, the BoltLockManager should be replaced with another class representing a light.
This PR adds nrf5 lighting-app demo.
Summary of Changes
This PR copied lock example and then replaced BoltLockManager to LightingManager.
However, I still have some concerns that what if we keep adding more examples to the examples? Maybe we need to extract common code to seperate directories so we can reuse them in different examples.
fixes #1259