-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf5] Add nRF5 Lighting Example App #1352
Conversation
Can we decouple examples and platforms? So that we don't need to have duplicate platform code. |
Aggree, I think the |
Size increase report for "Build Examples [nRF]"
Full report output
|
Size increase report for "Build Examples [ESP32]"
Full report output
|
Size increase report for "Build Examples [main-build]"
Full report output
|
This PR is replaced by #1436 due to the broken fork caused by making chip public, close now. |
Problem
Currently, we have a nRF5 lock app as a example, however, we does not have related ZCLs along with the code, however, we have On-Off cluster and Level Control Cluster, which is quite suitable for an example lighting app.
The code modification should not be large since most of the code should be same, however, the BoltLockManager should be replaced with another class representing a light.
This PR adds nrf5 lighting-app demo.
Summary of Changes
This PR copied lock example and then replaced BoltLockManager to LightingManager.
However, I still have some concerns that what if we keep adding more examples to the examples? Maybe we need to extract common code to seperate directories so we can reuse them in different examples.
fixes #1259