Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf5] Add nRF5 Lighting Example App #1352

Closed
wants to merge 4 commits into from

Conversation

erjiaqing
Copy link
Contributor

Problem

Currently, we have a nRF5 lock app as a example, however, we does not have related ZCLs along with the code, however, we have On-Off cluster and Level Control Cluster, which is quite suitable for an example lighting app.

The code modification should not be large since most of the code should be same, however, the BoltLockManager should be replaced with another class representing a light.

This PR adds nrf5 lighting-app demo.

Summary of Changes

This PR copied lock example and then replaced BoltLockManager to LightingManager.

However, I still have some concerns that what if we keep adding more examples to the examples? Maybe we need to extract common code to seperate directories so we can reuse them in different examples.

fixes #1259

@bukepo
Copy link
Contributor

bukepo commented Jun 30, 2020

Can we decouple examples and platforms? So that we don't need to have duplicate platform code.

@erjiaqing
Copy link
Contributor Author

Can we decouple examples and platforms? So that we don't need to have duplicate platform code.

Aggree, I think the AppTask, LEDWidget, main and Server can be put to seperate directories.

@chip-bot
Copy link

Size increase report for "Build Examples [nRF]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@chip-bot
Copy link

Size increase report for "Build Examples [ESP32]"

File Section File VM
chip-wifi-echo.elf .flash.rodata 8 8
chip-wifi-echo.elf .dram0.bss 0 -8
chip-wifi-echo.elf .dram0.data -8 -8
chip-wifi-echo.elf .flash.text -44 -44
Full report output
Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

sections,vmsize,filesize
.flash.rodata,8,8
[Unmapped],0,-4
.dram0.bss,-8,0
.dram0.data,-8,-8
.flash.text,-44,-44


@chip-bot
Copy link

Size increase report for "Build Examples [main-build]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

sections,vmsize,filesize


@CLAassistant
Copy link

CLAassistant commented Jul 1, 2020

CLA assistant check
All committers have signed the CLA.

@erjiaqing
Copy link
Contributor Author

This PR is replaced by #1436 due to the broken fork caused by making chip public, close now.

@erjiaqing erjiaqing closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nRF5 example lighting-app
8 participants