Update ZAP to force lists to be external-storage. #13846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
zap-update-storage-policy
branch
from
5633ee0 to
42bf26a
Compare
|
PR #13846: Size comparison from d6b2a6b to 42bf26a Increases above 0.2%:
Increases (6 builds for efr32, k32w, p6, qpg, telink)
Decreases (14 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
zap-update-storage-policy
branch
from
42bf26a to
c187d97
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02 and
mlepage-google
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #13846: Size comparison from d6b2a6b to c187d97 Increases above 0.2%:
Increases (6 builds for efr32, k32w, p6, qpg, telink)
Decreases (14 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
zap-update-storage-policy
branch
from
c187d97 to
c3eef3c
Compare
|
PR #13846: Size comparison from d6b2a6b to c3eef3c Increases above 0.2%:
Increases (16 builds for esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Decreases (24 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (30 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
The Power Source cluster addition is because that was one of two lists that we did not already have AttributeAccessInterface handling for (and the other one was in a cluster that already had an AttributeAccessInterface). Now that we have AttributeAccessInterface for all lists, we no longer need the fake "return an empty list" thing in ember-compatibility-functions.cpp.
bzbarsky-apple
force-pushed
the
zap-update-storage-policy
branch
from
c3eef3c to
3dce09c
Compare
|
PR #13846: Size comparison from 5227f3e to 3dce09c Increases above 0.2%:
Increases (17 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
reviewed
Jan 24, 2022
jmeg-sfy
reviewed
Jan 24, 2022
jmeg-sfy
approved these changes
Jan 24, 2022
tcarmelveilleux
approved these changes
Jan 24, 2022
|
fast track: change by domain owner, has been up sufficiently for cross timezone review. |
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
The Power Source cluster addition is because that was one of two lists that we did not already have AttributeAccessInterface handling for (and the other one was in a cluster that already had an AttributeAccessInterface). Now that we have AttributeAccessInterface for all lists, we no longer need the fake "return an empty list" thing in ember-compatibility-functions.cpp.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Feb 24, 2022
project-chip#13609 had a bad merge and ended up reverting part of project-chip#13846. This just restores the reverted bits, so we go back to forcing lists to be external storage.
andy31415
pushed a commit
that referenced
this pull request
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Power Source cluster addition is because that was one of two lists
that we did not already have AttributeAccessInterface handling for
(and the other one was in a cluster that already had an
AttributeAccessInterface).
Now that we have AttributeAccessInterface for all lists, we no longer
need the fake "return an empty list" thing in
ember-compatibility-functions.cpp.
Problem
Various lists are not marked as external in ZAP config.
Change overview
Force them to be treated as external automatically no matter what the UI says. Implement a Power Source cluster to actually provide one of the lists tests try to read. Fix various other clusters' attribute access interfaces to output empty lists as needed instead of just falling back to the attribute store, since these things no longer live in the attribute store.
Testing
Should be no observable behavior changes, apart from less RAM use.