-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Support complex types #13609
Conversation
PR #13609: Size comparison from a11413e to d34e13e Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
d34e13e
to
5551533
Compare
PR #13609: Size comparison from 78a6636 to 5551533 Full report (27 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
PR #13609: Size comparison from 78a6636 to d845aac Increases above 0.2%:
Increases (1 build for linux)
Decreases (2 builds for esp32)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
d845aac
to
3b73efb
Compare
PR #13609: Size comparison from ffd25d8 to 3b73efb Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
064b4d6
to
8a744d3
Compare
PR #13609: Size comparison from 332f97c to 8a744d3 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
3b73efb
to
89cea78
Compare
PR #13609: Size comparison from c750f4b to 89cea78 Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
PR #13609: Size comparison from 225a20b to cdfe2d6 Full report (12 builds for cyw30739, k32w, linux, p6, qpg, telink)
|
/rebase |
cdfe2d6
to
c30b5c4
Compare
PR #13609: Size comparison from 7cb2640 to c30b5c4 Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
src/controller/java/zap-generated/chip/devicecontroller/ChipStructs.java
Outdated
Show resolved
Hide resolved
We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable.
c30b5c4
to
f6d24b2
Compare
PR #13609: Size comparison from 2926d14 to f6d24b2 Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
PR #13609: Size comparison from 2926d14 to 1a058c8 Full report (2 builds for cyw30739, telink)
|
PR #13609: Size comparison from 2926d14 to 872685c Full report (12 builds for cyw30739, k32w, linux, p6, qpg, telink)
|
PR #13609: Size comparison from 2926d14 to 72a5918 Increases above 0.2%:
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast tracking: PR created by domain owner, has been up for a very long time. Complex data type support is a requirement for 1.0, hence attempting merge before feature complete deadline. |
* Complex types in Java * Regenerate * loop fix (project-chip#13828) * Ran zap regen (project-chip#13837) * Update ZAP to pick up reportability changes. (project-chip#13802) We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable. * Use UniquePtr, fix templates * Regen with updated ZAP * Regen again Co-authored-by: mkardous-silabs <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
project-chip#13609 had a bad merge and ended up reverting part of project-chip#13846. This just restores the reverted bits, so we go back to forcing lists to be external storage.
Problem
Change overview
ChipStructs.java
helper.js
refactored to centralize mapping of Java name, JNI name, JNI signature, etc.Testing