Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IM] Add Fabric Filtered Write Support #13756

Merged
merged 16 commits into from
Feb 1, 2022
Merged

[IM] Add Fabric Filtered Write Support #13756

merged 16 commits into from
Feb 1, 2022

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Jan 20, 2022 •
edited
Loading

Problem

Fabric filtered write is not well supported.

Fixes #12053

Change overview

Add support to fabric filtered write

  • Updated Decode() function (accepts a optional fabric index, for overwriting the fabric index in TLV)
  • Add DecodeWithoutFabricIndex() for client side decoding.
  • Update ACL cluster server

Testing

WIP, please review the logic first

@restyled-io restyled-io bot mentioned this pull request Jan 20, 2022
Closed
@mlepage-google mlepage-google self-requested a review January 27, 2022 16:35
This was referenced Jan 27, 2022
Closed
Closed
@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

PR #13756: Size comparison from 245035c to d831e62

Increases above 0.2%:

platform target config section 245035c d831e62 change % change
linux chip-tool-ipv6only arm64 (read only) 6767748 6788164 20416 0.3
.text 5808756 5829172 20416 0.4
Increases (25 builds for cyw30739, efr32, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 245035c d831e62 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578130 578178 48 0.0
.app_xip_area 484224 484272 48 0.0
lock-app CYW30739 (read/write) 536142 536174 32 0.0
.app_xip_area 443780 443812 32 0.0
efr32 lighting-app BRD4161A (read only) 842984 843064 80 0.0
.text 842976 843056 80 0.0
BRD4161A+rpc (read only) 830336 830416 80 0.0
.text 830328 830408 80 0.0
window-app BRD4161A (read only) 815560 815608 48 0.0
.text 815552 815600 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6767748 6788164 20416 0.3
.text 5808756 5829172 20416 0.4
thermostat-no-ble arm64 (read only) 2080748 2082892 2144 0.1
.text 1733472 1735616 2144 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2382472 2383352 880 0.0
.text 1345072 1345952 880 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338200 2338264 64 0.0
.text 1300800 1300864 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302240 2302304 64 0.0
.text 1264840 1264904 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2292980 2293044 64 0.0
.text 1255552 1255616 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981423 48 0.0
text 668228 668280 52 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 966971 48 0.0
text 664672 664724 52 0.0
nrf52840dongle_nrf52840 (read/write) 997459 997507 48 0.0
text 673656 673704 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 890610 64 0.0
text 584416 584468 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913955 914003 48 0.0
text 614212 614248 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824006 824054 48 0.0
text 531172 531208 36 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916819 916851 32 0.0
text 616748 616768 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912003 912051 48 0.0
text 612788 612824 36 0.0
p6 all-clusters-app default (read/write) 2441752 2442728 976 0.0
.text 1400016 1400992 976 0.1
light-app default (read/write) 2338568 2338648 80 0.0
.text 1296832 1296912 80 0.0
lock-app default (read/write) 2304080 2304112 32 0.0
.text 1262344 1262376 32 0.0
qpg lighting-app qpg6105+debug (read only) 570884 570932 48 0.0
.text 565564 565612 48 0.0
lock-app qpg6105+debug (read only) 517004 517036 32 0.0
.text 511684 511716 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 845786 845898 112 0.0
text 592522 592632 110 0.0
Full report (29 builds for cyw30739, efr32, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 245035c d831e62 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578130 578178 48 0.0
.app_xip_area 484224 484272 48 0.0
.bss 76652 76652 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536142 536174 32 0.0
.app_xip_area 443780 443812 32 0.0
.bss 75148 75148 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842984 843064 80 0.0
(read/write) 126200 126200 0 0.0
.bss 124296 124296 0 0.0
.data 1900 1900 0 0.0
.text 842976 843056 80 0.0
BRD4161A+rpc (read only) 830336 830416 80 0.0
(read/write) 142856 142856 0 0.0
.bss 140856 140856 0 0.0
.data 2000 2000 0 0.0
.text 830328 830408 80 0.0
window-app BRD4161A (read only) 815560 815608 48 0.0
(read/write) 124852 124852 0 0.0
.bss 122996 122996 0 0.0
.data 1856 1856 0 0.0
.text 815552 815600 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6767748 6788164 20416 0.3
(read/write) 279201 279201 0 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175984 175984 0 0.0
.dynamic 560 560 0 0.0
.got 42784 42784 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 386892 386892 0 0.0
.text 5808756 5829172 20416 0.4
thermostat-no-ble arm64 (read only) 2080748 2082892 2144 0.1
(read/write) 149537 149537 0 0.0
.bss 67169 67169 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 129932 129932 0 0.0
.text 1733472 1735616 2144 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382472 2383352 880 0.0
.bss 188588 188588 0 0.0
.data 5288 5288 0 0.0
.text 1345072 1345952 880 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338200 2338264 64 0.0
.bss 179304 179304 0 0.0
.data 5584 5584 0 0.0
.text 1300800 1300864 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302240 2302304 64 0.0
.bss 179208 179208 0 0.0
.data 5552 5552 0 0.0
.text 1264840 1264904 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2293044 64 0.0
.bss 176532 176532 0 0.0
.data 5384 5384 0 0.0
.text 1255552 1255616 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981423 48 0.0
bss 119660 119660 0 0.0
rodata 115684 115684 0 0.0
text 668228 668280 52 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 966971 48 0.0
bss 116704 116704 0 0.0
rodata 107160 107160 0 0.0
text 664672 664724 52 0.0
nrf52840dongle_nrf52840 (read/write) 997459 997507 48 0.0
bss 120832 120832 0 0.0
rodata 114516 114516 0 0.0
text 673656 673704 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 890610 64 0.0
bss 116448 116448 0 0.0
rodata 108964 108964 0 0.0
text 584416 584468 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913955 914003 48 0.0
bss 118040 118040 0 0.0
rodata 104320 104320 0 0.0
text 614212 614248 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824006 824054 48 0.0
bss 114856 114856 0 0.0
rodata 97528 97528 0 0.0
text 531172 531208 36 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916819 916851 32 0.0
bss 117792 117792 0 0.0
rodata 104832 104832 0 0.0
text 616748 616768 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912003 912051 48 0.0
bss 117816 117816 0 0.0
rodata 103936 103936 0 0.0
text 612788 612824 36 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2441752 2442728 976 0.0
.bss 116740 116740 0 0.0
.data 2584 2584 0 0.0
.text 1400016 1400992 976 0.1
light-app default (read/write) 2338568 2338648 80 0.0
.bss 104484 104484 0 0.0
.data 2408 2408 0 0.0
.text 1296832 1296912 80 0.0
lock-app default (read/write) 2304080 2304112 32 0.0
.bss 104228 104228 0 0.0
.data 2360 2360 0 0.0
.text 1262344 1262376 32 0.0
qpg lighting-app qpg6105+debug (read only) 570884 570932 48 0.0
(read/write) 146936 146936 0 0.0
.bss 88640 88640 0 0.0
.data 1060 1060 0 0.0
.text 565564 565612 48 0.0
lock-app qpg6105+debug (read only) 517004 517036 32 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 992 992 0 0.0
.text 511684 511716 32 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845786 845898 112 0.0
bss 86440 86440 0 0.0
noinit 37160 37160 0 0.0
text 592522 592632 110 0.0

bzbarsky-apple
bzbarsky-apple requested changes Jan 29, 2022
View reviewed changes
src/app/clusters/access-control-server/access-control-server.cpp Show resolved Hide resolved
src/app/data-model/DecodableList.h Outdated Show resolved Hide resolved
src/app/data-model/DecodableList.h Show resolved Hide resolved
src/app/AttributeAccessInterface.h Show resolved Hide resolved
src/app/data-model/Decode.h Outdated Show resolved Hide resolved
src/app/data-model/Decode.h Outdated Show resolved Hide resolved
src/app/data-model/Nullable.h Outdated Show resolved Hide resolved
src/app/tests/TestAttributeValueDecoder.cpp Outdated Show resolved Hide resolved
src/controller/TypedReadCallback.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #13756: Size comparison from 8b503ad to f9e2857

Increases above 0.2%:

platform target config section 8b503ad f9e2857 change % change
linux chip-tool-ipv6only arm64 (read only) 7054876 7078092 23216 0.3
.text 6069796 6093012 23216 0.4
Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8b503ad f9e2857 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577386 577450 64 0.0
.app_xip_area 483712 483776 64 0.0
lock-app CYW30739 (read/write) 535402 535434 32 0.0
.app_xip_area 443304 443336 32 0.0
efr32 lighting-app BRD4161A (read only) 842688 842784 96 0.0
.text 842680 842776 96 0.0
BRD4161A+rpc (read only) 830064 830160 96 0.0
.text 830056 830152 96 0.0
window-app BRD4161A (read only) 815300 815332 32 0.0
.text 815292 815324 32 0.0
esp32 all-clusters-app c3devkit (read only) 933376 934066 690 0.1
.flash.text 933376 934066 690 0.1
m5stack (read only) 981231 982071 840 0.1
.flash.text 975847 976687 840 0.1
k32w light k32w061+release (read/write) 662060 662108 48 0.0
.text 578284 578332 48 0.0
lock k32w061+release (read/write) 663120 663168 48 0.0
.text 579000 579048 48 0.0
linux chip-tool-ipv6only arm64 (read only) 7054876 7078092 23216 0.3
.text 6069796 6093012 23216 0.4
thermostat-no-ble arm64 (read only) 2082148 2084436 2288 0.1
.text 1734304 1736592 2288 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2382928 2383808 880 0.0
.text 1345528 1346408 880 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2337496 2337560 64 0.0
.text 1300096 1300160 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980759 980823 64 0.0
text 667972 668036 64 0.0
nrf52840dk_nrf52840+rpc (read/write) 966303 966367 64 0.0
text 664416 664480 64 0.0
nrf52840dongle_nrf52840 (read/write) 996827 996891 64 0.0
text 673384 673448 64 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 889926 889990 64 0.0
text 584156 584220 64 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913339 913387 48 0.0
text 613988 614024 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823402 823434 32 0.0
text 530952 530988 36 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916195 916227 32 0.0
text 616512 616548 36 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911387 911435 48 0.0
text 612564 612600 36 0.0
p6 all-clusters-app default (read/write) 2443728 2444720 992 0.0
.text 1401992 1402984 992 0.1
light-app default (read/write) 2339240 2339336 96 0.0
.text 1297504 1297600 96 0.0
lock-app default (read/write) 2304712 2304744 32 0.0
.text 1262976 1263008 32 0.0
qpg lighting-app qpg6105+debug (read only) 570496 570560 64 0.0
.text 565176 565240 64 0.0
lock-app qpg6105+debug (read only) 516624 516656 32 0.0
.text 511304 511336 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 845182 845302 120 0.0
text 592076 592196 120 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8b503ad f9e2857 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577386 577450 64 0.0
.app_xip_area 483712 483776 64 0.0
.bss 76420 76420 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 535402 535434 32 0.0
.app_xip_area 443304 443336 32 0.0
.bss 74884 74884 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842688 842784 96 0.0
(read/write) 125952 125952 0 0.0
.bss 124056 124056 0 0.0
.data 1892 1892 0 0.0
.text 842680 842776 96 0.0
BRD4161A+rpc (read only) 830064 830160 96 0.0
(read/write) 142608 142608 0 0.0
.bss 140616 140616 0 0.0
.data 1992 1992 0 0.0
.text 830056 830152 96 0.0
window-app BRD4161A (read only) 815300 815332 32 0.0
(read/write) 124580 124580 0 0.0
.bss 122732 122732 0 0.0
.data 1848 1848 0 0.0
.text 815292 815324 32 0.0
esp32 all-clusters-app c3devkit (read only) 933376 934066 690 0.1
(read/write) 1398882 1398882 0 0.0
.dram0.bss 69880 69880 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195832 195832 0 0.0
.flash.text 933376 934066 690 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981231 982071 840 0.1
(read/write) 463244 463244 0 0.0
.dram0.bss 74632 74632 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222460 222460 0 0.0
.flash.text 975847 976687 840 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 662060 662108 48 0.0
.bss 76116 76116 0 0.0
.data 1860 1860 0 0.0
.text 578284 578332 48 0.0
lock k32w061+release (read/write) 663120 663168 48 0.0
.bss 76428 76428 0 0.0
.data 1892 1892 0 0.0
.text 579000 579048 48 0.0
linux chip-tool-ipv6only arm64 (read only) 7054876 7078092 23216 0.3
(read/write) 284689 284689 0 0.0
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 179152 179152 0 0.0
.dynamic 560 560 0 0.0
.got 45080 45080 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 398660 398660 0 0.0
.text 6069796 6093012 23216 0.4
thermostat-no-ble arm64 (read only) 2082148 2084436 2288 0.1
(read/write) 149441 149441 0 0.0
.bss 67121 67121 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74248 74248 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130468 130468 0 0.0
.text 1734304 1736592 2288 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382928 2383808 880 0.0
.bss 188780 188780 0 0.0
.data 5288 5288 0 0.0
.text 1345528 1346408 880 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337496 2337560 64 0.0
.bss 179064 179064 0 0.0
.data 5576 5576 0 0.0
.text 1300096 1300160 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2301600 2301600 0 0.0
.bss 178936 178936 0 0.0
.data 5544 5544 0 0.0
.text 1264200 1264200 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292204 2292204 0 0.0
.bss 176220 176220 0 0.0
.data 5376 5376 0 0.0
.text 1254776 1254776 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980759 980823 64 0.0
bss 119428 119428 0 0.0
rodata 115548 115548 0 0.0
text 667972 668036 64 0.0
nrf52840dk_nrf52840+rpc (read/write) 966303 966367 64 0.0
bss 116472 116472 0 0.0
rodata 107020 107020 0 0.0
text 664416 664480 64 0.0
nrf52840dongle_nrf52840 (read/write) 996827 996891 64 0.0
bss 120600 120600 0 0.0
rodata 114380 114380 0 0.0
text 673384 673448 64 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 889926 889990 64 0.0
bss 116216 116216 0 0.0
rodata 108824 108824 0 0.0
text 584156 584220 64 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913339 913387 48 0.0
bss 117780 117780 0 0.0
rodata 104184 104184 0 0.0
text 613988 614024 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823402 823434 32 0.0
bss 114596 114596 0 0.0
rodata 97388 97388 0 0.0
text 530952 530988 36 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916195 916227 32 0.0
bss 117536 117536 0 0.0
rodata 104696 104696 0 0.0
text 616512 616548 36 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911387 911435 48 0.0
bss 117544 117544 0 0.0
rodata 103800 103800 0 0.0
text 612564 612600 36 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2443728 2444720 992 0.0
.bss 116932 116932 0 0.0
.data 2584 2584 0 0.0
.text 1401992 1402984 992 0.1
light-app default (read/write) 2339240 2339336 96 0.0
.bss 104244 104244 0 0.0
.data 2400 2400 0 0.0
.text 1297504 1297600 96 0.0
lock-app default (read/write) 2304712 2304744 32 0.0
.bss 103964 103964 0 0.0
.data 2360 2360 0 0.0
.text 1262976 1263008 32 0.0
qpg lighting-app qpg6105+debug (read only) 570496 570560 64 0.0
(read/write) 146940 146940 0 0.0
.bss 88400 88400 0 0.0
.data 1056 1056 0 0.0
.text 565176 565240 64 0.0
lock-app qpg6105+debug (read only) 516624 516656 32 0.0
(read/write) 146940 146940 0 0.0
.bss 87840 87840 0 0.0
.data 992 992 0 0.0
.text 511304 511336 32 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845182 845302 120 0.0
bss 86448 86448 0 0.0
noinit 37160 37160 0 0.0
text 592076 592196 120 0.0

@erjiaqing erjiaqing mentioned this pull request Jan 31, 2022
Closed
bzbarsky-apple
bzbarsky-apple reviewed Jan 31, 2022
View reviewed changes
src/app/clusters/access-control-server/access-control-server.cpp Outdated Show resolved Hide resolved
src/app/data-model/DecodableList.h Outdated Show resolved Hide resolved
src/app/data-model/Decode.h Outdated Show resolved Hide resolved
src/app/data-model/Decode.h Outdated Show resolved Hide resolved
src/app/AttributeAccessInterface.h Show resolved Hide resolved
@github-actions
Copy link

PR #13756: Size comparison from 39115b9 to 217ea7e

Increases above 0.2%:

platform target config section 39115b9 217ea7e change % change
linux chip-tool-ipv6only arm64 (read only) 6960580 6983780 23200 0.3
.text 5989156 6012356 23200 0.4
Increases (8 builds for cyw30739, k32w, linux, p6, qpg)
platform target config section 39115b9 217ea7e change % change
cyw30739 lock-app CYW30739 (read/write) 533606 533646 40 0.0
.app_xip_area 442404 442444 40 0.0
k32w light k32w061+release (read/write) 660276 660308 32 0.0
.text 577412 577444 32 0.0
lock k32w061+release (read/write) 661352 661400 48 0.0
.text 578128 578176 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6960580 6983780 23200 0.3
.text 5989156 6012356 23200 0.4
thermostat-no-ble arm64 (read only) 2079596 2081900 2304 0.1
.text 1732144 1734448 2304 0.1
p6 all-clusters-app default (read/write) 2442632 2443624 992 0.0
.text 1400896 1401888 992 0.1
lock-app default (read/write) 2303664 2303712 48 0.0
.text 1261928 1261976 48 0.0
qpg lock-app qpg6105+debug (read only) 515760 515792 32 0.0
.text 510440 510472 32 0.0
Decreases (4 builds for cyw30739, p6, qpg, telink)
platform target config section 39115b9 217ea7e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575578 573946 -1632 -0.3
.app_xip_area 482800 481176 -1624 -0.3
.bss 75524 75516 -8 -0.0
p6 light-app default (read/write) 2338192 2336016 -2176 -0.1
.text 1296456 1294280 -2176 -0.2
qpg lighting-app qpg6105+debug (read only) 569652 568020 -1632 -0.3
.text 564332 562700 -1632 -0.3
telink lighting-app tlsr9518adk80d (read/write) 843346 841490 -1856 -0.2
text 591218 589584 -1634 -0.3
Full report (13 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section 39115b9 217ea7e change % change
cyw30739 lock-app CYW30739 (read/write) 533606 533646 40 0.0
.app_xip_area 442404 442444 40 0.0
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
light cyw930739m2evb_01 (read/write) 575578 573946 -1632 -0.3
.app_xip_area 482800 481176 -1624 -0.3
.bss 75524 75516 -8 -0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
k32w light k32w061+release (read/write) 660276 660308 32 0.0
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 577412 577444 32 0.0
lock k32w061+release (read/write) 661352 661400 48 0.0
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 578128 578176 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6960580 6983780 23200 0.3
(read/write) 282561 282561 0 0.0
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178032 178032 0 0.0
.dynamic 560 560 0 0.0
.got 45056 45056 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 386556 386556 0 0.0
.text 5989156 6012356 23200 0.4
thermostat-no-ble arm64 (read only) 2079596 2081900 2304 0.1
(read/write) 148433 148433 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74200 74200 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130252 130252 0 0.0
.text 1732144 1734448 2304 0.1
p6 all-clusters-app default (read/write) 2442632 2443624 992 0.0
.bss 116028 116028 0 0.0
.data 2576 2576 0 0.0
.text 1400896 1401888 992 0.1
light-app default (read/write) 2338192 2336016 -2176 -0.1
.bss 103348 103348 0 0.0
.data 2400 2400 0 0.0
.text 1296456 1294280 -2176 -0.2
lock-app default (read/write) 2303664 2303712 48 0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1261928 1261976 48 0.0
qpg lighting-app qpg6105+debug (read only) 569652 568020 -1632 -0.3
(read/write) 146940 146940 0 0.0
.bss 87504 87504 0 0.0
.data 1056 1056 0 0.0
.text 564332 562700 -1632 -0.3
lock-app qpg6105+debug (read only) 515760 515792 32 0.0
(read/write) 146940 146940 0 0.0
.bss 86944 86944 0 0.0
.data 992 992 0 0.0
.text 510440 510472 32 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 843346 841490 -1856 -0.2
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 591218 589584 -1634 -0.3

@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #13756: Size comparison from 39115b9 to 1bc8198

Increases above 0.2%:

platform target config section 39115b9 1bc8198 change % change
linux chip-tool-ipv6only arm64 (read only) 6960580 6983780 23200 0.3
.text 5989156 6012356 23200 0.4
Increases (16 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
platform target config section 39115b9 1bc8198 change % change
cyw30739 lock-app CYW30739 (read/write) 533606 533646 40 0.0
.app_xip_area 442404 442444 40 0.0
efr32 window-app BRD4161A (read only) 814108 814156 48 0.0
.text 814100 814148 48 0.0
esp32 all-clusters-app c3devkit (read only) 932512 933202 690 0.1
.flash.text 932512 933202 690 0.1
m5stack (read only) 980495 981323 828 0.1
.flash.text 975111 975939 828 0.1
k32w light k32w061+release (read/write) 660276 660308 32 0.0
.text 577412 577444 32 0.0
lock k32w061+release (read/write) 661352 661400 48 0.0
.text 578128 578176 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6960580 6983780 23200 0.3
.text 5989156 6012356 23200 0.4
thermostat-no-ble arm64 (read only) 2079596 2081900 2304 0.1
.text 1732144 1734448 2304 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2382072 2382776 704 0.0
.text 1344672 1345376 704 0.1
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 911623 911655 32 0.0
text 613248 613284 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821670 821718 48 0.0
text 530212 530248 36 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914495 914543 48 0.0
text 615772 615808 36 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909671 909703 32 0.0
text 611820 611856 36 0.0
p6 all-clusters-app default (read/write) 2442632 2443624 992 0.0
.text 1400896 1401888 992 0.1
lock-app default (read/write) 2303664 2303712 48 0.0
.text 1261928 1261976 48 0.0
qpg lock-app qpg6105+debug (read only) 515760 515792 32 0.0
.text 510440 510472 32 0.0
Decreases (11 builds for cyw30739, efr32, mbed, nrfconnect, p6, qpg, telink)
platform target config section 39115b9 1bc8198 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575578 573946 -1632 -0.3
.app_xip_area 482800 481176 -1624 -0.3
.bss 75524 75516 -8 -0.0
efr32 lighting-app BRD4161A (read only) 841496 839304 -2192 -0.3
.text 841488 839296 -2192 -0.3
BRD4161A+rpc (read only) 828872 826680 -2192 -0.3
.text 828864 826672 -2192 -0.3
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2336640 2334848 -1792 -0.1
.text 1299240 1297448 -1792 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 978979 977355 -1624 -0.2
bss 118528 118524 -4 -0.0
rodata 115464 115248 -216 -0.2
text 667216 665808 -1408 -0.2
nrf52840dk_nrf52840+rpc (read/write) 964555 962931 -1624 -0.2
bss 115572 115568 -4 -0.0
rodata 106936 106720 -216 -0.2
text 663660 662252 -1408 -0.2
nrf52840dongle_nrf52840 (read/write) 995063 993435 -1628 -0.2
bss 119700 119696 -4 -0.0
rodata 114296 114076 -220 -0.2
text 672608 671200 -1408 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 888178 886554 -1624 -0.2
bss 115316 115312 -4 -0.0
rodata 108740 108524 -216 -0.2
text 583400 581992 -1408 -0.2
p6 light-app default (read/write) 2338192 2336016 -2176 -0.1
.text 1296456 1294280 -2176 -0.2
qpg lighting-app qpg6105+debug (read only) 569652 568020 -1632 -0.3
.text 564332 562700 -1632 -0.3
telink lighting-app tlsr9518adk80d (read/write) 843346 841490 -1856 -0.2
text 591218 589584 -1634 -0.3
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 39115b9 1bc8198 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575578 573946 -1632 -0.3
.app_xip_area 482800 481176 -1624 -0.3
.bss 75524 75516 -8 -0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 533606 533646 40 0.0
.app_xip_area 442404 442444 40 0.0
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 841496 839304 -2192 -0.3
(read/write) 125056 125056 0 0.0
.bss 123160 123160 0 0.0
.data 1892 1892 0 0.0
.text 841488 839296 -2192 -0.3
BRD4161A+rpc (read only) 828872 826680 -2192 -0.3
(read/write) 141712 141712 0 0.0
.bss 139720 139720 0 0.0
.data 1992 1992 0 0.0
.text 828864 826672 -2192 -0.3
window-app BRD4161A (read only) 814108 814156 48 0.0
(read/write) 123684 123684 0 0.0
.bss 121836 121836 0 0.0
.data 1848 1848 0 0.0
.text 814100 814148 48 0.0
esp32 all-clusters-app c3devkit (read only) 932512 933202 690 0.1
(read/write) 1397882 1397882 0 0.0
.dram0.bss 68968 68968 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195744 195744 0 0.0
.flash.text 932512 933202 690 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 980495 981323 828 0.1
(read/write) 462248 462248 0 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222368 222368 0 0.0
.flash.text 975111 975939 828 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660276 660308 32 0.0
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 577412 577444 32 0.0
lock k32w061+release (read/write) 661352 661400 48 0.0
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 578128 578176 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6960580 6983780 23200 0.3
(read/write) 282561 282561 0 0.0
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178032 178032 0 0.0
.dynamic 560 560 0 0.0
.got 45056 45056 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 386556 386556 0 0.0
.text 5989156 6012356 23200 0.4
thermostat-no-ble arm64 (read only) 2079596 2081900 2304 0.1
(read/write) 148433 148433 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74200 74200 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130252 130252 0 0.0
.text 1732144 1734448 2304 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382072 2382776 704 0.0
.bss 187884 187884 0 0.0
.data 5288 5288 0 0.0
.text 1344672 1345376 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336640 2334848 -1792 -0.1
.bss 178160 178160 0 0.0
.data 5568 5568 0 0.0
.text 1299240 1297448 -1792 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300744 2300744 0 0.0
.bss 178040 178040 0 0.0
.data 5544 5544 0 0.0
.text 1263344 1263344 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291348 2291348 0 0.0
.bss 175316 175316 0 0.0
.data 5368 5368 0 0.0
.text 1253920 1253920 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 978979 977355 -1624 -0.2
bss 118528 118524 -4 -0.0
rodata 115464 115248 -216 -0.2
text 667216 665808 -1408 -0.2
nrf52840dk_nrf52840+rpc (read/write) 964555 962931 -1624 -0.2
bss 115572 115568 -4 -0.0
rodata 106936 106720 -216 -0.2
text 663660 662252 -1408 -0.2
nrf52840dongle_nrf52840 (read/write) 995063 993435 -1628 -0.2
bss 119700 119696 -4 -0.0
rodata 114296 114076 -220 -0.2
text 672608 671200 -1408 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 888178 886554 -1624 -0.2
bss 115316 115312 -4 -0.0
rodata 108740 108524 -216 -0.2
text 583400 581992 -1408 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 911623 911655 32 0.0
bss 116888 116888 0 0.0
rodata 104100 104100 0 0.0
text 613248 613284 36 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821670 821718 48 0.0
bss 113704 113704 0 0.0
rodata 97304 97304 0 0.0
text 530212 530248 36 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914495 914543 48 0.0
bss 116644 116644 0 0.0
rodata 104612 104612 0 0.0
text 615772 615808 36 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909671 909703 32 0.0
bss 116652 116652 0 0.0
rodata 103716 103716 0 0.0
text 611820 611856 36 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2442632 2443624 992 0.0
.bss 116028 116028 0 0.0
.data 2576 2576 0 0.0
.text 1400896 1401888 992 0.1
light-app default (read/write) 2338192 2336016 -2176 -0.1
.bss 103348 103348 0 0.0
.data 2400 2400 0 0.0
.text 1296456 1294280 -2176 -0.2
lock-app default (read/write) 2303664 2303712 48 0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1261928 1261976 48 0.0
qpg lighting-app qpg6105+debug (read only) 569652 568020 -1632 -0.3
(read/write) 146940 146940 0 0.0
.bss 87504 87504 0 0.0
.data 1056 1056 0 0.0
.text 564332 562700 -1632 -0.3
lock-app qpg6105+debug (read only) 515760 515792 32 0.0
(read/write) 146940 146940 0 0.0
.bss 86944 86944 0 0.0
.data 992 992 0 0.0
.text 510440 510472 32 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 843346 841490 -1856 -0.2
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 591218 589584 -1634 -0.3

@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #13756: Size comparison from 39115b9 to ff70d0e

Increases above 0.2%:

platform target config section 39115b9 ff70d0e change % change
linux chip-tool-ipv6only arm64 (read only) 6960580 7009188 48608 0.7
(read/write) 282561 288945 6384 2.3
.data.rel.ro 178032 184384 6352 3.6
.text 5989156 6025652 36496 0.6
Increases (7 builds for cyw30739, efr32, k32w, linux, qpg)
platform target config section 39115b9 ff70d0e change % change
cyw30739 lock-app CYW30739 (read/write) 533606 533642 36 0.0
.app_xip_area 442404 442440 36 0.0
efr32 window-app BRD4161A (read only) 814108 814140 32 0.0
.text 814100 814132 32 0.0
k32w light k32w061+release (read/write) 660276 660308 32 0.0
.text 577412 577444 32 0.0
lock k32w061+release (read/write) 661352 661400 48 0.0
.text 578128 578176 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6960580 7009188 48608 0.7
(read/write) 282561 288945 6384 2.3
.data.rel.ro 178032 184384 6352 3.6
.got 45056 45072 16 0.0
.rodata 386556 387068 512 0.1
.text 5989156 6025652 36496 0.6
thermostat-no-ble arm64 (read only) 2079596 2081900 2304 0.1
.text 1732144 1734448 2304 0.1
qpg lock-app qpg6105+debug (read only) 515760 515796 36 0.0
.text 510440 510476 36 0.0
Decreases (5 builds for cyw30739, efr32, qpg, telink)
platform target config section 39115b9 ff70d0e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575578 573950 -1628 -0.3
.app_xip_area 482800 481180 -1620 -0.3
.bss 75524 75516 -8 -0.0
efr32 lighting-app BRD4161A (read only) 841496 839304 -2192 -0.3
.text 841488 839296 -2192 -0.3
BRD4161A+rpc (read only) 828872 826680 -2192 -0.3
.text 828864 826672 -2192 -0.3
qpg lighting-app qpg6105+debug (read only) 569652 568016 -1636 -0.3
.text 564332 562696 -1636 -0.3
telink lighting-app tlsr9518adk80d (read/write) 843346 841506 -1840 -0.2
text 591218 589602 -1616 -0.3
Full report (13 builds for cyw30739, efr32, k32w, linux, qpg, telink)
platform target config section 39115b9 ff70d0e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575578 573950 -1628 -0.3
.app_xip_area 482800 481180 -1620 -0.3
.bss 75524 75516 -8 -0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 533606 533642 36 0.0
.app_xip_area 442404 442440 36 0.0
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 841496 839304 -2192 -0.3
(read/write) 125056 125056 0 0.0
.bss 123160 123160 0 0.0
.data 1892 1892 0 0.0
.text 841488 839296 -2192 -0.3
BRD4161A+rpc (read only) 828872 826680 -2192 -0.3
(read/write) 141712 141712 0 0.0
.bss 139720 139720 0 0.0
.data 1992 1992 0 0.0
.text 828864 826672 -2192 -0.3
window-app BRD4161A (read only) 814108 814140 32 0.0
(read/write) 123684 123684 0 0.0
.bss 121836 121836 0 0.0
.data 1848 1848 0 0.0
.text 814100 814132 32 0.0
k32w light k32w061+release (read/write) 660276 660308 32 0.0
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 577412 577444 32 0.0
lock k32w061+release (read/write) 661352 661400 48 0.0
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 578128 578176 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6960580 7009188 48608 0.7
(read/write) 282561 288945 6384 2.3
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178032 184384 6352 3.6
.dynamic 560 560 0 0.0
.got 45056 45072 16 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 386556 387068 512 0.1
.text 5989156 6025652 36496 0.6
thermostat-no-ble arm64 (read only) 2079596 2081900 2304 0.1
(read/write) 148433 148433 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74200 74200 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130252 130252 0 0.0
.text 1732144 1734448 2304 0.1
qpg lighting-app qpg6105+debug (read only) 569652 568016 -1636 -0.3
(read/write) 146940 146940 0 0.0
.bss 87504 87504 0 0.0
.data 1056 1056 0 0.0
.text 564332 562696 -1636 -0.3
lock-app qpg6105+debug (read only) 515760 515796 36 0.0
(read/write) 146940 146940 0 0.0
.bss 86944 86944 0 0.0
.data 992 992 0 0.0
.text 510440 510476 36 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 843346 841506 -1840 -0.2
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 591218 589602 -1616 -0.3

@bzbarsky-apple bzbarsky-apple merged commit 723671f into project-chip:master Feb 1, 2022
@mlepage-google mlepage-google mentioned this pull request Feb 1, 2022
Merged
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

Assignees
No one assigned
Labels
app controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fabric Filtered Reads/Writes/Subscribes
5 participants
@erjiaqing @woody-apple @mrjerryjohns @bzbarsky-apple @mlepage-google