Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Fix ota-provider-app build failure #13394

Merged
merged 1 commit into from
Jan 10, 2022
Merged

[ESP32] Fix ota-provider-app build failure #13394

merged 1 commit into from
Jan 10, 2022

Conversation

shubhamdp
Copy link
Contributor

Problem

Change overview

  • Added the required changes introduced in [OTA] Support multiple sequential BDX transfers #13329
  • Fixed the build by moving BdxOtaSender.h to examples/ota-provider-app/esp32/main/include/ota-provider-common so that OTAProviderExample.h will include this header file based on include path.

This is the workaround to fix the build, we will need some interface which can be used by platforms for implementing OTA provider.

Testing

  • Linux-ota-provider and Linux-ota-requestor
  • ESP32-ota-provider and ESP32-ota-requestor
  • Linux-ota-provider and ESP32-ota-requestor

@shubhamdp shubhamdp mentioned this pull request Jan 8, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jan 8, 2022 •
edited
Loading

PR #13394: Size comparison from 5d0c314 to 21cb029

Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5d0c314 21cb029 change % change
efr32 lighting-app BRD4161A (read only) 829244 829244 0 0.0
(read/write) 126996 126996 0 0.0
.bss 125120 125120 0 0.0
.data 1876 1876 0 0.0
.text 829236 829236 0 0.0
BRD4161A+rpc (read only) 816888 816888 0 0.0
(read/write) 143656 143656 0 0.0
.bss 141680 141680 0 0.0
.data 1976 1976 0 0.0
.text 816880 816880 0 0.0
window-app BRD4161A (read only) 802692 802692 0 0.0
(read/write) 125936 125936 0 0.0
.bss 124104 124104 0 0.0
.data 1832 1832 0 0.0
.text 802684 802684 0 0.0
esp32 all-clusters-app c3devkit (read only) 891904 891904 0 0.0
(read/write) 1314010 1314010 0 0.0
.dram0.bss 69464 69464 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 177248 177248 0 0.0
.flash.text 891904 891904 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 951843 951843 0 0.0
(read/write) 445592 445592 0 0.0
.dram0.bss 73960 73960 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206560 206560 0 0.0
.flash.text 946459 946459 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655324 655324 0 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570900 570900 0 0.0
lock k32w061+release (read/write) 659616 659616 0 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574876 574876 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7056652 7056652 0 0.0
(read/write) 326113 326113 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209392 209392 0 0.0
.dynamic 560 560 0 0.0
.got 57072 57072 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384564 384564 0 0.0
.text 5978228 5978228 0 0.0
thermostat-no-ble arm64 (read only) 2033804 2033804 0 0.0
(read/write) 145089 145089 0 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72624 72624 0 0.0
.dynamic 560 560 0 0.0
.got 4000 4000 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128988 128988 0 0.0
.text 1691168 1691168 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348560 2348560 0 0.0
.bss 188724 188724 0 0.0
.data 5312 5312 0 0.0
.text 1311136 1311136 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330752 2330752 0 0.0
.bss 180544 180544 0 0.0
.data 5552 5552 0 0.0
.text 1293352 1293352 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303904 2303904 0 0.0
.bss 179592 179592 0 0.0
.data 5544 5544 0 0.0
.text 1266504 1266504 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937115 937115 0 0.0
bss 118112 118112 0 0.0
rodata 108120 108120 0 0.0
text 633324 633324 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 923511 923511 0 0.0
bss 115156 115156 0 0.0
rodata 101548 101548 0 0.0
text 628636 628636 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848094 848094 0 0.0
bss 116004 116004 0 0.0
rodata 101296 101296 0 0.0
text 550256 550256 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 909259 909259 0 0.0
bss 117300 117300 0 0.0
rodata 103392 103392 0 0.0
text 611188 611188 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820418 820418 0 0.0
bss 115220 115220 0 0.0
rodata 96620 96620 0 0.0
text 528164 528164 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910523 910523 0 0.0
bss 117060 117060 0 0.0
rodata 103608 103608 0 0.0
text 612404 612404 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 907339 907339 0 0.0
bss 117088 117088 0 0.0
rodata 102864 102864 0 0.0
text 609936 609936 0 0.0
shell nrf52840dk_nrf52840 (read/write) 797935 797935 0 0.0
bss 109768 109768 0 0.0
rodata 78148 78148 0 0.0
text 533508 533508 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710750 710750 0 0.0
bss 107656 107656 0 0.0
rodata 72448 72448 0 0.0
text 451188 451188 0 0.0
p6 all-clusters-app default (read/write) 2401656 2401656 0 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1359920 1359920 0 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295904 2295904 0 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254168 1254168 0 0.0
qpg lighting-app qpg6105+debug (read only) 533192 533192 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527872 527872 0 0.0
lock-app qpg6105+debug (read only) 504968 504968 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499648 499648 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834522 834522 0 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582766 582766 0 0.0

@bzbarsky-apple
Copy link
Contributor

Why wasn't this caught by CI?

@shubhamdp
Copy link
Contributor Author

Why wasn't this caught by CI?

This example is not added to CI, #13212 adds this to CI.

@carol-apple
Copy link
Contributor

Why wasn't this caught by CI?

This example is not added to CI, #13212 adds this to CI.

Sorry I broke this when fixing it on Linux OTA Provider

@shubhamdp shubhamdp force-pushed the esp32_ota_provider_build_fix branch from 21cb029 to 17c12c7 Compare January 9, 2022 14:35
@github-actions
Copy link

github-actions bot commented Jan 9, 2022 •
edited
Loading

PR #13394: Size comparison from b7ff37e to 17c12c7

Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b7ff37e 17c12c7 change % change
efr32 lighting-app BRD4161A (read only) 829244 829244 0 0.0
(read/write) 126996 126996 0 0.0
.bss 125120 125120 0 0.0
.data 1876 1876 0 0.0
.text 829236 829236 0 0.0
BRD4161A+rpc (read only) 816888 816888 0 0.0
(read/write) 143656 143656 0 0.0
.bss 141680 141680 0 0.0
.data 1976 1976 0 0.0
.text 816880 816880 0 0.0
window-app BRD4161A (read only) 802692 802692 0 0.0
(read/write) 125936 125936 0 0.0
.bss 124104 124104 0 0.0
.data 1832 1832 0 0.0
.text 802684 802684 0 0.0
esp32 all-clusters-app c3devkit (read only) 891904 891904 0 0.0
(read/write) 1314010 1314010 0 0.0
.dram0.bss 69464 69464 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 177248 177248 0 0.0
.flash.text 891904 891904 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 951843 951843 0 0.0
(read/write) 445592 445592 0 0.0
.dram0.bss 73960 73960 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206560 206560 0 0.0
.flash.text 946459 946459 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655324 655324 0 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570900 570900 0 0.0
lock k32w061+release (read/write) 659632 659632 0 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574892 574892 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7105148 7105148 0 0.0
(read/write) 327009 327009 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209392 209392 0 0.0
.dynamic 560 560 0 0.0
.got 57968 57968 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 388884 388884 0 0.0
.text 6019716 6019716 0 0.0
thermostat-no-ble arm64 (read only) 2033868 2033868 0 0.0
(read/write) 145089 145089 0 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72624 72624 0 0.0
.dynamic 560 560 0 0.0
.got 4000 4000 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128988 128988 0 0.0
.text 1691232 1691232 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348560 2348560 0 0.0
.bss 188724 188724 0 0.0
.data 5312 5312 0 0.0
.text 1311136 1311136 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330752 2330752 0 0.0
.bss 180544 180544 0 0.0
.data 5552 5552 0 0.0
.text 1293352 1293352 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303904 2303904 0 0.0
.bss 179592 179592 0 0.0
.data 5544 5544 0 0.0
.text 1266504 1266504 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937115 937115 0 0.0
bss 118112 118112 0 0.0
rodata 108120 108120 0 0.0
text 633324 633324 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 923511 923511 0 0.0
bss 115156 115156 0 0.0
rodata 101548 101548 0 0.0
text 628636 628636 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848094 848094 0 0.0
bss 116004 116004 0 0.0
rodata 101296 101296 0 0.0
text 550256 550256 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 909259 909259 0 0.0
bss 117300 117300 0 0.0
rodata 103392 103392 0 0.0
text 611188 611188 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820418 820418 0 0.0
bss 115220 115220 0 0.0
rodata 96620 96620 0 0.0
text 528164 528164 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910523 910523 0 0.0
bss 117060 117060 0 0.0
rodata 103608 103608 0 0.0
text 612404 612404 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 907339 907339 0 0.0
bss 117088 117088 0 0.0
rodata 102864 102864 0 0.0
text 609936 609936 0 0.0
shell nrf52840dk_nrf52840 (read/write) 797935 797935 0 0.0
bss 109768 109768 0 0.0
rodata 78148 78148 0 0.0
text 533508 533508 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710750 710750 0 0.0
bss 107656 107656 0 0.0
rodata 72448 72448 0 0.0
text 451188 451188 0 0.0
p6 all-clusters-app default (read/write) 2401656 2401656 0 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1359920 1359920 0 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295904 2295904 0 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254168 1254168 0 0.0
qpg lighting-app qpg6105+debug (read only) 533192 533192 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527872 527872 0 0.0
lock-app qpg6105+debug (read only) 504968 504968 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499648 499648 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834522 834522 0 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582766 582766 0 0.0

@Damian-Nordic Damian-Nordic merged commit 466ee90 into project-chip:master Jan 10, 2022
@shubhamdp shubhamdp deleted the esp32_ota_provider_build_fix branch January 10, 2022 18:15
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@shubhamdp @step0035
[ESP32] Fix ota-provider-app build failure (project-chip#13394)
1dd207c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carol-apple carol-apple carol-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shubhamdp @bzbarsky-apple @carol-apple @dhrishi @Damian-Nordic