[ESP32] Add ESP32 OTA provider and requestor app to CI builds #13212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt and
pan-apple
|
@bzbarsky-apple, @dhrishi, fortunately even after adding these two examples to ci, ESP-32 workflow in this PR was completed in 78 minutes. Anyway I have bumped it to 95 minutes. I think ~15 minutes of head room should be enough for now. |
Raised an issue #13221, will add a follow-up PR |
|
PR #13212: Size comparison from 9a80f75 to 8f36494 Decreases (5 builds for esp32, linux, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
shubhamdp
force-pushed
the
add_esp32_ota_app_to_ci
branch
from
8f36494 to
a9598c0
Compare
|
PR #13212: Size comparison from 3a617aa to a9598c0 Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
shubhamdp
force-pushed
the
add_esp32_ota_app_to_ci
branch
from
a9598c0 to
6a86eec
Compare
|
PR #13212: Size comparison from 83b2f46 to 6a86eec Full report (18 builds for k32w, nrfconnect, p6, qpg)
|
|
/rebase |
woody-apple
force-pushed
the
add_esp32_ota_app_to_ci
branch
from
6a86eec to
8d236d5
Compare
|
PR #13212: Size comparison from 83b2f46 to 8d236d5 Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Jan 4, 2022
bzbarsky-apple
approved these changes
Jan 7, 2022
andy31415
approved these changes
Jan 8, 2022
|
@shubhamdp Please resolve the conflict |
Its good that we have a conflict as the ota-provider-app/esp32 build is broken due to changes in #13329. Now, this MR has the dependency on #13394, its good to resolve the conflict once esp32-ota-provider build is fixed. |
dhrishi
approved these changes
Jan 10, 2022
shubhamdp
force-pushed
the
add_esp32_ota_app_to_ci
branch
from
8d236d5 to
6b006fc
Compare
shubhamdp
changed the title
|
PR #13212: Size comparison from 466ee90 to 6b006fc Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…t-chip#13212) * Add ESP32 OTA provider and requestor app to CI builds * Rename ESP32 OTA requestor project * Increase the timeout to 95 minutes * Split examples-esp32 workflow in two jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ESP32 OTA requestor and provider app are not present in CI builds
Fixes #13221
Change overview
Added ESP32 OTA Requestor and provider apps to examples-esp32.yaml
Testing