-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename media cluster commands & command arguments #13195
Rename media cluster commands & command arguments #13195
Conversation
f6afb14
to
0d3f3df
Compare
PR #13195: Size comparison from afec776 to 0d3f3df Increases (1 build for linux)
Decreases (1 build for linux)
Full report (11 builds for k32w, linux, p6, qpg, telink)
|
d47e141
to
accdb8e
Compare
PR #13195: Size comparison from afec776 to accdb8e Increases (1 build for linux)
Decreases (1 build for linux)
Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
accdb8e
to
a6d4d2f
Compare
PR #13195: Size comparison from afec776 to a6d4d2f Increases (5 builds for esp32, linux, mbed, p6)
Decreases (2 builds for esp32, linux)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
examples/tv-app/android/include/application-launcher/ApplicationLauncherManager.cpp
Show resolved
Hide resolved
examples/tv-app/android/include/application-launcher/ApplicationLauncherManager.cpp
Outdated
Show resolved
Hide resolved
examples/tv-app/android/include/application-launcher/ApplicationLauncherManager.cpp
Outdated
Show resolved
Hide resolved
examples/tv-app/android/include/application-launcher/ApplicationLauncherManager.cpp
Outdated
Show resolved
Hide resolved
examples/tv-app/android/include/target-navigator/TargetNavigatorManager.cpp
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/target-navigator-cluster.xml
Outdated
Show resolved
Hide resolved
a6d4d2f
to
4431076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so this is not blocked on me for the next 2 weeks, though I did not have a chance to read it very carefully after the changes...
c9f086b
to
11184d2
Compare
PR #13195: Size comparison from fcbcac2 to 11184d2 Increases (5 builds for esp32, linux, mbed, p6)
Decreases (1 build for linux)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Media clusters command names & command argument names were not updated per latest spec:
Change overview
see above
Testing
Run
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "