-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable content launcher test for tv app #12961
Merged
mrjerryjohns
merged 8 commits into
project-chip:master
from
lazarkov:feature/enable-content-launcher-test
Dec 16, 2021
Merged
Enable content launcher test for tv app #12961
mrjerryjohns
merged 8 commits into
project-chip:master
from
lazarkov:feature/enable-content-launcher-test
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazarkov
force-pushed
the
feature/enable-content-launcher-test
branch
from
December 13, 2021 22:02
d987286
to
622d7db
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda and
lzgrablic02
December 13, 2021 22:03
PR #12961: Size comparison from c52bc7b to f66b759 Increases above 0.2%:
Increases (5 builds for esp32, linux, mbed, p6)
Decreases (2 builds for mbed, p6)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
lazarkov
force-pushed
the
feature/enable-content-launcher-test
branch
from
December 15, 2021 15:56
f66b759
to
f54046f
Compare
lazarkov
force-pushed
the
feature/enable-content-launcher-test
branch
from
December 15, 2021 15:59
f54046f
to
8f51a89
Compare
PR #12961: Size comparison from 8f15eea to 8f51a89 Increases above 0.2%:
Increases (3 builds for linux, mbed, p6)
Decreases (2 builds for mbed, p6)
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
lazarkov
force-pushed
the
feature/enable-content-launcher-test
branch
from
December 15, 2021 17:46
8f51a89
to
0cc0e62
Compare
lazarkov
force-pushed
the
feature/enable-content-launcher-test
branch
from
December 15, 2021 17:51
0cc0e62
to
88662cf
Compare
PR #12961: Size comparison from ea34a97 to 88662cf Increases above 0.2%:
Increases (5 builds for esp32, linux, mbed, p6)
Decreases (2 builds for mbed, p6)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 15, 2021
lazarkov
force-pushed
the
feature/enable-content-launcher-test
branch
from
December 15, 2021 22:26
88662cf
to
f588434
Compare
lazarkov
force-pushed
the
feature/enable-content-launcher-test
branch
from
December 15, 2021 22:42
f588434
to
5bdba7f
Compare
lazarkov
force-pushed
the
feature/enable-content-launcher-test
branch
from
December 15, 2021 22:43
5bdba7f
to
629202e
Compare
PR #12961: Size comparison from fc5be12 to 629202e Increases above 0.2%:
Increases (3 builds for linux, mbed, p6)
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TV clusters were not updated per latest spec:
List<String>
in controller/ClusterInfo-java.zaptChange overview
see above
Testing
Run
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "