Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert chip-tool YAML tests to the new subscription API. #12852

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Convert chip-tool YAML tests to the new subscription API. #12852

merged 1 commit into from
Dec 10, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

chip-tool yaml tests can't do subscriptions to lists.

Change overview

Convert chip-tool yaml tests to the templated subscription api.

Testing

Passes existing yaml tests.

@woody-apple
Copy link
Contributor

Fast tracking, given this is updating tests.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12852: Size comparison from 3042ef8 to 927266d

Increases above 0.2%:

platform target config section 3042ef8 927266d change % change
linux chip-tool-ipv6only arm64 (read only) 6792492 6856476 63984 0.9
.text 5749668 5813748 64080 1.1
Increases (1 build for linux)
platform target config section 3042ef8 927266d change % change
linux chip-tool-ipv6only arm64 (read only) 6792492 6856476 63984 0.9
.text 5749668 5813748 64080 1.1
Decreases (1 build for linux)
platform target config section 3042ef8 927266d change % change
linux chip-tool-ipv6only arm64 (read/write) 318273 318257 -16 -0.0
.got 53048 53032 -16 -0.0
.rodata 363884 363836 -48 -0.0
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 3042ef8 927266d change % change
efr32 lighting-app BRD4161A (read only) 807372 807372 0 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807364 807364 0 0.0
BRD4161A+rpc (read only) 795008 795008 0 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 795000 795000 0 0.0
window-app BRD4161A (read only) 784348 784348 0 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784340 784340 0 0.0
esp32 all-clusters-app c3devkit (read only) 861942 861942 0 0.0
(read/write) 1305602 1305602 0 0.0
.dram0.bss 65696 65696 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172752 172752 0 0.0
.flash.text 861942 861942 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965155 965155 0 0.0
(read/write) 451296 451296 0 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210468 210468 0 0.0
.flash.text 959771 959771 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668468 668468 0 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587044 587044 0 0.0
lock-app k32w061+debug (read/write) 618428 618428 0 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538884 538884 0 0.0
shell k32w061+debug (read/write) 623520 623520 0 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541776 541776 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6792492 6856476 63984 0.9
(read/write) 318273 318257 -16 -0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53032 -16 -0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363836 -48 -0.0
.text 5749668 5813748 64080 1.1
thermostat-no-ble arm64 (read only) 1943060 1943060 0 0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610608 1610608 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323312 2323312 0 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285888 1285888 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307944 2307944 0 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270544 1270544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281056 2281056 0 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243656 1243656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
p6 all-clusters-app default (read/write) 2360072 2360072 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318336 1318336 0 0.0
light-app default (read/write) 2292872 2292872 0 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251136 1251136 0 0.0
lock-app default (read/write) 2268936 2268936 0 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227200 1227200 0 0.0
qpg lighting-app qpg6100+debug (read only) 520260 520260 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 514940 514940 0 0.0
lock-app qpg6100+debug (read only) 494636 494636 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489316 489316 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809658 809658 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565164 565164 0 0.0

@andy31415
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the chip-tool-yaml-subscription-api branch from 927266d to 2625bbd Compare December 10, 2021 00:57
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12852: Size comparison from 077a822 to 2625bbd

Increases above 0.2%:

platform target config section 077a822 2625bbd change % change
linux chip-tool-ipv6only arm64 (read only) 6792796 6856780 63984 0.9
.text 5749972 5814052 64080 1.1
Increases (1 build for linux)
platform target config section 077a822 2625bbd change % change
linux chip-tool-ipv6only arm64 (read only) 6792796 6856780 63984 0.9
.text 5749972 5814052 64080 1.1
Decreases (1 build for linux)
platform target config section 077a822 2625bbd change % change
linux chip-tool-ipv6only arm64 (read/write) 318273 318257 -16 -0.0
.got 53048 53032 -16 -0.0
.rodata 363884 363836 -48 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 077a822 2625bbd change % change
efr32 lighting-app BRD4161A (read only) 807484 807484 0 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807476 807476 0 0.0
BRD4161A+rpc (read only) 795120 795120 0 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 795112 795112 0 0.0
window-app BRD4161A (read only) 784460 784460 0 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784452 784452 0 0.0
esp32 all-clusters-app c3devkit (read only) 862060 862060 0 0.0
(read/write) 1305602 1305602 0 0.0
.dram0.bss 65696 65696 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172752 172752 0 0.0
.flash.text 862060 862060 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965247 965247 0 0.0
(read/write) 451296 451296 0 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210468 210468 0 0.0
.flash.text 959863 959863 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668532 0 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587108 587108 0 0.0
lock-app k32w061+debug (read/write) 618492 618492 0 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538948 538948 0 0.0
shell k32w061+debug (read/write) 623584 623584 0 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541840 541840 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6856780 63984 0.9
(read/write) 318273 318257 -16 -0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53032 -16 -0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363836 -48 -0.0
.text 5749972 5814052 64080 1.1
thermostat-no-ble arm64 (read only) 1943364 1943364 0 0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610912 1610912 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323376 2323376 0 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285952 1285952 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308008 2308008 0 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270608 1270608 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281120 2281120 0 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243720 1243720 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905659 905659 0 0.0
bss 116168 116168 0 0.0
rodata 101676 101676 0 0.0
text 612212 612212 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 868683 868683 0 0.0
bss 112516 112516 0 0.0
rodata 92972 92972 0 0.0
text 586940 586940 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831650 831650 0 0.0
bss 117544 117544 0 0.0
rodata 96932 96932 0 0.0
text 542640 542640 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878271 878271 0 0.0
bss 113432 113432 0 0.0
rodata 97792 97792 0 0.0
text 591656 591656 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804518 804518 0 0.0
bss 114840 114840 0 0.0
rodata 93080 93080 0 0.0
text 522176 522176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 883199 883199 0 0.0
bss 113344 113344 0 0.0
rodata 99144 99144 0 0.0
text 595244 595244 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876443 876443 0 0.0
bss 113220 113220 0 0.0
rodata 97284 97284 0 0.0
text 590444 590444 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2360184 2360184 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318448 1318448 0 0.0
light-app default (read/write) 2292984 2292984 0 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251248 1251248 0 0.0
lock-app default (read/write) 2269048 2269048 0 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227312 1227312 0 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520324 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 515004 515004 0 0.0
lock-app qpg6100+debug (read only) 494700 494700 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489380 489380 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809770 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565274 565274 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 55b7aba into project-chip:master Dec 10, 2021
@bzbarsky-apple bzbarsky-apple deleted the chip-tool-yaml-subscription-api branch December 10, 2021 02:55
kghost pushed a commit to kghost/connectedhomeip that referenced this pull request Dec 10, 2021
@bzbarsky-apple @kghost
Convert chip-tool YAML tests to the new subscription API. (project-ch…
e3a8ec1 
…ip#12852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @woody-apple @andy31415 @mrjerryjohns @yunhanw-google