Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add tracing service to example/platform/esp rpc (#12386)" #12686

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Revert "Add tracing service to example/platform/esp rpc (#12386)" #12686

merged 1 commit into from
Dec 7, 2021

Conversation

andy31415
Copy link
Contributor

This reverts commit 59ca414.

Problem

Cloud build failures on M5stack:

Step #1 - "ESP32": 2021-12-03 17:27:54 INFO    /opt/espressif/tools/tools/xtensa-esp32-elf/esp-2021r2-8.4.0/xtensa-esp32-elf/bin/../lib/gcc/xtensa-esp32-elf/8.4.0/../../../../xtensa-esp32-elf/bin/ld: third_party/connectedhomeip/third_party/pigweed/repo/pw_trace_tokenized/libpw_trace_tokenized.trace_buffer.a(trace_buffer.cc.obj): in function `pw::trace::(anonymous namespace)::TraceBuffer::TraceBuffer()':
Step #1 - "ESP32": 2021-12-03 17:27:54 INFO    /workspace/examples/all-clusters-app/esp32/third_party/connectedhomeip/third_party/pigweed/repo/pw_trace_tokenized/trace_buffer.cc:34: undefined reference to `pw::trace::CallbacksImpl::RegisterSink(void (*)(void*, unsigned int), void (*)(void*, void const*, unsigned int), void (*)(void*), void*, unsigned int*)'
Step #1 - "ESP32": 2021-12-03 17:27:54 INFO    collect2: error: ld returned 1 exit status

Change overview

Reverts a PR

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Dec 7, 2021
@andy31415 andy31415 merged commit 051685b into project-chip:master Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12686: Size comparison from 4243c42 to 1b60b90

Full report (32 builds for efr32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 4243c42 1b60b90 change % change
efr32 lighting-app BRD4161A (read only) 798156 798156 0 0.0
(read/write) 120548 120548 0 0.0
.bss 118720 118720 0 0.0
.data 1828 1828 0 0.0
.text 798148 798148 0 0.0
BRD4161A+rpc (read only) 826116 826116 0 0.0
(read/write) 138856 138856 0 0.0
.bss 136920 136920 0 0.0
.data 1936 1936 0 0.0
.text 826108 826108 0 0.0
lock-app BRD4161A (read only) 772832 772832 0 0.0
(read/write) 118488 118488 0 0.0
.bss 116696 116696 0 0.0
.data 1788 1788 0 0.0
.text 772824 772824 0 0.0
window-app BRD4161A (read only) 775104 775104 0 0.0
(read/write) 118688 118688 0 0.0
.bss 116896 116896 0 0.0
.data 1792 1792 0 0.0
.text 775096 775096 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732484 732484 0 0.0
.bss 79296 79296 0 0.0
.data 1860 1860 0 0.0
.text 645528 645528 0 0.0
lock-app k32w061+debug (read/write) 623164 623164 0 0.0
.bss 69960 69960 0 0.0
.data 1828 1828 0 0.0
.text 545576 545576 0 0.0
shell k32w061+debug (read/write) 689084 689084 0 0.0
.bss 81596 81596 0 0.0
.data 1800 1800 0 0.0
.text 599888 599888 0 0.0
linux all-clusters-app debug (read only) 1907689 1907689 0 0.0
(read/write) 128896 128896 0 0.0
.bss 54032 54032 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 68192 68192 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 156277 156277 0 0.0
.text 1605570 1605570 0 0.0
bridge-app debug+rpc (read only) 1456485 1456485 0 0.0
(read/write) 75088 75088 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31824 31824 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123932 123932 0 0.0
.text 1227173 1227173 0 0.0
chip-tool debug (read only) 6687597 6687597 0 0.0
(read/write) 201728 201728 0 0.0
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160376 160376 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335721 335721 0 0.0
.text 5942613 5942613 0 0.0
lighting-app debug+rpc (read only) 1742289 1742289 0 0.0
(read/write) 108152 108152 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59344 59344 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144529 144529 0 0.0
.text 1454610 1454610 0 0.0
ota-provider-app debug (read only) 1411953 1411953 0 0.0
(read/write) 73096 73096 0 0.0
.bss 38976 38976 0 0.0
.data 928 928 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 125086 125086 0 0.0
.text 1181794 1181794 0 0.0
ota-requestor-app debug (read only) 1516705 1516705 0 0.0
(read/write) 78144 78144 0 0.0
.bss 42144 42144 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29784 29784 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137807 137807 0 0.0
.text 1269922 1269922 0 0.0
shell debug (read only) 827345 827345 0 0.0
(read/write) 60640 60640 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39032 39032 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85714 85714 0 0.0
.text 634530 634530 0 0.0
tv-app debug (read only) 2056201 2056201 0 0.0
(read/write) 320504 320504 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64432 64432 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176828 176828 0 0.0
.text 1724178 1724178 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896707 896707 0 0.0
bss 113724 113724 0 0.0
rodata 100308 100308 0 0.0
text 607112 607112 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 859643 859643 0 0.0
bss 110072 110072 0 0.0
rodata 91500 91500 0 0.0
text 581848 581848 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822638 822638 0 0.0
bss 115100 115100 0 0.0
rodata 95568 95568 0 0.0
text 537480 537480 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869275 869275 0 0.0
bss 110988 110988 0 0.0
rodata 96428 96428 0 0.0
text 586468 586468 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795458 795458 0 0.0
bss 112396 112396 0 0.0
rodata 91716 91716 0 0.0
text 516932 516932 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874027 874027 0 0.0
bss 110900 110900 0 0.0
rodata 97780 97780 0 0.0
text 589884 589884 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867235 867235 0 0.0
bss 110776 110776 0 0.0
rodata 95916 95916 0 0.0
text 585092 585092 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781643 781643 0 0.0
bss 109552 109552 0 0.0
rodata 74296 74296 0 0.0
text 523284 523284 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696718 696718 0 0.0
bss 110532 110532 0 0.0
rodata 68936 68936 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2353392 2353392 0 0.0
.bss 110668 110668 0 0.0
.data 2520 2520 0 0.0
.heap 920152 920152 0 0.0
.text 1311656 1311656 0 0.0
light-app default (read/write) 2284536 2284536 0 0.0
.bss 98440 98440 0 0.0
.data 2336 2336 0 0.0
.heap 932568 932568 0 0.0
.text 1242800 1242800 0 0.0
lock-app default (read/write) 2260688 2260688 0 0.0
.bss 97320 97320 0 0.0
.data 2296 2296 0 0.0
.heap 933728 933728 0 0.0
.text 1218952 1218952 0 0.0
qpg lighting-app qpg6100+debug (read only) 514144 514144 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80168 80168 0 0.0
.data 964 964 0 0.0
.text 508824 508824 0 0.0
lock-app qpg6100+debug (read only) 488448 488448 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79304 79304 0 0.0
.data 920 920 0 0.0
.text 483128 483128 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799870 799870 0 0.0
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 559130 559130 0 0.0

@yyzhong-g yyzhong-g mentioned this pull request Dec 13, 2021
Merged
@andy31415 andy31415 deleted the fix_esp32_build_tracing branch June 14, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
examples hotfix urgent fix needed, can bypass review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy31415