Add access control check to IM read, write, invoke #12645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Access control check still not "enabled" - Subject descriptor not hooked up - Request privilege still default (not custom) - Check not necessarily in spec-required sequence (but OK for now) - Status always returned (not omitted for denied wildcard interactions)
get actual subject descriptorconnectedhomeip/src/app/CommandHandler.cpp Lines 252 to 262 in 0373b3b This comment was generated by todo based on a
|
get actual request privilegeconnectedhomeip/src/app/CommandHandler.cpp Lines 254 to 264 in 0373b3b This comment was generated by todo based on a
|
get actual subject descriptorconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 277 to 287 in 0373b3b This comment was generated by todo based on a
|
get actual request privilegeconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 279 to 289 in 0373b3b This comment was generated by todo based on a
|
get actual subject descriptorconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 749 to 759 in 0373b3b This comment was generated by todo based on a
|
get actual request privilegeconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 751 to 761 in 0373b3b This comment was generated by todo based on a
|
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
msandstedt,
mspang and
pan-apple
woody-apple
approved these changes
Dec 7, 2021
bzbarsky-apple
requested changes
Dec 7, 2021
- still not "enabled" - still not checking for events (will add later) - removed check for read with attribute override (will add later) - ensured checks for read, write, invoke are in correct stage - ensured works for wildcard reads (when they are ready)
remove overrideconnectedhomeip/src/app/CommandHandler.cpp Lines 255 to 265 in 8c68a22 This comment was generated by todo based on a
|
when wildcard/group invokes are supported, handle them to discard rather than fail with statusconnectedhomeip/src/app/CommandHandler.cpp Lines 259 to 266 in 8c68a22 This comment was generated by todo based on a
|
get actual expanded flagconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 346 to 356 in 8c68a22 This comment was generated by todo based on a
|
remove overrideconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 348 to 358 in 8c68a22 This comment was generated by todo based on a
|
remove overrideconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 751 to 761 in 8c68a22 This comment was generated by todo based on a
|
when wildcard/group writes are supported, handle them to discard rather than fail with statusconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 755 to 762 in 8c68a22 This comment was generated by todo based on a
|
|
PR #12645: Size comparison from a7dd25e to 8c68a22 Increases above 0.2%:
Increases (11 builds for efr32, linux, p6, qpg, telink)
Decreases (4 builds for p6, qpg)
Full report (12 builds for efr32, linux, p6, qpg, telink)
|
|
PR #12645: Size comparison from e4f3246 to c06a867 Increases above 0.2%:
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (5 builds for mbed, p6, qpg)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 9, 2021
- move attribute read check back up - respond with status if access control has serious error during command handling
|
PR #12645: Size comparison from 5bb8377 to a0dafee Increases above 0.2%:
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (5 builds for mbed, p6, qpg)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 9, 2021
|
fast track: pr created by domain owner, has been up for 3 days, has several checkmarks. |
This was referenced Dec 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Access control not consulted during IM interactions (read, write, invoke, events)
Change overview
This PR just adds the access control check in IM interactions,
with handling for when it fails.
Here's what it doesn't do:
Here's what it does do:
(return proper status, silently discard wildcard read denied, etc.)
This PR is one of a series towards
issues #10240, #10241, etc.
Testing