Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Loop::Break/Continue instead of bool in visitor of ForEachActiveO… #12420

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Use Loop::Break/Continue instead of bool in visitor of ForEachActiveO… #12420

merged 1 commit into from
Dec 2, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Dec 1, 2021

Problem

Use a bool to control when to break the loop is not intuitive.

Change overview

  • Use Loop::Break and Loop::Continue instead of bool in visitor of ForEachActiveObject
  • ForEachActiveObject will return Loop::Break or Loop::Finish

Testing

Checked unit-tests

@restyled-io restyled-io bot mentioned this pull request Dec 1, 2021
Closed
@kghost kghost force-pushed the pool-foreach-type branch from ba7d71a to b346e77 Compare December 1, 2021 17:54
@woody-apple
Copy link
Contributor

Fast tracking given this is just renaming.

@github-actions
Copy link

github-actions bot commented Dec 1, 2021 •
edited
Loading

PR #12420: Size comparison from 31156c4 to b346e77

Increases (3 builds for esp32, telink)
platform target config section 31156c4 b346e77 change % change
esp32 all-clusters-app c3devkit (read only) 837356 837366 10 0.0
.flash.text 837356 837366 10 0.0
m5stack (read only) 908839 908843 4 0.0
.flash.text 903455 903459 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 778686 778694 8 0.0
text 541466 541474 8 0.0
Decreases (16 builds for efr32, k32w, linux, nrfconnect, p6, qpg)
platform target config section 31156c4 b346e77 change % change
efr32 lighting-app BRD4161A (read only) 763312 763296 -16 -0.0
.text 763304 763288 -16 -0.0
window-app BRD4161A (read only) 740280 740264 -16 -0.0
.text 740272 740256 -16 -0.0
k32w lock-app k32w061+debug (read/write) 613524 613508 -16 -0.0
.text 536708 536692 -16 -0.0
linux tv-app debug (read only) 1927281 1927265 -16 -0.0
.text 1617298 1617282 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 590764 590760 -4 -0.0
nrf52840dk_nrf52840+rpc text 564932 564928 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801842 801826 -16 -0.0
text 520220 520216 -4 -0.0
lock-app nrf52840dk_nrf52840 text 569012 569008 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772906 772890 -16 -0.0
text 498560 498556 -4 -0.0
pump-app nrf52840dk_nrf52840 text 573080 573076 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 text 568140 568136 -4 -0.0
shell nrf52840dk_nrf52840 text 521888 521884 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694274 694258 -16 -0.0
text 442496 442492 -4 -0.0
p6 all-clusters-app default (read/write) 2318040 2318024 -16 -0.0
.text 1276304 1276288 -16 -0.0
qpg lighting-app qpg6100+debug (read only) 496884 496876 -8 -0.0
.text 491564 491556 -8 -0.0
lock-app qpg6100+debug (read only) 469480 469472 -8 -0.0
.text 464160 464152 -8 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 31156c4 b346e77 change % change
efr32 lighting-app BRD4161A (read only) 763312 763296 -16 -0.0
(read/write) 119972 119972 0 0.0
.bss 118164 118164 0 0.0
.data 1808 1808 0 0.0
.text 763304 763288 -16 -0.0
BRD4161A+rpc (read only) 791800 791800 0 0.0
(read/write) 138276 138276 0 0.0
.bss 136364 136364 0 0.0
.data 1908 1908 0 0.0
.text 791792 791792 0 0.0
lock-app BRD4161A (read only) 737176 737176 0 0.0
(read/write) 117684 117684 0 0.0
.bss 115916 115916 0 0.0
.data 1764 1764 0 0.0
.text 737168 737168 0 0.0
window-app BRD4161A (read only) 740280 740264 -16 -0.0
(read/write) 118116 118116 0 0.0
.bss 116340 116340 0 0.0
.data 1772 1772 0 0.0
.text 740272 740256 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 837356 837366 10 0.0
(read/write) 1224050 1224050 0 0.0
.dram0.bss 58528 58528 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166248 166248 0 0.0
.flash.text 837356 837366 10 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 908839 908843 4 0.0
(read/write) 423308 423308 0 0.0
.dram0.bss 63928 63928 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194100 194100 0 0.0
.flash.text 903455 903459 4 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724524 724524 0 0.0
.bss 78772 78772 0 0.0
.data 1840 1840 0 0.0
.text 638112 638112 0 0.0
lock-app k32w061+debug (read/write) 613524 613508 -16 -0.0
.bss 69212 69212 0 0.0
.data 1804 1804 0 0.0
.text 536708 536692 -16 -0.0
shell k32w061+debug (read/write) 679304 679304 0 0.0
.bss 80796 80796 0 0.0
.data 1776 1776 0 0.0
.text 590932 590932 0 0.0
linux all-clusters-app debug (read only) 1781513 1781513 0 0.0
(read/write) 125192 125192 0 0.0
.bss 53072 53072 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 65728 65728 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139797 139797 0 0.0
.text 1502098 1502098 0 0.0
bridge-app debug+rpc (read only) 1352565 1352565 0 0.0
(read/write) 71312 71312 0 0.0
.bss 35120 35120 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29488 29488 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 113820 113820 0 0.0
.text 1138533 1138533 0 0.0
chip-tool debug (read only) 6272725 6272725 0 0.0
(read/write) 197904 197904 0 0.0
.bss 33448 33448 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 157880 157880 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 295624 295624 0 0.0
.text 5574133 5574133 0 0.0
lighting-app debug+rpc (read only) 1632633 1632633 0 0.0
(read/write) 104400 104400 0 0.0
.bss 40784 40784 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 57072 57072 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 132273 132273 0 0.0
.text 1362450 1362450 0 0.0
ota-provider-app debug (read only) 1313009 1313009 0 0.0
(read/write) 69768 69768 0 0.0
.bss 37696 37696 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 115024 115024 0 0.0
.text 1097538 1097538 0 0.0
ota-requestor-app debug (read only) 1412993 1412993 0 0.0
(read/write) 73664 73664 0 0.0
.bss 39808 39808 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 126848 126848 0 0.0
.text 1182258 1182258 0 0.0
shell debug (read only) 808969 808969 0 0.0
(read/write) 60104 60104 0 0.0
.bss 16872 16872 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38528 38528 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 79794 79794 0 0.0
.text 623474 623474 0 0.0
tv-app debug (read only) 1927281 1927265 -16 -0.0
(read/write) 314032 314032 0 0.0
.bss 245176 245176 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61696 61696 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 161448 161448 0 0.0
.text 1617298 1617282 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296632 2296632 0 0.0
.bss 181612 181612 0 0.0
.data 5168 5168 0 0.0
.heap 849664 849664 0 0.0
.text 1259232 1259232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281312 2281312 0 0.0
.bss 172636 172636 0 0.0
.data 5480 5480 0 0.0
.heap 858328 858328 0 0.0
.text 1243912 1243912 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254344 2254344 0 0.0
.bss 171452 171452 0 0.0
.data 5464 5464 0 0.0
.heap 859528 859528 0 0.0
.text 1216944 1216944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2045928 2045928 0 0.0
.bss 156624 156624 0 0.0
.data 4864 4864 0 0.0
.heap 874960 874960 0 0.0
.text 1008528 1008528 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876807 876807 0 0.0
bss 113136 113136 0 0.0
rodata 97368 97368 0 0.0
text 590764 590760 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 839255 839255 0 0.0
bss 109488 109488 0 0.0
rodata 88632 88632 0 0.0
text 564932 564928 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801842 801826 -16 -0.0
bss 114512 114512 0 0.0
rodata 92628 92628 0 0.0
text 520220 520216 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 847635 847635 0 0.0
bss 110176 110176 0 0.0
rodata 93108 93108 0 0.0
text 569012 569008 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772906 772890 -16 -0.0
bss 111584 111584 0 0.0
rodata 88396 88396 0 0.0
text 498560 498556 -4 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853679 853679 0 0.0
bss 110312 110312 0 0.0
rodata 94840 94840 0 0.0
text 573080 573076 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846743 846743 0 0.0
bss 110188 110188 0 0.0
rodata 92976 92976 0 0.0
text 568140 568136 -4 -0.0
shell nrf52840dk_nrf52840 (read/write) 779227 779227 0 0.0
bss 109616 109616 0 0.0
rodata 73216 73216 0 0.0
text 521888 521884 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694274 694258 -16 -0.0
bss 110600 110600 0 0.0
rodata 67860 67860 0 0.0
text 442496 442492 -4 -0.0
p6 all-clusters-app default (read/write) 2318040 2318024 -16 -0.0
.bss 109688 109688 0 0.0
.data 2456 2456 0 0.0
.heap 921200 921200 0 0.0
.text 1276304 1276288 -16 -0.0
light-app default (read/write) 2253768 2253768 0 0.0
.bss 97752 97752 0 0.0
.data 2320 2320 0 0.0
.heap 933272 933272 0 0.0
.text 1212032 1212032 0 0.0
lock-app default (read/write) 2229128 2229128 0 0.0
.bss 96408 96408 0 0.0
.data 2280 2280 0 0.0
.heap 934656 934656 0 0.0
.text 1187392 1187392 0 0.0
qpg lighting-app qpg6100+debug (read only) 496884 496876 -8 -0.0
(read/write) 114140 114140 0 0.0
.bss 79656 79656 0 0.0
.data 940 940 0 0.0
.text 491564 491556 -8 -0.0
lock-app qpg6100+debug (read only) 469480 469472 -8 -0.0
(read/write) 114140 114140 0 0.0
.bss 78568 78568 0 0.0
.data 892 892 0 0.0
.text 464160 464152 -8 -0.0
persistent-storage-app qpg6100+debug (read only) 108020 108020 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36688 36688 0 0.0
.data 292 292 0 0.0
.text 102700 102700 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778686 778694 8 0.0
bss 79716 79716 0 0.0
noinit 37160 37160 0 0.0
text 541466 541474 8 0.0

@kghost kghost force-pushed the pool-foreach-type branch from b346e77 to 9f298b5 Compare December 2, 2021 07:30
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12420: Size comparison from 4ec0e4e to 9f298b5

Increases (3 builds for esp32, linux, telink)
platform target config section 4ec0e4e 9f298b5 change % change
esp32 all-clusters-app c3devkit (read only) 838886 838896 10 0.0
.flash.text 838886 838896 10 0.0
linux lighting-app debug+rpc (read only) 1650393 1650409 16 0.0
.text 1373330 1373346 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 782450 782458 8 0.0
text 543752 543760 8 0.0
Decreases (6 builds for efr32, k32w, p6, qpg)
platform target config section 4ec0e4e 9f298b5 change % change
efr32 lock-app BRD4161A (read only) 703636 703620 -16 -0.0
.text 703628 703612 -16 -0.0
window-app BRD4161A (read only) 706732 706716 -16 -0.0
.text 706724 706708 -16 -0.0
k32w lock-app k32w061+debug (read/write) 616644 616628 -16 -0.0
.text 539584 539568 -16 -0.0
p6 light-app default (read/write) 2256336 2256320 -16 -0.0
.text 1214600 1214584 -16 -0.0
qpg lighting-app qpg6100+debug (read only) 499644 499636 -8 -0.0
.text 494324 494316 -8 -0.0
lock-app qpg6100+debug (read only) 472456 472448 -8 -0.0
.text 467136 467128 -8 -0.0
Full report (29 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 4ec0e4e 9f298b5 change % change
efr32 lighting-app BRD4161A (read only) 729760 729760 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 729752 729752 0 0.0
BRD4161A+rpc (read only) 758400 758400 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758392 758392 0 0.0
lock-app BRD4161A (read only) 703636 703620 -16 -0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703628 703612 -16 -0.0
window-app BRD4161A (read only) 706732 706716 -16 -0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 706724 706708 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 838886 838896 10 0.0
(read/write) 1225018 1225018 0 0.0
.dram0.bss 58824 58824 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166912 166912 0 0.0
.flash.text 838886 838896 10 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910603 910603 0 0.0
(read/write) 424248 424248 0 0.0
.dram0.bss 64224 64224 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194744 194744 0 0.0
.flash.text 905219 905219 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727656 727656 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641000 641000 0 0.0
lock-app k32w061+debug (read/write) 616644 616628 -16 -0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539584 539568 -16 -0.0
shell k32w061+debug (read/write) 682532 682532 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 593844 593844 0 0.0
linux all-clusters-app debug (read only) 1796361 1796361 0 0.0
(read/write) 125992 125992 0 0.0
.bss 53456 53456 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145781 145781 0 0.0
.text 1510242 1510242 0 0.0
bridge-app debug+rpc (read only) 1366581 1366581 0 0.0
(read/write) 71920 71920 0 0.0
.bss 35440 35440 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118732 118732 0 0.0
.text 1147013 1147013 0 0.0
chip-tool debug (read only) 6527581 6527581 0 0.0
(read/write) 199760 199760 0 0.0
.bss 33736 33736 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 159432 159432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304856 304856 0 0.0
.text 5816117 5816117 0 0.0
lighting-app debug+rpc (read only) 1650393 1650409 16 0.0
(read/write) 105008 105008 0 0.0
.bss 41136 41136 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138481 138481 0 0.0
.text 1373330 1373346 16 0.0
ota-provider-app debug (read only) 1327177 1327177 0 0.0
(read/write) 70376 70376 0 0.0
.bss 38016 38016 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120168 120168 0 0.0
.text 1105938 1105938 0 0.0
ota-requestor-app debug (read only) 1427233 1427233 0 0.0
(read/write) 74272 74272 0 0.0
.bss 40128 40128 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132112 132112 0 0.0
.text 1190610 1190610 0 0.0
shell debug (read only) 812841 812841 0 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623250 0 0.0
tv-app debug (read only) 1944113 1944113 0 0.0
(read/write) 314640 314640 0 0.0
.bss 245496 245496 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168584 168584 0 0.0
.text 1626370 1626370 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299296 2299296 0 0.0
.bss 181892 181892 0 0.0
.data 5168 5168 0 0.0
.heap 849384 849384 0 0.0
.text 1261896 1261896 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284088 2284088 0 0.0
.bss 172896 172896 0 0.0
.data 5480 5480 0 0.0
.heap 858072 858072 0 0.0
.text 1246688 1246688 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257120 2257120 0 0.0
.bss 171712 171712 0 0.0
.data 5480 5480 0 0.0
.heap 859256 859256 0 0.0
.text 1219720 1219720 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4864 0 0.0
.heap 874880 874880 0 0.0
.text 1009176 1009176 0 0.0
p6 all-clusters-app default (read/write) 2320536 2320536 0 0.0
.bss 110072 110072 0 0.0
.data 2464 2464 0 0.0
.heap 920808 920808 0 0.0
.text 1278800 1278800 0 0.0
light-app default (read/write) 2256336 2256320 -16 -0.0
.bss 98112 98112 0 0.0
.data 2328 2328 0 0.0
.heap 932904 932904 0 0.0
.text 1214600 1214584 -16 -0.0
lock-app default (read/write) 2231680 2231680 0 0.0
.bss 96768 96768 0 0.0
.data 2288 2288 0 0.0
.heap 934288 934288 0 0.0
.text 1189944 1189944 0 0.0
qpg lighting-app qpg6100+debug (read only) 499644 499636 -8 -0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494324 494316 -8 -0.0
lock-app qpg6100+debug (read only) 472456 472448 -8 -0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467136 467128 -8 -0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782450 782458 8 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543752 543760 8 0.0

@kghost kghost force-pushed the pool-foreach-type branch from 9f298b5 to c160672 Compare December 2, 2021 13:56
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12420: Size comparison from dc10c82 to c160672

Increases (3 builds for esp32, linux, telink)
platform target config section dc10c823 c160672 change % change
esp32 all-clusters-app c3devkit (read only) 839114 839124 10 0.0
.flash.text 839114 839124 10 0.0
linux lighting-app debug+rpc (read only) 1651097 1651113 16 0.0
.text 1373906 1373922 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782742 8 0.0
text 543976 543984 8 0.0
Decreases (14 builds for efr32, k32w, nrfconnect, p6)
platform target config section dc10c823 c160672 change % change
efr32 lighting-app BRD4161A (read only) 730064 730048 -16 -0.0
.text 730056 730040 -16 -0.0
BRD4161A+rpc (read only) 758704 758688 -16 -0.0
.text 758696 758680 -16 -0.0
k32w lock-app k32w061+debug (read/write) 616916 616900 -16 -0.0
.text 539856 539840 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 593036 593028 -8 -0.0
nrf52840dk_nrf52840+rpc text 568032 568024 -8 -0.0
nrf5340dk_nrf5340_cpuapp text 523376 523368 -8 -0.0
lock-app nrf52840dk_nrf52840 text 571288 571280 -8 -0.0
nrf5340dk_nrf5340_cpuapp text 501720 501712 -8 -0.0
pump-app nrf52840dk_nrf52840 text 575356 575348 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 850459 850443 -16 -0.0
text 570416 570408 -8 -0.0
shell nrf52840dk_nrf52840 text 521924 521916 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694930 -16 -0.0
text 442528 442520 -8 -0.0
p6 all-clusters-app default (read/write) 2320840 2320824 -16 -0.0
.text 1279104 1279088 -16 -0.0
lock-app default (read/write) 2231984 2231968 -16 -0.0
.text 1190248 1190232 -16 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section dc10c823 c160672 change % change
efr32 lighting-app BRD4161A (read only) 730064 730048 -16 -0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730056 730040 -16 -0.0
BRD4161A+rpc (read only) 758704 758688 -16 -0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758696 758680 -16 -0.0
lock-app BRD4161A (read only) 703924 703924 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703916 703916 0 0.0
window-app BRD4161A (read only) 707020 707020 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 707012 707012 0 0.0
esp32 all-clusters-app c3devkit (read only) 839114 839124 10 0.0
(read/write) 1225090 1225090 0 0.0
.dram0.bss 58824 58824 0 0.0
.dram0.data 14036 14036 0 0.0
.flash.rodata 166968 166968 0 0.0
.flash.text 839114 839124 10 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910791 910791 0 0.0
(read/write) 424312 424312 0 0.0
.dram0.bss 64224 64224 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194808 194808 0 0.0
.flash.text 905407 905407 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727928 727928 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641272 641272 0 0.0
lock-app k32w061+debug (read/write) 616916 616900 -16 -0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539856 539840 -16 -0.0
shell k32w061+debug (read/write) 682804 682804 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 594116 594116 0 0.0
linux all-clusters-app debug (read only) 1797065 1797065 0 0.0
(read/write) 125992 125992 0 0.0
.bss 53456 53456 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145909 0 0.0
.text 1510818 1510818 0 0.0
bridge-app debug+rpc (read only) 1367285 1367285 0 0.0
(read/write) 71920 71920 0 0.0
.bss 35440 35440 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147589 1147589 0 0.0
chip-tool debug (read only) 6528285 6528285 0 0.0
(read/write) 199760 199760 0 0.0
.bss 33736 33736 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 159432 159432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 304984 0 0.0
.text 5816693 5816693 0 0.0
lighting-app debug+rpc (read only) 1651097 1651113 16 0.0
(read/write) 105008 105008 0 0.0
.bss 41136 41136 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373906 1373922 16 0.0
ota-provider-app debug (read only) 1327881 1327881 0 0.0
(read/write) 70376 70376 0 0.0
.bss 38016 38016 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106514 1106514 0 0.0
ota-requestor-app debug (read only) 1427937 1427937 0 0.0
(read/write) 74272 74272 0 0.0
.bss 40128 40128 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191186 1191186 0 0.0
shell debug (read only) 812841 812841 0 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623250 0 0.0
tv-app debug (read only) 1944817 1944817 0 0.0
(read/write) 314640 314640 0 0.0
.bss 245496 245496 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168712 168712 0 0.0
.text 1626946 1626946 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299376 2299376 0 0.0
.bss 181892 181892 0 0.0
.data 5168 5168 0 0.0
.heap 849384 849384 0 0.0
.text 1261976 1261976 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284104 2284104 0 0.0
.bss 172896 172896 0 0.0
.data 5480 5480 0 0.0
.heap 858072 858072 0 0.0
.text 1246704 1246704 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257200 2257200 0 0.0
.bss 171712 171712 0 0.0
.data 5480 5480 0 0.0
.heap 859256 859256 0 0.0
.text 1219800 1219800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4864 0 0.0
.heap 874880 874880 0 0.0
.text 1009176 1009176 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 880507 880507 0 0.0
bss 113396 113396 0 0.0
rodata 98540 98540 0 0.0
text 593036 593028 -8 -0.0
nrf52840dk_nrf52840+rpc (read/write) 843883 843883 0 0.0
bss 109744 109744 0 0.0
rodata 89900 89900 0 0.0
text 568032 568024 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806422 806422 0 0.0
bss 114768 114768 0 0.0
rodata 93800 93800 0 0.0
text 523376 523368 -8 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 851335 851335 0 0.0
bss 110432 110432 0 0.0
rodata 94280 94280 0 0.0
text 571288 571280 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 777518 777518 0 0.0
bss 111844 111844 0 0.0
rodata 89568 89568 0 0.0
text 501720 501712 -8 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 857379 857379 0 0.0
bss 110568 110568 0 0.0
rodata 96012 96012 0 0.0
text 575356 575348 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 850459 850443 -16 -0.0
bss 110448 110448 0 0.0
rodata 94148 94148 0 0.0
text 570416 570408 -8 -0.0
shell nrf52840dk_nrf52840 (read/write) 779903 779903 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521924 521916 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694930 -16 -0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442528 442520 -8 -0.0
p6 all-clusters-app default (read/write) 2320840 2320824 -16 -0.0
.bss 110072 110072 0 0.0
.data 2464 2464 0 0.0
.heap 920808 920808 0 0.0
.text 1279104 1279088 -16 -0.0
light-app default (read/write) 2256624 2256624 0 0.0
.bss 98112 98112 0 0.0
.data 2328 2328 0 0.0
.heap 932904 932904 0 0.0
.text 1214888 1214888 0 0.0
lock-app default (read/write) 2231984 2231968 -16 -0.0
.bss 96768 96768 0 0.0
.data 2288 2288 0 0.0
.heap 934288 934288 0 0.0
.text 1190248 1190232 -16 -0.0
qpg lighting-app qpg6100+debug (read only) 499800 499800 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494480 494480 0 0.0
lock-app qpg6100+debug (read only) 472612 472612 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467292 467292 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782742 8 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543984 8 0.0

@kghost kghost merged commit e2e4c17 into project-chip:master Dec 2, 2021
@kghost kghost deleted the pool-foreach-type branch December 2, 2021 17:15
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Dec 2, 2021
@kpschoedel
Fix build conflict
a68d25c 
#### Problem

bf383b3 project-chip#11937 landed with a form
changed a few minutes earlier by e2e4c17 project-chip#12420

#### Change overview

Fix return values.

#### Testing

Build & CI
@kpschoedel kpschoedel mentioned this pull request Dec 2, 2021
Merged
@vivien-apple vivien-apple mentioned this pull request Dec 2, 2021
Closed
woody-apple pushed a commit that referenced this pull request Dec 2, 2021
@kpschoedel
Fix build conflict (#12487)
d402781 
#### Problem

bf383b3 #11937 landed with a form
changed a few minutes earlier by e2e4c17 #12420

#### Change overview

Fix return values.

#### Testing

Build & CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpschoedel kpschoedel kpschoedel approved these changes

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller fast track inet lib review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kghost @woody-apple @andy31415 @msandstedt @kpschoedel