Add support for CASE session caching for session resume use cases #11937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement this based on peer idconnectedhomeip/src/protocols/secure_channel/CASESessionCache.cpp Lines 104 to 108 in 61d02d8 This comment was generated by todo based on a
|
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic and
turon
nivi-apple
force-pushed
the
case_session_cache_rebased
branch
from
bbd68f5 to
1ba061e
Compare
|
PR #11937: Size comparison from 489de97 to 1ba061e Increases (5 builds for mbed, p6)
Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
@nivi-apple @tcarmelveilleux How do we make progress here? Looks like this has been stuck in review for a while, should we have a breakout? |
|
/rebase |
woody-apple
approved these changes
Nov 30, 2021
nivi-apple
force-pushed
the
case_session_cache_rebased
branch
2 times, most recently
from
203cc71 to
dfb4740
Compare
pan-apple
approved these changes
Nov 30, 2021
|
/rebase |
- Add tests for the CASE session cache - Update the CASESessionCachable struct to have only necessary members and rename the struct and APIs appropriately - Remove the tests that serilaize and deserilaize the CASE Session as its outdated
woody-apple
force-pushed
the
case_session_cache_rebased
branch
from
dfb4740 to
7304eaa
Compare
|
PR #11937: Size comparison from 2072f8e to 7304eaa Increases (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (13 builds for linux, mbed, p6)
Full report (37 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
dismissed
tcarmelveilleux’s stale review
Comments appear resolved.
|
Fast tracking given this is 3 days without comment. |
This was referenced Dec 2, 2021
Closed
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Dec 2, 2021
#### Problem bf383b3 project-chip#11937 landed with a form changed a few minutes earlier by e2e4c17 project-chip#12420 #### Change overview Fix return values. #### Testing Build & CI
Merged
woody-apple
pushed a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Add support for a CASE session cache pool and API's for adding, removing and getting the sessions
Testing
How was this tested? (at least one bullet point required)
*Unit tests were added to test the cache features and APIs