Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IM event processing function and callback interface in client side #11615

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Add IM event processing function and callback interface in client side #11615

merged 1 commit into from
Nov 17, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Nov 10, 2021 •
edited
Loading

Problem

Add IM event processing function and callback interface in client side
Add function to generate EventHeader
Add ConcreteEventPath and EventHeader struct
(Note: currently ClusterObject integration with event in server is not ready, so we don't have E2E test with clusterOjbect on Event)

Change overview

See above

Testing

Update the test to test new OnEventData

@boring-cyborg boring-cyborg bot added the lib label Nov 12, 2021
@yunhanw-google yunhanw-google force-pushed the feature/add_event_processing branch from e83c42a to 25b76b6 Compare November 12, 2021 23:53
@github-actions
Copy link

github-actions bot commented Nov 13, 2021 •
edited
Loading

PR #11615: Size comparison from 507ba15 to 25b76b6

Increases above 0.2%:

platform target config section 507ba15 25b76b6 change % change
linux all-clusters-app debug (read only) 1722337 1727793 5456 0.3
.text 1447842 1453234 5392 0.4
bridge-app debug+rpc (read only) 1312741 1318197 5456 0.4
.text 1103909 1109301 5392 0.5
lighting-app debug+rpc (read only) 1582281 1587737 5456 0.3
.text 1317746 1323138 5392 0.4
ota-provider-app debug (read only) 1267337 1272761 5424 0.4
.text 1057106 1062498 5392 0.5
ota-requestor-app debug (read only) 1352009 1357433 5424 0.4
.text 1128402 1133794 5392 0.5
tv-app debug (read only) 1858569 1864009 5440 0.3
.text 1556418 1561826 5408 0.3
Increases (25 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 507ba15 25b76b6 change % change
efr32 lighting-app BRD4161A (read only) 750088 751000 912 0.1
(read/write) 115940 116004 64 0.1
.bss 114140 114204 64 0.1
.text 750080 750992 912 0.1
BRD4161A+rpc (read only) 737636 738548 912 0.1
(read/write) 132568 132632 64 0.0
.bss 130644 130708 64 0.0
.text 737628 738540 912 0.1
lock-app BRD4161A (read only) 726752 727664 912 0.1
(read/write) 113724 113788 64 0.1
.bss 111964 112028 64 0.1
.text 726744 727656 912 0.1
window-app BRD4161A (read only) 727744 728640 896 0.1
(read/write) 114044 114108 64 0.1
.bss 112284 112348 64 0.1
.text 727736 728632 896 0.1
esp32 all-clusters-app c3devkit (read only) 826956 827702 746 0.1
(read/write) 1224466 1224530 64 0.0
.dram0.bss 57088 57152 64 0.1
.flash.text 826956 827702 746 0.1
m5stack (read only) 897631 898415 784 0.1
(read/write) 422624 422688 64 0.0
.dram0.bss 62184 62248 64 0.1
.flash.text 892247 893031 784 0.1
k32w lighting-app k32w061+se05x+release (read/write) 702540 703228 688 0.1
.bss 77508 77572 64 0.1
.text 617324 617948 624 0.1
lock-app k32w061+debug (read/write) 593548 594252 704 0.1
.bss 68028 68092 64 0.1
.text 517844 518484 640 0.1
shell k32w061+debug (read/write) 659232 659920 688 0.1
.bss 78820 78884 64 0.1
.text 572768 573392 624 0.1
linux all-clusters-app debug (read only) 1722337 1727793 5456 0.3
(read/write) 126816 126880 64 0.1
.bss 57776 57840 64 0.1
.rodata 140277 140341 64 0.0
.text 1447842 1453234 5392 0.4
bridge-app debug+rpc (read only) 1312741 1318197 5456 0.4
(read/write) 77424 77488 64 0.1
.bss 42896 42960 64 0.1
.rodata 111860 111924 64 0.1
.text 1103909 1109301 5392 0.5
chip-tool debug (read only) 4921493 4926933 5440 0.1
(read/write) 167208 167272 64 0.0
.bss 41192 41256 64 0.2
.rodata 268242 268274 32 0.0
.text 4343605 4349013 5408 0.1
lighting-app debug+rpc (read only) 1582281 1587737 5456 0.3
(read/write) 110192 110256 64 0.1
.bss 48080 48144 64 0.1
.rodata 129841 129905 64 0.0
.text 1317746 1323138 5392 0.4
ota-provider-app debug (read only) 1267337 1272761 5424 0.4
(read/write) 75176 75240 64 0.1
.bss 44512 44576 64 0.1
.rodata 113383 113415 32 0.0
.text 1057106 1062498 5392 0.5
ota-requestor-app debug (read only) 1352009 1357433 5424 0.4
(read/write) 78944 79008 64 0.1
.bss 46976 47040 64 0.1
.rodata 124208 124240 32 0.0
.text 1128402 1133794 5392 0.5
shell debug (read only) 789081 789161 80 0.0
.rodata 77903 77967 64 0.1
.text 609282 609298 16 0.0
tv-app debug (read only) 1858569 1864009 5440 0.3
(read/write) 407896 407960 64 0.0
.bss 339752 339816 64 0.0
.rodata 157069 157101 32 0.0
.text 1556418 1561826 5408 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292200 2292968 768 0.0
.bss 179692 179756 64 0.0
.text 1254800 1255568 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274688 2275392 704 0.0
.bss 172556 172620 64 0.0
.text 1237288 1237992 704 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2250128 2250832 704 0.0
.bss 171436 171500 64 0.0
.text 1212728 1213432 704 0.1
p6 all-clusters-app default (read/write) 2301232 2302128 896 0.0
.bss 112680 112744 64 0.1
.text 1259496 1260392 896 0.1
lock-app default (read/write) 2214704 2215616 912 0.0
.bss 101296 101360 64 0.1
.text 1172968 1173880 912 0.1
qpg lighting-app qpg6100+debug (read only) 494216 494864 648 0.1
.bss 50640 50672 32 0.1
.text 488896 489544 648 0.1
lock-app qpg6100+debug (read only) 468752 469400 648 0.1
.bss 49576 49608 32 0.1
.text 463432 464080 648 0.1
telink lighting-app tlsr9518adk80d (read/write) 667854 668638 784 0.1
bss 69320 69384 64 0.1
text 462372 463094 722 0.2
Decreases (5 builds for mbed, p6)
platform target config section 507ba15 25b76b6 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851536 851472 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858312 858248 -64 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859440 859376 -64 -0.0
p6 all-clusters-app default .heap 918144 918080 -64 -0.0
lock-app default .heap 929648 929584 -64 -0.0
Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 507ba15 25b76b6 change % change
efr32 lighting-app BRD4161A (read only) 750088 751000 912 0.1
(read/write) 115940 116004 64 0.1
.bss 114140 114204 64 0.1
.data 1800 1800 0 0.0
.text 750080 750992 912 0.1
BRD4161A+rpc (read only) 737636 738548 912 0.1
(read/write) 132568 132632 64 0.0
.bss 130644 130708 64 0.0
.data 1924 1924 0 0.0
.text 737628 738540 912 0.1
lock-app BRD4161A (read only) 726752 727664 912 0.1
(read/write) 113724 113788 64 0.1
.bss 111964 112028 64 0.1
.data 1756 1756 0 0.0
.text 726744 727656 912 0.1
window-app BRD4161A (read only) 727744 728640 896 0.1
(read/write) 114044 114108 64 0.1
.bss 112284 112348 64 0.1
.data 1760 1760 0 0.0
.text 727736 728632 896 0.1
esp32 all-clusters-app c3devkit (read only) 826956 827702 746 0.1
(read/write) 1224466 1224530 64 0.0
.dram0.bss 57088 57152 64 0.1
.dram0.data 14092 14092 0 0.0
.flash.rodata 168040 168040 0 0.0
.flash.text 826956 827702 746 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 897631 898415 784 0.1
(read/write) 422624 422688 64 0.0
.dram0.bss 62184 62248 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 195060 195060 0 0.0
.flash.text 892247 893031 784 0.1
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 702540 703228 688 0.1
.bss 77508 77572 64 0.1
.data 1908 1908 0 0.0
.text 617324 617948 624 0.1
lock-app k32w061+debug (read/write) 593548 594252 704 0.1
.bss 68028 68092 64 0.1
.data 1876 1876 0 0.0
.text 517844 518484 640 0.1
shell k32w061+debug (read/write) 659232 659920 688 0.1
.bss 78820 78884 64 0.1
.data 1844 1844 0 0.0
.text 572768 573392 624 0.1
linux all-clusters-app debug (read only) 1722337 1727793 5456 0.3
(read/write) 126816 126880 64 0.1
.bss 57776 57840 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 62720 62720 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 140277 140341 64 0.0
.text 1447842 1453234 5392 0.4
bridge-app debug+rpc (read only) 1312741 1318197 5456 0.4
(read/write) 77424 77488 64 0.1
.bss 42896 42960 64 0.1
.data 1568 1568 0 0.0
.data.rel.ro 27960 27960 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111860 111924 64 0.1
.text 1103909 1109301 5392 0.5
chip-tool debug (read only) 4921493 4926933 5440 0.1
(read/write) 167208 167272 64 0.0
.bss 41192 41256 64 0.2
.data 2272 2272 0 0.0
.data.rel.ro 118256 118256 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268242 268274 32 0.0
.text 4343605 4349013 5408 0.1
lighting-app debug+rpc (read only) 1582281 1587737 5456 0.3
(read/write) 110192 110256 64 0.1
.bss 48080 48144 64 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129841 129905 64 0.0
.text 1317746 1323138 5392 0.4
ota-provider-app debug (read only) 1267337 1272761 5424 0.4
(read/write) 75176 75240 64 0.1
.bss 44512 44576 64 0.1
.data 784 784 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113383 113415 32 0.0
.text 1057106 1062498 5392 0.5
ota-requestor-app debug (read only) 1352009 1357433 5424 0.4
(read/write) 78944 79008 64 0.1
.bss 46976 47040 64 0.1
.data 848 848 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124208 124240 32 0.0
.text 1128402 1133794 5392 0.5
shell debug (read only) 789081 789161 80 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77967 64 0.1
.text 609282 609298 16 0.0
tv-app debug (read only) 1858569 1864009 5440 0.3
(read/write) 407896 407960 64 0.0
.bss 339752 339816 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59696 59696 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157069 157101 32 0.0
.text 1556418 1561826 5408 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292200 2292968 768 0.0
.bss 179692 179756 64 0.0
.data 5216 5216 0 0.0
.heap 851536 851472 -64 -0.0
.text 1254800 1255568 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274688 2275392 704 0.0
.bss 172556 172620 64 0.0
.data 5576 5576 0 0.0
.heap 858312 858248 -64 -0.0
.text 1237288 1237992 704 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250128 2250832 704 0.0
.bss 171436 171500 64 0.0
.data 5568 5568 0 0.0
.heap 859440 859376 -64 -0.0
.text 1212728 1213432 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
p6 all-clusters-app default (read/write) 2301232 2302128 896 0.0
.bss 112680 112744 64 0.1
.data 2520 2520 0 0.0
.heap 918144 918080 -64 -0.0
.text 1259496 1260392 896 0.1
lock-app default (read/write) 2214704 2215616 912 0.0
.bss 101296 101360 64 0.1
.data 2400 2400 0 0.0
.heap 929648 929584 -64 -0.0
.text 1172968 1173880 912 0.1
qpg lighting-app qpg6100+debug (read only) 494216 494864 648 0.1
(read/write) 114144 114144 0 0.0
.bss 50640 50672 32 0.1
.data 1008 1008 0 0.0
.text 488896 489544 648 0.1
lock-app qpg6100+debug (read only) 468752 469400 648 0.1
(read/write) 114140 114140 0 0.0
.bss 49576 49608 32 0.1
.data 964 964 0 0.0
.text 463432 464080 648 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 667854 668638 784 0.1
bss 69320 69384 64 0.1
noinit 33216 33216 0 0.0
text 462372 463094 722 0.2

@yunhanw-google yunhanw-google force-pushed the feature/add_event_processing branch from 25b76b6 to c1547ee Compare November 13, 2021 02:24
@github-actions
Copy link

github-actions bot commented Nov 13, 2021 •
edited
Loading

PR #11615: Size comparison from 507ba15 to c1547ee

Increases above 0.2%:

platform target config section 507ba15 c1547ee change % change
linux all-clusters-app debug (read only) 1722337 1727793 5456 0.3
.text 1447842 1453234 5392 0.4
bridge-app debug+rpc (read only) 1312741 1318197 5456 0.4
.text 1103909 1109301 5392 0.5
lighting-app debug+rpc (read only) 1582281 1587737 5456 0.3
.text 1317746 1323138 5392 0.4
ota-provider-app debug (read only) 1267337 1272761 5424 0.4
.text 1057106 1062498 5392 0.5
ota-requestor-app debug (read only) 1352009 1357449 5440 0.4
.text 1128402 1133810 5408 0.5
tv-app debug (read only) 1858569 1864009 5440 0.3
.text 1556418 1561826 5408 0.3
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 507ba15 c1547ee change % change
efr32 lighting-app BRD4161A (read only) 750088 751048 960 0.1
(read/write) 115940 116004 64 0.1
.bss 114140 114204 64 0.1
.text 750080 751040 960 0.1
BRD4161A+rpc (read only) 737636 738596 960 0.1
(read/write) 132568 132632 64 0.0
.bss 130644 130708 64 0.0
.text 737628 738588 960 0.1
lock-app BRD4161A (read only) 726752 727712 960 0.1
(read/write) 113724 113788 64 0.1
.bss 111964 112028 64 0.1
.text 726744 727704 960 0.1
window-app BRD4161A (read only) 727744 728704 960 0.1
(read/write) 114044 114108 64 0.1
.bss 112284 112348 64 0.1
.text 727736 728696 960 0.1
esp32 all-clusters-app c3devkit (read only) 826956 827728 772 0.1
(read/write) 1224466 1224530 64 0.0
.dram0.bss 57088 57152 64 0.1
.flash.text 826956 827728 772 0.1
m5stack (read only) 897631 898431 800 0.1
(read/write) 422624 422688 64 0.0
.dram0.bss 62184 62248 64 0.1
.flash.text 892247 893047 800 0.1
k32w lighting-app k32w061+se05x+release (read/write) 702540 703244 704 0.1
.bss 77508 77572 64 0.1
.text 617324 617964 640 0.1
lock-app k32w061+debug (read/write) 593548 594268 720 0.1
.bss 68028 68092 64 0.1
.text 517844 518500 656 0.1
shell k32w061+debug (read/write) 659232 659936 704 0.1
.bss 78820 78884 64 0.1
.text 572768 573408 640 0.1
linux all-clusters-app debug (read only) 1722337 1727793 5456 0.3
(read/write) 126816 126880 64 0.1
.bss 57776 57840 64 0.1
.rodata 140277 140341 64 0.0
.text 1447842 1453234 5392 0.4
bridge-app debug+rpc (read only) 1312741 1318197 5456 0.4
(read/write) 77424 77488 64 0.1
.bss 42896 42960 64 0.1
.rodata 111860 111924 64 0.1
.text 1103909 1109301 5392 0.5
chip-tool debug (read only) 4921493 4926933 5440 0.1
(read/write) 167208 167272 64 0.0
.bss 41192 41256 64 0.2
.rodata 268242 268274 32 0.0
.text 4343605 4349013 5408 0.1
lighting-app debug+rpc (read only) 1582281 1587737 5456 0.3
(read/write) 110192 110256 64 0.1
.bss 48080 48144 64 0.1
.rodata 129841 129905 64 0.0
.text 1317746 1323138 5392 0.4
ota-provider-app debug (read only) 1267337 1272761 5424 0.4
(read/write) 75176 75240 64 0.1
.bss 44512 44576 64 0.1
.rodata 113383 113415 32 0.0
.text 1057106 1062498 5392 0.5
ota-requestor-app debug (read only) 1352009 1357449 5440 0.4
(read/write) 78944 79008 64 0.1
.bss 46976 47040 64 0.1
.rodata 124208 124240 32 0.0
.text 1128402 1133810 5408 0.5
shell debug (read only) 789081 789161 80 0.0
.rodata 77903 77967 64 0.1
.text 609282 609298 16 0.0
tv-app debug (read only) 1858569 1864009 5440 0.3
(read/write) 407896 407960 64 0.0
.bss 339752 339816 64 0.0
.rodata 157069 157101 32 0.0
.text 1556418 1561826 5408 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292200 2292968 768 0.0
.bss 179692 179756 64 0.0
.text 1254800 1255568 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274688 2275392 704 0.0
.bss 172556 172620 64 0.0
.text 1237288 1237992 704 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2250128 2250832 704 0.0
.bss 171436 171500 64 0.0
.text 1212728 1213432 704 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865175 865895 720 0.1
bss 110964 111028 64 0.1
text 581516 582168 652 0.1
nrf52840dk_nrf52840+rpc (read/write) 827567 828271 704 0.1
bss 107320 107384 64 0.1
text 555688 556340 652 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 790234 790938 704 0.1
bss 112340 112404 64 0.1
text 510984 511636 652 0.1
lock-app nrf52840dk_nrf52840 (read/write) 840199 840919 720 0.1
bss 109988 110052 64 0.1
text 561616 562268 652 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 765514 766234 720 0.1
bss 111400 111464 64 0.1
text 491176 491828 652 0.1
pump-app nrf52840dk_nrf52840 (read/write) 846327 847031 704 0.1
bss 110128 110192 64 0.1
text 565800 566452 652 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 839903 840623 720 0.1
bss 110024 110088 64 0.1
text 561236 561888 652 0.1
p6 all-clusters-app default (read/write) 2301232 2302176 944 0.0
.bss 112680 112744 64 0.1
.text 1259496 1260440 944 0.1
lock-app default (read/write) 2214704 2215680 976 0.0
.bss 101296 101360 64 0.1
.text 1172968 1173944 976 0.1
qpg lighting-app qpg6100+debug (read only) 494216 494888 672 0.1
.bss 50640 50672 32 0.1
.text 488896 489568 672 0.1
lock-app qpg6100+debug (read only) 468752 469424 672 0.1
.bss 49576 49608 32 0.1
.text 463432 464104 672 0.1
telink lighting-app tlsr9518adk80d (read/write) 667854 668670 816 0.1
bss 69320 69384 64 0.1
text 462372 463124 752 0.2
Decreases (5 builds for mbed, p6)
platform target config section 507ba15 c1547ee change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851536 851472 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858312 858248 -64 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859440 859376 -64 -0.0
p6 all-clusters-app default .heap 918144 918080 -64 -0.0
lock-app default .heap 929648 929584 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 507ba15 c1547ee change % change
efr32 lighting-app BRD4161A (read only) 750088 751048 960 0.1
(read/write) 115940 116004 64 0.1
.bss 114140 114204 64 0.1
.data 1800 1800 0 0.0
.text 750080 751040 960 0.1
BRD4161A+rpc (read only) 737636 738596 960 0.1
(read/write) 132568 132632 64 0.0
.bss 130644 130708 64 0.0
.data 1924 1924 0 0.0
.text 737628 738588 960 0.1
lock-app BRD4161A (read only) 726752 727712 960 0.1
(read/write) 113724 113788 64 0.1
.bss 111964 112028 64 0.1
.data 1756 1756 0 0.0
.text 726744 727704 960 0.1
window-app BRD4161A (read only) 727744 728704 960 0.1
(read/write) 114044 114108 64 0.1
.bss 112284 112348 64 0.1
.data 1760 1760 0 0.0
.text 727736 728696 960 0.1
esp32 all-clusters-app c3devkit (read only) 826956 827728 772 0.1
(read/write) 1224466 1224530 64 0.0
.dram0.bss 57088 57152 64 0.1
.dram0.data 14092 14092 0 0.0
.flash.rodata 168040 168040 0 0.0
.flash.text 826956 827728 772 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 897631 898431 800 0.1
(read/write) 422624 422688 64 0.0
.dram0.bss 62184 62248 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 195060 195060 0 0.0
.flash.text 892247 893047 800 0.1
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 702540 703244 704 0.1
.bss 77508 77572 64 0.1
.data 1908 1908 0 0.0
.text 617324 617964 640 0.1
lock-app k32w061+debug (read/write) 593548 594268 720 0.1
.bss 68028 68092 64 0.1
.data 1876 1876 0 0.0
.text 517844 518500 656 0.1
shell k32w061+debug (read/write) 659232 659936 704 0.1
.bss 78820 78884 64 0.1
.data 1844 1844 0 0.0
.text 572768 573408 640 0.1
linux all-clusters-app debug (read only) 1722337 1727793 5456 0.3
(read/write) 126816 126880 64 0.1
.bss 57776 57840 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 62720 62720 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 140277 140341 64 0.0
.text 1447842 1453234 5392 0.4
bridge-app debug+rpc (read only) 1312741 1318197 5456 0.4
(read/write) 77424 77488 64 0.1
.bss 42896 42960 64 0.1
.data 1568 1568 0 0.0
.data.rel.ro 27960 27960 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111860 111924 64 0.1
.text 1103909 1109301 5392 0.5
chip-tool debug (read only) 4921493 4926933 5440 0.1
(read/write) 167208 167272 64 0.0
.bss 41192 41256 64 0.2
.data 2272 2272 0 0.0
.data.rel.ro 118256 118256 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268242 268274 32 0.0
.text 4343605 4349013 5408 0.1
lighting-app debug+rpc (read only) 1582281 1587737 5456 0.3
(read/write) 110192 110256 64 0.1
.bss 48080 48144 64 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129841 129905 64 0.0
.text 1317746 1323138 5392 0.4
ota-provider-app debug (read only) 1267337 1272761 5424 0.4
(read/write) 75176 75240 64 0.1
.bss 44512 44576 64 0.1
.data 784 784 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113383 113415 32 0.0
.text 1057106 1062498 5392 0.5
ota-requestor-app debug (read only) 1352009 1357449 5440 0.4
(read/write) 78944 79008 64 0.1
.bss 46976 47040 64 0.1
.data 848 848 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124208 124240 32 0.0
.text 1128402 1133810 5408 0.5
shell debug (read only) 789081 789161 80 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77967 64 0.1
.text 609282 609298 16 0.0
tv-app debug (read only) 1858569 1864009 5440 0.3
(read/write) 407896 407960 64 0.0
.bss 339752 339816 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59696 59696 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157069 157101 32 0.0
.text 1556418 1561826 5408 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292200 2292968 768 0.0
.bss 179692 179756 64 0.0
.data 5216 5216 0 0.0
.heap 851536 851472 -64 -0.0
.text 1254800 1255568 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274688 2275392 704 0.0
.bss 172556 172620 64 0.0
.data 5576 5576 0 0.0
.heap 858312 858248 -64 -0.0
.text 1237288 1237992 704 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250128 2250832 704 0.0
.bss 171436 171500 64 0.0
.data 5568 5568 0 0.0
.heap 859440 859376 -64 -0.0
.text 1212728 1213432 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865175 865895 720 0.1
bss 110964 111028 64 0.1
rodata 97080 97080 0 0.0
text 581516 582168 652 0.1
nrf52840dk_nrf52840+rpc (read/write) 827567 828271 704 0.1
bss 107320 107384 64 0.1
rodata 88272 88272 0 0.0
text 555688 556340 652 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 790234 790938 704 0.1
bss 112340 112404 64 0.1
rodata 92340 92340 0 0.0
text 510984 511636 652 0.1
lock-app nrf52840dk_nrf52840 (read/write) 840199 840919 720 0.1
bss 109988 110052 64 0.1
rodata 93144 93144 0 0.0
text 561616 562268 652 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 765514 766234 720 0.1
bss 111400 111464 64 0.1
rodata 88452 88452 0 0.0
text 491176 491828 652 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846327 847031 704 0.1
bss 110128 110192 64 0.1
rodata 94856 94856 0 0.0
text 565800 566452 652 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 839903 840623 720 0.1
bss 110024 110088 64 0.1
rodata 93104 93104 0 0.0
text 561236 561888 652 0.1
shell nrf52840dk_nrf52840 (read/write) 775499 775499 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520020 520020 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690554 690554 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440628 440628 0 0.0
p6 all-clusters-app default (read/write) 2301232 2302176 944 0.0
.bss 112680 112744 64 0.1
.data 2520 2520 0 0.0
.heap 918144 918080 -64 -0.0
.text 1259496 1260440 944 0.1
lock-app default (read/write) 2214704 2215680 976 0.0
.bss 101296 101360 64 0.1
.data 2400 2400 0 0.0
.heap 929648 929584 -64 -0.0
.text 1172968 1173944 976 0.1
qpg lighting-app qpg6100+debug (read only) 494216 494888 672 0.1
(read/write) 114144 114144 0 0.0
.bss 50640 50672 32 0.1
.data 1008 1008 0 0.0
.text 488896 489568 672 0.1
lock-app qpg6100+debug (read only) 468752 469424 672 0.1
(read/write) 114140 114140 0 0.0
.bss 49576 49608 32 0.1
.data 964 964 0 0.0
.text 463432 464104 672 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 667854 668670 816 0.1
bss 69320 69384 64 0.1
noinit 33216 33216 0 0.0
text 462372 463124 752 0.2

mrjerryjohns
mrjerryjohns reviewed Nov 16, 2021
View reviewed changes
src/app/EventLoggingTypes.h Outdated Show resolved Hide resolved
src/app/MessageDef/EventDataIB.cpp Outdated Show resolved Hide resolved
src/app/MessageDef/EventDataIB.cpp Show resolved Hide resolved
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/app/ReadClient.h Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/add_event_processing branch 2 times, most recently from 8dda88a to 96d81c0 Compare November 16, 2021 22:02
@restyled-io restyled-io bot mentioned this pull request Nov 16, 2021
Closed
@yunhanw-google yunhanw-google force-pushed the feature/add_event_processing branch from 96d81c0 to b7a9cf0 Compare November 16, 2021 22:04
@github-actions
Copy link

github-actions bot commented Nov 16, 2021 •
edited
Loading

PR #11615: Size comparison from eb84a9d to b7a9cf0

Increases above 0.2%:

platform target config section eb84a9d1 b7a9cf0 change % change
linux all-clusters-app debug (read only) 1701841 1707377 5536 0.3
.text 1433138 1438610 5472 0.4
bridge-app debug+rpc (read only) 1297013 1302549 5536 0.4
.text 1089445 1094917 5472 0.5
lighting-app debug+rpc (read only) 1566073 1571577 5504 0.4
.text 1303298 1308770 5472 0.4
ota-provider-app debug (read only) 1252473 1257977 5504 0.4
.text 1042386 1047858 5472 0.5
ota-requestor-app debug (read only) 1335857 1341377 5520 0.4
.text 1112418 1117906 5488 0.5
tv-app debug (read only) 1844841 1850393 5552 0.3
.text 1543730 1549218 5488 0.4
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eb84a9d1 b7a9cf0 change % change
efr32 lighting-app BRD4161A (read only) 745208 746184 976 0.1
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.text 745200 746176 976 0.1
BRD4161A+rpc (read only) 732724 733700 976 0.1
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.text 732716 733692 976 0.1
lock-app BRD4161A (read only) 722296 723272 976 0.1
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.text 722288 723264 976 0.1
window-app BRD4161A (read only) 723272 724232 960 0.1
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.text 723264 724224 960 0.1
esp32 all-clusters-app c3devkit (read only) 824912 825684 772 0.1
(read/write) 1219650 1219714 64 0.0
.dram0.bss 56512 56576 64 0.1
.flash.text 824912 825684 772 0.1
m5stack (read only) 895819 896651 832 0.1
(read/write) 418980 419044 64 0.0
.dram0.bss 61864 61928 64 0.1
.flash.text 890435 891267 832 0.1
k32w lighting-app k32w061+se05x+release (read/write) 703576 704296 720 0.1
.bss 76988 77052 64 0.1
.text 618876 619532 656 0.1
lock-app k32w061+debug (read/write) 595020 595740 720 0.1
.bss 67500 67564 64 0.1
.text 519840 520496 656 0.1
shell k32w061+debug (read/write) 660252 660972 720 0.1
.bss 78564 78628 64 0.1
.text 574040 574696 656 0.1
linux all-clusters-app debug (read only) 1701841 1707377 5536 0.3
(read/write) 126624 126688 64 0.1
.bss 57520 57584 64 0.1
.rodata 135253 135317 64 0.0
.text 1433138 1438610 5472 0.4
bridge-app debug+rpc (read only) 1297013 1302549 5536 0.4
(read/write) 76816 76880 64 0.1
.bss 42224 42288 64 0.2
.rodata 110668 110732 64 0.1
.text 1089445 1094917 5472 0.5
chip-tool debug (read only) 4955885 4961453 5568 0.1
(read/write) 166504 166568 64 0.0
.bss 40584 40648 64 0.2
.rodata 267090 267154 64 0.0
.text 4379365 4384869 5504 0.1
lighting-app debug+rpc (read only) 1566073 1571577 5504 0.4
(read/write) 110064 110128 64 0.1
.bss 47888 47952 64 0.1
.rodata 128273 128305 32 0.0
.text 1303298 1308770 5472 0.4
ota-provider-app debug (read only) 1252473 1257977 5504 0.4
(read/write) 75560 75624 64 0.1
.bss 44832 44896 64 0.1
.rodata 112999 113031 32 0.0
.text 1042386 1047858 5472 0.5
ota-requestor-app debug (read only) 1335857 1341377 5520 0.4
(read/write) 79264 79328 64 0.1
.bss 47296 47360 64 0.1
.rodata 124016 124048 32 0.0
.text 1112418 1117906 5488 0.5
shell debug (read only) 794665 794745 80 0.0
.rodata 78479 78543 64 0.1
.text 612674 612690 16 0.0
tv-app debug (read only) 1844841 1850393 5552 0.3
(read/write) 318136 318200 64 0.0
.bss 249960 250024 64 0.0
.rodata 156557 156621 64 0.0
.text 1543730 1549218 5488 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2283728 2284496 768 0.0
.bss 179108 179172 64 0.0
.text 1246328 1247096 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2269720 2270424 704 0.0
.bss 171972 172036 64 0.0
.text 1232320 1233024 704 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2245560 2246328 768 0.0
.bss 170860 170924 64 0.0
.text 1208160 1208928 768 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860887 704 0.1
bss 110384 110448 64 0.1
text 579140 579788 648 0.1
nrf52840dk_nrf52840+rpc (read/write) 822551 823271 720 0.1
bss 106740 106804 64 0.1
text 553312 553960 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785942 720 0.1
bss 111760 111824 64 0.1
text 508608 509256 648 0.1
lock-app nrf52840dk_nrf52840 (read/write) 835579 836283 704 0.1
bss 109408 109472 64 0.1
text 559236 559888 652 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 760902 761622 720 0.1
bss 110820 110884 64 0.1
text 488796 489448 652 0.1
pump-app nrf52840dk_nrf52840 (read/write) 841723 842427 704 0.1
bss 109548 109612 64 0.1
text 563420 564068 648 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 836019 704 0.1
bss 109444 109508 64 0.1
text 558856 559508 652 0.1
p6 all-clusters-app default (read/write) 2292608 2293568 960 0.0
.bss 112096 112160 64 0.1
.text 1250872 1251832 960 0.1
lock-app default (read/write) 2210080 2211056 976 0.0
.bss 100720 100784 64 0.1
.text 1168344 1169320 976 0.1
qpg lighting-app qpg6100+debug (read only) 489736 490408 672 0.1
.bss 50056 50088 32 0.1
.text 484416 485088 672 0.1
lock-app qpg6100+debug (read only) 464692 465364 672 0.1
.bss 49000 49032 32 0.1
.text 459372 460044 672 0.1
telink lighting-app tlsr9518adk80d (read/write) 763014 763830 816 0.1
bss 78896 78960 64 0.1
text 529210 529962 752 0.1
Decreases (5 builds for mbed, p6)
platform target config section eb84a9d1 b7a9cf0 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 852120 852056 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858896 858832 -64 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 860016 859952 -64 -0.0
p6 all-clusters-app default .heap 918728 918664 -64 -0.0
lock-app default .heap 930224 930160 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eb84a9d1 b7a9cf0 change % change
efr32 lighting-app BRD4161A (read only) 745208 746184 976 0.1
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.data 1800 1800 0 0.0
.text 745200 746176 976 0.1
BRD4161A+rpc (read only) 732724 733700 976 0.1
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.data 1924 1924 0 0.0
.text 732716 733692 976 0.1
lock-app BRD4161A (read only) 722296 723272 976 0.1
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.data 1756 1756 0 0.0
.text 722288 723264 976 0.1
window-app BRD4161A (read only) 723272 724232 960 0.1
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.data 1760 1760 0 0.0
.text 723264 724224 960 0.1
esp32 all-clusters-app c3devkit (read only) 824912 825684 772 0.1
(read/write) 1219650 1219714 64 0.0
.dram0.bss 56512 56576 64 0.1
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163800 0 0.0
.flash.text 824912 825684 772 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 896651 832 0.1
(read/write) 418980 419044 64 0.0
.dram0.bss 61864 61928 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191780 0 0.0
.flash.text 890435 891267 832 0.1
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703576 704296 720 0.1
.bss 76988 77052 64 0.1
.data 1912 1912 0 0.0
.text 618876 619532 656 0.1
lock-app k32w061+debug (read/write) 595020 595740 720 0.1
.bss 67500 67564 64 0.1
.data 1880 1880 0 0.0
.text 519840 520496 656 0.1
shell k32w061+debug (read/write) 660252 660972 720 0.1
.bss 78564 78628 64 0.1
.data 1848 1848 0 0.0
.text 574040 574696 656 0.1
linux all-clusters-app debug (read only) 1701841 1707377 5536 0.3
(read/write) 126624 126688 64 0.1
.bss 57520 57584 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135317 64 0.0
.text 1433138 1438610 5472 0.4
bridge-app debug+rpc (read only) 1297013 1302549 5536 0.4
(read/write) 76816 76880 64 0.1
.bss 42224 42288 64 0.2
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110732 64 0.1
.text 1089445 1094917 5472 0.5
chip-tool debug (read only) 4955885 4961453 5568 0.1
(read/write) 166504 166568 64 0.0
.bss 40584 40648 64 0.2
.data 2272 2272 0 0.0
.data.rel.ro 118136 118136 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267090 267154 64 0.0
.text 4379365 4384869 5504 0.1
lighting-app debug+rpc (read only) 1566073 1571577 5504 0.4
(read/write) 110064 110128 64 0.1
.bss 47888 47952 64 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128305 32 0.0
.text 1303298 1308770 5472 0.4
ota-provider-app debug (read only) 1252473 1257977 5504 0.4
(read/write) 75560 75624 64 0.1
.bss 44832 44896 64 0.1
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 113031 32 0.0
.text 1042386 1047858 5472 0.5
ota-requestor-app debug (read only) 1335857 1341377 5520 0.4
(read/write) 79264 79328 64 0.1
.bss 47296 47360 64 0.1
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124016 124048 32 0.0
.text 1112418 1117906 5488 0.5
shell debug (read only) 794665 794745 80 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78543 64 0.1
.text 612674 612690 16 0.0
tv-app debug (read only) 1844841 1850393 5552 0.3
(read/write) 318136 318200 64 0.0
.bss 249960 250024 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156557 156621 64 0.0
.text 1543730 1549218 5488 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2284496 768 0.0
.bss 179108 179172 64 0.0
.data 5216 5216 0 0.0
.heap 852120 852056 -64 -0.0
.text 1246328 1247096 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2270424 704 0.0
.bss 171972 172036 64 0.0
.data 5576 5576 0 0.0
.heap 858896 858832 -64 -0.0
.text 1232320 1233024 704 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2246328 768 0.0
.bss 170860 170924 64 0.0
.data 5568 5568 0 0.0
.heap 860016 859952 -64 -0.0
.text 1208160 1208928 768 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860887 704 0.1
bss 110384 110448 64 0.1
rodata 95032 95032 0 0.0
text 579140 579788 648 0.1
nrf52840dk_nrf52840+rpc (read/write) 822551 823271 720 0.1
bss 106740 106804 64 0.1
rodata 86216 86216 0 0.0
text 553312 553960 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785942 720 0.1
bss 111760 111824 64 0.1
rodata 90288 90288 0 0.0
text 508608 509256 648 0.1
lock-app nrf52840dk_nrf52840 (read/write) 835579 836283 704 0.1
bss 109408 109472 64 0.1
rodata 91500 91500 0 0.0
text 559236 559888 652 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 760902 761622 720 0.1
bss 110820 110884 64 0.1
rodata 86808 86808 0 0.0
text 488796 489448 652 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 842427 704 0.1
bss 109548 109612 64 0.1
rodata 93212 93212 0 0.0
text 563420 564068 648 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 836019 704 0.1
bss 109444 109508 64 0.1
rodata 91460 91460 0 0.0
text 558856 559508 652 0.1
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292608 2293568 960 0.0
.bss 112096 112160 64 0.1
.data 2520 2520 0 0.0
.heap 918728 918664 -64 -0.0
.text 1250872 1251832 960 0.1
lock-app default (read/write) 2210080 2211056 976 0.0
.bss 100720 100784 64 0.1
.data 2400 2400 0 0.0
.heap 930224 930160 -64 -0.0
.text 1168344 1169320 976 0.1
qpg lighting-app qpg6100+debug (read only) 489736 490408 672 0.1
(read/write) 114144 114144 0 0.0
.bss 50056 50088 32 0.1
.data 1008 1008 0 0.0
.text 484416 485088 672 0.1
lock-app qpg6100+debug (read only) 464692 465364 672 0.1
(read/write) 114140 114140 0 0.0
.bss 49000 49032 32 0.1
.data 964 964 0 0.0
.text 459372 460044 672 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763830 816 0.1
bss 78896 78960 64 0.1
noinit 37160 37160 0 0.0
text 529210 529962 752 0.1

mrjerryjohns
mrjerryjohns approved these changes Nov 17, 2021
View reviewed changes
src/app/ReadClient.h Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/add_event_processing branch from b7a9cf0 to 27ecc50 Compare November 17, 2021 18:13
@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11615: Size comparison from e568d70 to 27ecc50

Increases above 0.2%:

platform target config section e568d70 27ecc50 change % change
linux all-clusters-app debug (read only) 1716873 1722393 5520 0.3
.text 1447314 1452770 5456 0.4
bridge-app debug+rpc (read only) 1312005 1317541 5536 0.4
.text 1103621 1109093 5472 0.5
lighting-app debug+rpc (read only) 1581137 1586641 5504 0.3
.text 1317506 1322978 5472 0.4
ota-provider-app debug (read only) 1260681 1266185 5504 0.4
.text 1049938 1055410 5472 0.5
ota-requestor-app debug (read only) 1344369 1349889 5520 0.4
.text 1120226 1125714 5488 0.5
tv-app debug (read only) 1861825 1867377 5552 0.3
.text 1559666 1565154 5488 0.4
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e568d70 27ecc50 change % change
efr32 lighting-app BRD4161A (read only) 748400 749344 944 0.1
(read/write) 115572 115636 64 0.1
.bss 113772 113836 64 0.1
.text 748392 749336 944 0.1
BRD4161A+rpc (read only) 735932 736876 944 0.1
(read/write) 132200 132264 64 0.0
.bss 130276 130340 64 0.0
.text 735924 736868 944 0.1
lock-app BRD4161A (read only) 725472 726416 944 0.1
(read/write) 113356 113420 64 0.1
.bss 111596 111660 64 0.1
.text 725464 726408 944 0.1
window-app BRD4161A (read only) 726432 727392 960 0.1
(read/write) 113676 113740 64 0.1
.bss 111916 111980 64 0.1
.text 726424 727384 960 0.1
esp32 all-clusters-app c3devkit (read only) 827574 828340 766 0.1
(read/write) 1220162 1220226 64 0.0
.dram0.bss 56720 56784 64 0.1
.flash.text 827574 828340 766 0.1
m5stack (read only) 898475 899259 784 0.1
(read/write) 419484 419548 64 0.0
.dram0.bss 62072 62136 64 0.1
.flash.text 893091 893875 784 0.1
k32w lighting-app k32w061+se05x+release (read/write) 706012 706732 720 0.1
.bss 77196 77260 64 0.1
.text 621104 621760 656 0.1
lock-app k32w061+debug (read/write) 597452 598172 720 0.1
.bss 67708 67772 64 0.1
.text 522064 522720 656 0.1
shell k32w061+debug (read/write) 662796 663500 704 0.1
.bss 78836 78900 64 0.1
.text 576312 576952 640 0.1
linux all-clusters-app debug (read only) 1716873 1722393 5520 0.3
(read/write) 127200 127264 64 0.1
.bss 57776 57840 64 0.1
.rodata 135605 135669 64 0.0
.text 1447314 1452770 5456 0.4
bridge-app debug+rpc (read only) 1312005 1317541 5536 0.4
(read/write) 77392 77456 64 0.1
.bss 42480 42544 64 0.2
.rodata 110980 111044 64 0.1
.text 1103621 1109093 5472 0.5
chip-tool debug (read only) 4970909 4976445 5536 0.1
(read/write) 167304 167368 64 0.0
.bss 40840 40904 64 0.2
.rodata 267690 267754 64 0.0
.text 4392709 4398181 5472 0.1
lighting-app debug+rpc (read only) 1581137 1586641 5504 0.3
(read/write) 110608 110672 64 0.1
.bss 48144 48208 64 0.1
.rodata 128625 128657 32 0.0
.text 1317506 1322978 5472 0.4
ota-provider-app debug (read only) 1260681 1266185 5504 0.4
(read/write) 76040 76104 64 0.1
.bss 45088 45152 64 0.1
.rodata 113151 113183 32 0.0
.text 1049938 1055410 5472 0.5
ota-requestor-app debug (read only) 1344369 1349889 5520 0.4
(read/write) 79776 79840 64 0.1
.bss 47552 47616 64 0.1
.rodata 124168 124200 32 0.0
.text 1120226 1125714 5488 0.5
shell debug (read only) 797793 797873 80 0.0
.rodata 78383 78447 64 0.1
.text 615394 615410 16 0.0
tv-app debug (read only) 1861825 1867377 5552 0.3
(read/write) 319352 319416 64 0.0
.bss 250760 250824 64 0.0
.rodata 157029 157093 64 0.0
.text 1559666 1565154 5488 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2287032 2287800 768 0.0
.bss 179316 179380 64 0.0
.text 1249632 1250400 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272960 2273728 768 0.0
.bss 172180 172244 64 0.0
.text 1235560 1236328 768 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2248864 2249568 704 0.0
.bss 171068 171132 64 0.0
.text 1211464 1212168 704 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863671 864391 720 0.1
bss 110592 110656 64 0.1
text 581692 582340 648 0.1
nrf52840dk_nrf52840+rpc (read/write) 826071 826791 720 0.1
bss 106948 107012 64 0.1
text 555860 556508 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788730 789434 704 0.1
bss 111968 112032 64 0.1
text 511164 511812 648 0.1
lock-app nrf52840dk_nrf52840 (read/write) 839103 839823 720 0.1
bss 109616 109680 64 0.1
text 561788 562436 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 764406 765110 704 0.1
bss 111028 111092 64 0.1
text 491352 492000 648 0.1
pump-app nrf52840dk_nrf52840 (read/write) 845211 845931 720 0.1
bss 109756 109820 64 0.1
text 565968 566616 648 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 838803 839523 720 0.1
bss 109652 109716 64 0.1
text 561408 562056 648 0.1
p6 all-clusters-app default (read/write) 2296424 2297384 960 0.0
.bss 112304 112368 64 0.1
.text 1254688 1255648 960 0.1
lock-app default (read/write) 2213896 2214856 960 0.0
.bss 100928 100992 64 0.1
.text 1172160 1173120 960 0.1
qpg lighting-app qpg6100+debug (read only) 492792 493472 680 0.1
.bss 50216 50248 32 0.1
.text 487472 488152 680 0.1
lock-app qpg6100+debug (read only) 467772 468452 680 0.1
.bss 49160 49192 32 0.1
.text 462452 463132 680 0.1
telink lighting-app tlsr9518adk80d (read/write) 767062 767870 808 0.1
bss 79104 79168 64 0.1
text 532258 533006 748 0.1
Decreases (5 builds for mbed, p6)
platform target config section e568d70 27ecc50 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851912 851848 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858688 858624 -64 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859808 859744 -64 -0.0
p6 all-clusters-app default .heap 918520 918456 -64 -0.0
lock-app default .heap 930016 929952 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e568d70 27ecc50 change % change
efr32 lighting-app BRD4161A (read only) 748400 749344 944 0.1
(read/write) 115572 115636 64 0.1
.bss 113772 113836 64 0.1
.data 1800 1800 0 0.0
.text 748392 749336 944 0.1
BRD4161A+rpc (read only) 735932 736876 944 0.1
(read/write) 132200 132264 64 0.0
.bss 130276 130340 64 0.0
.data 1924 1924 0 0.0
.text 735924 736868 944 0.1
lock-app BRD4161A (read only) 725472 726416 944 0.1
(read/write) 113356 113420 64 0.1
.bss 111596 111660 64 0.1
.data 1756 1756 0 0.0
.text 725464 726408 944 0.1
window-app BRD4161A (read only) 726432 727392 960 0.1
(read/write) 113676 113740 64 0.1
.bss 111916 111980 64 0.1
.data 1760 1760 0 0.0
.text 726424 727384 960 0.1
esp32 all-clusters-app c3devkit (read only) 827574 828340 766 0.1
(read/write) 1220162 1220226 64 0.0
.dram0.bss 56720 56784 64 0.1
.dram0.data 14084 14084 0 0.0
.flash.rodata 164104 164104 0 0.0
.flash.text 827574 828340 766 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 898475 899259 784 0.1
(read/write) 419484 419548 64 0.0
.dram0.bss 62072 62136 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 192076 192076 0 0.0
.flash.text 893091 893875 784 0.1
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706012 706732 720 0.1
.bss 77196 77260 64 0.1
.data 1912 1912 0 0.0
.text 621104 621760 656 0.1
lock-app k32w061+debug (read/write) 597452 598172 720 0.1
.bss 67708 67772 64 0.1
.data 1880 1880 0 0.0
.text 522064 522720 656 0.1
shell k32w061+debug (read/write) 662796 663500 704 0.1
.bss 78836 78900 64 0.1
.data 1848 1848 0 0.0
.text 576312 576952 640 0.1
linux all-clusters-app debug (read only) 1716873 1722393 5520 0.3
(read/write) 127200 127264 64 0.1
.bss 57776 57840 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135605 135669 64 0.0
.text 1447314 1452770 5456 0.4
bridge-app debug+rpc (read only) 1312005 1317541 5536 0.4
(read/write) 77392 77456 64 0.1
.bss 42480 42544 64 0.2
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110980 111044 64 0.1
.text 1103621 1109093 5472 0.5
chip-tool debug (read only) 4970909 4976445 5536 0.1
(read/write) 167304 167368 64 0.0
.bss 40840 40904 64 0.2
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267690 267754 64 0.0
.text 4392709 4398181 5472 0.1
lighting-app debug+rpc (read only) 1581137 1586641 5504 0.3
(read/write) 110608 110672 64 0.1
.bss 48144 48208 64 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128625 128657 32 0.0
.text 1317506 1322978 5472 0.4
ota-provider-app debug (read only) 1260681 1266185 5504 0.4
(read/write) 76040 76104 64 0.1
.bss 45088 45152 64 0.1
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113151 113183 32 0.0
.text 1049938 1055410 5472 0.5
ota-requestor-app debug (read only) 1344369 1349889 5520 0.4
(read/write) 79776 79840 64 0.1
.bss 47552 47616 64 0.1
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124168 124200 32 0.0
.text 1120226 1125714 5488 0.5
shell debug (read only) 797793 797873 80 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78383 78447 64 0.1
.text 615394 615410 16 0.0
tv-app debug (read only) 1861825 1867377 5552 0.3
(read/write) 319352 319416 64 0.0
.bss 250760 250824 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157029 157093 64 0.0
.text 1559666 1565154 5488 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287032 2287800 768 0.0
.bss 179316 179380 64 0.0
.data 5216 5216 0 0.0
.heap 851912 851848 -64 -0.0
.text 1249632 1250400 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272960 2273728 768 0.0
.bss 172180 172244 64 0.0
.data 5576 5576 0 0.0
.heap 858688 858624 -64 -0.0
.text 1235560 1236328 768 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248864 2249568 704 0.0
.bss 171068 171132 64 0.0
.data 5568 5568 0 0.0
.heap 859808 859744 -64 -0.0
.text 1211464 1212168 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050352 2050352 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1012952 1012952 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863671 864391 720 0.1
bss 110592 110656 64 0.1
rodata 95784 95784 0 0.0
text 581692 582340 648 0.1
nrf52840dk_nrf52840+rpc (read/write) 826071 826791 720 0.1
bss 106948 107012 64 0.1
rodata 86968 86968 0 0.0
text 555860 556508 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788730 789434 704 0.1
bss 111968 112032 64 0.1
rodata 91044 91044 0 0.0
text 511164 511812 648 0.1
lock-app nrf52840dk_nrf52840 (read/write) 839103 839823 720 0.1
bss 109616 109680 64 0.1
rodata 92256 92256 0 0.0
text 561788 562436 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 764406 765110 704 0.1
bss 111028 111092 64 0.1
rodata 87560 87560 0 0.0
text 491352 492000 648 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845211 845931 720 0.1
bss 109756 109820 64 0.1
rodata 93964 93964 0 0.0
text 565968 566616 648 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 838803 839523 720 0.1
bss 109652 109716 64 0.1
rodata 92212 92212 0 0.0
text 561408 562056 648 0.1
shell nrf52840dk_nrf52840 (read/write) 777795 777795 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521068 521068 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692850 692850 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441680 441680 0 0.0
p6 all-clusters-app default (read/write) 2296424 2297384 960 0.0
.bss 112304 112368 64 0.1
.data 2520 2520 0 0.0
.heap 918520 918456 -64 -0.0
.text 1254688 1255648 960 0.1
lock-app default (read/write) 2213896 2214856 960 0.0
.bss 100928 100992 64 0.1
.data 2400 2400 0 0.0
.heap 930016 929952 -64 -0.0
.text 1172160 1173120 960 0.1
qpg lighting-app qpg6100+debug (read only) 492792 493472 680 0.1
(read/write) 114144 114144 0 0.0
.bss 50216 50248 32 0.1
.data 1008 1008 0 0.0
.text 487472 488152 680 0.1
lock-app qpg6100+debug (read only) 467772 468452 680 0.1
(read/write) 114140 114140 0 0.0
.bss 49160 49192 32 0.1
.data 964 964 0 0.0
.text 462452 463132 680 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767062 767870 808 0.1
bss 79104 79168 64 0.1
noinit 37160 37160 0 0.0
text 532258 533006 748 0.1

@yunhanw-google yunhanw-google force-pushed the feature/add_event_processing branch from 27ecc50 to dc8f7c0 Compare November 17, 2021 20:21
@yunhanw-google
Copy link
Contributor Author

@woody-apple @saurabhst @msandstedt @jelderton ?

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11615: Size comparison from bd4515c to dc8f7c0

Increases above 0.2%:

platform target config section bd4515c dc8f7c0 change % change
linux all-clusters-app debug (read only) 1718665 1724201 5536 0.3
.text 1448434 1453906 5472 0.4
bridge-app debug+rpc (read only) 1313765 1319301 5536 0.4
.text 1104741 1110213 5472 0.5
lighting-app debug+rpc (read only) 1582849 1588385 5536 0.3
.text 1318642 1324114 5472 0.4
ota-provider-app debug (read only) 1262441 1267977 5536 0.4
.text 1051058 1056530 5472 0.5
ota-requestor-app debug (read only) 1348113 1353649 5536 0.4
.text 1123330 1128802 5472 0.5
tv-app debug (read only) 1865521 1871041 5520 0.3
.text 1562754 1568242 5488 0.4
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bd4515c dc8f7c0 change % change
efr32 lighting-app BRD4161A (read only) 748512 749456 944 0.1
(read/write) 115476 115540 64 0.1
.bss 113676 113740 64 0.1
.text 748504 749448 944 0.1
BRD4161A+rpc (read only) 736044 736988 944 0.1
(read/write) 132104 132168 64 0.0
.bss 130180 130244 64 0.0
.text 736036 736980 944 0.1
lock-app BRD4161A (read only) 725584 726528 944 0.1
(read/write) 113260 113324 64 0.1
.bss 111500 111564 64 0.1
.text 725576 726520 944 0.1
window-app BRD4161A (read only) 726560 727504 944 0.1
(read/write) 113580 113644 64 0.1
.bss 111820 111884 64 0.1
.text 726552 727496 944 0.1
esp32 all-clusters-app c3devkit (read only) 827530 828296 766 0.1
(read/write) 1220066 1220130 64 0.0
.dram0.bss 56624 56688 64 0.1
.flash.text 827530 828296 766 0.1
m5stack (read only) 898495 899319 824 0.1
(read/write) 419388 419452 64 0.0
.dram0.bss 61976 62040 64 0.1
.flash.text 893111 893935 824 0.1
k32w lighting-app k32w061+se05x+release (read/write) 705932 706636 704 0.1
.bss 77100 77164 64 0.1
.text 621120 621760 640 0.1
lock-app k32w061+debug (read/write) 597372 598076 704 0.1
.bss 67612 67676 64 0.1
.text 522080 522720 640 0.1
shell k32w061+debug (read/write) 662700 663420 720 0.1
.bss 78740 78804 64 0.1
.text 576312 576968 656 0.1
linux all-clusters-app debug (read only) 1718665 1724201 5536 0.3
(read/write) 126752 126816 64 0.1
.bss 57328 57392 64 0.1
.rodata 136277 136341 64 0.0
.text 1448434 1453906 5472 0.4
bridge-app debug+rpc (read only) 1313765 1319301 5536 0.4
(read/write) 76944 77008 64 0.1
.bss 42032 42096 64 0.2
.rodata 111620 111684 64 0.1
.text 1104741 1110213 5472 0.5
chip-tool debug (read only) 4975181 4980685 5504 0.1
(read/write) 166856 166920 64 0.0
.bss 40392 40456 64 0.2
.rodata 268330 268362 32 0.0
.text 4396341 4401813 5472 0.1
lighting-app debug+rpc (read only) 1582849 1588385 5536 0.3
(read/write) 110160 110224 64 0.1
.bss 47696 47760 64 0.1
.rodata 129201 129265 64 0.0
.text 1318642 1324114 5472 0.4
ota-provider-app debug (read only) 1262441 1267977 5536 0.4
(read/write) 75592 75656 64 0.1
.bss 44640 44704 64 0.1
.rodata 113791 113855 64 0.1
.text 1051058 1056530 5472 0.5
ota-requestor-app debug (read only) 1348113 1353649 5536 0.4
(read/write) 79328 79392 64 0.1
.bss 47104 47168 64 0.1
.rodata 124808 124872 64 0.1
.text 1123330 1128802 5472 0.5
shell debug (read only) 798129 798209 80 0.0
.rodata 78639 78703 64 0.1
.text 615474 615490 16 0.0
tv-app debug (read only) 1865521 1871041 5520 0.3
(read/write) 318904 318968 64 0.0
.bss 250312 250376 64 0.0
.rodata 157637 157669 32 0.0
.text 1562754 1568242 5488 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2286616 2287384 768 0.0
.bss 179220 179284 64 0.0
.text 1249216 1249984 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272552 2273320 768 0.0
.bss 172084 172148 64 0.0
.text 1235152 1235920 768 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2248456 2249160 704 0.0
.bss 170972 171036 64 0.0
.text 1211056 1211760 704 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863591 864295 704 0.1
bss 110496 110560 64 0.1
text 581696 582344 648 0.1
nrf52840dk_nrf52840+rpc (read/write) 825991 826695 704 0.1
bss 106852 106916 64 0.1
text 555864 556512 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788634 789354 720 0.1
bss 111872 111936 64 0.1
text 511168 511816 648 0.1
lock-app nrf52840dk_nrf52840 (read/write) 839007 839727 720 0.1
bss 109520 109584 64 0.1
text 561788 562436 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 764310 765014 704 0.1
bss 110932 110996 64 0.1
text 491352 492000 648 0.1
pump-app nrf52840dk_nrf52840 (read/write) 845115 845835 720 0.1
bss 109660 109724 64 0.1
text 565972 566620 648 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 838707 839427 720 0.1
bss 109556 109620 64 0.1
text 561408 562056 648 0.1
p6 all-clusters-app default (read/write) 2296552 2297480 928 0.0
.bss 112208 112272 64 0.1
.text 1254816 1255744 928 0.1
lock-app default (read/write) 2214024 2214968 944 0.0
.bss 100832 100896 64 0.1
.text 1172288 1173232 944 0.1
qpg lighting-app qpg6100+debug (read only) 492800 493472 672 0.1
.bss 50176 50208 32 0.1
.text 487480 488152 672 0.1
lock-app qpg6100+debug (read only) 467780 468452 672 0.1
.bss 49120 49152 32 0.1
.text 462460 463132 672 0.1
telink lighting-app tlsr9518adk80d (read/write) 766926 767742 816 0.1
bss 79008 79072 64 0.1
text 532224 532972 748 0.1
Decreases (5 builds for mbed, p6)
platform target config section bd4515c dc8f7c0 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 852008 851944 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858784 858720 -64 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859904 859840 -64 -0.0
p6 all-clusters-app default .heap 918616 918552 -64 -0.0
lock-app default .heap 930112 930048 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bd4515c dc8f7c0 change % change
efr32 lighting-app BRD4161A (read only) 748512 749456 944 0.1
(read/write) 115476 115540 64 0.1
.bss 113676 113740 64 0.1
.data 1800 1800 0 0.0
.text 748504 749448 944 0.1
BRD4161A+rpc (read only) 736044 736988 944 0.1
(read/write) 132104 132168 64 0.0
.bss 130180 130244 64 0.0
.data 1924 1924 0 0.0
.text 736036 736980 944 0.1
lock-app BRD4161A (read only) 725584 726528 944 0.1
(read/write) 113260 113324 64 0.1
.bss 111500 111564 64 0.1
.data 1756 1756 0 0.0
.text 725576 726520 944 0.1
window-app BRD4161A (read only) 726560 727504 944 0.1
(read/write) 113580 113644 64 0.1
.bss 111820 111884 64 0.1
.data 1760 1760 0 0.0
.text 726552 727496 944 0.1
esp32 all-clusters-app c3devkit (read only) 827530 828296 766 0.1
(read/write) 1220066 1220130 64 0.0
.dram0.bss 56624 56688 64 0.1
.dram0.data 14084 14084 0 0.0
.flash.rodata 164104 164104 0 0.0
.flash.text 827530 828296 766 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 898495 899319 824 0.1
(read/write) 419388 419452 64 0.0
.dram0.bss 61976 62040 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 192076 192076 0 0.0
.flash.text 893111 893935 824 0.1
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 705932 706636 704 0.1
.bss 77100 77164 64 0.1
.data 1912 1912 0 0.0
.text 621120 621760 640 0.1
lock-app k32w061+debug (read/write) 597372 598076 704 0.1
.bss 67612 67676 64 0.1
.data 1880 1880 0 0.0
.text 522080 522720 640 0.1
shell k32w061+debug (read/write) 662700 663420 720 0.1
.bss 78740 78804 64 0.1
.data 1848 1848 0 0.0
.text 576312 576968 656 0.1
linux all-clusters-app debug (read only) 1718665 1724201 5536 0.3
(read/write) 126752 126816 64 0.1
.bss 57328 57392 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136277 136341 64 0.0
.text 1448434 1453906 5472 0.4
bridge-app debug+rpc (read only) 1313765 1319301 5536 0.4
(read/write) 76944 77008 64 0.1
.bss 42032 42096 64 0.2
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111620 111684 64 0.1
.text 1104741 1110213 5472 0.5
chip-tool debug (read only) 4975181 4980685 5504 0.1
(read/write) 166856 166920 64 0.0
.bss 40392 40456 64 0.2
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268330 268362 32 0.0
.text 4396341 4401813 5472 0.1
lighting-app debug+rpc (read only) 1582849 1588385 5536 0.3
(read/write) 110160 110224 64 0.1
.bss 47696 47760 64 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129201 129265 64 0.0
.text 1318642 1324114 5472 0.4
ota-provider-app debug (read only) 1262441 1267977 5536 0.4
(read/write) 75592 75656 64 0.1
.bss 44640 44704 64 0.1
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113791 113855 64 0.1
.text 1051058 1056530 5472 0.5
ota-requestor-app debug (read only) 1348113 1353649 5536 0.4
(read/write) 79328 79392 64 0.1
.bss 47104 47168 64 0.1
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124808 124872 64 0.1
.text 1123330 1128802 5472 0.5
shell debug (read only) 798129 798209 80 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78639 78703 64 0.1
.text 615474 615490 16 0.0
tv-app debug (read only) 1865521 1871041 5520 0.3
(read/write) 318904 318968 64 0.0
.bss 250312 250376 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157637 157669 32 0.0
.text 1562754 1568242 5488 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2286616 2287384 768 0.0
.bss 179220 179284 64 0.0
.data 5216 5216 0 0.0
.heap 852008 851944 -64 -0.0
.text 1249216 1249984 768 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272552 2273320 768 0.0
.bss 172084 172148 64 0.0
.data 5576 5576 0 0.0
.heap 858784 858720 -64 -0.0
.text 1235152 1235920 768 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248456 2249160 704 0.0
.bss 170972 171036 64 0.0
.data 5568 5568 0 0.0
.heap 859904 859840 -64 -0.0
.text 1211056 1211760 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050352 2050352 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1012952 1012952 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863591 864295 704 0.1
bss 110496 110560 64 0.1
rodata 95784 95784 0 0.0
text 581696 582344 648 0.1
nrf52840dk_nrf52840+rpc (read/write) 825991 826695 704 0.1
bss 106852 106916 64 0.1
rodata 86968 86968 0 0.0
text 555864 556512 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788634 789354 720 0.1
bss 111872 111936 64 0.1
rodata 91044 91044 0 0.0
text 511168 511816 648 0.1
lock-app nrf52840dk_nrf52840 (read/write) 839007 839727 720 0.1
bss 109520 109584 64 0.1
rodata 92256 92256 0 0.0
text 561788 562436 648 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 764310 765014 704 0.1
bss 110932 110996 64 0.1
rodata 87560 87560 0 0.0
text 491352 492000 648 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845115 845835 720 0.1
bss 109660 109724 64 0.1
rodata 93964 93964 0 0.0
text 565972 566620 648 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 838707 839427 720 0.1
bss 109556 109620 64 0.1
rodata 92212 92212 0 0.0
text 561408 562056 648 0.1
shell nrf52840dk_nrf52840 (read/write) 777795 777795 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521068 521068 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692850 692850 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441680 441680 0 0.0
p6 all-clusters-app default (read/write) 2296552 2297480 928 0.0
.bss 112208 112272 64 0.1
.data 2520 2520 0 0.0
.heap 918616 918552 -64 -0.0
.text 1254816 1255744 928 0.1
lock-app default (read/write) 2214024 2214968 944 0.0
.bss 100832 100896 64 0.1
.data 2400 2400 0 0.0
.heap 930112 930048 -64 -0.0
.text 1172288 1173232 944 0.1
qpg lighting-app qpg6100+debug (read only) 492800 493472 672 0.1
(read/write) 114144 114144 0 0.0
.bss 50176 50208 32 0.1
.data 1008 1008 0 0.0
.text 487480 488152 672 0.1
lock-app qpg6100+debug (read only) 467780 468452 672 0.1
(read/write) 114140 114140 0 0.0
.bss 49120 49152 32 0.1
.data 964 964 0 0.0
.text 462460 463132 672 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 766926 767742 816 0.1
bss 79008 79072 64 0.1
noinit 37160 37160 0 0.0
text 532224 532972 748 0.1

@yunhanw-google yunhanw-google merged commit f3d6b7c into project-chip:master Nov 17, 2021
bzbarsky-apple
bzbarsky-apple reviewed Nov 17, 2021
View reviewed changes
src/app/ReadClient.h Show resolved Hide resolved
src/app/MessageDef/EventDataIB.cpp Show resolved Hide resolved
src/app/ReadClient.h Show resolved Hide resolved
src/controller/ReadInteraction.h Show resolved Hide resolved
src/controller/ReadInteraction.h Show resolved Hide resolved
src/controller/ReadInteraction.h Show resolved Hide resolved
src/controller/ReadInteraction.h Show resolved Hide resolved
src/controller/TypedReadCallback.h Show resolved Hide resolved
src/controller/TypedReadCallback.h Show resolved Hide resolved
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 18, 2021
Closed
@mrjerryjohns mrjerryjohns mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@LuDuda LuDuda LuDuda approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees
No one assigned
Labels
app controller lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yunhanw-google @electrocucaracha @LuDuda @mrjerryjohns @chrisdecenzo @bzbarsky-apple @jmartinez-silabs