Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a TestCluster response command that just returns a boolean. #11397

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Add a TestCluster response command that just returns a boolean. #11397

merged 1 commit into from
Nov 4, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Use this instead of relying on status codes in various tests.

Fixes #10555

Problem

See #10555

Change overview

See above.

Testing

Ran the TestClusterComplexTypes yaml test and it passes.

@bzbarsky-apple
Add a TestCluster response command that just returns a boolean.
ca6173a 
Use this instead of relying on status codes in various tests.

Fixes project-chip#10555
@bzbarsky-apple bzbarsky-apple force-pushed the test-cluster-boolean-response branch from 92b4431 to ca6173a Compare November 3, 2021 22:55
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11397: Size comparison from 38fe11e to ca6173a

Increases (6 builds for esp32, linux, mbed, p6)
platform target config section 38fe11e ca6173a change % change
esp32 all-clusters-app c3devkit (read only) 880670 880858 188 0.0
.flash.text 880670 880858 188 0.0
m5stack (read only) 911823 911955 132 0.0
.flash.text 911823 911955 132 0.0
linux all-clusters-app debug (read only) 1691153 1692241 1088 0.1
.text 1417810 1418898 1088 0.1
chip-tool debug (read only) 4422981 4428797 5816 0.1
(read/write) 125888 125952 64 0.1
.data.rel.ro 100032 100096 64 0.1
.rodata 226384 226512 128 0.1
.text 3928277 3933845 5568 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293160 2293288 128 0.0
.text 1255760 1255888 128 0.0
p6 all-clusters-app default (read/write) 2300656 2300832 176 0.0
.text 1258920 1259096 176 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 38fe11e ca6173a change % change
efr32 lighting-app BRD4161A (read only) 737168 737168 0 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737160 737160 0 0.0
BRD4161A+rpc (read only) 726364 726364 0 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726356 726356 0 0.0
lock-app BRD4161A (read only) 716432 716432 0 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716424 716424 0 0.0
window-app BRD4161A (read only) 717332 717332 0 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717324 717324 0 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880858 188 0.0
(read/write) 1308064 1308064 0 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199776 0 0.0
.flash.text 880670 880858 188 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911823 911955 132 0.0
(read/write) 427828 427828 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208476 0 0.0
.flash.text 911823 911955 132 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699416 699416 0 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 613888 613888 0 0.0
lock-app k32w061+debug (read/write) 591724 591724 0 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515716 515716 0 0.0
shell k32w061+debug (read/write) 657656 657656 0 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571024 571024 0 0.0
linux all-clusters-app debug (read only) 1691153 1692241 1088 0.1
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139925 139925 0 0.0
.text 1417810 1418898 1088 0.1
bridge-app debug+rpc (read only) 1287373 1287373 0 0.0
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1080021 1080021 0 0.0
chip-tool debug (read only) 4422981 4428797 5816 0.1
(read/write) 125888 125952 64 0.1
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100096 64 0.1
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226384 226512 128 0.1
.text 3928277 3933845 5568 0.1
lighting-app debug+rpc (read only) 1548401 1548401 0 0.0
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130129 130129 0 0.0
.text 1284690 1284690 0 0.0
ota-provider-app debug (read only) 1243889 1243889 0 0.0
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112456 112456 0 0.0
.text 1035330 1035330 0 0.0
ota-requestor-app debug (read only) 1311169 1311169 0 0.0
(read/write) 76808 76808 0 0.0
.bss 45344 45344 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123344 123344 0 0.0
.text 1090034 1090034 0 0.0
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1810537 1810537 0 0.0
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155528 155528 0 0.0
.text 1512722 1512722 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293160 2293288 128 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255760 1255888 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272728 2272728 0 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235328 1235328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250448 2250448 0 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213048 1213048 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861379 0 0.0
bss 111288 111288 0 0.0
rodata 96772 96772 0 0.0
text 577712 577712 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 823755 0 0.0
bss 107640 107640 0 0.0
rodata 87948 87948 0 0.0
text 551896 551896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786418 0 0.0
bss 112664 112664 0 0.0
rodata 92028 92028 0 0.0
text 507168 507168 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838083 0 0.0
bss 110324 110324 0 0.0
rodata 93140 93140 0 0.0
text 559188 559188 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763382 0 0.0
bss 111732 111732 0 0.0
rodata 88448 88448 0 0.0
text 488736 488736 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844195 0 0.0
bss 110460 110460 0 0.0
rodata 94852 94852 0 0.0
text 563368 563368 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837955 0 0.0
bss 110360 110360 0 0.0
rodata 93140 93140 0 0.0
text 558924 558924 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2300656 2300832 176 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1258920 1259096 176 0.0
lock-app default (read/write) 2213648 2213648 0 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1171912 1171912 0 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490708 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485388 485388 0 0.0
lock-app qpg6100+debug (read only) 467048 467048 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461728 461728 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458058 458058 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, as this is adding tests.

@woody-apple woody-apple merged commit 1538bbb into project-chip:master Nov 4, 2021
@bzbarsky-apple bzbarsky-apple deleted the test-cluster-boolean-response branch November 4, 2021 14:27
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Add a TestCluster response command that just returns a boolean. (proj…
cb6ecba 
…ect-chip#11397)

Use this instead of relying on status codes in various tests.

Fixes project-chip#10555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin fast track review - pending
Projects
None yet
Milestone
No milestone
3 participants
@bzbarsky-apple @woody-apple @msandstedt