Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TestCluster] Add a respondWithBoolean response command to differentiate between parsing error and expected behaviours #10555

Closed
vivien-apple opened this issue Oct 15, 2021 · 0 comments · Fixed by #11397
Closed

[TestCluster] Add a respondWithBoolean response command to differentiate between parsing error and expected behaviours #10555

vivien-apple opened this issue Oct 15, 2021 · 0 comments · Fixed by #11397

Comments

@vivien-apple
Copy link
Contributor

As a followup, maybe define a "respond with boolean" response command and use that, so we can tell apart "parsing failed" and "test is working as it should and responding with false"?

Originally posted by @bzbarsky-apple in #10498 (comment)
This was referenced Oct 15, 2021
Merged
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 3, 2021
@bzbarsky-apple
Add a TestCluster response command that just returns a boolean.
92b4431 
Use this instead of relying on status codes in various tests.

Fixes project-chip#10555
@bzbarsky-apple bzbarsky-apple mentioned this issue Nov 3, 2021
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 3, 2021
@bzbarsky-apple
Add a TestCluster response command that just returns a boolean.
ca6173a 
Use this instead of relying on status codes in various tests.

Fixes project-chip#10555
woody-apple pushed a commit that referenced this issue Nov 4, 2021
@bzbarsky-apple
Add a TestCluster response command that just returns a boolean. (#11397)
1538bbb 
Use this instead of relying on status codes in various tests.

Fixes #10555
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this issue Dec 3, 2021
@bzbarsky-apple
Add a TestCluster response command that just returns a boolean. (proj…
cb6ecba 
…ect-chip#11397)

Use this instead of relying on status codes in various tests.

Fixes project-chip#10555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a TestCluster response command that just returns a boolean. bzbarsky-apple/connectedhomeip
1 participant
@vivien-apple