Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Pull up LayerLwIP::ScheduleLambda to SystemLayer" #11341

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Revert "Pull up LayerLwIP::ScheduleLambda to SystemLayer" #11341

merged 1 commit into from
Nov 3, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Reverts #11187 because it causes all-clusters-app on m5stack to boot-loop and the p6 lock app to hang on startup.

@bzbarsky-apple
Copy link
Contributor Author

Specifically, git bisect says, for the esp32 boot loop:

16cd474e9068e3184865603e8812849b1cc0644c is the first bad commit
commit 16cd474e9068e3184865603e8812849b1cc0644c
Author: Zang MingJie <[email protected]>
Date:   Tue Nov 2 21:57:36 2021 +0800

    Pull up LayerLwIP::ScheduleLambda to SystemLayer (#11187)

The actual output there is:

Guru Meditation Error: Core  1 panic'ed (LoadProhibited). Exception was unhandled.

Core  1 register dump:
PC      : 0x400fa36d  PS      : 0x00060a30  A0      : 0x800f9be8  A1      : 0x3ffe6840  
0x400fa36d: chip::System::Timer::HandleComplete() at /Users/bzbarsky/connectedhomeip/examples/all-clusters-app/esp32/build/esp-idf/chip/../../../../../../config/esp32/third_party/connectedhomeip/src/system/SystemTimer.cpp:118

A2      : 0x00000064  A3      : 0x00000000  A4      : 0x00060a20  A5      : 0x3ffe68e0  
A6      : 0x3ffbc6b0  A7      : 0x400ff188  A8      : 0x800fc750  A9      : 0x3ffe6820  
0x400ff188: chip::DeviceLayer::ConnectivityManagerImpl::DriveStationState(chip::System::Layer*, void*) at /Users/bzbarsky/connectedhomeip/examples/all-clusters-app/esp32/build/esp-idf/chip/../../../../../../config/esp32/third_party/connectedhomeip/src/platform/ESP32/ConnectivityManagerImpl_WiFi.cpp:683

A10     : 0x00000064  A11     : 0x00000000  A12     : 0x00000488  A13     : 0x00000000  
A14     : 0x3ffe6840  A15     : 0x3ffe67b0  SAR     : 0x00000007  EXCCAUSE: 0x0000001c  
EXCVADDR: 0x00000070  LBEG    : 0x4000c2e0  LEND    : 0x4000c2f6  LCOUNT  : 0x00000000  

Backtrace:0x400fa36a:0x3ffe6840 0x400f9be5:0x3ffe6860 0x400fd9ed:0x3ffe6880 0x400fdbde:0x3ffe68a0 0x400fdc05:0x3ffe6900 0x400951c1:0x3ffe6920
0x400fa36a: chip::System::Timer::HandleComplete() at /Users/bzbarsky/connectedhomeip/examples/all-clusters-app/esp32/build/esp-idf/chip/../../../../../../config/esp32/third_party/connectedhomeip/src/system/SystemTimer.cpp:115

0x400f9be5: operator() at /Users/bzbarsky/connectedhomeip/examples/all-clusters-app/esp32/build/esp-idf/chip/../../../../../../config/esp32/third_party/connectedhomeip/src/system/SystemLayerImplLwIP.cpp:97
 (inlined by) operator() at /Users/bzbarsky/connectedhomeip/examples/all-clusters-app/esp32/build/esp-idf/chip/../../../../../../config/esp32/third_party/connectedhomeip/src/lib/support/LambdaBridge.h:39
 (inlined by) _FUN at /Users/bzbarsky/connectedhomeip/examples/all-clusters-app/esp32/build/esp-idf/chip/../../../../../../config/esp32/third_party/connectedhomeip/src/lib/support/LambdaBridge.h:38

@bzbarsky-apple
Copy link
Contributor Author

Hotfix; this is blocking testing of other PRs, and is a straight revert.

@bzbarsky-apple bzbarsky-apple added the hotfix urgent fix needed, can bypass review label Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11341: Size comparison from cb7c854 to e1211c7

Increases (11 builds for efr32, esp32, k32w, qpg)
platform target config section cb7c854 e1211c7 change % change
efr32 lighting-app BRD4161A (read only) 737128 737168 40 0.0
.text 737120 737160 40 0.0
BRD4161A+rpc (read only) 724552 724592 40 0.0
.text 724544 724584 40 0.0
lock-app BRD4161A (read only) 716392 716448 56 0.0
.text 716384 716440 56 0.0
window-app BRD4161A (read only) 717308 717348 40 0.0
.text 717300 717340 40 0.0
esp32 all-clusters-app c3devkit (read only) 880594 880618 24 0.0
(read/write) 1308072 1308080 8 0.0
.flash.rodata 199768 199776 8 0.0
.flash.text 880594 880618 24 0.0
m5stack (read/write) 427844 427852 8 0.0
.flash.rodata 208468 208476 8 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699408 699448 40 0.0
.text 613848 613888 40 0.0
lock-app k32w061+debug (read/write) 591716 591756 40 0.0
.text 515676 515716 40 0.0
shell k32w061+debug (read/write) 424884 424916 32 0.0
.text 359216 359248 32 0.0
qpg lighting-app qpg6100+debug (read only) 490680 490712 32 0.0
.text 485360 485392 32 0.0
lock-app qpg6100+debug (read only) 467016 467048 32 0.0
.text 461696 461728 32 0.0
Decreases (1 build for esp32)
platform target config section cb7c854 e1211c7 change % change
esp32 all-clusters-app m5stack (read only) 911719 911667 -52 -0.0
.flash.text 911719 911667 -52 -0.0
Full report (12 builds for efr32, esp32, k32w, qpg)
platform target config section cb7c854 e1211c7 change % change
efr32 lighting-app BRD4161A (read only) 737128 737168 40 0.0
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737120 737160 40 0.0
BRD4161A+rpc (read only) 724552 724592 40 0.0
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724544 724584 40 0.0
lock-app BRD4161A (read only) 716392 716448 56 0.0
(read/write) 112436 112436 0 0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716384 716440 56 0.0
window-app BRD4161A (read only) 717308 717348 40 0.0
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717300 717340 40 0.0
esp32 all-clusters-app c3devkit (read only) 880594 880618 24 0.0
(read/write) 1308072 1308080 8 0.0
.dram0.bss 58608 58608 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199768 199776 8 0.0
.flash.text 880594 880618 24 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911719 911667 -52 -0.0
(read/write) 427844 427852 8 0.0
.dram0.bss 61112 61112 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208468 208476 8 0.0
.flash.text 911719 911667 -52 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699408 699448 40 0.0
.bss 77856 77856 0 0.0
.data 1904 1904 0 0.0
.text 613848 613888 40 0.0
lock-app k32w061+debug (read/write) 591716 591756 40 0.0
.bss 68372 68372 0 0.0
.data 1868 1868 0 0.0
.text 515676 515716 40 0.0
shell k32w061+debug (read/write) 424884 424916 32 0.0
.bss 63296 63296 0 0.0
.data 668 668 0 0.0
.text 359216 359248 32 0.0
qpg lighting-app qpg6100+debug (read only) 490680 490712 32 0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485360 485392 32 0.0
lock-app qpg6100+debug (read only) 467016 467048 32 0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461696 461728 32 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit c9db3dc into master Nov 3, 2021
@bzbarsky-apple bzbarsky-apple deleted the revert-11187-schedule-lambda branch November 3, 2021 00:12
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Revert "Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chi…
e53f6d3 
…p#11187)" (project-chip#11341)

This reverts commit 16cd474.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
hotfix urgent fix needed, can bypass review lib platform review - pending system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @woody-apple