Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull up LayerLwIP::ScheduleLambda to SystemLayer #11187

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Pull up LayerLwIP::ScheduleLambda to SystemLayer #11187

merged 1 commit into from
Nov 2, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Oct 29, 2021 •
edited
Loading

Problem

ScheduleLambda is a convenient function, should be available on all platforms

Change overview

Pull up LayerLwIP::ScheduleLambda to SystemLayer

Implement ScheduleLambdaBridge for LayerImplLibevent and LayerImplSelect

Testing

Verified by unit-tests

@restyled-io restyled-io bot mentioned this pull request Oct 29, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11187: Size comparison from 3947eba to 52d2fe1

Increases (9 builds for esp32, linux)
platform target config section 3947eba 52d2fe1 change % change
esp32 all-clusters-app m5stack (read only) 911375 911427 52 0.0
.flash.text 911375 911427 52 0.0
linux all-clusters-app debug (read only) 1687001 1687033 32 0.0
.text 1415874 1415906 32 0.0
bridge-app debug+rpc (read only) 1281957 1281989 32 0.0
.text 1076693 1076725 32 0.0
chip-tool debug (read only) 4314925 4314957 32 0.0
.text 3831621 3831653 32 0.0
lighting-app debug+rpc (read only) 1540865 1540897 32 0.0
.text 1280370 1280402 32 0.0
ota-provider-app debug (read only) 1239033 1239065 32 0.0
.text 1032498 1032530 32 0.0
ota-requestor-app debug (read only) 1302033 1302065 32 0.0
.text 1077170 1077202 32 0.0
shell debug (read only) 786145 786193 48 0.0
.text 607186 607234 48 0.0
tv-app debug (read only) 1773337 1773369 32 0.0
.text 1477682 1477714 32 0.0
Decreases (13 builds for efr32, esp32, k32w, p6, qpg)
platform target config section 3947eba 52d2fe1 change % change
efr32 lighting-app BRD4161A (read only) 736636 736596 -40 -0.0
.text 736628 736588 -40 -0.0
BRD4161A+rpc (read only) 724076 724036 -40 -0.0
.text 724068 724028 -40 -0.0
lock-app BRD4161A (read only) 715932 715892 -40 -0.0
.text 715924 715884 -40 -0.0
window-app BRD4161A (read only) 716836 716796 -40 -0.0
.text 716828 716788 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 880562 880538 -24 -0.0
(read/write) 1307800 1307792 -8 -0.0
.flash.rodata 199640 199632 -8 -0.0
.flash.text 880562 880538 -24 -0.0
m5stack (read/write) 427560 427552 -8 -0.0
.flash.rodata 208344 208336 -8 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699088 -40 -0.0
.text 613708 613668 -40 -0.0
lock-app k32w061+debug (read/write) 591432 591392 -40 -0.0
.text 515548 515508 -40 -0.0
shell k32w061+debug (read/write) 424988 424956 -32 -0.0
.text 359332 359300 -32 -0.0
p6 lock-app default (read/write) 2167872 2167832 -40 -0.0
.text 1126136 1126096 -40 -0.0
qpg lighting-app qpg6100+debug (read only) 490500 490476 -24 -0.0
.text 485180 485156 -24 -0.0
lock-app qpg6100+debug (read only) 466844 466820 -24 -0.0
.text 461524 461500 -24 -0.0
persistent-storage-app qpg6100+debug (read only) 155820 155796 -24 -0.0
.text 150500 150476 -24 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3947eba 52d2fe1 change % change
efr32 lighting-app BRD4161A (read only) 736636 736596 -40 -0.0
(read/write) 114476 114476 0 0.0
.bss 112724 112724 0 0.0
.data 1752 1752 0 0.0
.text 736628 736588 -40 -0.0
BRD4161A+rpc (read only) 724076 724036 -40 -0.0
(read/write) 131080 131080 0 0.0
.bss 129228 129228 0 0.0
.data 1852 1852 0 0.0
.text 724068 724028 -40 -0.0
lock-app BRD4161A (read only) 715932 715892 -40 -0.0
(read/write) 112292 112292 0 0.0
.bss 110580 110580 0 0.0
.data 1712 1712 0 0.0
.text 715924 715884 -40 -0.0
window-app BRD4161A (read only) 716836 716796 -40 -0.0
(read/write) 112616 112616 0 0.0
.bss 110900 110900 0 0.0
.data 1716 1716 0 0.0
.text 716828 716788 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 880562 880538 -24 -0.0
(read/write) 1307800 1307792 -8 -0.0
.dram0.bss 58456 58456 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199640 199632 -8 -0.0
.flash.text 880562 880538 -24 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911375 911427 52 0.0
(read/write) 427560 427552 -8 -0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208344 208336 -8 -0.0
.flash.text 911375 911427 52 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699088 -40 -0.0
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 613668 -40 -0.0
lock-app k32w061+debug (read/write) 591432 591392 -40 -0.0
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 515508 -40 -0.0
shell k32w061+debug (read/write) 424988 424956 -32 -0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359300 -32 -0.0
linux all-clusters-app debug (read only) 1687001 1687033 32 0.0
(read/write) 119024 119024 0 0.0
.bss 50640 50640 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 138069 0 0.0
.text 1415874 1415906 32 0.0
bridge-app debug+rpc (read only) 1281957 1281989 32 0.0
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110020 0 0.0
.text 1076693 1076725 32 0.0
chip-tool debug (read only) 4314925 4314957 32 0.0
(read/write) 123648 123648 0 0.0
.bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98928 98928 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217360 217360 0 0.0
.text 3831621 3831653 32 0.0
lighting-app debug+rpc (read only) 1540865 1540897 32 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1280370 1280402 32 0.0
ota-provider-app debug (read only) 1239033 1239065 32 0.0
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110408 0 0.0
.text 1032498 1032530 32 0.0
ota-requestor-app debug (read only) 1302033 1302065 32 0.0
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127072 0 0.0
.text 1077170 1077202 32 0.0
shell debug (read only) 786145 786193 48 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607234 48 0.0
tv-app debug (read only) 1773337 1773369 32 0.0
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153464 0 0.0
.text 1477682 1477714 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2294952 0 0.0
.bss 179828 179828 0 0.0
.data 5216 5216 0 0.0
.heap 851400 851400 0 0.0
.text 1257552 1257552 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274336 0 0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1236936 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2252056 0 0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861267 0 0.0
bss 111180 111180 0 0.0
rodata 96860 96860 0 0.0
text 577612 577612 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822095 0 0.0
bss 107424 107424 0 0.0
rodata 87640 87640 0 0.0
text 550784 550784 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786306 0 0.0
bss 112556 112556 0 0.0
rodata 92100 92100 0 0.0
text 507080 507080 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 837975 0 0.0
bss 110216 110216 0 0.0
rodata 93216 93216 0 0.0
text 559092 559092 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763270 0 0.0
bss 111628 111628 0 0.0
rodata 88520 88520 0 0.0
text 488652 488652 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842643 0 0.0
bss 110352 110352 0 0.0
rodata 94460 94460 0 0.0
text 562300 562300 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 837947 0 0.0
bss 110252 110252 0 0.0
rodata 93236 93236 0 0.0
text 558932 558932 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2167832 -40 -0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126096 -40 -0.0
qpg lighting-app qpg6100+debug (read only) 490500 490476 -24 -0.0
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485156 -24 -0.0
lock-app qpg6100+debug (read only) 466844 466820 -24 -0.0
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461524 461500 -24 -0.0
persistent-storage-app qpg6100+debug (read only) 155820 155796 -24 -0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150476 -24 -0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662890 0 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458036 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11187: Size comparison from 1073bb2 to 5379c9f

Increases (8 builds for linux)
platform target config section 1073bb2 5379c9f change % change
linux all-clusters-app debug (read only) 1684281 1684313 32 0.0
.text 1413730 1413762 32 0.0
bridge-app debug+rpc (read only) 1279205 1279237 32 0.0
.text 1074549 1074581 32 0.0
chip-tool debug (read only) 4313789 4313821 32 0.0
.text 3830805 3830837 32 0.0
lighting-app debug+rpc (read only) 1538145 1538177 32 0.0
.text 1278226 1278258 32 0.0
ota-provider-app debug (read only) 1236185 1236233 48 0.0
.text 1030258 1030306 48 0.0
ota-requestor-app debug (read only) 1293681 1293713 32 0.0
.text 1074770 1074802 32 0.0
shell debug (read only) 786145 786193 48 0.0
.text 607186 607234 48 0.0
tv-app debug (read only) 1771081 1771113 32 0.0
.text 1476354 1476386 32 0.0
Decreases (11 builds for efr32, k32w, p6, qpg)
platform target config section 1073bb2 5379c9f change % change
efr32 lighting-app BRD4161A (read only) 735256 735216 -40 -0.0
.text 735248 735208 -40 -0.0
BRD4161A+rpc (read only) 722680 722640 -40 -0.0
.text 722672 722632 -40 -0.0
lock-app BRD4161A (read only) 714552 714496 -56 -0.0
.text 714544 714488 -56 -0.0
window-app BRD4161A (read only) 715440 715400 -40 -0.0
.text 715432 715392 -40 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 698016 697976 -40 -0.0
.text 612628 612588 -40 -0.0
lock-app k32w061+debug (read/write) 590320 590280 -40 -0.0
.text 514468 514428 -40 -0.0
shell k32w061+debug (read/write) 424988 424956 -32 -0.0
.text 359332 359300 -32 -0.0
p6 lock-app default (read/write) 2166464 2166424 -40 -0.0
.text 1124728 1124688 -40 -0.0
qpg lighting-app qpg6100+debug (read only) 489412 489380 -32 -0.0
.text 484092 484060 -32 -0.0
lock-app qpg6100+debug (read only) 465752 465720 -32 -0.0
.text 460432 460400 -32 -0.0
persistent-storage-app qpg6100+debug (read only) 155820 155796 -24 -0.0
.text 150500 150476 -24 -0.0
Full report (20 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 1073bb2 5379c9f change % change
efr32 lighting-app BRD4161A (read only) 735256 735216 -40 -0.0
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735248 735208 -40 -0.0
BRD4161A+rpc (read only) 722680 722640 -40 -0.0
(read/write) 131052 131052 0 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 722672 722632 -40 -0.0
lock-app BRD4161A (read only) 714552 714496 -56 -0.0
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714544 714488 -56 -0.0
window-app BRD4161A (read only) 715440 715400 -40 -0.0
(read/write) 112588 112588 0 0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715432 715392 -40 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 698016 697976 -40 -0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612628 612588 -40 -0.0
lock-app k32w061+debug (read/write) 590320 590280 -40 -0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514468 514428 -40 -0.0
shell k32w061+debug (read/write) 424988 424956 -32 -0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359300 -32 -0.0
linux all-clusters-app debug (read only) 1684281 1684313 32 0.0
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137493 137493 0 0.0
.text 1413730 1413762 32 0.0
bridge-app debug+rpc (read only) 1279205 1279237 32 0.0
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109412 109412 0 0.0
.text 1074549 1074581 32 0.0
chip-tool debug (read only) 4313789 4313821 32 0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217328 217328 0 0.0
.text 3830805 3830837 32 0.0
lighting-app debug+rpc (read only) 1538145 1538177 32 0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127537 127537 0 0.0
.text 1278226 1278258 32 0.0
ota-provider-app debug (read only) 1236185 1236233 48 0.0
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 109800 109800 0 0.0
.text 1030258 1030306 48 0.0
ota-requestor-app debug (read only) 1293681 1293713 32 0.0
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121120 121120 0 0.0
.text 1074770 1074802 32 0.0
shell debug (read only) 786145 786193 48 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607234 48 0.0
tv-app debug (read only) 1771081 1771113 32 0.0
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152824 152824 0 0.0
.text 1476354 1476386 32 0.0
p6 lock-app default (read/write) 2166464 2166424 -40 -0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124728 1124688 -40 -0.0
qpg lighting-app qpg6100+debug (read only) 489412 489380 -32 -0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484092 484060 -32 -0.0
lock-app qpg6100+debug (read only) 465752 465720 -32 -0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460432 460400 -32 -0.0
persistent-storage-app qpg6100+debug (read only) 155820 155796 -24 -0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150476 -24 -0.0
telink lighting-app tlsr9518adk80d (read/write) 661646 661646 0 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457394 457394 0 0.0

andy31415
andy31415 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except please convert struct to class and delete the @file comments.

src/lib/support/LambdaBridge.h Outdated Show resolved Hide resolved
src/system/SystemLayer.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11187: Size comparison from 1073bb2 to c17aa5c

Increases (8 builds for linux)
platform target config section 1073bb2 c17aa5c change % change
linux all-clusters-app debug (read only) 1684281 1684313 32 0.0
.text 1413730 1413762 32 0.0
bridge-app debug+rpc (read only) 1279205 1279237 32 0.0
.text 1074549 1074581 32 0.0
chip-tool debug (read only) 4313789 4313821 32 0.0
.text 3830805 3830837 32 0.0
lighting-app debug+rpc (read only) 1538145 1538177 32 0.0
.text 1278226 1278258 32 0.0
ota-provider-app debug (read only) 1236185 1236233 48 0.0
.text 1030258 1030306 48 0.0
ota-requestor-app debug (read only) 1293681 1293713 32 0.0
.text 1074770 1074802 32 0.0
shell debug (read only) 786145 786193 48 0.0
.text 607186 607234 48 0.0
tv-app debug (read only) 1771081 1771113 32 0.0
.text 1476354 1476386 32 0.0
Decreases (13 builds for efr32, esp32, k32w, p6, qpg)
platform target config section 1073bb2 c17aa5c change % change
efr32 lighting-app BRD4161A (read only) 735256 735216 -40 -0.0
.text 735248 735208 -40 -0.0
BRD4161A+rpc (read only) 722680 722640 -40 -0.0
.text 722672 722632 -40 -0.0
lock-app BRD4161A (read only) 714552 714496 -56 -0.0
.text 714544 714488 -56 -0.0
window-app BRD4161A (read only) 715440 715400 -40 -0.0
.text 715432 715392 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 879954 879930 -24 -0.0
(read/write) 1307184 1307176 -8 -0.0
.flash.rodata 199056 199048 -8 -0.0
.flash.text 879954 879930 -24 -0.0
m5stack (read only) 910915 910887 -28 -0.0
(read/write) 426968 426960 -8 -0.0
.flash.rodata 207784 207776 -8 -0.0
.flash.text 910915 910887 -28 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 698016 697976 -40 -0.0
.text 612628 612588 -40 -0.0
lock-app k32w061+debug (read/write) 590320 590280 -40 -0.0
.text 514468 514428 -40 -0.0
shell k32w061+debug (read/write) 424988 424956 -32 -0.0
.text 359332 359300 -32 -0.0
p6 lock-app default (read/write) 2166464 2166424 -40 -0.0
.text 1124728 1124688 -40 -0.0
qpg lighting-app qpg6100+debug (read only) 489412 489380 -32 -0.0
.text 484092 484060 -32 -0.0
lock-app qpg6100+debug (read only) 465752 465720 -32 -0.0
.text 460432 460400 -32 -0.0
persistent-storage-app qpg6100+debug (read only) 155820 155796 -24 -0.0
.text 150500 150476 -24 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1073bb2 c17aa5c change % change
efr32 lighting-app BRD4161A (read only) 735256 735216 -40 -0.0
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735248 735208 -40 -0.0
BRD4161A+rpc (read only) 722680 722640 -40 -0.0
(read/write) 131052 131052 0 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 722672 722632 -40 -0.0
lock-app BRD4161A (read only) 714552 714496 -56 -0.0
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714544 714488 -56 -0.0
window-app BRD4161A (read only) 715440 715400 -40 -0.0
(read/write) 112588 112588 0 0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715432 715392 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 879954 879930 -24 -0.0
(read/write) 1307184 1307176 -8 -0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199056 199048 -8 -0.0
.flash.text 879954 879930 -24 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 910915 910887 -28 -0.0
(read/write) 426968 426960 -8 -0.0
.dram0.bss 60920 60920 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 207784 207776 -8 -0.0
.flash.text 910915 910887 -28 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698016 697976 -40 -0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612628 612588 -40 -0.0
lock-app k32w061+debug (read/write) 590320 590280 -40 -0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514468 514428 -40 -0.0
shell k32w061+debug (read/write) 424988 424956 -32 -0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359300 -32 -0.0
linux all-clusters-app debug (read only) 1684281 1684313 32 0.0
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137493 137493 0 0.0
.text 1413730 1413762 32 0.0
bridge-app debug+rpc (read only) 1279205 1279237 32 0.0
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109412 109412 0 0.0
.text 1074549 1074581 32 0.0
chip-tool debug (read only) 4313789 4313821 32 0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217328 217328 0 0.0
.text 3830805 3830837 32 0.0
lighting-app debug+rpc (read only) 1538145 1538177 32 0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127537 127537 0 0.0
.text 1278226 1278258 32 0.0
ota-provider-app debug (read only) 1236185 1236233 48 0.0
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 109800 109800 0 0.0
.text 1030258 1030306 48 0.0
ota-requestor-app debug (read only) 1293681 1293713 32 0.0
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121120 121120 0 0.0
.text 1074770 1074802 32 0.0
shell debug (read only) 786145 786193 48 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607234 48 0.0
tv-app debug (read only) 1771081 1771113 32 0.0
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152824 152824 0 0.0
.text 1476354 1476386 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293808 2293808 0 0.0
.bss 179796 179796 0 0.0
.data 5216 5216 0 0.0
.heap 851432 851432 0 0.0
.text 1256408 1256408 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273256 2273256 0 0.0
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1235856 1235856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250912 2250912 0 0.0
.bss 170740 170740 0 0.0
.data 5552 5552 0 0.0
.heap 860152 860152 0 0.0
.text 1213512 1213512 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860167 860167 0 0.0
bss 111148 111148 0 0.0
rodata 96304 96304 0 0.0
text 577100 577100 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 820991 820991 0 0.0
bss 107392 107392 0 0.0
rodata 87080 87080 0 0.0
text 550276 550276 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785210 785210 0 0.0
bss 112524 112524 0 0.0
rodata 91548 91548 0 0.0
text 506568 506568 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836875 836875 0 0.0
bss 110184 110184 0 0.0
rodata 92660 92660 0 0.0
text 558580 558580 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762170 762170 0 0.0
bss 111596 111596 0 0.0
rodata 87964 87964 0 0.0
text 488140 488140 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841547 841547 0 0.0
bss 110320 110320 0 0.0
rodata 93908 93908 0 0.0
text 561792 561792 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836867 836867 0 0.0
bss 110220 110220 0 0.0
rodata 92684 92684 0 0.0
text 558424 558424 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2166464 2166424 -40 -0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124728 1124688 -40 -0.0
qpg lighting-app qpg6100+debug (read only) 489412 489380 -32 -0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484092 484060 -32 -0.0
lock-app qpg6100+debug (read only) 465752 465720 -32 -0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460432 460400 -32 -0.0
persistent-storage-app qpg6100+debug (read only) 155820 155796 -24 -0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150476 -24 -0.0
telink lighting-app tlsr9518adk80d (read/write) 661646 661646 0 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457394 457394 0 0.0

@andy31415
Copy link
Contributor

andy31415 commented Nov 2, 2021 •
edited
Loading

fast track: several days old PR (had time to review) with several checkmarks already.

@andy31415 andy31415 merged commit 16cd474 into project-chip:master Nov 2, 2021
@kghost kghost deleted the schedule-lambda branch November 2, 2021 14:29
bzbarsky-apple added a commit that referenced this pull request Nov 2, 2021
@bzbarsky-apple
Revert "Pull up LayerLwIP::ScheduleLambda to SystemLayer (#11187)"
e1211c7 
This reverts commit 16cd474.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 2, 2021
Merged
bzbarsky-apple added a commit that referenced this pull request Nov 3, 2021
@bzbarsky-apple
Revert "Pull up LayerLwIP::ScheduleLambda to SystemLayer (#11187)" (#…
c9db3dc 
…11341)

This reverts commit 16cd474.
@bzbarsky-apple
Copy link
Contributor

@kghost Note that this was reverted because it broke various platforms...

kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 3, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
092a272
@kghost kghost mentioned this pull request Nov 3, 2021
Merged
kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 3, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
27ea53e
kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 3, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
8be8640
kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 3, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
f19d78f
kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 3, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
8c04ee8
kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 4, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
7440624
kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 4, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
4a0c43d
kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 4, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
baff164
kghost added a commit to kghost/connectedhomeip that referenced this pull request Nov 4, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
bedcb91
woody-apple pushed a commit to kghost/connectedhomeip that referenced this pull request Nov 4, 2021
@kghost @woody-apple
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
d243216
bzbarsky-apple pushed a commit that referenced this pull request Nov 5, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (#11361)
39ff9bf 
* Pull up LayerLwIP::ScheduleLambda to SystemLayer (#11187)

* Fix ScheduleLambda and Add unit-tests
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)
0bd6749
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Revert "Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chi…
e53f6d3 
…p#11187)" (project-chip#11341)

This reverts commit 16cd474.
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kghost
Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11361)
b6de0b3 
* Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187)

* Fix ScheduleLambda and Add unit-tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpschoedel kpschoedel kpschoedel left review comments

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
fast track lib platform review - pending system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kghost @andy31415 @bzbarsky-apple @Damian-Nordic @kpschoedel