[OperationalCredentials]: Reporting change for the attributes not managed by the attribute store. #11155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic and
turon
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
|
PR #11155: Size comparison from e7c1d2b to 1ca9059 Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
LGTM. Side-note: I notice that this cluster is still writing to the Ember global attribute store for the fabrics list. That should be deleted right? Please file an issue to do so. |
mrjerryjohns
approved these changes
Oct 28, 2021
Co-authored-by: Jerry Johns <[email protected]>
|
PR #11155: Size comparison from 1e27d92 to ac89fb2 Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Per @pan-apple this part of logic will be refactored. #11165 |
yunhanw-google
approved these changes
Oct 29, 2021
bzbarsky-apple
approved these changes
Oct 29, 2021
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #11155: Size comparison from 1e27d92 to 08495ad Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
saurabhst
approved these changes
Oct 29, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…aged by the attribute store. (project-chip#11155) * Reporting OperationalCredentials Attribute Change * Update src/app/reporting/Engine.h Co-authored-by: Jerry Johns <[email protected]> * Update src/app/util/ember-compatibility-functions.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments Co-authored-by: Jerry Johns <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Reporting change for the attributes not managed by the attribute store.
Testing
How was this tested? (at least one bullet point required)