Improve nRF Connect Docker image used by Build example - nRF Connect SDK workflow #10937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
tcarmelveilleux,
tecimovic,
turon,
vivien-apple,
wbschiller and
woody-apple
|
PR #10937: Size comparison from 93fef33 to e6895cc 12 builds (for efr32, k32w, p6, qpg, telink)
8 builds (for linux)
16 builds (for esp32, mbed, nrfconnect)
|
Damian-Nordic
approved these changes
Oct 26, 2021
woody-apple
approved these changes
Oct 27, 2021
|
PR #10937: Size comparison from e4407c4 to e6c2ac7 Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Some of these best practices are: * Multi-stage builds * Pin versions * Avoid additional packages installation * Clean all missing after apt command Signed-off-by: Victor Morales <[email protected]>
electrocucaracha
force-pushed
the
improve_nrf
branch
from
e6c2ac7 to
3cf4fbf
Compare
|
PR #10937: Size comparison from cb7c854 to 3cf4fbf Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #10937: Size comparison from 2ea9fbc to fede2d9 Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
) Some of these best practices are: * Multi-stage builds * Pin versions * Avoid additional packages installation * Clean all missing after apt command Signed-off-by: Victor Morales <[email protected]> Co-authored-by: Justin Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Hadolint tool helps to build Docker images following best practices. Using those guidelines can help to reduce the size of the image and speed up the pulling process during the CI execution.
Change overview
This change uses the multi-stage builds feature to get the Nordic Connect SDK source code in one stage and installing it in the following stage. As result the image size has been reduced from 4.14GB to 4.09GB
Testing
This was tested locally using the act tool (
$ act -j nrfconnect) using the Docker image built with these changes.